PMD Results

The following document contains the results of PMD 4.1.

Files

net/ftlines/wicket/fullcalendar/AbstractFullCalendar.java

Violation	Line
An empty method in an abstract class should be abstract instead	52 - 55

net/ftlines/wicket/fullcalendar/ButtonText.java

Violation	Line
Classes implementing Serializable should set a serialVersionUID	19 - 112

net/ftlines/wicket/fullcalendar/CalendarResponse.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'js' could be declared final	74

net/ftlines/wicket/fullcalendar/Config.java

Violation	Line
Classes implementing Serializable should set a serialVersionUID	30 - 487
KONSTANTHEIT_VERSTECKTE: Private field 'eventSources' could be made final; it is only initialized in the declaration or constructor.	38
KONSTANTHEIT_VERSTECKTE: Private field 'header' could be made final; it is only initialized in the declaration or constructor.	39
KONSTANTHEIT_VERSTECKTE: Private field 'buttonText' could be made final; it is only initialized in the declaration or constructor.	40
KONSTANTHEIT_VERSTECKTE: Private field 'columnFormat' could be made final; it is only initialized in the declaration or constructor.	57

net/ftlines/wicket/fullcalendar/Event.java

Violation	Line
Classes implementing Serializable should set a serialVersionUID	19 - 178

net/ftlines/wicket/fullcalendar/EventManager.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'calendar' could be made final; it is only initialized in the declaration or constructor.	21

net/ftlines/wicket/fullcalendar/EventSource.java

Violation	Line
Classes implementing Serializable should set a serialVersionUID	26 - 273
KONSTANTHEIT_VERSTECKTE: Private field 'data' could be made final; it is only initialized in the declaration or constructor.	38

net/ftlines/wicket/fullcalendar/FullCalendar.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'uuid' could be declared final	72
Avoid instantiating new objects inside loops	87 - 92
Prefer StringBuffer over += for concatenating strings	174
Prefer StringBuffer over += for concatenating strings	175

net/ftlines/wicket/fullcalendar/Header.java

Violation	Line
Classes implementing Serializable should set a serialVersionUID	17 - 57

net/ftlines/wicket/fullcalendar/Json.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'mapper' could be declared final	65
KONSTANTHEIT_VERSTECKTE: Local variable 'module' could be declared final	66
Classes implementing Serializable should set a serialVersionUID	118 - 132
KONSTANTHEIT_VERSTECKTE: Private field 'code' could be made final; it is only initialized in the declaration or constructor.	120

net/ftlines/wicket/fullcalendar/callback/AbstractAjaxCallback.java

Violation	Line
An empty method in an abstract class should be abstract instead	28 - 31
An empty method in an abstract class should be abstract instead	45 - 48

net/ftlines/wicket/fullcalendar/callback/AbstractAjaxCallbackWithClientsideRevert.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'uuid' could be made final; it is only initialized in the declaration or constructor.	24
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	40
An empty method in an abstract class should be abstract instead	45 - 48
An empty method in an abstract class should be abstract instead	51 - 55

net/ftlines/wicket/fullcalendar/callback/AbstractCallback.java

Violation	Line
An empty method in an abstract class should be abstract instead	36 - 47
Prefer StringBuffer over += for concatenating strings	43
An empty method in an abstract class should be abstract instead	63 - 66

net/ftlines/wicket/fullcalendar/callback/AbstractEventParam.java

Violation	Line
This abstract class does not have any abstract methods	20 - 42
An empty method in an abstract class should be abstract instead	31 - 34
An empty method in an abstract class should be abstract instead	36 - 39

net/ftlines/wicket/fullcalendar/callback/BlockingDecorator.java

Violation	Line
Prefer StringBuffer over += for concatenating strings	59

net/ftlines/wicket/fullcalendar/callback/DateRangeSelectedCallback.java

Violation	Line
An empty method in an abstract class should be abstract instead	43 - 47
An empty method in an abstract class should be abstract instead	49 - 57
KONSTANTHEIT_VERSTECKTE: Local variable 'r' could be declared final	62
KONSTANTHEIT_VERSTECKTE: Local variable 'remoteOffset' could be declared final	68
KONSTANTHEIT_VERSTECKTE: Local variable 'localOffset' could be declared final	69
KONSTANTHEIT_VERSTECKTE: Local variable 'minutesAdjustment' could be declared final	70
KONSTANTHEIT_VERSTECKTE: Local variable 'allDay' could be declared final	74

net/ftlines/wicket/fullcalendar/callback/EventClickedCallback.java

Violation	Line
An empty method in an abstract class should be abstract instead	30 - 33
An empty method in an abstract class should be abstract instead	35 - 44
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	52
Avoid using final local variables, turn them into fields	54
Avoid using final local variables, turn them into fields	55

net/ftlines/wicket/fullcalendar/callback/EventDroppedCallback.java

Violation	Line
An empty method in an abstract class should be abstract instead	30 - 35
An empty method in an abstract class should be abstract instead	37 - 46
Avoid using final local variables, turn them into fields	52
Avoid using final local variables, turn them into fields	53
Avoid using final local variables, turn them into fields	54
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	57
Avoid using final local variables, turn them into fields	59
Avoid using final local variables, turn them into fields	60
Avoid using final local variables, turn them into fields	61
An empty method in an abstract class should be abstract instead	74 - 77

net/ftlines/wicket/fullcalendar/callback/EventResizedCallback.java

Violation	Line
An empty method in an abstract class should be abstract instead	29 - 33
An empty method in an abstract class should be abstract instead	35 - 43
An empty method in an abstract class should be abstract instead	46 - 61
KONSTANTHEIT_VERSTECKTE: Local variable 'r' could be declared final	48
KONSTANTHEIT_VERSTECKTE: Local variable 'eventId' could be declared final	49
KONSTANTHEIT_VERSTECKTE: Local variable 'sourceId' could be declared final	50
KONSTANTHEIT_VERSTECKTE: Local variable 'source' could be declared final	52
KONSTANTHEIT_VERSTECKTE: Local variable 'event' could be declared final	53
KONSTANTHEIT_VERSTECKTE: Local variable 'dayDelta' could be declared final	55
KONSTANTHEIT_VERSTECKTE: Local variable 'minuteDelta' could be declared final	56
An empty method in an abstract class should be abstract instead	66 - 69

net/ftlines/wicket/fullcalendar/callback/GetEventsCallback.java

Violation	Line
Avoid using final local variables, turn them into fields	42
Avoid using final local variables, turn them into fields	43
Avoid using final local variables, turn them into fields	48
Avoid using final local variables, turn them into fields	49
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	54
Avoid using final local variables, turn them into fields	55
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	65
Avoid unnecessary comparisons in boolean expressions	66

net/ftlines/wicket/fullcalendar/callback/View.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'type' could be made final; it is only initialized in the declaration or constructor.	23
KONSTANTHEIT_VERSTECKTE: Private field 'start' could be made final; it is only initialized in the declaration or constructor.	24
KONSTANTHEIT_VERSTECKTE: Private field 'end' could be made final; it is only initialized in the declaration or constructor.	25
KONSTANTHEIT_VERSTECKTE: Private field 'visibleStart' could be made final; it is only initialized in the declaration or constructor.	26
KONSTANTHEIT_VERSTECKTE: Private field 'visibleEnd' could be made final; it is only initialized in the declaration or constructor.	27

net/ftlines/wicket/fullcalendar/callback/ViewDisplayCallback.java

Violation	Line
An empty method in an abstract class should be abstract instead	38 - 44
An empty method in an abstract class should be abstract instead	46 - 55
Avoid using final local variables, turn them into fields	60
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	66 - 67
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	76
Avoid unnecessary comparisons in boolean expressions	77

org/projectforge/Version.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	43
Avoid using final local variables, turn them into fields	54
Avoid using final local variables, turn them into fields	55
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	176
WRAPPER_INSTANZIIERUNG: Avoid instantiating Integer objects. Call Integer.valueOf() instead.	194

org/projectforge/access/AccessChecker.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'userRights' could be made final; it is only initialized in the declaration or constructor.	57
Avoid unnecessary comparisons in boolean expressions	77
KONSTANTHEIT_VERSTECKTE: Local variable 'node' could be declared final	81
Avoid unnecessary comparisons in boolean expressions	84
KONSTANTHEIT_VERSTECKTE: Local variable 'groupIds' could be declared final	89
Avoid unnecessary comparisons in boolean expressions	92
Avoid unnecessary comparisons in boolean expressions	98
Avoid unnecessary comparisons in boolean expressions	102
Avoid unnecessary comparisons in boolean expressions	192
Avoid unnecessary comparisons in boolean expressions	232
Avoid unnecessary comparisons in boolean expressions	237
Avoid unnecessary comparisons in boolean expressions	239
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	248
KONSTANTHEIT_VERSTECKTE: Local variable 'str' could be declared final	255
Avoid using final local variables, turn them into fields	312
Avoid using final local variables, turn them into fields	317
Avoid unnecessary comparisons in boolean expressions	323
Avoid using final local variables, turn them into fields	342
Avoid unnecessary comparisons in boolean expressions	371
Avoid unnecessary comparisons in boolean expressions	371
Avoid using final local variables, turn them into fields	542
Avoid using final local variables, turn them into fields	543
Avoid unnecessary comparisons in boolean expressions	545
Avoid unnecessary comparisons in boolean expressions	549
Avoid unnecessary comparisons in boolean expressions	554
Avoid using final local variables, turn them into fields	620
Avoid unnecessary comparisons in boolean expressions	624
Avoid unnecessary comparisons in boolean expressions	626
Avoid using final local variables, turn them into fields	675
Avoid unnecessary comparisons in boolean expressions	676
Avoid using final local variables, turn them into fields	681
Avoid using final local variables, turn them into fields	690
Avoid unnecessary comparisons in boolean expressions	699
Avoid unnecessary comparisons in boolean expressions	710

org/projectforge/access/AccessDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'task' could be declared final	90
KONSTANTHEIT_VERSTECKTE: Local variable 'group' could be declared final	101
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	123
Avoid using final local variables, turn them into fields	134 - 135
Avoid using final local variables, turn them into fields	137
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	153
Avoid using final local variables, turn them into fields	157
Avoid unnecessary comparisons in boolean expressions	158
Avoid unnecessary comparisons in boolean expressions	161
Avoid using final local variables, turn them into fields	165
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	183
Avoid using final local variables, turn them into fields	185
Avoid unnecessary comparisons in boolean expressions	215
Avoid unnecessary comparisons in boolean expressions	215
Avoid unnecessary comparisons in boolean expressions	219
Avoid unnecessary comparisons in boolean expressions	219
Avoid unnecessary comparisons in boolean expressions	246
Avoid unnecessary comparisons in boolean expressions	249
Avoid unnecessary comparisons in boolean expressions	251
Avoid unnecessary comparisons in boolean expressions	255
Avoid using final local variables, turn them into fields	269
Avoid unnecessary comparisons in boolean expressions	270
Avoid using final local variables, turn them into fields	274
Avoid unnecessary comparisons in boolean expressions	275
Avoid using final local variables, turn them into fields	291
Avoid using final local variables, turn them into fields	292
Avoid using final local variables, turn them into fields	293
Avoid using final local variables, turn them into fields	296
Avoid unnecessary comparisons in boolean expressions	305
Avoid appending characters as strings in StringBuffer.append.	308
Avoid appending characters as strings in StringBuffer.append.	310
Avoid appending characters as strings in StringBuffer.append.	311
Avoid appending characters as strings in StringBuffer.append.	311
Avoid appending characters as strings in StringBuffer.append.	311
Avoid unnecessary comparisons in boolean expressions	313
Avoid appending characters as strings in StringBuffer.append.	316
Avoid appending characters as strings in StringBuffer.append.	318
Avoid appending characters as strings in StringBuffer.append.	319
Avoid appending characters as strings in StringBuffer.append.	319
Avoid appending characters as strings in StringBuffer.append.	319
Avoid unnecessary comparisons in boolean expressions	322
Avoid unnecessary comparisons in boolean expressions	322
Avoid using final local variables, turn them into fields	330
Avoid using final local variables, turn them into fields	332
Avoid instantiating new objects inside loops	332

org/projectforge/access/AccessEntryDO.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setAccess' called during object construction	114
KONSTANTHEIT_VERSTECKTE: Local variable 'other' could be declared final	210
Avoid unnecessary comparisons in boolean expressions	211
Avoid unnecessary comparisons in boolean expressions	213
KONSTANTHEIT_VERSTECKTE: Local variable 'hcb' could be declared final	223
KONSTANTHEIT_VERSTECKTE: Local variable 'sb' could be declared final	232

org/projectforge/access/AccessException.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'task' could be declared final	120
KONSTANTHEIT_VERSTECKTE: Local variable 'task' could be declared final	142
Returning 'params' may expose an internal array.	175
KONSTANTHEIT_VERSTECKTE: Local variable 'builder' could be declared final	270
No need to call String.valueOf to append to a string.	272
KONSTANTHEIT_VERSTECKTE: Local variable 'task' could be declared final	275
KONSTANTHEIT_VERSTECKTE: Local variable 'ts' could be declared final	276
No need to call String.valueOf to append to a string.	277

org/projectforge/access/GroupTaskAccessDO.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'entry' could be declared final	107
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	129
KONSTANTHEIT_VERSTECKTE: Local variable 'other' could be declared final	205
Avoid unnecessary comparisons in boolean expressions	206
Avoid unnecessary comparisons in boolean expressions	208
KONSTANTHEIT_VERSTECKTE: Local variable 'hcb' could be declared final	218
KONSTANTHEIT_VERSTECKTE: Local variable 'src' could be declared final	273
KONSTANTHEIT_VERSTECKTE: Local variable 'destEntry' could be declared final	276
Avoid unnecessary comparisons in boolean expressions	277
KONSTANTHEIT_VERSTECKTE: Local variable 'iterator' could be declared final	280
KONSTANTHEIT_VERSTECKTE: Local variable 'destEntry' could be declared final	282
KONSTANTHEIT_VERSTECKTE: Local variable 'tos' could be declared final	293
Avoid unnecessary comparisons in boolean expressions	297

org/projectforge/address/AddressDO.java

Violation	Line
Avoid using final local variables, turn them into fields	449
Avoid appending characters as strings in StringBuffer.append.	451
Avoid appending characters as strings in StringBuffer.append.	454
Avoid appending characters as strings in StringBuffer.append.	457
Avoid unnecessary comparisons in boolean expressions	666
Avoid unnecessary comparisons in boolean expressions	668
Avoid unnecessary comparisons in boolean expressions	683
Avoid unnecessary comparisons in boolean expressions	685
Avoid unnecessary comparisons in boolean expressions	700
Avoid unnecessary comparisons in boolean expressions	702
Avoid unnecessary comparisons in boolean expressions	717
Avoid unnecessary comparisons in boolean expressions	719
Avoid unnecessary comparisons in boolean expressions	734
Avoid unnecessary comparisons in boolean expressions	736
Avoid unnecessary comparisons in boolean expressions	785
Avoid using final local variables, turn them into fields	788
Avoid unnecessary comparisons in boolean expressions	789
Avoid using final local variables, turn them into fields	790
Avoid unnecessary comparisons in boolean expressions	791
Avoid using final local variables, turn them into fields	794
Avoid using final local variables, turn them into fields	800
Avoid unnecessary comparisons in boolean expressions	834
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	853
Avoid using final local variables, turn them into fields	856
Avoid unnecessary comparisons in boolean expressions	859
Avoid unnecessary comparisons in boolean expressions	862
Avoid appending characters as strings in StringBuffer.append.	864
Avoid appending characters as strings in StringBuffer.append.	865
Avoid unnecessary comparisons in boolean expressions	867

org/projectforge/address/AddressDao.java

Violation	Line
When instantiating a SimpleDateFormat object, specify a Locale	65
Avoid using final local variables, turn them into fields	105 - 108
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	136
Avoid unnecessary comparisons in boolean expressions	137
Avoid unnecessary comparisons in boolean expressions	138
Avoid unnecessary comparisons in boolean expressions	139
Avoid unnecessary comparisons in boolean expressions	142
Avoid unnecessary comparisons in boolean expressions	148
Avoid unnecessary comparisons in boolean expressions	149
Avoid unnecessary comparisons in boolean expressions	150
Avoid unnecessary comparisons in boolean expressions	151
Avoid unnecessary comparisons in boolean expressions	152
Avoid using final local variables, turn them into fields	153
Avoid unnecessary comparisons in boolean expressions	154
Avoid unnecessary comparisons in boolean expressions	157
Avoid unnecessary comparisons in boolean expressions	160
Avoid unnecessary comparisons in boolean expressions	163
Avoid unnecessary comparisons in boolean expressions	166
Avoid unnecessary comparisons in boolean expressions	174
Avoid unnecessary comparisons in boolean expressions	174
Avoid unnecessary comparisons in boolean expressions	174
Avoid using final local variables, turn them into fields	175
Avoid unnecessary comparisons in boolean expressions	176
Avoid unnecessary comparisons in boolean expressions	179
Avoid unnecessary comparisons in boolean expressions	182
Avoid unnecessary comparisons in boolean expressions	189
Avoid using final local variables, turn them into fields	204
Avoid unnecessary comparisons in boolean expressions	247
Avoid unnecessary comparisons in boolean expressions	250
Avoid unnecessary comparisons in boolean expressions	252
Avoid unnecessary comparisons in boolean expressions	256
Avoid using final local variables, turn them into fields	274
Avoid using final local variables, turn them into fields	276
Avoid using final local variables, turn them into fields	278
Avoid using final local variables, turn them into fields	279
Avoid using final local variables, turn them into fields	280
Avoid using final local variables, turn them into fields	281
Avoid using final local variables, turn them into fields	283
Avoid using final local variables, turn them into fields	284
Avoid using final local variables, turn them into fields	285
Avoid using final local variables, turn them into fields	286
Avoid unnecessary comparisons in boolean expressions	288
Avoid unnecessary comparisons in boolean expressions	288
Avoid instantiating new objects inside loops	292
Avoid using final local variables, turn them into fields	293
Avoid using final local variables, turn them into fields	294
Avoid unnecessary comparisons in boolean expressions	295
Avoid using final local variables, turn them into fields	298
Avoid instantiating new objects inside loops	298
Avoid unnecessary comparisons in boolean expressions	299
Avoid using final local variables, turn them into fields	309
Avoid using final local variables, turn them into fields	310
Avoid unnecessary comparisons in boolean expressions	311
Avoid unnecessary comparisons in boolean expressions	313
Avoid using final local variables, turn them into fields	323
Avoid using final local variables, turn them into fields	324
Avoid unnecessary comparisons in boolean expressions	325
Avoid unnecessary comparisons in boolean expressions	327
Avoid using final local variables, turn them into fields	338
Avoid unnecessary comparisons in boolean expressions	340
Avoid using final local variables, turn them into fields	344
Avoid unnecessary comparisons in boolean expressions	355
Avoid unnecessary comparisons in boolean expressions	355
Avoid unnecessary comparisons in boolean expressions	359
Avoid unnecessary comparisons in boolean expressions	373
Avoid unnecessary comparisons in boolean expressions	373
Avoid unnecessary comparisons in boolean expressions	373
Avoid unnecessary comparisons in boolean expressions	384
Avoid unnecessary comparisons in boolean expressions	384
Avoid unnecessary comparisons in boolean expressions	384
Avoid unnecessary comparisons in boolean expressions	398
Avoid using final local variables, turn them into fields	420
Avoid unnecessary comparisons in boolean expressions	422
Avoid unnecessary comparisons in boolean expressions	426
Avoid unnecessary comparisons in boolean expressions	427
Avoid unnecessary comparisons in boolean expressions	434
Avoid unnecessary comparisons in boolean expressions	435
Avoid using final local variables, turn them into fields	447
Avoid using final local variables, turn them into fields	448
Avoid unnecessary comparisons in boolean expressions	449
Avoid unnecessary comparisons in boolean expressions	451
Avoid unnecessary comparisons in boolean expressions	452
Avoid unnecessary comparisons in boolean expressions	453
Avoid unnecessary comparisons in boolean expressions	454
Avoid using final local variables, turn them into fields	468
Avoid using final local variables, turn them into fields	471
Avoid unnecessary comparisons in boolean expressions	473
Avoid unnecessary comparisons in boolean expressions	477
Avoid unnecessary comparisons in boolean expressions	481
Avoid unnecessary comparisons in boolean expressions	485
Avoid unnecessary comparisons in boolean expressions	486
Avoid using final local variables, turn them into fields	486
Avoid unnecessary comparisons in boolean expressions	490
Avoid unnecessary comparisons in boolean expressions	499
Avoid unnecessary comparisons in boolean expressions	536
Avoid using final local variables, turn them into fields	540 - 541
Avoid using final local variables, turn them into fields	542
Avoid using final local variables, turn them into fields	547

org/projectforge/address/AddressExport.java

Violation	Line
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	230
Avoid using final local variables, turn them into fields	232
Avoid unnecessary comparisons in boolean expressions	234
Avoid unnecessary comparisons in boolean expressions	237
Avoid unnecessary comparisons in boolean expressions	241
Avoid using final local variables, turn them into fields	244
Avoid using final local variables, turn them into fields	245
Avoid using final local variables, turn them into fields	249
Avoid using final local variables, turn them into fields	250
Avoid using final local variables, turn them into fields	263

org/projectforge/address/AddressFilter.java

Violation	Line
TOTE_ATTRIBUTE: Avoid unused private fields such as 'myFavorites'.	57
TOTE_ATTRIBUTE: Avoid unused private fields such as 'newest'.	61

org/projectforge/address/AddressStatus.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	52
Avoid unnecessary comparisons in boolean expressions	55
Avoid unnecessary comparisons in boolean expressions	57
Avoid unnecessary comparisons in boolean expressions	59

org/projectforge/address/BirthdayAddress.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	46
Avoid using final local variables, turn them into fields	58
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	97
Avoid using final local variables, turn them into fields	170

org/projectforge/address/ContactStatus.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	48
Avoid unnecessary comparisons in boolean expressions	51
Avoid unnecessary comparisons in boolean expressions	53
Avoid unnecessary comparisons in boolean expressions	55
Avoid unnecessary comparisons in boolean expressions	57
Avoid unnecessary comparisons in boolean expressions	59

org/projectforge/address/FormOfAddress.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	37
Avoid unnecessary comparisons in boolean expressions	40
Avoid unnecessary comparisons in boolean expressions	42
Avoid unnecessary comparisons in boolean expressions	44
Avoid unnecessary comparisons in boolean expressions	46
Avoid unnecessary comparisons in boolean expressions	48

org/projectforge/address/HibernateSearchInstantMessagingBridge.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	42
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	45

org/projectforge/address/InstantMessagingType.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	41
Avoid unnecessary comparisons in boolean expressions	44
Avoid unnecessary comparisons in boolean expressions	46
Avoid unnecessary comparisons in boolean expressions	48
Avoid unnecessary comparisons in boolean expressions	50
Avoid unnecessary comparisons in boolean expressions	52
Avoid unnecessary comparisons in boolean expressions	54
Avoid unnecessary comparisons in boolean expressions	56

org/projectforge/address/PersonalAddressDO.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	77
Avoid unnecessary comparisons in boolean expressions	77
Avoid unnecessary comparisons in boolean expressions	77
Avoid unnecessary comparisons in boolean expressions	77
Avoid unnecessary comparisons in boolean expressions	77

org/projectforge/address/PersonalAddressDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'user' could be declared final	76
Avoid unnecessary comparisons in boolean expressions	87
Avoid using final local variables, turn them into fields	98
Avoid unnecessary comparisons in boolean expressions	99
Avoid unnecessary comparisons in boolean expressions	107
KONSTANTHEIT_VERSTECKTE: Local variable 'id' could be declared final	114
Avoid unnecessary comparisons in boolean expressions	121
Avoid unnecessary comparisons in boolean expressions	122
Avoid unnecessary comparisons in boolean expressions	123
Avoid unnecessary comparisons in boolean expressions	124
Avoid unnecessary comparisons in boolean expressions	125
Avoid unnecessary comparisons in boolean expressions	126
Avoid unnecessary comparisons in boolean expressions	148
KONSTANTHEIT_VERSTECKTE: Local variable 'modified' could be declared final	155
Avoid unnecessary comparisons in boolean expressions	156
Avoid using final local variables, turn them into fields	170
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	173 - 175
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	177
Avoid using final local variables, turn them into fields	199
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	202 - 205
Avoid using final local variables, turn them into fields	217
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	220 - 221
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	222
Avoid unnecessary comparisons in boolean expressions	224
Avoid using final local variables, turn them into fields	239
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	242 - 245
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	246
Avoid unnecessary comparisons in boolean expressions	248

org/projectforge/admin/DatabaseCoreUpdates.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 202
Avoid using final local variables, turn them into fields	53
Avoid using final local variables, turn them into fields	62
Avoid unnecessary comparisons in boolean expressions	63
Avoid using final local variables, turn them into fields	70
Avoid unnecessary comparisons in boolean expressions	71
Avoid unnecessary comparisons in boolean expressions	74
Avoid using final local variables, turn them into fields	90
Avoid unnecessary comparisons in boolean expressions	91
Avoid unnecessary comparisons in boolean expressions	92
Avoid using final local variables, turn them into fields	99
Avoid unnecessary comparisons in boolean expressions	100
Avoid unnecessary comparisons in boolean expressions	103
Avoid unnecessary comparisons in boolean expressions	106
Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !	118
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	125
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	127
Avoid using final local variables, turn them into fields	128
Avoid using final local variables, turn them into fields	129
Avoid unnecessary comparisons in boolean expressions	130
Avoid unnecessary comparisons in boolean expressions	131
Avoid unnecessary comparisons in boolean expressions	132
Avoid unnecessary comparisons in boolean expressions	133
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	142
Avoid unnecessary comparisons in boolean expressions	143
Avoid using final local variables, turn them into fields	146
Avoid unnecessary comparisons in boolean expressions	147
Avoid using final local variables, turn them into fields	150
Avoid unnecessary comparisons in boolean expressions	151
Avoid using final local variables, turn them into fields	154
Avoid unnecessary comparisons in boolean expressions	155
Avoid using final local variables, turn them into fields	158
Avoid unnecessary comparisons in boolean expressions	159
Avoid using final local variables, turn them into fields	175
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	177
Avoid unnecessary comparisons in boolean expressions	178
Avoid unnecessary comparisons in boolean expressions	179
Avoid using final local variables, turn them into fields	186
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	188
Avoid using final local variables, turn them into fields	194

org/projectforge/admin/SystemUpdater.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	52
Avoid using final local variables, turn them into fields	96
Avoid unnecessary comparisons in boolean expressions	98
Avoid using final local variables, turn them into fields	157
Avoid unnecessary comparisons in boolean expressions	158

org/projectforge/admin/UpdateEntry.java

Violation	Line
An empty method in an abstract class should be abstract instead	57 - 60
An empty method in an abstract class should be abstract instead	67 - 70
An empty method in an abstract class should be abstract instead	90 - 94
Avoid using final local variables, turn them into fields	92
An empty method in an abstract class should be abstract instead	101 - 112

org/projectforge/admin/UpdateEntryImpl.java

Violation	Line
Avoid using final local variables, turn them into fields	63
An empty method in an abstract class should be abstract instead	73 - 76
An empty method in an abstract class should be abstract instead	84 - 87
An empty method in an abstract class should be abstract instead	96 - 99
An empty method in an abstract class should be abstract instead	102 - 105
An empty method in an abstract class should be abstract instead	126 - 130
Avoid using final local variables, turn them into fields	128

org/projectforge/book/BookDO.java

Violation	Line
Avoid using final local variables, turn them into fields	192
Avoid using final local variables, turn them into fields	195
Avoid unnecessary comparisons in boolean expressions	196
Avoid instantiating new objects inside loops	204

org/projectforge/book/BookDao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	97
Avoid using final local variables, turn them into fields	103
KONSTANTHEIT_VERSTECKTE: Local variable 'queryFilter' could be declared final	109
Avoid unnecessary comparisons in boolean expressions	110
Avoid unnecessary comparisons in boolean expressions	112
Avoid unnecessary comparisons in boolean expressions	112
Avoid unnecessary comparisons in boolean expressions	112
Avoid unnecessary comparisons in boolean expressions	114
Avoid unnecessary comparisons in boolean expressions	118
Avoid unnecessary comparisons in boolean expressions	122
KONSTANTHEIT_VERSTECKTE: Local variable 'inCrit' could be declared final	129
Avoid unnecessary comparisons in boolean expressions	130
Avoid unnecessary comparisons in boolean expressions	164
KONSTANTHEIT_VERSTECKTE: Local variable 'task' could be declared final	185
KONSTANTHEIT_VERSTECKTE: Local variable 'user' could be declared final	196
Avoid unnecessary comparisons in boolean expressions	230
Avoid unnecessary comparisons in boolean expressions	233
Avoid unnecessary comparisons in boolean expressions	235
Avoid unnecessary comparisons in boolean expressions	239

org/projectforge/calendar/ConfigureHoliday.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'builder' could be declared final	133

org/projectforge/calendar/DayHolder.java

Violation	Line
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	71
Avoid unnecessary comparisons in boolean expressions	79
KONSTANTHEIT_VERSTECKTE: Local variable 'day' could be declared final	82
Avoid unnecessary comparisons in boolean expressions	86
Avoid using final local variables, turn them into fields	87
Avoid unnecessary comparisons in boolean expressions	100
Avoid using final local variables, turn them into fields	101
Avoid unnecessary comparisons in boolean expressions	108
KONSTANTHEIT_VERSTECKTE: Local variable 'dayOfWeek' could be declared final	171
Avoid unnecessary comparisons in boolean expressions	182
Avoid unnecessary comparisons in boolean expressions	182
Avoid unnecessary if..then..else statements when returning a boolean	182 - 184
KONSTANTHEIT_VERSTECKTE: Local variable 'day' could be declared final	226
KONSTANTHEIT_VERSTECKTE: Local variable 'cal' could be declared final	237

org/projectforge/calendar/Holiday.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'workingDay' could be made final; it is only initialized in the declaration or constructor.	39
KONSTANTHEIT_VERSTECKTE: Private field 'i18nKey' could be made final; it is only initialized in the declaration or constructor.	41
KONSTANTHEIT_VERSTECKTE: Private field 'label' could be made final; it is only initialized in the declaration or constructor.	43
KONSTANTHEIT_VERSTECKTE: Private field 'workFraction' could be made final; it is only initialized in the declaration or constructor.	45
Avoid unnecessary comparisons in boolean expressions	59
Avoid using final local variables, turn them into fields	90

org/projectforge/calendar/Holidays.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'holidaysByYear' could be made final; it is only initialized in the declaration or constructor.	52
KONSTANTHEIT_VERSTECKTE: Private field 'reconfiguredHolidays' could be made final; it is only initialized in the declaration or constructor.	54
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	62
KONSTANTHEIT_VERSTECKTE: Local variable 'g' could be declared final	70
KONSTANTHEIT_VERSTECKTE: Local variable 'c' could be declared final	75
KONSTANTHEIT_VERSTECKTE: Local variable 'h' could be declared final	76
KONSTANTHEIT_VERSTECKTE: Local variable 'l' could be declared final	82
KONSTANTHEIT_VERSTECKTE: Local variable 'm' could be declared final	83
KONSTANTHEIT_VERSTECKTE: Local variable 'd' could be declared final	84
Avoid unnecessary comparisons in boolean expressions	97
Avoid unnecessary comparisons in boolean expressions	99
Avoid using final local variables, turn them into fields	109
Avoid instantiating new objects inside loops	109
Avoid using final local variables, turn them into fields	125
Avoid using final local variables, turn them into fields	134
KONSTANTHEIT_VERSTECKTE: Local variable 'isWorkingDay' could be declared final	146
Avoid unnecessary comparisons in boolean expressions	147
Avoid using final local variables, turn them into fields	148
Avoid unnecessary comparisons in boolean expressions	149
Avoid unnecessary comparisons in boolean expressions	153
Avoid unnecessary comparisons in boolean expressions	166
SYNCHRONISATION: Use block level rather than method level synchronization	175 - 194
WRAPPER_INSTANZIIERUNG: Avoid instantiating Integer objects. Call Integer.valueOf() instead.	188
Avoid unnecessary comparisons in boolean expressions	198
Avoid unnecessary comparisons in boolean expressions	203
Avoid using final local variables, turn them into fields	206
Avoid unnecessary comparisons in boolean expressions	207
Avoid unnecessary comparisons in boolean expressions	215
Avoid using final local variables, turn them into fields	218
Avoid using final local variables, turn them into fields	227
Avoid unnecessary comparisons in boolean expressions	231

org/projectforge/calendar/MonthHolder.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'dateHolder' could be declared final	108
Avoid instantiating new objects inside loops	121
KONSTANTHEIT_VERSTECKTE: Local variable 'week' could be declared final	121
Avoid unnecessary comparisons in boolean expressions	177
Avoid unnecessary comparisons in boolean expressions	177
Avoid using final local variables, turn them into fields	182
Avoid using final local variables, turn them into fields	183

org/projectforge/calendar/TimePeriod.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	49
KONSTANTHEIT_VERSTECKTE: Local variable 'millis' could be declared final	52
Consider simply returning the value vs storing it in local variable 'millis'	53
KONSTANTHEIT_VERSTECKTE: Local variable 'duration' could be declared final	84
KONSTANTHEIT_VERSTECKTE: Local variable 'minutes' could be declared final	86
KONSTANTHEIT_VERSTECKTE: Local variable 'sb' could be declared final	185

org/projectforge/calendar/WeekHolder.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'dateHolder' could be declared final	75
Avoid instantiating new objects inside loops	82
KONSTANTHEIT_VERSTECKTE: Local variable 'day' could be declared final	82
Returning 'days' may expose an internal array.	99
KONSTANTHEIT_VERSTECKTE: Local variable 'tos' could be declared final	140

org/projectforge/common/AbstractCache.java

Violation	Line
SYNCHRONISATION: Use block level rather than method level synchronization	93 - 113
Avoid unnecessary comparisons in boolean expressions	95
Avoid unnecessary comparisons in boolean expressions	99

org/projectforge/common/Base64Helper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 75
KONSTANTHEIT_VERSTECKTE: Local variable 'ois' could be declared final	54
KONSTANTHEIT_VERSTECKTE: Local variable 'o' could be declared final	55
KONSTANTHEIT_VERSTECKTE: Local variable 'baos' could be declared final	68
KONSTANTHEIT_VERSTECKTE: Local variable 'oos' could be declared final	69

org/projectforge/common/BaseFormatter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'sb' could be declared final	41

org/projectforge/common/BeanHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 468
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	51
Avoid using final local variables, turn them into fields	74
Avoid unnecessary comparisons in boolean expressions	75
Avoid unnecessary comparisons in boolean expressions	75
Avoid unnecessary comparisons in boolean expressions	77
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	86
Avoid unnecessary comparisons in boolean expressions	88
Avoid unnecessary comparisons in boolean expressions	88
Avoid unnecessary comparisons in boolean expressions	89
Avoid using final local variables, turn them into fields	103
Avoid unnecessary comparisons in boolean expressions	104
Avoid unnecessary comparisons in boolean expressions	104
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	119
Avoid unnecessary comparisons in boolean expressions	121
Avoid using final local variables, turn them into fields	130
Avoid unnecessary comparisons in boolean expressions	131
Avoid unnecessary comparisons in boolean expressions	135
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	137
Avoid unnecessary comparisons in boolean expressions	139
Avoid using final local variables, turn them into fields	140
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	158
Avoid unnecessary comparisons in boolean expressions	208
Avoid using final local variables, turn them into fields	318
Avoid using final local variables, turn them into fields	345
Avoid using final local variables, turn them into fields	371
Avoid using final local variables, turn them into fields	375
Avoid using final local variables, turn them into fields	376
Avoid using final local variables, turn them into fields	377
Avoid using final local variables, turn them into fields	381
Avoid unnecessary comparisons in boolean expressions	385
Avoid unnecessary comparisons in boolean expressions	387
Avoid unnecessary comparisons in boolean expressions	408
Avoid using final local variables, turn them into fields	411
Avoid using final local variables, turn them into fields	433
Avoid using final local variables, turn them into fields	434
Avoid unnecessary comparisons in boolean expressions	436
Avoid unnecessary comparisons in boolean expressions	437
Avoid unnecessary comparisons in boolean expressions	438
Avoid using final local variables, turn them into fields	442

org/projectforge/common/CSVParser.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'source' could be made final; it is only initialized in the declaration or constructor.	55
It is somewhat confusing to have a field name with the same name as a method	59
KONSTANTHEIT_VERSTECKTE: Local variable 'cell' could be declared final	87
Avoid instantiating new objects inside loops	90
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	110
Avoid unnecessary comparisons in boolean expressions	113
Avoid unnecessary comparisons in boolean expressions	119
Avoid unnecessary comparisons in boolean expressions	125
Avoid unnecessary comparisons in boolean expressions	127
Avoid unnecessary comparisons in boolean expressions	138
Avoid unnecessary comparisons in boolean expressions	174
KONSTANTHEIT_VERSTECKTE: Local variable 'c' could be declared final	202

org/projectforge/common/CSVWriter.java

Violation	Line
When instantiating a SimpleDateFormat object, specify a Locale	40
KONSTANTHEIT_VERSTECKTE: Private field 'out' could be made final; it is only initialized in the declaration or constructor.	46
KONSTANTHEIT_VERSTECKTE: Local variable 'len' could be declared final	122
Avoid unnecessary comparisons in boolean expressions	170

org/projectforge/common/ClassHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 66
Avoid unnecessary comparisons in boolean expressions	38
Avoid unnecessary comparisons in boolean expressions	41
Avoid unnecessary comparisons in boolean expressions	44
Avoid unnecessary comparisons in boolean expressions	61
Avoid unnecessary comparisons in boolean expressions	61

org/projectforge/common/Crypt.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 87
Avoid using final local variables, turn them into fields	58
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	73
Avoid instantiating new objects inside loops	73
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	78
Do not add empty strings	79
Prefer StringBuffer over += for concatenating strings	79

org/projectforge/common/CurrencyHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 61
Avoid unnecessary comparisons in boolean expressions	41

org/projectforge/common/DateFormats.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 284
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	116
Avoid unnecessary comparisons in boolean expressions	117
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	169
Avoid unnecessary comparisons in boolean expressions	170
Avoid using final local variables, turn them into fields	189
Avoid unnecessary comparisons in boolean expressions	237
Avoid unnecessary comparisons in boolean expressions	242
Avoid unnecessary comparisons in boolean expressions	244
This call to String.startsWith can be rewritten using String.charAt(0)	244
Avoid unnecessary comparisons in boolean expressions	250

org/projectforge/common/DateHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 624
When instantiating a SimpleDateFormat object, specify a Locale	90
When instantiating a SimpleDateFormat object, specify a Locale	92
When instantiating a SimpleDateFormat object, specify a Locale	94
When instantiating a SimpleDateFormat object, specify a Locale	96
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	160
When instantiating a SimpleDateFormat object, specify a Locale	174
Avoid using final local variables, turn them into fields	174
When instantiating a SimpleDateFormat object, specify a Locale	187
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	198
When instantiating a SimpleDateFormat object, specify a Locale	223
Avoid using final local variables, turn them into fields	223
Avoid using final local variables, turn them into fields	267
Avoid unnecessary comparisons in boolean expressions	270
When instantiating a SimpleDateFormat object, specify a Locale	289
Avoid using final local variables, turn them into fields	289
When instantiating a SimpleDateFormat object, specify a Locale	307
Avoid using final local variables, turn them into fields	307
When instantiating a SimpleDateFormat object, specify a Locale	330
Avoid using final local variables, turn them into fields	330
Avoid using final local variables, turn them into fields	332
Avoid using final local variables, turn them into fields	336
Avoid using final local variables, turn them into fields	337
Avoid unnecessary comparisons in boolean expressions	421
Avoid using final local variables, turn them into fields	424
Avoid using final local variables, turn them into fields	434
Avoid using final local variables, turn them into fields	435
Avoid using final local variables, turn them into fields	436
Avoid using final local variables, turn them into fields	437
Avoid using final local variables, turn them into fields	451
Avoid instantiating new objects inside loops	454
Avoid using final local variables, turn them into fields	466
Avoid using final local variables, turn them into fields	470
Avoid using final local variables, turn them into fields	493
Avoid using final local variables, turn them into fields	512
Avoid unnecessary if..then..else statements when returning a boolean	545 - 549
Avoid using final local variables, turn them into fields	553
Avoid unnecessary if..then..else statements when returning a boolean	566 - 570
Avoid using final local variables, turn them into fields	620
Avoid using final local variables, turn them into fields	621

org/projectforge/common/DateHolder.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setPrecision' called during object construction	67
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setPrecision' called during object construction	79
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setPrecision' called during object construction	89
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setPrecision' called during object construction	104
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setPrecision' called during object construction	116
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setPrecision' called during object construction	128
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'ensurePrecision' called during object construction	142
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'ensurePrecision' called during object construction	183
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setPrecision' called during object construction	190
Avoid using final local variables, turn them into fields	221
Avoid unnecessary comparisons in boolean expressions	226
Avoid unnecessary comparisons in boolean expressions	229
Avoid unnecessary comparisons in boolean expressions	231
Avoid unnecessary comparisons in boolean expressions	231
Avoid using final local variables, turn them into fields	236
Avoid using final local variables, turn them into fields	237
Avoid using final local variables, turn them into fields	299
Avoid using final local variables, turn them into fields	330
Avoid using final local variables, turn them into fields	337
Consider simply returning the value vs storing it in local variable 'date'	338
Avoid using final local variables, turn them into fields	348
Avoid using final local variables, turn them into fields	398
Avoid using final local variables, turn them into fields	627
Avoid using final local variables, turn them into fields	634
Avoid using final local variables, turn them into fields	643
Avoid using final local variables, turn them into fields	644
Avoid using final local variables, turn them into fields	648
Do not use the short type	684
Avoid unnecessary comparisons in boolean expressions	695
Avoid instantiating new objects inside loops	695
clone() method should throw CloneNotSupportedException	708 - 715
Avoid using final local variables, turn them into fields	710
Avoid using final local variables, turn them into fields	787
Avoid using final local variables, turn them into fields	798

org/projectforge/common/ExceptionHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 96
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	48
KONSTANTHEIT_VERSTECKTE: Local variable 'sta' could be declared final	49
Avoid unnecessary comparisons in boolean expressions	53
Avoid unnecessary comparisons in boolean expressions	54
Avoid unnecessary comparisons in boolean expressions	60
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	75
Avoid unnecessary comparisons in boolean expressions	94
Avoid unnecessary comparisons in boolean expressions	94

org/projectforge/common/FileHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 116
Avoid unnecessary comparisons in boolean expressions	50
Avoid using final local variables, turn them into fields	80
KONSTANTHEIT_VERSTECKTE: Local variable 'ch' could be declared final	84
KONSTANTHEIT_VERSTECKTE: Local variable 'substitution' could be declared final	91
KONSTANTHEIT_VERSTECKTE: Local variable 'remain' could be declared final	92
Avoid unnecessary comparisons in boolean expressions	102
Avoid appending characters as strings in StringBuffer.append.	103
Avoid unnecessary comparisons in boolean expressions	108

org/projectforge/common/ImportStorage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	82
Avoid unnecessary comparisons in boolean expressions	86
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	95
SYNCHRONISATION: Use block level rather than method level synchronization	129 - 132

org/projectforge/common/ImportedElement.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'index' could be made final; it is only initialized in the declaration or constructor.	57
KONSTANTHEIT_VERSTECKTE: Private field 'clazz' could be made final; it is only initialized in the declaration or constructor.	59
KONSTANTHEIT_VERSTECKTE: Private field 'diffProperties' could be made final; it is only initialized in the declaration or constructor.	61
KONSTANTHEIT_VERSTECKTE: Local variable 'method' could be declared final	114
KONSTANTHEIT_VERSTECKTE: Local variable 'newValue' could be declared final	121
KONSTANTHEIT_VERSTECKTE: Local variable 'origValue' could be declared final	122
Avoid unnecessary comparisons in boolean expressions	125
Avoid unnecessary comparisons in boolean expressions	128
Avoid unnecessary comparisons in boolean expressions	131
Avoid instantiating new objects inside loops	133
Avoid instantiating new objects inside loops	147
KONSTANTHEIT_VERSTECKTE: Local variable 'delta' could be declared final	147
Avoid unnecessary comparisons in boolean expressions	169
Avoid unnecessary comparisons in boolean expressions	169
Avoid unnecessary comparisons in boolean expressions	177
Avoid unnecessary comparisons in boolean expressions	177
Avoid unnecessary comparisons in boolean expressions	185
Avoid unnecessary comparisons in boolean expressions	214
Avoid unnecessary comparisons in boolean expressions	223

org/projectforge/common/ImportedSheet.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	111
Avoid unnecessary comparisons in boolean expressions	111
Avoid unnecessary comparisons in boolean expressions	111
Avoid unnecessary comparisons in boolean expressions	126
Avoid unnecessary comparisons in boolean expressions	126
Avoid unnecessary comparisons in boolean expressions	126
Avoid unnecessary comparisons in boolean expressions	166
Avoid unnecessary comparisons in boolean expressions	168
Avoid unnecessary comparisons in boolean expressions	171
Avoid unnecessary comparisons in boolean expressions	174
Avoid unnecessary comparisons in boolean expressions	178
Avoid unnecessary comparisons in boolean expressions	184
Avoid unnecessary comparisons in boolean expressions	188
Avoid unnecessary comparisons in boolean expressions	196
Avoid unnecessary comparisons in boolean expressions	282
Avoid unnecessary comparisons in boolean expressions	285
Avoid unnecessary comparisons in boolean expressions	290
Avoid using final local variables, turn them into fields	291
Avoid using final local variables, turn them into fields	293
Avoid instantiating new objects inside loops	295
Avoid unnecessary comparisons in boolean expressions	298
Avoid instantiating new objects inside loops	302
Avoid unnecessary comparisons in boolean expressions	316
Avoid empty if statements	320 - 322
Avoid empty if statements	322 - 324
Avoid unnecessary comparisons in boolean expressions	325
Avoid unnecessary comparisons in boolean expressions	334

org/projectforge/common/IntRanges.java

Violation	Line
WRAPPER_INSTANZIIERUNG: Avoid instantiating Integer objects. Call Integer.valueOf() instead.	52

org/projectforge/common/KeyValueBean.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'sb' could be declared final	68

org/projectforge/common/LabelValueBean.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'sb' could be declared final	73

org/projectforge/common/ListCopyHelper.java

Violation	Line
An empty method in an abstract class should be abstract instead	39 - 65
Avoid using final local variables, turn them into fields	41
Avoid using final local variables, turn them into fields	42
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	49
Avoid unnecessary comparisons in boolean expressions	50
Avoid using final local variables, turn them into fields	58

org/projectforge/common/MyBeanComparator.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'value1' could be declared final	49
KONSTANTHEIT_VERSTECKTE: Local variable 'value2' could be declared final	50
Avoid unnecessary comparisons in boolean expressions	54
Avoid unnecessary comparisons in boolean expressions	57
Avoid unnecessary comparisons in boolean expressions	59

org/projectforge/common/NumberHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 521
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	89
No need to call String.valueOf to append to a string.	103
WRAPPER_INSTANZIIERUNG: Avoid instantiating Integer objects. Call Integer.valueOf() instead.	179
WRAPPER_INSTANZIIERUNG: Avoid instantiating Short objects. Call Short.valueOf() instead	202
WRAPPER_INSTANZIIERUNG: Avoid instantiating Long objects.Call Long.valueOf() instead	223
Avoid using final local variables, turn them into fields	265
Avoid using final local variables, turn them into fields	268
Avoid using final local variables, turn them into fields	335
Avoid using final local variables, turn them into fields	336
Avoid using final local variables, turn them into fields	355
Avoid unnecessary comparisons in boolean expressions	356
Avoid unnecessary comparisons in boolean expressions	356
Avoid unnecessary comparisons in boolean expressions	361
Avoid unnecessary comparisons in boolean expressions	362
Avoid using final local variables, turn them into fields	369
Avoid unnecessary comparisons in boolean expressions	370
Avoid empty if statements	372 - 374
Avoid unnecessary comparisons in boolean expressions	372
Avoid using final local variables, turn them into fields	447
Avoid using final local variables, turn them into fields	448
Avoid unnecessary comparisons in boolean expressions	469
Avoid using final local variables, turn them into fields	470
Avoid using final local variables, turn them into fields	503
Avoid using final local variables, turn them into fields	504

org/projectforge/common/ObjectHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 52

org/projectforge/common/Ranges.java

Violation	Line
It is somewhat confusing to have a field name matching the declaring class name	42
KONSTANTHEIT_NICHT_STATISCHE: This final field could be made static	46
KONSTANTHEIT_NICHT_STATISCHE: This final field could be made static	48
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setRanges' called during object construction	56
An empty method in an abstract class should be abstract instead	59 - 79
Avoid unnecessary comparisons in boolean expressions	66
An empty method in an abstract class should be abstract instead	87 - 124
Avoid unnecessary comparisons in boolean expressions	91
Avoid using final local variables, turn them into fields	95
Avoid unnecessary comparisons in boolean expressions	97
Avoid using final local variables, turn them into fields	101
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	110
Avoid instantiating new objects inside loops	110
An empty method in an abstract class should be abstract instead	129 - 132
An empty method in an abstract class should be abstract instead	137 - 140
An empty method in an abstract class should be abstract instead	146 - 161
Avoid using final local variables, turn them into fields	148

org/projectforge/common/RecentQueue.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	60
KONSTANTHEIT_VERSTECKTE: Local variable 'idx' could be declared final	94
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	99

org/projectforge/common/ReflectionHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 95
Avoid using final local variables, turn them into fields	42
Avoid using final local variables, turn them into fields	44
Avoid using final local variables, turn them into fields	60
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	79

org/projectforge/common/ReflectionToString.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	52
Avoid unnecessary comparisons in boolean expressions	53
Avoid using final local variables, turn them into fields	55
KONSTANTHEIT_VERSTECKTE: Local variable 'value' could be declared final	70
Avoid unnecessary comparisons in boolean expressions	71

org/projectforge/common/ResultHolder.java

Violation	Line
Avoid using implementation types like 'ArrayList'; use the interface instead	39
It is somewhat confusing to have a field name matching the declaring class name	48
KONSTANTHEIT_VERSTECKTE: Private field 'params' could be made final; it is only initialized in the declaration or constructor.	66
Avoid using implementation types like 'ArrayList'; use the interface instead	102

org/projectforge/common/StringHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 558
Avoid unnecessary comparisons in boolean expressions	59
Avoid unnecessary comparisons in boolean expressions	62
Avoid unnecessary comparisons in boolean expressions	86
Avoid unnecessary comparisons in boolean expressions	90
Avoid unnecessary comparisons in boolean expressions	108
Avoid unnecessary comparisons in boolean expressions	126
Avoid unnecessary comparisons in boolean expressions	143
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	166
Avoid using final local variables, turn them into fields	189
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	216
Avoid using final local variables, turn them into fields	222
Avoid using final local variables, turn them into fields	242
Avoid unnecessary comparisons in boolean expressions	246
Avoid using final local variables, turn them into fields	258
Avoid using final local variables, turn them into fields	260
Consider simply returning the value vs storing it in local variable 'result'	261
Avoid using final local variables, turn them into fields	313
Avoid using final local variables, turn them into fields	315
Avoid using final local variables, turn them into fields	328
Avoid using final local variables, turn them into fields	330
Avoid using final local variables, turn them into fields	352
Avoid using final local variables, turn them into fields	353
Avoid using final local variables, turn them into fields	356
Avoid unnecessary comparisons in boolean expressions	357
Avoid unnecessary comparisons in boolean expressions	360
Avoid using final local variables, turn them into fields	369
Avoid using final local variables, turn them into fields	381
Avoid using final local variables, turn them into fields	383
Avoid unnecessary comparisons in boolean expressions	384
Avoid using final local variables, turn them into fields	416
Avoid unnecessary comparisons in boolean expressions	433
Avoid unnecessary comparisons in boolean expressions	436
Avoid unnecessary comparisons in boolean expressions	437
This call to String.startsWith can be rewritten using String.charAt(0)	437
Avoid unnecessary comparisons in boolean expressions	439
Avoid using final local variables, turn them into fields	443
Avoid using final local variables, turn them into fields	469
Avoid using final local variables, turn them into fields	470
Avoid using final local variables, turn them into fields	483
Avoid using final local variables, turn them into fields	484
Avoid unnecessary comparisons in boolean expressions	486
Avoid using final local variables, turn them into fields	487
Avoid using final local variables, turn them into fields	488
Avoid using final local variables, turn them into fields	506
Avoid using final local variables, turn them into fields	507
Avoid unnecessary comparisons in boolean expressions	522
Avoid unnecessary comparisons in boolean expressions	537
Avoid using final local variables, turn them into fields	551

org/projectforge/core/AbstractBaseDO.java

Violation	Line
An empty method in an abstract class should be abstract instead	83 - 85
An empty method in an abstract class should be abstract instead	88 - 91
An empty method in an abstract class should be abstract instead	99 - 102
An empty method in an abstract class should be abstract instead	121 - 124
An empty method in an abstract class should be abstract instead	141 - 144
An empty method in an abstract class should be abstract instead	155 - 158
An empty method in an abstract class should be abstract instead	165 - 171
An empty method in an abstract class should be abstract instead	187 - 190
An empty method in an abstract class should be abstract instead	199 - 202
An empty method in an abstract class should be abstract instead	213 - 226
Avoid unnecessary comparisons in boolean expressions	215
Avoid unnecessary comparisons in boolean expressions	222
An empty method in an abstract class should be abstract instead	237 - 367
Avoid using final local variables, turn them into fields	239
Avoid unnecessary comparisons in boolean expressions	243
Avoid unnecessary comparisons in boolean expressions	243
Avoid using final local variables, turn them into fields	247
Avoid using final local variables, turn them into fields	248
Avoid unnecessary comparisons in boolean expressions	249
Avoid unnecessary comparisons in boolean expressions	250
Avoid unnecessary comparisons in boolean expressions	257
Avoid empty if statements	264 - 266
Avoid using final local variables, turn them into fields	269
Avoid using final local variables, turn them into fields	270
Avoid instantiating new objects inside loops	270
Avoid instantiating new objects inside loops	273
Avoid instantiating new objects inside loops	275
Avoid instantiating new objects inside loops	277
Avoid instantiating new objects inside loops	279
Avoid unnecessary comparisons in boolean expressions	286
Avoid unnecessary comparisons in boolean expressions	291
Avoid unnecessary comparisons in boolean expressions	298
Avoid unnecessary comparisons in boolean expressions	299
Avoid using final local variables, turn them into fields	305
Avoid unnecessary comparisons in boolean expressions	306
Avoid unnecessary comparisons in boolean expressions	309
Avoid unnecessary comparisons in boolean expressions	315
Avoid using final local variables, turn them into fields	322
Avoid unnecessary comparisons in boolean expressions	324
Avoid using final local variables, turn them into fields	336
Avoid instantiating new objects inside loops	336
Avoid using final local variables, turn them into fields	337
Avoid instantiating new objects inside loops	337
Avoid unnecessary comparisons in boolean expressions	338
Avoid unnecessary comparisons in boolean expressions	353
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	358
Avoid using final local variables, turn them into fields	361
Avoid unnecessary comparisons in boolean expressions	363
An empty method in an abstract class should be abstract instead	380 - 398
Avoid unnecessary comparisons in boolean expressions	386
Avoid unnecessary comparisons in boolean expressions	390
Avoid unnecessary comparisons in boolean expressions	394
Avoid unnecessary comparisons in boolean expressions	394

org/projectforge/core/AbstractCronJob.java

Violation	Line
An empty method in an abstract class should be abstract instead	39 - 46
Avoid using final local variables, turn them into fields	41

org/projectforge/core/AbstractHistorizableBaseDO.java

Violation	Line
An empty method in an abstract class should be abstract instead	52 - 55
An empty method in an abstract class should be abstract instead	59 - 62
An empty method in an abstract class should be abstract instead	65 - 68

org/projectforge/core/ActionLog.java

Violation	Line
Avoid appending characters as strings in StringBuffer.append.	77
Avoid appending characters as strings in StringBuffer.append.	91

org/projectforge/core/BaseDao.java

Violation	Line
SYNCHRONISATION: Use block level rather than method level synchronization	169 - 215
An empty method in an abstract class should be abstract instead	169 - 215
Returning 'searchFields' may expose an internal array.	172
Avoid using final local variables, turn them into fields	174
Avoid using final local variables, turn them into fields	175
Avoid unnecessary comparisons in boolean expressions	177
Avoid using final local variables, turn them into fields	179
Avoid unnecessary comparisons in boolean expressions	181
Avoid using final local variables, turn them into fields	186
Avoid unnecessary comparisons in boolean expressions	190
Avoid unnecessary comparisons in boolean expressions	192
Avoid using final local variables, turn them into fields	196
Avoid unnecessary comparisons in boolean expressions	198
Avoid using final local variables, turn them into fields	199
Avoid unnecessary comparisons in boolean expressions	201
Avoid using final local variables, turn them into fields	202
Returning 'searchFields' may expose an internal array.	214
An empty method in an abstract class should be abstract instead	221 - 224
Avoid unnecessary comparisons in boolean expressions	228
An empty method in an abstract class should be abstract instead	262 - 264
An empty method in an abstract class should be abstract instead	275 - 278
An empty method in an abstract class should be abstract instead	288 - 291
An empty method in an abstract class should be abstract instead	299 - 315
Avoid unnecessary comparisons in boolean expressions	301
Avoid using final local variables, turn them into fields	304
Avoid unnecessary comparisons in boolean expressions	308
Avoid using final local variables, turn them into fields	312 - 313
Consider simply returning the value vs storing it in local variable 'result'	314
An empty method in an abstract class should be abstract instead	318 - 323
Avoid using final local variables, turn them into fields	320 - 321
Consider simply returning the value vs storing it in local variable 'list'	322
An empty method in an abstract class should be abstract instead	332 - 336
Avoid using final local variables, turn them into fields	334
An empty method in an abstract class should be abstract instead	344 - 353
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	348
An empty method in an abstract class should be abstract instead	362 - 426
Avoid using final local variables, turn them into fields	364
Avoid unnecessary comparisons in boolean expressions	366
Avoid using final local variables, turn them into fields	371
Avoid unnecessary comparisons in boolean expressions	372
Avoid using final local variables, turn them into fields	375
Avoid using final local variables, turn them into fields	376
Avoid using final local variables, turn them into fields	377
Avoid using final local variables, turn them into fields	384 - 390
Avoid using final local variables, turn them into fields	395
Avoid using final local variables, turn them into fields	399 - 405
Avoid unnecessary comparisons in boolean expressions	414
Avoid using final local variables, turn them into fields	415
Avoid using final local variables, turn them into fields	416
Avoid unnecessary comparisons in boolean expressions	418
An empty method in an abstract class should be abstract instead	434 - 440
An empty method in an abstract class should be abstract instead	442 - 447
Avoid using final local variables, turn them into fields	444 - 445
Consider simply returning the value vs storing it in local variable 'result'	446
An empty method in an abstract class should be abstract instead	449 - 459
Avoid using final local variables, turn them into fields	451
Avoid unnecessary comparisons in boolean expressions	453
An empty method in an abstract class should be abstract instead	465 - 468
An empty method in an abstract class should be abstract instead	480 - 517
Avoid unnecessary comparisons in boolean expressions	485
This call to String.startsWith can be rewritten using String.charAt(0)	485
Avoid using final local variables, turn them into fields	489
Avoid unnecessary comparisons in boolean expressions	490
Avoid unnecessary comparisons in boolean expressions	490
Avoid using final local variables, turn them into fields	491
Avoid using final local variables, turn them into fields	497
Avoid using final local variables, turn them into fields	498
Avoid unnecessary comparisons in boolean expressions	501
Avoid appending characters as strings in StringBuffer.append.	504
Avoid unnecessary comparisons in boolean expressions	506
Avoid using final local variables, turn them into fields	507
Avoid unnecessary comparisons in boolean expressions	509
Avoid unnecessary comparisons in boolean expressions	509
An empty method in an abstract class should be abstract instead	524 - 535
Avoid using final local variables, turn them into fields	526
Avoid using final local variables, turn them into fields	528
An empty method in an abstract class should be abstract instead	542 - 551
Avoid using final local variables, turn them into fields	545
An empty method in an abstract class should be abstract instead	554 - 562
Avoid using final local variables, turn them into fields	559
An empty method in an abstract class should be abstract instead	570 - 574
An empty method in an abstract class should be abstract instead	577 - 582
Avoid using final local variables, turn them into fields	579
An empty method in an abstract class should be abstract instead	591 - 607
Avoid unnecessary comparisons in boolean expressions	593
Avoid using final local variables, turn them into fields	596 - 605
Avoid using final local variables, turn them into fields	599
An empty method in an abstract class should be abstract instead	609 - 622
Avoid using final local variables, turn them into fields	611 - 620
Avoid using final local variables, turn them into fields	614
An empty method in an abstract class should be abstract instead	624 - 632
Avoid using final local variables, turn them into fields	626
Avoid using final local variables, turn them into fields	628
An empty method in an abstract class should be abstract instead	634 - 648
Avoid using final local variables, turn them into fields	636
Avoid using final local variables, turn them into fields	637
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	638
Avoid using final local variables, turn them into fields	639
Avoid using final local variables, turn them into fields	643
Avoid instantiating new objects inside loops	643
An empty method in an abstract class should be abstract instead	657 - 683
Avoid using final local variables, turn them into fields	659 - 681
Avoid using final local variables, turn them into fields	662
Avoid using final local variables, turn them into fields	666
Avoid using final local variables, turn them into fields	668
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	669
Avoid using final local variables, turn them into fields	670
Avoid using final local variables, turn them into fields	674
An empty method in an abstract class should be abstract instead	691 - 700
An empty method in an abstract class should be abstract instead	707 - 716
An empty method in an abstract class should be abstract instead	740 - 748
Avoid unnecessary comparisons in boolean expressions	743
An empty method in an abstract class should be abstract instead	754 - 757
An empty method in an abstract class should be abstract instead	763 - 765
An empty method in an abstract class should be abstract instead	771 - 773
An empty method in an abstract class should be abstract instead	778 - 780
An empty method in an abstract class should be abstract instead	785 - 787
An empty method in an abstract class should be abstract instead	795 - 798
An empty method in an abstract class should be abstract instead	806 - 808
An empty method in an abstract class should be abstract instead	814 - 816
An empty method in an abstract class should be abstract instead	822 - 824
An empty method in an abstract class should be abstract instead	830 - 832
An empty method in an abstract class should be abstract instead	840 - 857
Avoid using final local variables, turn them into fields	848
Avoid using final local variables, turn them into fields	849
Avoid using final local variables, turn them into fields	870
Avoid using final local variables, turn them into fields	895
An empty method in an abstract class should be abstract instead	916 - 925
Avoid using final local variables, turn them into fields	920
An empty method in an abstract class should be abstract instead	934 - 937
An empty method in an abstract class should be abstract instead	947 - 985
Avoid using final local variables, turn them into fields	951
Avoid unnecessary comparisons in boolean expressions	952
Avoid using final local variables, turn them into fields	956
Avoid unnecessary comparisons in boolean expressions	957
Avoid using final local variables, turn them into fields	962
Avoid using final local variables, turn them into fields	964
Avoid unnecessary comparisons in boolean expressions	965
Avoid using final local variables, turn them into fields	972
Avoid unnecessary comparisons in boolean expressions	976
Avoid unnecessary comparisons in boolean expressions	981
Avoid unnecessary comparisons in boolean expressions	994
An empty method in an abstract class should be abstract instead	1003 - 1008
Avoid using final local variables, turn them into fields	1005
An empty method in an abstract class should be abstract instead	1014 - 1016
Avoid using final local variables, turn them into fields	1027
Avoid using final local variables, turn them into fields	1031
Avoid unnecessary comparisons in boolean expressions	1039
Avoid using final local variables, turn them into fields	1045
Avoid using final local variables, turn them into fields	1050
Avoid using final local variables, turn them into fields	1068
Avoid using final local variables, turn them into fields	1073
Avoid using final local variables, turn them into fields	1079
Avoid using final local variables, turn them into fields	1096
Avoid using final local variables, turn them into fields	1108
Avoid using final local variables, turn them into fields	1116
Avoid unnecessary comparisons in boolean expressions	1129
Avoid unnecessary comparisons in boolean expressions	1138
Avoid unnecessary comparisons in boolean expressions	1147
Avoid unnecessary comparisons in boolean expressions	1147
Avoid unnecessary comparisons in boolean expressions	1161
Avoid unnecessary comparisons in boolean expressions	1185
Avoid unnecessary comparisons in boolean expressions	1194
An empty method in an abstract class should be abstract instead	1206 - 1209
An empty method in an abstract class should be abstract instead	1216 - 1219
An empty method in an abstract class should be abstract instead	1229 - 1232
An empty method in an abstract class should be abstract instead	1257 - 1260
An empty method in an abstract class should be abstract instead	1269 - 1272
An empty method in an abstract class should be abstract instead	1279 - 1282
An empty method in an abstract class should be abstract instead	1289 - 1298
Avoid unnecessary comparisons in boolean expressions	1291
An empty method in an abstract class should be abstract instead	1304 - 1307
An empty method in an abstract class should be abstract instead	1313 - 1319
An empty method in an abstract class should be abstract instead	1327 - 1330
An empty method in an abstract class should be abstract instead	1338 - 1341
An empty method in an abstract class should be abstract instead	1349 - 1352
An empty method in an abstract class should be abstract instead	1360 - 1366
An empty method in an abstract class should be abstract instead	1375 - 1378
An empty method in an abstract class should be abstract instead	1387 - 1390
An empty method in an abstract class should be abstract instead	1399 - 1402
An empty method in an abstract class should be abstract instead	1411 - 1414
An empty method in an abstract class should be abstract instead	1424 - 1427
Avoid using final local variables, turn them into fields	1433
Avoid using final local variables, turn them into fields	1434
An empty method in an abstract class should be abstract instead	1453 - 1474
Avoid unnecessary comparisons in boolean expressions	1456
Avoid using final local variables, turn them into fields	1459 - 1466
Avoid using final local variables, turn them into fields	1467
Avoid using final local variables, turn them into fields	1468
Avoid using final local variables, turn them into fields	1472
Consider simply returning the value vs storing it in local variable 'list'	1473
Avoid using final local variables, turn them into fields	1482
Avoid using final local variables, turn them into fields	1491
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	1508
Avoid using final local variables, turn them into fields	1515
Avoid unnecessary comparisons in boolean expressions	1517
An empty method in an abstract class should be abstract instead	1533 - 1536
An empty method in an abstract class should be abstract instead	1550 - 1565
Avoid unnecessary comparisons in boolean expressions	1553
Avoid unnecessary comparisons in boolean expressions	1553
Avoid using final local variables, turn them into fields	1557
Avoid using final local variables, turn them into fields	1571
Avoid using final local variables, turn them into fields	1572
Avoid using final local variables, turn them into fields	1587 - 1588
An empty method in an abstract class should be abstract instead	1596 - 1599
An empty method in an abstract class should be abstract instead	1604 - 1607
An empty method in an abstract class should be abstract instead	1612 - 1615

org/projectforge/core/BaseDaoReindexRegistry.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	56

org/projectforge/core/BaseSearchFilter.java

Violation	Line
Returning 'searchFields' may expose an internal array.	111

org/projectforge/core/ConfigXml.java

Violation	Line
Possible unsafe assignment to a non-final static field in a constructor.	96
Do not use the short type	142
Avoid unnecessary comparisons in boolean expressions	246
Avoid unnecessary comparisons in boolean expressions	250
Avoid using final local variables, turn them into fields	266
Avoid using final local variables, turn them into fields	267
Avoid unnecessary comparisons in boolean expressions	268
Avoid unnecessary comparisons in boolean expressions	269
Avoid using final local variables, turn them into fields	273
Avoid unnecessary comparisons in boolean expressions	274
Avoid using final local variables, turn them into fields	277
Avoid using final local variables, turn them into fields	278
Avoid unnecessary comparisons in boolean expressions	284
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'readConfiguration' called during object construction	289
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'getKeystoreFile' called during object construction	299
Avoid unnecessary comparisons in boolean expressions	319
Avoid using final local variables, turn them into fields	323
Avoid using final local variables, turn them into fields	333
Avoid using final local variables, turn them into fields	334
Prefer StringBuffer over += for concatenating strings	338
Avoid using final local variables, turn them into fields	355 - 365
Avoid unnecessary comparisons in boolean expressions	359
Avoid unnecessary comparisons in boolean expressions	360
Avoid using final local variables, turn them into fields	366
Avoid using final local variables, turn them into fields	372
Avoid using final local variables, turn them into fields	373
Avoid using final local variables, turn them into fields	386
Avoid using final local variables, turn them into fields	387
Avoid using final local variables, turn them into fields	388
Avoid using final local variables, turn them into fields	397
Avoid using final local variables, turn them into fields	398
Avoid using final local variables, turn them into fields	410
Avoid using final local variables, turn them into fields	413
Avoid using final local variables, turn them into fields	415
Avoid using final local variables, turn them into fields	416
Avoid using final local variables, turn them into fields	427
Avoid using final local variables, turn them into fields	428
TOTE_METHODEN: Avoid unused private methods such as 'copyDeclaredFields(String,Class,Object,Object,String)'.	436 - 437
Avoid using final local variables, turn them into fields	439
Avoid unnecessary comparisons in boolean expressions	442
Avoid using final local variables, turn them into fields	444
Avoid empty if statements	445 - 447
Avoid using final local variables, turn them into fields	448
Avoid using final local variables, turn them into fields	450
Avoid instantiating new objects inside loops	450
Avoid using final local variables, turn them into fields	456
Avoid appending characters as strings in StringBuffer.append.	466
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	473
Avoid using final local variables, turn them into fields	477
Avoid using final local variables, turn them into fields	493
Avoid unnecessary comparisons in boolean expressions	494
Avoid using final local variables, turn them into fields	495
Avoid unnecessary comparisons in boolean expressions	496
Avoid using final local variables, turn them into fields	510
Avoid using final local variables, turn them into fields	511
Avoid using final local variables, turn them into fields	520
Avoid using final local variables, turn them into fields	535
Avoid using final local variables, turn them into fields	536
Avoid unnecessary comparisons in boolean expressions	550
Avoid unnecessary comparisons in boolean expressions	553
Avoid using final local variables, turn them into fields	553
Avoid unnecessary comparisons in boolean expressions	561
Avoid unnecessary comparisons in boolean expressions	564
Avoid using final local variables, turn them into fields	564
Avoid unnecessary comparisons in boolean expressions	586
Avoid unnecessary comparisons in boolean expressions	590
Do not use the short type	731
Avoid unnecessary comparisons in boolean expressions	736
Avoid using final local variables, turn them into fields	764
Avoid unnecessary comparisons in boolean expressions	853

org/projectforge/core/Configuration.java

Violation	Line
Possible unsafe assignment to a non-final static field in a constructor.	50
Avoid unnecessary comparisons in boolean expressions	105
Avoid unnecessary comparisons in boolean expressions	106
Avoid using final local variables, turn them into fields	127
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	142
Consider simply returning the value vs storing it in local variable 'sa'	143
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	165
Avoid using final local variables, turn them into fields	166
Consider simply returning the value vs storing it in local variable 'sa'	167
Avoid using final local variables, turn them into fields	175
Avoid using final local variables, turn them into fields	198
Avoid unnecessary if..then..else statements when returning a boolean	199 - 203
Avoid using final local variables, turn them into fields	221
Avoid unnecessary comparisons in boolean expressions	252
Avoid using final local variables, turn them into fields	258
Avoid unnecessary comparisons in boolean expressions	270

org/projectforge/core/ConfigurationDO.java

Violation	Line
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	148
Consider simply returning the value vs storing it in local variable 'timeZone'	149
Avoid unnecessary comparisons in boolean expressions	230
Avoid unnecessary comparisons in boolean expressions	275
Avoid unnecessary comparisons in boolean expressions	278
Avoid unnecessary comparisons in boolean expressions	281
Avoid unnecessary comparisons in boolean expressions	295
Avoid empty if statements	314 - 316
Avoid empty if statements	317 - 319
Avoid unnecessary comparisons in boolean expressions	317
Avoid empty if statements	319 - 321
Avoid empty if statements	321 - 323

org/projectforge/core/ConfigurationDao.java

Violation	Line
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	69
Avoid unnecessary comparisons in boolean expressions	74
Avoid using final local variables, turn them into fields	85 - 86
Avoid unnecessary comparisons in boolean expressions	87
Avoid unnecessary comparisons in boolean expressions	95
Avoid using final local variables, turn them into fields	99
Avoid unnecessary comparisons in boolean expressions	105
Avoid using final local variables, turn them into fields	124
Avoid unnecessary comparisons in boolean expressions	165
Avoid unnecessary comparisons in boolean expressions	172
Avoid unnecessary comparisons in boolean expressions	177
Avoid using final local variables, turn them into fields	185
Avoid unnecessary comparisons in boolean expressions	188

org/projectforge/core/CronHourlyJob.java

Violation	Line
Avoid using final local variables, turn them into fields	52

org/projectforge/core/CronSetup.java

Violation	Line
Avoid using final local variables, turn them into fields	76
Avoid unnecessary comparisons in boolean expressions	77
TOTE_METHODEN: Avoid unused private methods such as 'createCron(String,Class,String,String,Object)'.	106 - 107
Avoid using final local variables, turn them into fields	110
Avoid using final local variables, turn them into fields	113
Avoid using final local variables, turn them into fields	119
Avoid unnecessary comparisons in boolean expressions	120
Avoid using final local variables, turn them into fields	125

org/projectforge/core/CurrencyFormatter.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 66
KONSTANTHEIT_VERSTECKTE: Local variable 'nf' could be declared final	63

org/projectforge/core/DisplayHistoryEntry.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'userId' could be declared final	72
Avoid unnecessary comparisons in boolean expressions	84
KONSTANTHEIT_VERSTECKTE: Local variable 'id' could be declared final	87
Avoid unnecessary comparisons in boolean expressions	100
KONSTANTHEIT_VERSTECKTE: Local variable 'propType' could be declared final	116
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'toShortName' called during object construction	118
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'toShortName' called during object construction	119
Avoid unnecessary comparisons in boolean expressions	120
Avoid unnecessary comparisons in boolean expressions	121
Avoid unnecessary comparisons in boolean expressions	122
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'toShortName' called during object construction	126
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'toShortName' called during object construction	127

org/projectforge/core/HibernateSearchDependentObjectsReindexer.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	100
Avoid using final local variables, turn them into fields	103
Avoid unnecessary comparisons in boolean expressions	104
Avoid unnecessary comparisons in boolean expressions	104
Avoid using final local variables, turn them into fields	110
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'register' called during object construction	112
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'register' called during object construction	112
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	125
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	129
Avoid unnecessary comparisons in boolean expressions	140
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	150
Avoid unnecessary comparisons in boolean expressions	167
Avoid unnecessary comparisons in boolean expressions	168
Avoid using final local variables, turn them into fields	174
Avoid unnecessary comparisons in boolean expressions	184
Avoid using final local variables, turn them into fields	192
Avoid using final local variables, turn them into fields	199
Avoid unnecessary comparisons in boolean expressions	200
Avoid unnecessary comparisons in boolean expressions	205
Avoid using final local variables, turn them into fields	208
Consider simply returning the value vs storing it in local variable 'result'	209
Avoid using final local variables, turn them into fields	219
Avoid using final local variables, turn them into fields	225
Avoid unnecessary comparisons in boolean expressions	227
Avoid unnecessary comparisons in boolean expressions	228
Avoid unnecessary comparisons in boolean expressions	231
Avoid unnecessary comparisons in boolean expressions	231
Avoid using final local variables, turn them into fields	233
Avoid using final local variables, turn them into fields	235
Avoid unnecessary comparisons in boolean expressions	242
Avoid using final local variables, turn them into fields	246
Avoid using final local variables, turn them into fields	247
Avoid instantiating new objects inside loops	247
Avoid instantiating new objects inside loops	250
Avoid using final local variables, turn them into fields	251 - 252
Avoid unnecessary comparisons in boolean expressions	256

org/projectforge/core/HibernateSearchPhoneNumberBridge.java

Violation	Line
No need to call String.valueOf to append to a string.	39

org/projectforge/core/HibernateSearchReindexer.java

Violation	Line
Avoid using final local variables, turn them into fields	52
Avoid unnecessary comparisons in boolean expressions	53
Avoid using final local variables, turn them into fields	55
Avoid unnecessary comparisons in boolean expressions	56
Avoid using final local variables, turn them into fields	58

org/projectforge/core/HistoryUser.java

Violation	Line
Avoid using final local variables, turn them into fields	76

org/projectforge/core/InternalErrorException.java

Violation	Line
Returning 'msgParams' may expose an internal array.	96
Returning 'params' may expose an internal array.	104
Returning 'params' may expose an internal array.	114
Avoid unnecessary comparisons in boolean expressions	118
KONSTANTHEIT_VERSTECKTE: Local variable 'builder' could be declared final	130

org/projectforge/core/MemoryQueryFilter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'searchKeys' could be made final; it is only initialized in the declaration or constructor.	37
KONSTANTHEIT_VERSTECKTE: Private field 'fields' could be made final; it is only initialized in the declaration or constructor.	39
Returning 'fields' may expose an internal array.	56
Returning 'searchKeys' may expose an internal array.	61

org/projectforge/core/MessageParam.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'value' could be made final; it is only initialized in the declaration or constructor.	32
KONSTANTHEIT_VERSTECKTE: Private field 'paramType' could be made final; it is only initialized in the declaration or constructor.	34
Avoid unnecessary comparisons in boolean expressions	69

org/projectforge/core/NumberFormatter.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 118
Avoid using final local variables, turn them into fields	41
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	99

org/projectforge/core/PrintingHistoryFormatter.java

Violation	Line
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	69

org/projectforge/core/Priority.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	49
Avoid unnecessary comparisons in boolean expressions	52
Avoid unnecessary comparisons in boolean expressions	54
Avoid unnecessary comparisons in boolean expressions	56
Avoid unnecessary comparisons in boolean expressions	58
Avoid unnecessary comparisons in boolean expressions	60

org/projectforge/core/QueryFilter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'filterSettings' could be made final; it is only initialized in the declaration or constructor.	48
KONSTANTHEIT_VERSTECKTE: Local variable 'cal' could be declared final	175
KONSTANTHEIT_VERSTECKTE: Local variable 'lastDayOfMonth' could be declared final	183
KONSTANTHEIT_VERSTECKTE: Local variable 'lastDayOfYear' could be declared final	189
KONSTANTHEIT_VERSTECKTE: Local variable 'criteria' could be declared final	199
KONSTANTHEIT_VERSTECKTE: Local variable 'alias' could be declared final	212
KONSTANTHEIT_VERSTECKTE: Local variable 'filter' could be declared final	215
Avoid unnecessary comparisons in boolean expressions	217
KONSTANTHEIT_VERSTECKTE: Local variable 'filter' could be declared final	244
KONSTANTHEIT_VERSTECKTE: Local variable 'filter' could be declared final	251

org/projectforge/core/ReindexSettings.java

Violation	Line
Avoid using final local variables, turn them into fields	60

org/projectforge/core/ScriptingDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field '__baseDao' could be made final; it is only initialized in the declaration or constructor.	34

org/projectforge/core/SearchDao.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	49
Avoid unnecessary comparisons in boolean expressions	49
Avoid using final local variables, turn them into fields	60
Avoid using final local variables, turn them into fields	61
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	62
Avoid using final local variables, turn them into fields	69
Avoid instantiating new objects inside loops	69
Avoid instantiating new objects inside loops	79

org/projectforge/core/SearchFilter.java

Violation	Line
Avoid using final local variables, turn them into fields	54
Avoid using final local variables, turn them into fields	66
Avoid unnecessary comparisons in boolean expressions	102

org/projectforge/core/SendFeedback.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'params' could be made final; it is only initialized in the declaration or constructor.	38
Avoid using final local variables, turn them into fields	50
KONSTANTHEIT_VERSTECKTE: Local variable 'content' could be declared final	54

org/projectforge/core/SimpleHistoryEntry.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'userId' could be declared final	61

org/projectforge/core/SystemDao.java

Violation	Line
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	95
StringBuffer constructor is initialized with size 16, but has at least 292 characters appended.	95
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	104
Avoid unnecessary comparisons in boolean expressions	112
Avoid unnecessary comparisons in boolean expressions	132
Avoid unnecessary comparisons in boolean expressions	141

org/projectforge/core/SystemInfoCache.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	57
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	100

org/projectforge/core/Translation.java

Violation	Line
It is somewhat confusing to have a field name matching the declaring class name	41

org/projectforge/core/UserException.java

Violation	Line
Returning 'msgParams' may expose an internal array.	92
Returning 'params' may expose an internal array.	100
Returning 'params' may expose an internal array.	110
Avoid unnecessary comparisons in boolean expressions	114
KONSTANTHEIT_VERSTECKTE: Local variable 'builder' could be declared final	126

org/projectforge/database/AutoSessionFactoryBean.java

Violation	Line
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	53
Avoid unnecessary comparisons in boolean expressions	77

org/projectforge/database/DatabaseDao.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	75
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	100
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	142
Avoid unnecessary comparisons in boolean expressions	143
Avoid using final local variables, turn them into fields	144
Avoid using final local variables, turn them into fields	145
Avoid appending characters as strings in StringBuffer.append.	155
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	180
Avoid unnecessary comparisons in boolean expressions	184
Avoid using final local variables, turn them into fields	187
Avoid unnecessary comparisons in boolean expressions	188
Avoid using final local variables, turn them into fields	189
Avoid using final local variables, turn them into fields	199
Avoid using final local variables, turn them into fields	214
Avoid unnecessary comparisons in boolean expressions	215

org/projectforge/database/DatabaseSupport.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	39
Singleton is not thread safe	45 - 47
Avoid unnecessary comparisons in boolean expressions	74
Avoid unnecessary comparisons in boolean expressions	92
Avoid unnecessary comparisons in boolean expressions	101
Avoid unnecessary comparisons in boolean expressions	138
Avoid unnecessary comparisons in boolean expressions	141
Avoid appending characters as strings in StringBuffer.append.	142
Avoid unnecessary comparisons in boolean expressions	145
Avoid appending characters as strings in StringBuffer.append.	146
Avoid unnecessary comparisons in boolean expressions	148
Avoid using final local variables, turn them into fields	156
Avoid appending characters as strings in StringBuffer.append.	157

org/projectforge/database/DatabaseUpdateDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	66
Avoid unnecessary comparisons in boolean expressions	83
Avoid unnecessary comparisons in boolean expressions	87
Avoid unnecessary comparisons in boolean expressions	103
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	147
Avoid instantiating new objects inside loops	147
Avoid unnecessary comparisons in boolean expressions	148
Avoid using final local variables, turn them into fields	165
Avoid unnecessary comparisons in boolean expressions	180
Avoid unnecessary comparisons in boolean expressions	184
Avoid unnecessary comparisons in boolean expressions	211
Avoid using final local variables, turn them into fields	219
Avoid unnecessary comparisons in boolean expressions	225
Avoid appending characters as strings in StringBuffer.append.	241
Avoid unnecessary comparisons in boolean expressions	242
Avoid appending characters as strings in StringBuffer.append.	256
Avoid appending characters as strings in StringBuffer.append.	257
Avoid unnecessary comparisons in boolean expressions	264
Avoid using final local variables, turn them into fields	268
Avoid unnecessary comparisons in boolean expressions	277
Avoid using final local variables, turn them into fields	293
Avoid using final local variables, turn them into fields	315
Avoid using final local variables, turn them into fields	329
RESSOURCEN_SCHLIESSEN: Ensure that resources like this ResultSet object are closed after use	347
KONSTANTHEIT_VERSTECKTE: Local variable 'reference' could be declared final	347
KONSTANTHEIT_VERSTECKTE: Local variable 'fkTable' could be declared final	349
KONSTANTHEIT_VERSTECKTE: Local variable 'fkCol' could be declared final	350
Avoid unnecessary comparisons in boolean expressions	351
Avoid unnecessary comparisons in boolean expressions	353
Avoid using final local variables, turn them into fields	366
StringBuffer constructor is initialized with size 16, but has at least 25 characters appended.	366
Avoid appending characters as strings in StringBuffer.append.	372
Avoid using final local variables, turn them into fields	373
Avoid using final local variables, turn them into fields	374
Avoid using final local variables, turn them into fields	396
Avoid using final local variables, turn them into fields	398
Avoid unnecessary comparisons in boolean expressions	405
Avoid using final local variables, turn them into fields	406
Avoid using final local variables, turn them into fields	407
Avoid using final local variables, turn them into fields	408
Avoid using final local variables, turn them into fields	409
Avoid using final local variables, turn them into fields	410
Avoid using final local variables, turn them into fields	411
Avoid using final local variables, turn them into fields	412
Avoid using final local variables, turn them into fields	413
Avoid using final local variables, turn them into fields	422
StringBuffer constructor is initialized with size 16, but has at least 49 characters appended.	422
Avoid appending characters as strings in StringBuffer.append.	426
Avoid unnecessary comparisons in boolean expressions	430
Avoid appending characters as strings in StringBuffer.append.	435
Avoid unnecessary comparisons in boolean expressions	438
Avoid appending characters as strings in StringBuffer.append.	443
Avoid using final local variables, turn them into fields	446
Do not add empty strings	456
Avoid unnecessary comparisons in boolean expressions	463
Avoid using final local variables, turn them into fields	464
Avoid using final local variables, turn them into fields	465
Avoid using final local variables, turn them into fields	466
Avoid using final local variables, turn them into fields	471
Avoid using final local variables, turn them into fields	472
Do not add empty strings	482
Avoid unnecessary comparisons in boolean expressions	493
Avoid using final local variables, turn them into fields	496
Avoid unnecessary comparisons in boolean expressions	504
Avoid using final local variables, turn them into fields	507
Consider simply returning the value vs storing it in local variable 'id'	508
Avoid using final local variables, turn them into fields	522
Avoid using final local variables, turn them into fields	523
Avoid using final local variables, turn them into fields	569
Avoid unnecessary comparisons in boolean expressions	571
Avoid using final local variables, turn them into fields	587

org/projectforge/database/DatabaseUpdateHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 136
Avoid using final local variables, turn them into fields	46
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	69
WRAPPER_INSTANZIIERUNG: Avoid instantiating Integer objects. Call Integer.valueOf() instead.	69
Consider simply returning the value vs storing it in local variable 'result'	70
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	104
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	117
Avoid unnecessary comparisons in boolean expressions	121
Avoid unnecessary comparisons in boolean expressions	126
Avoid using final local variables, turn them into fields	133

org/projectforge/database/HibernateUtils.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	61
Avoid unnecessary comparisons in boolean expressions	98
Avoid unnecessary comparisons in boolean expressions	121
Avoid unnecessary comparisons in boolean expressions	144
Avoid unnecessary comparisons in boolean expressions	144
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	148
Avoid unnecessary comparisons in boolean expressions	150
Avoid printStackTrace(); use a logger call instead.	154
Avoid printStackTrace(); use a logger call instead.	156
Avoid unnecessary comparisons in boolean expressions	170
Avoid unnecessary comparisons in boolean expressions	170
Avoid using final local variables, turn them into fields	171
Avoid printStackTrace(); use a logger call instead.	177
Avoid printStackTrace(); use a logger call instead.	179
Avoid using final local variables, turn them into fields	230
Avoid unnecessary comparisons in boolean expressions	231
Avoid unnecessary comparisons in boolean expressions	233
Avoid using final local variables, turn them into fields	241
Avoid using final local variables, turn them into fields	247
Avoid using final local variables, turn them into fields	248
Avoid using final local variables, turn them into fields	250
Avoid unnecessary comparisons in boolean expressions	251
Avoid unnecessary comparisons in boolean expressions	267
Avoid using final local variables, turn them into fields	270
Avoid using final local variables, turn them into fields	272
Avoid unnecessary comparisons in boolean expressions	273
Avoid unnecessary comparisons in boolean expressions	288
Avoid using final local variables, turn them into fields	296
Avoid unnecessary comparisons in boolean expressions	297
Avoid unnecessary comparisons in boolean expressions	299

org/projectforge/database/InitDatabaseDao.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	134
Avoid using final local variables, turn them into fields	137
Avoid using final local variables, turn them into fields	143
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	186
Avoid unnecessary comparisons in boolean expressions	197
Avoid using final local variables, turn them into fields	200
Avoid using final local variables, turn them into fields	202
Avoid unnecessary comparisons in boolean expressions	215
Avoid using final local variables, turn them into fields	246
Avoid unnecessary comparisons in boolean expressions	247
Avoid unnecessary comparisons in boolean expressions	248
Avoid using final local variables, turn them into fields	252
Avoid unnecessary comparisons in boolean expressions	253
Avoid unnecessary comparisons in boolean expressions	254
Avoid using final local variables, turn them into fields	261

org/projectforge/database/JPAHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 180
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	49
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	111
Avoid using final local variables, turn them into fields	170

org/projectforge/database/SQLHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 82
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	59
KONSTANTHEIT_VERSTECKTE: Local variable 'min' could be declared final	64
KONSTANTHEIT_VERSTECKTE: Local variable 'max' could be declared final	65
KONSTANTHEIT_VERSTECKTE: Local variable 'cal' could be declared final	66

org/projectforge/database/SchemaExport.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'exp' could be declared final	46
KONSTANTHEIT_VERSTECKTE: Local variable 'exp' could be declared final	65
KONSTANTHEIT_VERSTECKTE: Local variable 'exp' could be declared final	87

org/projectforge/database/StatisticsCache.java

Violation	Line
The Logger variable declaration does not contain the static and final modifiers	44
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	72

org/projectforge/database/Table.java

Violation	Line
Avoid using final local variables, turn them into fields	54
Avoid using final local variables, turn them into fields	55
Avoid unnecessary comparisons in boolean expressions	56
Avoid unnecessary comparisons in boolean expressions	84
Avoid unnecessary comparisons in boolean expressions	108
Avoid instantiating new objects inside loops	140

org/projectforge/database/TableAttribute.java

Violation	Line
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	90
Avoid unnecessary comparisons in boolean expressions	91
Avoid unnecessary comparisons in boolean expressions	91
Avoid unnecessary comparisons in boolean expressions	93
Avoid unnecessary comparisons in boolean expressions	93
Avoid unnecessary comparisons in boolean expressions	95
Avoid unnecessary comparisons in boolean expressions	95
Avoid unnecessary comparisons in boolean expressions	97
Avoid unnecessary comparisons in boolean expressions	99
Avoid unnecessary comparisons in boolean expressions	101
Avoid unnecessary comparisons in boolean expressions	103
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	107
Avoid unnecessary comparisons in boolean expressions	108
Avoid using final local variables, turn them into fields	110
Avoid using final local variables, turn them into fields	115
Avoid unnecessary comparisons in boolean expressions	116
Avoid using final local variables, turn them into fields	129
Avoid unnecessary comparisons in boolean expressions	134
Avoid using final local variables, turn them into fields	137
Avoid unnecessary comparisons in boolean expressions	139
Avoid unnecessary comparisons in boolean expressions	139
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'isPrimaryKey' called during object construction	139
Avoid unnecessary comparisons in boolean expressions	142
Avoid unnecessary comparisons in boolean expressions	145
Avoid using final local variables, turn them into fields	157
Avoid unnecessary comparisons in boolean expressions	159

org/projectforge/database/UserPrefAreaSingleValueConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	57

org/projectforge/database/UserRightIdSingleValueConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	57

org/projectforge/database/XmlDump.java

Violation	Line
Avoid using final local variables, turn them into fields	150 - 197
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	166
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	169
Avoid using final local variables, turn them into fields	173
Avoid using final local variables, turn them into fields	192
Avoid using final local variables, turn them into fields	207
Avoid using final local variables, turn them into fields	210
Avoid using final local variables, turn them into fields	237
Avoid unnecessary comparisons in boolean expressions	241
Avoid using final local variables, turn them into fields	266 - 275
Avoid unnecessary comparisons in boolean expressions	281
Avoid using final local variables, turn them into fields	315
Avoid using final local variables, turn them into fields	323
Avoid using final local variables, turn them into fields	324
Avoid unnecessary comparisons in boolean expressions	329
Avoid using final local variables, turn them into fields	332
Avoid using final local variables, turn them into fields	338
Avoid using final local variables, turn them into fields	340
Avoid unnecessary comparisons in boolean expressions	341
Avoid using final local variables, turn them into fields	349
Avoid using final local variables, turn them into fields	350
Avoid unnecessary comparisons in boolean expressions	362
Avoid using final local variables, turn them into fields	386
Avoid unnecessary comparisons in boolean expressions	387
Avoid unnecessary comparisons in boolean expressions	387
Avoid unnecessary comparisons in boolean expressions	392
Avoid using final local variables, turn them into fields	397
Avoid using final local variables, turn them into fields	398
Avoid unnecessary comparisons in boolean expressions	401
Avoid using final local variables, turn them into fields	405
Avoid using final local variables, turn them into fields	406
Avoid unnecessary comparisons in boolean expressions	407
Avoid unnecessary comparisons in boolean expressions	408
Avoid unnecessary comparisons in boolean expressions	409
Avoid unnecessary comparisons in boolean expressions	417
Avoid unnecessary comparisons in boolean expressions	424
Avoid using final local variables, turn them into fields	430
Avoid using final local variables, turn them into fields	431
Avoid unnecessary comparisons in boolean expressions	433
Avoid unnecessary comparisons in boolean expressions	444
Avoid unnecessary comparisons in boolean expressions	444
Avoid unnecessary comparisons in boolean expressions	447
Avoid unnecessary comparisons in boolean expressions	449
Avoid unnecessary comparisons in boolean expressions	450
Avoid unnecessary comparisons in boolean expressions	463
Avoid unnecessary comparisons in boolean expressions	468
Avoid unnecessary comparisons in boolean expressions	469
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	475
Avoid unnecessary comparisons in boolean expressions	493
Avoid unnecessary comparisons in boolean expressions	498
Avoid unnecessary comparisons in boolean expressions	499
Avoid using final local variables, turn them into fields	520
Avoid using final local variables, turn them into fields	521
Avoid unnecessary comparisons in boolean expressions	523
Avoid unnecessary comparisons in boolean expressions	525
Avoid unnecessary comparisons in boolean expressions	544
Avoid unnecessary comparisons in boolean expressions	548
Avoid unnecessary comparisons in boolean expressions	552

org/projectforge/database/xstream/HibernateCollectionConverter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'listSetConverter' could be made final; it is only initialized in the declaration or constructor.	53
KONSTANTHEIT_VERSTECKTE: Private field 'mapConverter' could be made final; it is only initialized in the declaration or constructor.	55
KONSTANTHEIT_VERSTECKTE: Private field 'treeMapConverter' could be made final; it is only initialized in the declaration or constructor.	57
KONSTANTHEIT_VERSTECKTE: Private field 'treeSetConverter' could be made final; it is only initialized in the declaration or constructor.	59
KONSTANTHEIT_VERSTECKTE: Private field 'defaultConverter' could be made final; it is only initialized in the declaration or constructor.	61
Avoid using implementation types like 'ArrayList'; use the interface instead	65
Avoid using implementation types like 'HashMap'; use the interface instead	66
Avoid using implementation types like 'TreeMap'; use the interface instead	67
Avoid using implementation types like 'TreeSet'; use the interface instead	68
KONSTANTHEIT_VERSTECKTE: Local variable 'col' could be declared final	89

org/projectforge/database/xstream/HibernateCollectionsMapper.java

Violation	Line
Avoid using implementation types like 'ArrayList'; use the interface instead	56
Avoid using implementation types like 'HashSet'; use the interface instead	56
Avoid using implementation types like 'HashMap'; use the interface instead	56
Avoid using implementation types like 'TreeSet'; use the interface instead	57
Avoid using implementation types like 'TreeMap'; use the interface instead	57
Avoid using implementation types like 'ArrayList'; use the interface instead	62
Avoid using implementation types like 'HashSet'; use the interface instead	62
Avoid using implementation types like 'HashMap'; use the interface instead	62
Avoid using implementation types like 'TreeSet'; use the interface instead	62
Avoid using implementation types like 'TreeMap'; use the interface instead	62

org/projectforge/database/xstream/HibernateMapper.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'collectionMap' could be made final; it is only initialized in the declaration or constructor.	57
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'init' called during object construction	62
Avoid using implementation types like 'ArrayList'; use the interface instead	67
Avoid using implementation types like 'ArrayList'; use the interface instead	68
Avoid using implementation types like 'HashMap'; use the interface instead	69
Avoid using implementation types like 'HashSet'; use the interface instead	70
Avoid using implementation types like 'TreeMap'; use the interface instead	71
Avoid using implementation types like 'TreeSet'; use the interface instead	72
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'init' called during object construction	78

org/projectforge/database/xstream/HibernateProxyConverter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'converterLookup' could be made final; it is only initialized in the declaration or constructor.	37
KONSTANTHEIT_VERSTECKTE: Local variable 'item' could be declared final	57

org/projectforge/database/xstream/HibernateXmlConverter.java

Violation	Line
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	160
Avoid using final local variables, turn them into fields	161
Avoid using final local variables, turn them into fields	162
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	171
Avoid unnecessary comparisons in boolean expressions	175
Avoid unnecessary comparisons in boolean expressions	180
Avoid using final local variables, turn them into fields	183
Avoid instantiating new objects inside loops	189
Avoid unnecessary comparisons in boolean expressions	191
Avoid unnecessary comparisons in boolean expressions	198
Avoid using final local variables, turn them into fields	209
TOTE_PARAMETER: Avoid unused method parameters such as 'session'.	225 - 242
TOTE_PARAMETER: Avoid unused method parameters such as 'nullifyPk'.	225 - 242
Avoid using final local variables, turn them into fields	227 - 233

org/projectforge/database/xstream/XStreamSavingConverter.java

Violation	Line
Avoid using final local variables, turn them into fields	97
Avoid unnecessary comparisons in boolean expressions	154
Avoid using final local variables, turn them into fields	157
Avoid using final local variables, turn them into fields	175
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	178
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	189
Avoid using final local variables, turn them into fields	204
Avoid using final local variables, turn them into fields	205
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	217
Avoid using final local variables, turn them into fields	220
Avoid using final local variables, turn them into fields	238
Avoid using final local variables, turn them into fields	239
Avoid unnecessary comparisons in boolean expressions	240
Avoid using final local variables, turn them into fields	241
Avoid using final local variables, turn them into fields	254
Avoid unnecessary comparisons in boolean expressions	277
Avoid unnecessary comparisons in boolean expressions	277
Avoid unnecessary comparisons in boolean expressions	283
Avoid unnecessary comparisons in boolean expressions	286
Avoid using final local variables, turn them into fields	289
Avoid unnecessary comparisons in boolean expressions	294
Avoid unnecessary comparisons in boolean expressions	298
Avoid unnecessary comparisons in boolean expressions	309
Avoid using final local variables, turn them into fields	332
Avoid using final local variables, turn them into fields	333
Avoid unnecessary comparisons in boolean expressions	334
Avoid unnecessary comparisons in boolean expressions	336
Avoid using final local variables, turn them into fields	379
Avoid unnecessary comparisons in boolean expressions	380
Avoid unnecessary comparisons in boolean expressions	438
Avoid unnecessary comparisons in boolean expressions	441

org/projectforge/export/CellFormat.java

Violation	Line
Avoid using final local variables, turn them into fields	173
Avoid unnecessary comparisons in boolean expressions	174
Avoid unnecessary comparisons in boolean expressions	178
clone() method should throw CloneNotSupportedException	190 - 200
clone() method should be implemented only if implementing Cloneable interface	190
Avoid using final local variables, turn them into fields	192

org/projectforge/export/ExportCell.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'poiCell' could be made final; it is only initialized in the declaration or constructor.	34
KONSTANTHEIT_VERSTECKTE: Private field 'row' could be made final; it is only initialized in the declaration or constructor.	36
KONSTANTHEIT_VERSTECKTE: Private field 'col' could be made final; it is only initialized in the declaration or constructor.	38
KONSTANTHEIT_VERSTECKTE: Local variable 'obj' could be declared final	80

org/projectforge/export/ExportJFreeChart.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'jFreeChart' could be made final; it is only initialized in the declaration or constructor.	30
KONSTANTHEIT_VERSTECKTE: Private field 'width' could be made final; it is only initialized in the declaration or constructor.	32
KONSTANTHEIT_VERSTECKTE: Private field 'height' could be made final; it is only initialized in the declaration or constructor.	34

org/projectforge/export/ExportRow.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'sheet' could be made final; it is only initialized in the declaration or constructor.	39
KONSTANTHEIT_VERSTECKTE: Private field 'poiRow' could be made final; it is only initialized in the declaration or constructor.	41
KONSTANTHEIT_VERSTECKTE: Private field 'cellMap' could be made final; it is only initialized in the declaration or constructor.	43
KONSTANTHEIT_VERSTECKTE: Private field 'rowNum' could be made final; it is only initialized in the declaration or constructor.	47
KONSTANTHEIT_VERSTECKTE: Local variable 'poiCell' could be declared final	63
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'addPoiCell' called during object construction	65
KONSTANTHEIT_VERSTECKTE: Local variable 'poiCell' could be declared final	83
KONSTANTHEIT_VERSTECKTE: Local variable 'cell' could be declared final	84
KONSTANTHEIT_VERSTECKTE: Local variable 'cell' could be declared final	94
Returning 'cells' may expose an internal array.	172
KONSTANTHEIT_VERSTECKTE: Local variable 'region' could be declared final	230
KONSTANTHEIT_VERSTECKTE: Local variable 'cell' could be declared final	232
Consider simply returning the value vs storing it in local variable 'cell'	233

org/projectforge/export/ExportSheet.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'poiSheet' could be made final; it is only initialized in the declaration or constructor.	45
KONSTANTHEIT_VERSTECKTE: Private field 'rows' could be made final; it is only initialized in the declaration or constructor.	47
KONSTANTHEIT_VERSTECKTE: Private field 'name' could be made final; it is only initialized in the declaration or constructor.	49
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	67
Avoid using final local variables, turn them into fields	68
Avoid instantiating new objects inside loops	68
Avoid using final local variables, turn them into fields	72
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'getPrintSetup' called during object construction	72
Avoid using final local variables, turn them into fields	86
Avoid using final local variables, turn them into fields	87
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	236
Avoid using final local variables, turn them into fields	238
Avoid using final local variables, turn them into fields	239
Consider simply returning the value vs storing it in local variable 'cell'	240

org/projectforge/export/ExportWorkbook.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'poiWorkbook' could be made final; it is only initialized in the declaration or constructor.	51
KONSTANTHEIT_VERSTECKTE: Private field 'sheets' could be made final; it is only initialized in the declaration or constructor.	53
KONSTANTHEIT_VERSTECKTE: Private field 'dataFormats' could be made final; it is only initialized in the declaration or constructor.	61
KONSTANTHEIT_VERSTECKTE: Local variable 'no' could be declared final	74
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	78
Avoid instantiating new objects inside loops	78
Avoid unnecessary comparisons in boolean expressions	121
Avoid using final local variables, turn them into fields	131
KONSTANTHEIT_VERSTECKTE: Local variable 'poiSheet' could be declared final	157
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	164
Avoid unnecessary comparisons in boolean expressions	182
Do not use the short type	215
Avoid unnecessary comparisons in boolean expressions	217
Do not use the short type	220
KONSTANTHEIT_VERSTECKTE: Local variable 'value' could be declared final	220

org/projectforge/export/PropertyMapping.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	37

org/projectforge/export/SVGHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 326
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	52
Avoid using final local variables, turn them into fields	53
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	76
Avoid appending characters as strings in StringBuffer.append.	77
Avoid appending characters as strings in StringBuffer.append.	80
Avoid appending characters as strings in StringBuffer.append.	81
Avoid appending characters as strings in StringBuffer.append.	83
Avoid appending characters as strings in StringBuffer.append.	84
Avoid appending characters as strings in StringBuffer.append.	86
Avoid appending characters as strings in StringBuffer.append.	88
Avoid appending characters as strings in StringBuffer.append.	92
Avoid appending characters as strings in StringBuffer.append.	93
Avoid appending characters as strings in StringBuffer.append.	95
Avoid appending characters as strings in StringBuffer.append.	96
Avoid appending characters as strings in StringBuffer.append.	98
Avoid appending characters as strings in StringBuffer.append.	100
Avoid using final local variables, turn them into fields	103
Avoid appending characters as strings in StringBuffer.append.	109
Avoid appending characters as strings in StringBuffer.append.	110
Avoid appending characters as strings in StringBuffer.append.	112
Avoid using final local variables, turn them into fields	120
Avoid appending characters as strings in StringBuffer.append.	122
Avoid appending characters as strings in StringBuffer.append.	123
Avoid appending characters as strings in StringBuffer.append.	124
Avoid appending characters as strings in StringBuffer.append.	126
Avoid appending characters as strings in StringBuffer.append.	127
Avoid appending characters as strings in StringBuffer.append.	128
Avoid unnecessary comparisons in boolean expressions	142
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	154 - 155
Avoid unnecessary comparisons in boolean expressions	170
Avoid using final local variables, turn them into fields	184 - 185
Avoid unnecessary comparisons in boolean expressions	211
Avoid using final local variables, turn them into fields	223 - 224
Avoid using final local variables, turn them into fields	231
Consider simply returning the value vs storing it in local variable 'el'	232
Avoid using final local variables, turn them into fields	242
Avoid using final local variables, turn them into fields	245
Avoid using final local variables, turn them into fields	246
Avoid using final local variables, turn them into fields	247
Avoid unnecessary comparisons in boolean expressions	248
Avoid using final local variables, turn them into fields	264
Avoid using final local variables, turn them into fields	277
Avoid unnecessary comparisons in boolean expressions	288
Avoid unnecessary comparisons in boolean expressions	288
Avoid unnecessary comparisons in boolean expressions	300
Avoid unnecessary comparisons in boolean expressions	300
Avoid using final local variables, turn them into fields	321

org/projectforge/export/XlsContentProvider.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	76
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	78
Do not use the short type	78
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	80
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	82
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	84
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	86
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	88
KONSTANTHEIT_VERSTECKTE: Private field 'formatMap' could be made final; it is only initialized in the declaration or constructor.	94
KONSTANTHEIT_VERSTECKTE: Private field 'defaultFormatMap' could be made final; it is only initialized in the declaration or constructor.	96
KONSTANTHEIT_VERSTECKTE: Private field 'colWidthMap' could be made final; it is only initialized in the declaration or constructor.	98
Avoid unnecessary comparisons in boolean expressions	137
KONSTANTHEIT_VERSTECKTE: Local variable 'format' could be declared final	139
Avoid using final local variables, turn them into fields	162
Do not use the short type	171
Do not use the short type	172
Do not use the short type	173
Do not use the short type	174
Avoid using final local variables, turn them into fields	176
Do not use the short type	178
KONSTANTHEIT_VERSTECKTE: Local variable 'df' could be declared final	178
KONSTANTHEIT_VERSTECKTE: Local variable 'poiCell' could be declared final	195
TOTE_PARAMETER: Avoid unused method parameters such as 'cell'.	231 - 264
Avoid unnecessary comparisons in boolean expressions	248
Avoid unnecessary comparisons in boolean expressions	249
Avoid using final local variables, turn them into fields	251

org/projectforge/fibu/AbstractRechnungDO.java

Violation	Line
Avoid using final local variables, turn them into fields	91
An empty method in an abstract class should be abstract instead	96 - 99
An empty method in an abstract class should be abstract instead	101 - 105
An empty method in an abstract class should be abstract instead	108 - 111
An empty method in an abstract class should be abstract instead	113 - 117
An empty method in an abstract class should be abstract instead	120 - 123
An empty method in an abstract class should be abstract instead	125 - 129
An empty method in an abstract class should be abstract instead	132 - 135
An empty method in an abstract class should be abstract instead	137 - 141
An empty method in an abstract class should be abstract instead	144 - 147
An empty method in an abstract class should be abstract instead	149 - 153
An empty method in an abstract class should be abstract instead	160 - 163
An empty method in an abstract class should be abstract instead	165 - 169
An empty method in an abstract class should be abstract instead	172 - 181
An empty method in an abstract class should be abstract instead	184 - 193
An empty method in an abstract class should be abstract instead	196 - 205
An empty method in an abstract class should be abstract instead	208 - 211
An empty method in an abstract class should be abstract instead	213 - 217
An empty method in an abstract class should be abstract instead	224 - 227
An empty method in an abstract class should be abstract instead	229 - 233
An empty method in an abstract class should be abstract instead	239 - 246
Avoid unnecessary comparisons in boolean expressions	241
Avoid using final local variables, turn them into fields	244
Avoid unnecessary comparisons in boolean expressions	245
An empty method in an abstract class should be abstract instead	251 - 255
An empty method in an abstract class should be abstract instead	261 - 270
An empty method in an abstract class should be abstract instead	272 - 286
Do not use the short type	275
An empty method in an abstract class should be abstract instead	302 - 318
Avoid unnecessary comparisons in boolean expressions	309
An empty method in an abstract class should be abstract instead	321 - 324
An empty method in an abstract class should be abstract instead	326 - 337
Avoid unnecessary comparisons in boolean expressions	332

org/projectforge/fibu/AbstractRechnungsPositionDO.java

Violation	Line
Do not use the short type	60
An empty method in an abstract class should be abstract instead	78 - 81
Do not use the short type	78
An empty method in an abstract class should be abstract instead	83 - 87
Do not use the short type	83
An empty method in an abstract class should be abstract instead	90 - 93
An empty method in an abstract class should be abstract instead	95 - 99
An empty method in an abstract class should be abstract instead	102 - 105
An empty method in an abstract class should be abstract instead	107 - 111
An empty method in an abstract class should be abstract instead	114 - 117
An empty method in an abstract class should be abstract instead	119 - 127
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	157
An empty method in an abstract class should be abstract instead	166 - 169
An empty method in an abstract class should be abstract instead	171 - 175
An empty method in an abstract class should be abstract instead	183 - 187
An empty method in an abstract class should be abstract instead	193 - 206
An empty method in an abstract class should be abstract instead	208 - 222
Do not use the short type	211
An empty method in an abstract class should be abstract instead	228 - 240
Avoid unnecessary comparisons in boolean expressions	230
Avoid using final local variables, turn them into fields	233
An operation on an Immutable object (BigDecimal or BigInteger) won't change the object itself	236
An empty method in an abstract class should be abstract instead	246 - 249
An empty method in an abstract class should be abstract instead	286 - 299
Avoid using final local variables, turn them into fields	288
Avoid unnecessary comparisons in boolean expressions	292
An empty method in an abstract class should be abstract instead	306 - 324
An empty method in an abstract class should be abstract instead	326 - 332
An empty method in an abstract class should be abstract instead	338 - 347
Avoid unnecessary comparisons in boolean expressions	341
An empty method in an abstract class should be abstract instead	350 - 353
An empty method in an abstract class should be abstract instead	359 - 370
Avoid using final local variables, turn them into fields	361
Avoid using final local variables, turn them into fields	365
An empty method in an abstract class should be abstract instead	373 - 379
Avoid unnecessary comparisons in boolean expressions	375
Avoid unnecessary comparisons in boolean expressions	378
An empty method in an abstract class should be abstract instead	382 - 395
Avoid using final local variables, turn them into fields	385
Avoid unnecessary comparisons in boolean expressions	386
Avoid unnecessary comparisons in boolean expressions	389
An empty method in an abstract class should be abstract instead	398 - 406
Avoid using final local variables, turn them into fields	400
An empty method in an abstract class should be abstract instead	409 - 412

org/projectforge/fibu/AbstractRechnungsStatistik.java

Violation	Line
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	67
Avoid unnecessary comparisons in boolean expressions	77
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	82
KONSTANTHEIT_VERSTECKTE: Local variable 'bezahlDatum' could be declared final	85

org/projectforge/fibu/AuftragDO.java

Violation	Line
Avoid using final local variables, turn them into fields	176
Avoid unnecessary comparisons in boolean expressions	224
Avoid using final local variables, turn them into fields	305
Avoid unnecessary comparisons in boolean expressions	309
Avoid unnecessary comparisons in boolean expressions	314
Avoid unnecessary comparisons in boolean expressions	315
Avoid unnecessary comparisons in boolean expressions	416
Avoid unnecessary comparisons in boolean expressions	417
Avoid unnecessary comparisons in boolean expressions	427
Avoid unnecessary comparisons in boolean expressions	427
Avoid unnecessary comparisons in boolean expressions	432
Do not use the short type	455
Do not use the short type	477
Avoid unnecessary comparisons in boolean expressions	526

org/projectforge/fibu/AuftragDao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	143
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	153 - 154
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	164 - 166
Avoid using final local variables, turn them into fields	175
Avoid instantiating new objects inside loops	175
Avoid instantiating new objects inside loops	178
KONSTANTHEIT_VERSTECKTE: Local variable 'stats' could be declared final	188
Avoid using final local variables, turn them into fields	211
Avoid using final local variables, turn them into fields	230
Avoid using final local variables, turn them into fields	242
Avoid using final local variables, turn them into fields	253
Avoid using final local variables, turn them into fields	264
Avoid using final local variables, turn them into fields	279
Avoid using final local variables, turn them into fields	289 - 290
Avoid unnecessary comparisons in boolean expressions	291
SYNCHRONISATION: Use block level rather than method level synchronization	297 - 307
Avoid using final local variables, turn them into fields	302
Avoid using final local variables, turn them into fields	304
Avoid using final local variables, turn them into fields	317
Avoid using final local variables, turn them into fields	323
KONSTANTHEIT_VERSTECKTE: Local variable 'cal' could be declared final	325
KONSTANTHEIT_VERSTECKTE: Local variable 'lastDayOfYear' could be declared final	331
Avoid unnecessary comparisons in boolean expressions	338
Avoid unnecessary comparisons in boolean expressions	342
Avoid unnecessary comparisons in boolean expressions	346
Avoid unnecessary comparisons in boolean expressions	348
Avoid unnecessary comparisons in boolean expressions	350
Avoid unnecessary comparisons in boolean expressions	355
Avoid unnecessary comparisons in boolean expressions	358
Avoid unnecessary comparisons in boolean expressions	361
Avoid using final local variables, turn them into fields	364
Avoid unnecessary comparisons in boolean expressions	365
Avoid using final local variables, turn them into fields	371
Avoid using final local variables, turn them into fields	372
Avoid using final local variables, turn them into fields	376
Avoid unnecessary comparisons in boolean expressions	379
Avoid unnecessary comparisons in boolean expressions	387
KONSTANTHEIT_VERSTECKTE: Local variable 'next' could be declared final	410
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	415 - 416
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	417
Avoid unnecessary comparisons in boolean expressions	421
Avoid using final local variables, turn them into fields	424
Avoid using final local variables, turn them into fields	427
Avoid unnecessary comparisons in boolean expressions	428
Avoid unnecessary comparisons in boolean expressions	434
Avoid unnecessary comparisons in boolean expressions	468
Avoid using final local variables, turn them into fields	471
Avoid unnecessary comparisons in boolean expressions	475
Avoid using final local variables, turn them into fields	478
Avoid using final local variables, turn them into fields	482
Avoid using final local variables, turn them into fields	483
Avoid using final local variables, turn them into fields	492
Avoid using final local variables, turn them into fields	494
Avoid using final local variables, turn them into fields	504
KONSTANTHEIT_VERSTECKTE: Local variable 'orig' could be declared final	521
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	527
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	529
Consider simply returning the value vs storing it in local variable 'number'	534
Avoid using final local variables, turn them into fields	544
Avoid unnecessary comparisons in boolean expressions	545
Avoid unnecessary comparisons in boolean expressions	548
Avoid using final local variables, turn them into fields	550
Avoid using final local variables, turn them into fields	552
Returning 'ADDITIONAL_SEARCH_DOS' may expose an internal array.	574
Avoid unnecessary comparisons in boolean expressions	584
Avoid unnecessary comparisons in boolean expressions	588

org/projectforge/fibu/AuftragFilter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	133
Position literals first in String comparisons	133

org/projectforge/fibu/AuftragRight.java

Violation	Line
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	89
Avoid unnecessary comparisons in boolean expressions	91
Avoid unnecessary comparisons in boolean expressions	94
Avoid unnecessary comparisons in boolean expressions	98
Avoid unnecessary comparisons in boolean expressions	103
Avoid unnecessary comparisons in boolean expressions	104
Avoid unnecessary comparisons in boolean expressions	108
Do not use the short type	113
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	115
Avoid unnecessary comparisons in boolean expressions	117
Avoid unnecessary comparisons in boolean expressions	126
Avoid empty if statements	127 - 129
Avoid unnecessary comparisons in boolean expressions	132
Avoid unnecessary comparisons in boolean expressions	138
Avoid unnecessary comparisons in boolean expressions	139
KONSTANTHEIT_VERSTECKTE: Local variable 'millis' could be declared final	142

org/projectforge/fibu/AuftragsPositionDO.java

Violation	Line
Do not use the short type	64
Avoid unnecessary comparisons in boolean expressions	98
Do not use the short type	105
Do not use the short type	110
Avoid unnecessary comparisons in boolean expressions	254
Avoid unnecessary comparisons in boolean expressions	284
Avoid unnecessary comparisons in boolean expressions	284
KONSTANTHEIT_VERSTECKTE: Local variable 'other' could be declared final	293
Avoid unnecessary comparisons in boolean expressions	294
Avoid unnecessary comparisons in boolean expressions	297
KONSTANTHEIT_VERSTECKTE: Local variable 'hcb' could be declared final	308
No need to call String.valueOf to append to a string.	319
Avoid using final local variables, turn them into fields	328
Avoid appending characters as strings in StringBuffer.append.	332

org/projectforge/fibu/AuftragsPositionVO.java

Violation	Line
Do not use the short type	40
KONSTANTHEIT_VERSTECKTE: Private field 'number' could be made final; it is only initialized in the declaration or constructor.	40
KONSTANTHEIT_VERSTECKTE: Private field 'taskId' could be made final; it is only initialized in the declaration or constructor.	52
KONSTANTHEIT_VERSTECKTE: Private field 'art' could be made final; it is only initialized in the declaration or constructor.	54
KONSTANTHEIT_VERSTECKTE: Private field 'status' could be made final; it is only initialized in the declaration or constructor.	56
KONSTANTHEIT_VERSTECKTE: Private field 'titel' could be made final; it is only initialized in the declaration or constructor.	58
KONSTANTHEIT_VERSTECKTE: Private field 'nettoSumme' could be made final; it is only initialized in the declaration or constructor.	60
KONSTANTHEIT_VERSTECKTE: Private field 'vollstaendigFakturiert' could be made final; it is only initialized in the declaration or constructor.	64
Avoid using final local variables, turn them into fields	68
Do not use the short type	89
KONSTANTHEIT_VERSTECKTE: Local variable 'other' could be declared final	167
Avoid unnecessary comparisons in boolean expressions	168
Avoid unnecessary comparisons in boolean expressions	170
KONSTANTHEIT_VERSTECKTE: Local variable 'hcb' could be declared final	180
Avoid unnecessary comparisons in boolean expressions	188

org/projectforge/fibu/AuftragsStatistik.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'netto' could be declared final	62
Avoid unnecessary comparisons in boolean expressions	64
Avoid unnecessary comparisons in boolean expressions	67
Avoid unnecessary comparisons in boolean expressions	70
Avoid unnecessary comparisons in boolean expressions	70
Avoid unnecessary comparisons in boolean expressions	75

org/projectforge/fibu/EingangsrechnungDao.java

Violation	Line
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	95
Avoid unnecessary comparisons in boolean expressions	112
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	118
Avoid unnecessary comparisons in boolean expressions	119
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	130
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	142
Avoid using final local variables, turn them into fields	146
Avoid unnecessary comparisons in boolean expressions	147
Avoid unnecessary comparisons in boolean expressions	147
Avoid using final local variables, turn them into fields	150
Avoid unnecessary comparisons in boolean expressions	152
Avoid unnecessary comparisons in boolean expressions	153
Avoid unnecessary comparisons in boolean expressions	156
Avoid unnecessary comparisons in boolean expressions	157
Avoid using final local variables, turn them into fields	174
Avoid unnecessary comparisons in boolean expressions	175
Avoid unnecessary comparisons in boolean expressions	178
Avoid using final local variables, turn them into fields	180
Avoid using final local variables, turn them into fields	182
Avoid unnecessary comparisons in boolean expressions	190
Avoid using final local variables, turn them into fields	192
Avoid using final local variables, turn them into fields	194
Returning 'ADDITIONAL_SEARCH_DOS' may expose an internal array.	219
Avoid unnecessary comparisons in boolean expressions	229
Avoid unnecessary comparisons in boolean expressions	233

org/projectforge/fibu/EmployeeDao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	69
Avoid using final local variables, turn them into fields	75 - 76
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	97 - 99
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	125
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	138
Avoid using final local variables, turn them into fields	139
Avoid using final local variables, turn them into fields	140
Avoid unnecessary comparisons in boolean expressions	141
Avoid using final local variables, turn them into fields	145
Avoid unnecessary comparisons in boolean expressions	146
Avoid unnecessary comparisons in boolean expressions	148

org/projectforge/fibu/EmployeeSalaryDO.java

Violation	Line
No need to call String.valueOf to append to a string.	136

org/projectforge/fibu/EmployeeSalaryDao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	60
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	69
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	82
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	91
Consider simply returning the value vs storing it in local variable 'list'	92
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	106 - 107
Avoid unnecessary comparisons in boolean expressions	108
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	112 - 113
Avoid unnecessary comparisons in boolean expressions	114
KONSTANTHEIT_VERSTECKTE: Local variable 'employee' could be declared final	127

org/projectforge/fibu/EmployeeScriptingDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field '__baseDao' could be made final; it is only initialized in the declaration or constructor.	30

org/projectforge/fibu/HibernateSearchAuftragsPositionBridge.java

Violation	Line
Avoid using final local variables, turn them into fields	45
Avoid using final local variables, turn them into fields	46
Avoid using final local variables, turn them into fields	47
Avoid appending characters as strings in StringBuffer.append.	51
Avoid unnecessary comparisons in boolean expressions	52

org/projectforge/fibu/HibernateSearchProjectKostBridge.java

Violation	Line
Avoid using final local variables, turn them into fields	43
Avoid using final local variables, turn them into fields	44

org/projectforge/fibu/KontoCache.java

Violation	Line
The Logger variable declaration does not contain the static and final modifiers	42
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	73

org/projectforge/fibu/KontoDO.java

Violation	Line
No need to call String.valueOf to append to a string.	69
Avoid using final local variables, turn them into fields	138
Avoid unnecessary comparisons in boolean expressions	139
Avoid using final local variables, turn them into fields	150

org/projectforge/fibu/KontoDao.java

Violation	Line
Avoid using final local variables, turn them into fields	58
Avoid unnecessary comparisons in boolean expressions	59

org/projectforge/fibu/KostFormatter.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 382
Avoid unnecessary comparisons in boolean expressions	72
KONSTANTHEIT_VERSTECKTE: Local variable 'delimiter' could be declared final	72
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	73
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	94
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	124
Avoid unnecessary comparisons in boolean expressions	128
Avoid unnecessary comparisons in boolean expressions	157
KONSTANTHEIT_VERSTECKTE: Local variable 'delimiter' could be declared final	157
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	158
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	184
Avoid unnecessary comparisons in boolean expressions	185
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	214
Avoid unnecessary comparisons in boolean expressions	218
Avoid unnecessary comparisons in boolean expressions	242
KONSTANTHEIT_VERSTECKTE: Local variable 'delimiter' could be declared final	242
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	243
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	285
Consider simply returning the value vs storing it in local variable 'result'	286
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	335
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	349
KONSTANTHEIT_VERSTECKTE: Local variable 'a' could be declared final	361
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	372

org/projectforge/fibu/KundeDO.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	157

org/projectforge/fibu/KundeDao.java

Violation	Line
Avoid using final local variables, turn them into fields	55
Avoid using final local variables, turn them into fields	62
Avoid unnecessary comparisons in boolean expressions	84
Avoid unnecessary comparisons in boolean expressions	87
Avoid unnecessary comparisons in boolean expressions	89
Avoid unnecessary comparisons in boolean expressions	90
Avoid unnecessary comparisons in boolean expressions	95

org/projectforge/fibu/KundeFormatter.java

Violation	Line
Avoid using final local variables, turn them into fields	45
Avoid unnecessary comparisons in boolean expressions	47
Avoid unnecessary comparisons in boolean expressions	51
Avoid unnecessary comparisons in boolean expressions	52
KONSTANTHEIT_VERSTECKTE: Local variable 'sb' could be declared final	86
KONSTANTHEIT_VERSTECKTE: Local variable 'hasAccess' could be declared final	88
Avoid unnecessary comparisons in boolean expressions	89
Avoid unnecessary comparisons in boolean expressions	92

org/projectforge/fibu/MonthlyEmployeeReport.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'kost2' could be made final; it is only initialized in the declaration or constructor.	120
KONSTANTHEIT_VERSTECKTE: Private field 'year' could be made final; it is only initialized in the declaration or constructor.	123
KONSTANTHEIT_VERSTECKTE: Private field 'month' could be made final; it is only initialized in the declaration or constructor.	125
KONSTANTHEIT_VERSTECKTE: Private field 'bookedDays' could be made final; it is only initialized in the declaration or constructor.	145
KONSTANTHEIT_VERSTECKTE: Private field 'unbookedDays' could be made final; it is only initialized in the declaration or constructor.	147
KONSTANTHEIT_VERSTECKTE: Local variable 'hours' could be declared final	170
KONSTANTHEIT_VERSTECKTE: Local variable 'dh' could be declared final	211
KONSTANTHEIT_VERSTECKTE: Local variable 'dh2' could be declared final	214
Avoid instantiating new objects inside loops	219
KONSTANTHEIT_VERSTECKTE: Local variable 'week' could be declared final	219
Avoid using final local variables, turn them into fields	232
Avoid unnecessary comparisons in boolean expressions	235
Avoid unnecessary comparisons in boolean expressions	251
Avoid instantiating new objects inside loops	254
Avoid instantiating new objects inside loops	257
Avoid unnecessary comparisons in boolean expressions	267
Avoid instantiating new objects inside loops	273
Avoid using final local variables, turn them into fields	283
Avoid unnecessary comparisons in boolean expressions	287
Avoid unnecessary comparisons in boolean expressions	287
Avoid using final local variables, turn them into fields	307
Avoid unnecessary comparisons in boolean expressions	310
Avoid appending characters as strings in StringBuffer.append.	315
Avoid appending characters as strings in StringBuffer.append.	315
Avoid unnecessary comparisons in boolean expressions	317

org/projectforge/fibu/MonthlyEmployeeReportDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'report' could be declared final	53
KONSTANTHEIT_VERSTECKTE: Local variable 'employee' could be declared final	54
KONSTANTHEIT_VERSTECKTE: Local variable 'filter' could be declared final	61
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	66
Avoid unnecessary comparisons in boolean expressions	67

org/projectforge/fibu/MonthlyEmployeeReportEntry.java

Violation	Line
Avoid using final local variables, turn them into fields	87

org/projectforge/fibu/MonthlyEmployeeReportWeek.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'fromDate' could be made final; it is only initialized in the declaration or constructor.	46
KONSTANTHEIT_VERSTECKTE: Private field 'fromDayOfMonth' could be made final; it is only initialized in the declaration or constructor.	48
KONSTANTHEIT_VERSTECKTE: Private field 'weekOfYear' could be made final; it is only initialized in the declaration or constructor.	54
KONSTANTHEIT_VERSTECKTE: Private field 'kost2Entries' could be made final; it is only initialized in the declaration or constructor.	61
KONSTANTHEIT_VERSTECKTE: Private field 'taskEntries' could be made final; it is only initialized in the declaration or constructor.	66
KONSTANTHEIT_VERSTECKTE: Local variable 'd1' could be declared final	76
KONSTANTHEIT_VERSTECKTE: Local variable 'd2' could be declared final	80
Avoid unnecessary comparisons in boolean expressions	82
Avoid unnecessary comparisons in boolean expressions	97
Avoid unnecessary comparisons in boolean expressions	97
Avoid unnecessary comparisons in boolean expressions	102
KONSTANTHEIT_VERSTECKTE: Local variable 'duration' could be declared final	119

org/projectforge/fibu/ProjektDO.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	207

org/projectforge/fibu/ProjektDao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	81
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	109
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	137
Avoid using final local variables, turn them into fields	147 - 148
Avoid unnecessary comparisons in boolean expressions	149
Avoid using final local variables, turn them into fields	159 - 160
Avoid unnecessary comparisons in boolean expressions	161
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	177
Avoid unnecessary comparisons in boolean expressions	178
Avoid unnecessary comparisons in boolean expressions	180
Avoid using final local variables, turn them into fields	193

org/projectforge/fibu/ProjektFilter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	81
Position literals first in String comparisons	81

org/projectforge/fibu/ProjektFormatter.java

Violation	Line
Avoid using final local variables, turn them into fields	46
Avoid unnecessary comparisons in boolean expressions	48
Avoid unnecessary comparisons in boolean expressions	52
Avoid unnecessary comparisons in boolean expressions	53
Avoid unnecessary comparisons in boolean expressions	60
Avoid unnecessary comparisons in boolean expressions	61
Avoid unnecessary comparisons in boolean expressions	66
Avoid unnecessary comparisons in boolean expressions	67
KONSTANTHEIT_VERSTECKTE: Local variable 'sb' could be declared final	104
KONSTANTHEIT_VERSTECKTE: Local variable 'hasAccess' could be declared final	106
Avoid unnecessary comparisons in boolean expressions	107
Avoid unnecessary comparisons in boolean expressions	110

org/projectforge/fibu/ProjektRight.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	73
Avoid unnecessary comparisons in boolean expressions	76
Avoid unnecessary comparisons in boolean expressions	78
Avoid unnecessary comparisons in boolean expressions	79
Avoid unnecessary comparisons in boolean expressions	79
Avoid unnecessary comparisons in boolean expressions	84
Avoid unnecessary comparisons in boolean expressions	85
Avoid unnecessary comparisons in boolean expressions	89
Avoid unnecessary comparisons in boolean expressions	106

org/projectforge/fibu/RechnungCache.java

Violation	Line
The Logger variable declaration does not contain the static and final modifiers	43
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	75
Avoid unnecessary comparisons in boolean expressions	80
Avoid unnecessary comparisons in boolean expressions	80
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	85
Avoid instantiating new objects inside loops	88
Avoid instantiating new objects inside loops	93
Avoid using final local variables, turn them into fields	96
Avoid instantiating new objects inside loops	96
Avoid unnecessary comparisons in boolean expressions	97
Avoid unnecessary comparisons in boolean expressions	100

org/projectforge/fibu/RechnungDO.java

Violation	Line
Avoid instantiating new objects inside loops	209
Avoid instantiating new objects inside loops	211
KONSTANTHEIT_VERSTECKTE: Local variable 'r' could be declared final	227

org/projectforge/fibu/RechnungDao.java

Violation	Line
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	84
Avoid using final local variables, turn them into fields	120
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	194
Avoid using final local variables, turn them into fields	199 - 200
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	201
Avoid unnecessary comparisons in boolean expressions	210
Avoid using final local variables, turn them into fields	213
Avoid using final local variables, turn them into fields	216
Avoid unnecessary comparisons in boolean expressions	217
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	243
Avoid using final local variables, turn them into fields	253
Avoid using final local variables, turn them into fields	255
Avoid empty if statements	256 - 258
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	256
Avoid using final local variables, turn them into fields	266
Avoid using final local variables, turn them into fields	272
Avoid unnecessary comparisons in boolean expressions	276
Avoid using final local variables, turn them into fields	279
Avoid unnecessary comparisons in boolean expressions	280
Avoid unnecessary comparisons in boolean expressions	280
Avoid using final local variables, turn them into fields	283
Avoid unnecessary comparisons in boolean expressions	285
Avoid unnecessary comparisons in boolean expressions	286
Avoid unnecessary comparisons in boolean expressions	289
Avoid unnecessary comparisons in boolean expressions	290
Avoid using final local variables, turn them into fields	319
Avoid using final local variables, turn them into fields	325
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	327
Consider simply returning the value vs storing it in local variable 'number'	332
Avoid using final local variables, turn them into fields	342
Avoid unnecessary comparisons in boolean expressions	343
Avoid unnecessary comparisons in boolean expressions	346
Avoid using final local variables, turn them into fields	348
Avoid using final local variables, turn them into fields	350
Avoid unnecessary comparisons in boolean expressions	358
Avoid using final local variables, turn them into fields	360
Avoid using final local variables, turn them into fields	362
Returning 'ADDITIONAL_SEARCH_DOS' may expose an internal array.	387
Avoid unnecessary comparisons in boolean expressions	397
Avoid unnecessary comparisons in boolean expressions	401

org/projectforge/fibu/RechnungFilter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	117

org/projectforge/fibu/RechnungsPositionVO.java

Violation	Line
Do not use the short type	40
KONSTANTHEIT_VERSTECKTE: Private field 'number' could be made final; it is only initialized in the declaration or constructor.	40
KONSTANTHEIT_VERSTECKTE: Private field 'rechnungId' could be made final; it is only initialized in the declaration or constructor.	42
KONSTANTHEIT_VERSTECKTE: Private field 'rechnungNummer' could be made final; it is only initialized in the declaration or constructor.	44
KONSTANTHEIT_VERSTECKTE: Private field 'rechnungBetreff' could be made final; it is only initialized in the declaration or constructor.	46
KONSTANTHEIT_VERSTECKTE: Private field 'text' could be made final; it is only initialized in the declaration or constructor.	48
Do not use the short type	52
KONSTANTHEIT_VERSTECKTE: Private field 'netSum' could be made final; it is only initialized in the declaration or constructor.	54
Avoid using final local variables, turn them into fields	58
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	67
Do not use the short type	75
Do not use the short type	113
KONSTANTHEIT_VERSTECKTE: Local variable 'other' could be declared final	122
Avoid unnecessary comparisons in boolean expressions	123
Avoid unnecessary comparisons in boolean expressions	125
KONSTANTHEIT_VERSTECKTE: Local variable 'hcb' could be declared final	135
Avoid unnecessary comparisons in boolean expressions	143

org/projectforge/fibu/datev/BuchungssatzExcelImporter.java

Violation	Line
Do not use the short type	64
KONSTANTHEIT_VERSTECKTE: Private field 'kontoDao' could be made final; it is only initialized in the declaration or constructor.	66
KONSTANTHEIT_VERSTECKTE: Private field 'kost1Dao' could be made final; it is only initialized in the declaration or constructor.	68
KONSTANTHEIT_VERSTECKTE: Private field 'kost2Dao' could be made final; it is only initialized in the declaration or constructor.	70
KONSTANTHEIT_VERSTECKTE: Private field 'storage' could be made final; it is only initialized in the declaration or constructor.	72
KONSTANTHEIT_VERSTECKTE: Private field 'actionLog' could be made final; it is only initialized in the declaration or constructor.	74
Avoid using final local variables, turn them into fields	88
Do not use the short type	89
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	101
WRAPPER_INSTANZIIERUNG: Avoid instantiating Integer objects. Call Integer.valueOf() instead.	104
Avoid using final local variables, turn them into fields	110
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	168
Avoid instantiating new objects inside loops	168
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	177 - 180
Avoid using final local variables, turn them into fields	184
Avoid using final local variables, turn them into fields	205
Do not use the short type	209
Avoid using final local variables, turn them into fields	211
Avoid using final local variables, turn them into fields	215
Avoid unnecessary comparisons in boolean expressions	217
Avoid unnecessary comparisons in boolean expressions	229
Avoid using final local variables, turn them into fields	232 - 233
KONSTANTHEIT_VERSTECKTE: Local variable 'satz' could be declared final	234
KONSTANTHEIT_VERSTECKTE: Local variable 'kost1' could be declared final	257
KONSTANTHEIT_VERSTECKTE: Local variable 'kost2' could be declared final	264

org/projectforge/fibu/datev/BuchungssatzImportRow.java

Violation	Line
Avoid using final local variables, turn them into fields	249
Avoid using final local variables, turn them into fields	260
KONSTANTHEIT_VERSTECKTE: Local variable 'txt' could be declared final	275
KONSTANTHEIT_VERSTECKTE: Local variable 'day' could be declared final	276

org/projectforge/fibu/datev/DatevImportDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'storage' could be declared final	134
KONSTANTHEIT_VERSTECKTE: Local variable 'imp' could be declared final	136
Avoid using final local variables, turn them into fields	154
Avoid using final local variables, turn them into fields	156
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	173
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	189
KONSTANTHEIT_VERSTECKTE: Local variable 'konto' could be declared final	206
KONSTANTHEIT_VERSTECKTE: Local variable 'dbKonto' could be declared final	207
KONSTANTHEIT_VERSTECKTE: Local variable 'satz' could be declared final	220
Avoid unnecessary comparisons in boolean expressions	221
KONSTANTHEIT_VERSTECKTE: Local variable 'vals' could be declared final	224
KONSTANTHEIT_VERSTECKTE: Local variable 'kost1' could be declared final	225
KONSTANTHEIT_VERSTECKTE: Local variable 'vals' could be declared final	233
KONSTANTHEIT_VERSTECKTE: Local variable 'kost2' could be declared final	234
KONSTANTHEIT_VERSTECKTE: Local variable 'dbSatz' could be declared final	241
KONSTANTHEIT_VERSTECKTE: Local variable 'col' could be declared final	253
KONSTANTHEIT_VERSTECKTE: Local variable 'konto' could be declared final	255
KONSTANTHEIT_VERSTECKTE: Local variable 'dbKonto' could be declared final	256
Avoid unnecessary comparisons in boolean expressions	259
Avoid unnecessary comparisons in boolean expressions	262
Avoid using final local variables, turn them into fields	281
Avoid using final local variables, turn them into fields	283
Avoid using final local variables, turn them into fields	284
Avoid unnecessary comparisons in boolean expressions	288
Avoid unnecessary comparisons in boolean expressions	291
Avoid unnecessary comparisons in boolean expressions	294
Avoid using final local variables, turn them into fields	295
Avoid instantiating new objects inside loops	295

org/projectforge/fibu/datev/EmployeeSalaryExportDao.java

Violation	Line
Avoid using final local variables, turn them into fields	93
Do not use the short type	145
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	165
Avoid using final local variables, turn them into fields	166
Avoid unnecessary comparisons in boolean expressions	170
Avoid unnecessary comparisons in boolean expressions	175
Avoid unnecessary comparisons in boolean expressions	179
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	188
Avoid using final local variables, turn them into fields	192
Avoid using final local variables, turn them into fields	193
Avoid using final local variables, turn them into fields	194
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	197
Avoid using final local variables, turn them into fields	198
Avoid using final local variables, turn them into fields	201
Avoid using final local variables, turn them into fields	202
Avoid using final local variables, turn them into fields	205
Avoid using final local variables, turn them into fields	211
KONSTANTHEIT_VERSTECKTE: Local variable 'employeeRow' could be declared final	213
Avoid using final local variables, turn them into fields	221
Avoid using final local variables, turn them into fields	223
Avoid using final local variables, turn them into fields	224
Avoid using final local variables, turn them into fields	225
Avoid using final local variables, turn them into fields	238
Avoid using final local variables, turn them into fields	253
Avoid using final local variables, turn them into fields	260
Avoid instantiating new objects inside loops	260
Avoid using final local variables, turn them into fields	261
Avoid using final local variables, turn them into fields	264
Avoid using final local variables, turn them into fields	266
Avoid using final local variables, turn them into fields	267
Avoid using final local variables, turn them into fields	268
Avoid instantiating new objects inside loops	268
KONSTANTHEIT_VERSTECKTE: Local variable 'rows' could be declared final	269
Avoid using final local variables, turn them into fields	273
KONSTANTHEIT_VERSTECKTE: Local variable 'entry' could be declared final	274
Avoid instantiating new objects inside loops	278
KONSTANTHEIT_VERSTECKTE: Local variable 'duration' could be declared final	278
Avoid instantiating new objects inside loops	281
Avoid using final local variables, turn them into fields	283 - 284
Avoid instantiating new objects inside loops	283
Avoid using final local variables, turn them into fields	287
Avoid unnecessary comparisons in boolean expressions	290
Avoid using final local variables, turn them into fields	308
Avoid using final local variables, turn them into fields	309
Avoid instantiating new objects inside loops	309
Avoid using final local variables, turn them into fields	314
Avoid using final local variables, turn them into fields	315
Avoid instantiating new objects inside loops	315
Avoid using final local variables, turn them into fields	320
Avoid using final local variables, turn them into fields	333
Avoid using final local variables, turn them into fields	334
Avoid using final local variables, turn them into fields	343
Avoid using final local variables, turn them into fields	346
Avoid using final local variables, turn them into fields	349

org/projectforge/fibu/datev/KontenplanExcelImporter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'imp' could be declared final	50
Do not use the short type	51
KONSTANTHEIT_VERSTECKTE: Local variable 'name' could be declared final	53
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	56
TOTE_PARAMETER: Avoid unused method parameters such as 'sheet'.	64 - 90
KONSTANTHEIT_VERSTECKTE: Local variable 'importedSheet' could be declared final	67
KONSTANTHEIT_VERSTECKTE: Local variable 'map' could be declared final	74
KONSTANTHEIT_VERSTECKTE: Local variable 'konto' could be declared final	83
Avoid instantiating new objects inside loops	84 - 85
KONSTANTHEIT_VERSTECKTE: Local variable 'element' could be declared final	84 - 85
KONSTANTHEIT_VERSTECKTE: Local variable 'konto' could be declared final	94

org/projectforge/fibu/datev/KontenplanExcelRow.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'txt' could be declared final	58

org/projectforge/fibu/kost/BuchungssatzDO.java

Violation	Line
No need to call String.valueOf to append to a string.	119
KONSTANTHEIT_VERSTECKTE: Local variable 'kto' could be declared final	140
KONSTANTHEIT_VERSTECKTE: Local variable 'sollHaben' could be declared final	141
Avoid empty if statements	142 - 144
Avoid empty if statements	145 - 147
Avoid unnecessary comparisons in boolean expressions	151
Avoid empty if statements	153 - 156
Avoid unnecessary comparisons in boolean expressions	336
Avoid unnecessary comparisons in boolean expressions	338
KONSTANTHEIT_VERSTECKTE: Local variable 'msg' could be declared final	341

org/projectforge/fibu/kost/BuchungssatzDao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	48
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	63
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	64
KONSTANTHEIT_VERSTECKTE: Local variable 'minYear' could be declared final	67
KONSTANTHEIT_VERSTECKTE: Local variable 'maxYear' could be declared final	68
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	83 - 84
Avoid unnecessary comparisons in boolean expressions	85
KONSTANTHEIT_VERSTECKTE: Local variable 'toMonth' could be declared final	93
KONSTANTHEIT_VERSTECKTE: Local variable 'toYear' could be declared final	94
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	128
Avoid unnecessary comparisons in boolean expressions	129
Avoid using final local variables, turn them into fields	153
Consider simply returning the value vs storing it in local variable 'list'	154

org/projectforge/fibu/kost/BusinessAssessment.java

Violation	Line
Avoid using final local variables, turn them into fields	83
Avoid unnecessary comparisons in boolean expressions	85
Avoid instantiating new objects inside loops	106
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setAccountRecords' called during object construction	113
Avoid unnecessary comparisons in boolean expressions	125
Avoid unnecessary comparisons in boolean expressions	128
Avoid unnecessary comparisons in boolean expressions	132
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	139
Avoid unnecessary comparisons in boolean expressions	142
Avoid unnecessary comparisons in boolean expressions	148
Avoid using final local variables, turn them into fields	188
Avoid using final local variables, turn them into fields	202
Avoid using final local variables, turn them into fields	216
Avoid using final local variables, turn them into fields	222
StringBuffer constructor is initialized with size 16, but has at least 49 characters appended.	222
Avoid using final local variables, turn them into fields	241
StringBuffer constructor is initialized with size 16, but has at least 82 characters appended.	241
Avoid unnecessary comparisons in boolean expressions	242
Avoid appending characters as strings in StringBuffer.append.	254
Avoid unnecessary comparisons in boolean expressions	256
Avoid using final local variables, turn them into fields	267
Avoid unnecessary comparisons in boolean expressions	280
Avoid unnecessary comparisons in boolean expressions	287
Avoid appending characters as strings in StringBuffer.append.	288
Avoid unnecessary comparisons in boolean expressions	292
Avoid appending characters as strings in StringBuffer.append.	295
Avoid appending characters as strings in StringBuffer.append.	295
Avoid unnecessary comparisons in boolean expressions	297
Avoid unnecessary comparisons in boolean expressions	302
Avoid using final local variables, turn them into fields	305
Avoid unnecessary comparisons in boolean expressions	310
Avoid appending characters as strings in StringBuffer.append.	313
Avoid unnecessary comparisons in boolean expressions	332
Avoid unnecessary comparisons in boolean expressions	332

org/projectforge/fibu/kost/BusinessAssessmentConfig.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	71
Avoid unnecessary comparisons in boolean expressions	71
Avoid using final local variables, turn them into fields	118

org/projectforge/fibu/kost/BusinessAssessmentRow.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	87
Avoid unnecessary comparisons in boolean expressions	206
Avoid using final local variables, turn them into fields	210
Avoid using final local variables, turn them into fields	216
Avoid using final local variables, turn them into fields	218
Avoid using final local variables, turn them into fields	219

org/projectforge/fibu/kost/BusinessAssessmentRowConfig.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'indent' could be made final; it is only initialized in the declaration or constructor.	77
Avoid unnecessary comparisons in boolean expressions	133
Avoid unnecessary comparisons in boolean expressions	135
This call to String.startsWith can be rewritten using String.charAt(0)	135
Avoid using final local variables, turn them into fields	203
SYNCHRONISATION: Use block level rather than method level synchronization	210 - 221
Avoid unnecessary comparisons in boolean expressions	212

org/projectforge/fibu/kost/HibernateSearchKost1Bridge.java

Violation	Line
Avoid using final local variables, turn them into fields	45
Avoid using final local variables, turn them into fields	46

org/projectforge/fibu/kost/HibernateSearchKost2Bridge.java

Violation	Line
Avoid using final local variables, turn them into fields	45
Avoid using final local variables, turn them into fields	46

org/projectforge/fibu/kost/Kost1DO.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'other' could be declared final	185
KONSTANTHEIT_VERSTECKTE: Local variable 'hcb' could be declared final	199

org/projectforge/fibu/kost/Kost1Dao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	53
Avoid using final local variables, turn them into fields	75
Avoid unnecessary comparisons in boolean expressions	79
Avoid using final local variables, turn them into fields	82
Avoid using final local variables, turn them into fields	98
Avoid using final local variables, turn them into fields	108 - 112
Avoid unnecessary comparisons in boolean expressions	113
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	129
Avoid unnecessary comparisons in boolean expressions	130
Avoid unnecessary comparisons in boolean expressions	132
Avoid unnecessary comparisons in boolean expressions	134
Avoid unnecessary comparisons in boolean expressions	136
Avoid using final local variables, turn them into fields	148
Avoid unnecessary comparisons in boolean expressions	158

org/projectforge/fibu/kost/Kost1ScriptingDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field '__baseDao' could be made final; it is only initialized in the declaration or constructor.	30

org/projectforge/fibu/kost/Kost2ArtDO.java

Violation	Line
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	186

org/projectforge/fibu/kost/Kost2ArtDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'queryFilter' could be declared final	58

org/projectforge/fibu/kost/Kost2DO.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'other' could be declared final	289
KONSTANTHEIT_VERSTECKTE: Local variable 'hcb' could be declared final	306

org/projectforge/fibu/kost/Kost2Dao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	81
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	128 - 130
Avoid unnecessary comparisons in boolean expressions	131
Avoid using final local variables, turn them into fields	140 - 143
Avoid unnecessary comparisons in boolean expressions	144
Avoid using final local variables, turn them into fields	166
Avoid using final local variables, turn them into fields	172
Avoid unnecessary comparisons in boolean expressions	174
Avoid unnecessary comparisons in boolean expressions	176
Avoid unnecessary comparisons in boolean expressions	178
Avoid unnecessary comparisons in boolean expressions	180
Avoid using final local variables, turn them into fields	194
Avoid using final local variables, turn them into fields	216
Avoid unnecessary comparisons in boolean expressions	226

org/projectforge/fibu/kost/KostCache.java

Violation	Line
The Logger variable declaration does not contain the static and final modifiers	49
Avoid unnecessary comparisons in boolean expressions	65
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	99
Avoid unnecessary comparisons in boolean expressions	108
Avoid unnecessary comparisons in boolean expressions	116
KONSTANTHEIT_VERSTECKTE: Local variable 'set' could be declared final	129
Avoid unnecessary comparisons in boolean expressions	134
Avoid unnecessary comparisons in boolean expressions	137
KONSTANTHEIT_VERSTECKTE: Local variable 'kost2Art' could be declared final	138
Avoid using final local variables, turn them into fields	154
Avoid using final local variables, turn them into fields	155
Avoid unnecessary comparisons in boolean expressions	157
Avoid using final local variables, turn them into fields	160
Avoid instantiating new objects inside loops	160
Avoid using final local variables, turn them into fields	162
Avoid instantiating new objects inside loops	162
Avoid unnecessary comparisons in boolean expressions	163
Avoid using final local variables, turn them into fields	174
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	178
Avoid instantiating new objects inside loops	178
Avoid instantiating new objects inside loops	180
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	213
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	214
Avoid instantiating new objects inside loops	216
KONSTANTHEIT_VERSTECKTE: Local variable 'art' could be declared final	216
Avoid using final local variables, turn them into fields	243
Avoid using final local variables, turn them into fields	244
Avoid using final local variables, turn them into fields	249
Avoid using final local variables, turn them into fields	250
Avoid unnecessary comparisons in boolean expressions	253
Avoid unnecessary comparisons in boolean expressions	253

org/projectforge/fibu/kost/KostFilter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	95
Position literals first in String comparisons	95

org/projectforge/fibu/kost/KostHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 72
Avoid using final local variables, turn them into fields	39
Avoid unnecessary comparisons in boolean expressions	42
Avoid unnecessary comparisons in boolean expressions	52
Avoid using final local variables, turn them into fields	59

org/projectforge/fibu/kost/KostZuweisungDO.java

Violation	Line
Do not use the short type	67
Do not use the short type	96
Do not use the short type	101
Avoid using final local variables, turn them into fields	131
Avoid unnecessary comparisons in boolean expressions	311
Avoid using final local variables, turn them into fields	334
Avoid unnecessary comparisons in boolean expressions	335
Avoid unnecessary comparisons in boolean expressions	337
Avoid unnecessary comparisons in boolean expressions	339
Avoid unnecessary comparisons in boolean expressions	341
Avoid using final local variables, turn them into fields	351
Avoid using final local variables, turn them into fields	377

org/projectforge/fibu/kost/KostZuweisungDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'kost1' could be declared final	80
KONSTANTHEIT_VERSTECKTE: Local variable 'kost2' could be declared final	91

org/projectforge/fibu/kost/KostZuweisungExport.java

Violation	Line
Do not use the short type	96
Avoid using final local variables, turn them into fields	108
Avoid unnecessary comparisons in boolean expressions	112
Avoid using final local variables, turn them into fields	115
Avoid instantiating new objects inside loops	115
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	140
Avoid using final local variables, turn them into fields	143
Avoid instantiating new objects inside loops	146
Avoid using final local variables, turn them into fields	152
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	161
Avoid using final local variables, turn them into fields	162
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	174
Avoid using final local variables, turn them into fields	178
Avoid unnecessary comparisons in boolean expressions	183
Avoid using final local variables, turn them into fields	190
Avoid using final local variables, turn them into fields	192
Avoid using final local variables, turn them into fields	198
Avoid using final local variables, turn them into fields	200

org/projectforge/fibu/kost/KostZuweisungenCopyHelper.java

Violation	Line
Avoid using final local variables, turn them into fields	59
Avoid using final local variables, turn them into fields	60
Avoid using final local variables, turn them into fields	69

org/projectforge/fibu/kost/NewKostZuweisungDao.java

Violation	Line
TOTE_ATTRIBUTE: Avoid unused private fields such as 'log'.	39
TOTE_ATTRIBUTE: Avoid unused private fields such as 'employeeDao'.	41
Perhaps 'employeeDao' could be replaced by a local variable.	41
TOTE_ATTRIBUTE: Avoid unused private fields such as 'employeeSalaryDao'.	47
Perhaps 'employeeSalaryDao' could be replaced by a local variable.	47
TOTE_ATTRIBUTE: Avoid unused private fields such as 'kostZuweisungDao'.	49
Perhaps 'kostZuweisungDao' could be replaced by a local variable.	49
TOTE_ATTRIBUTE: Avoid unused private fields such as 'monthlyEmployeeReportDao'.	51
Perhaps 'monthlyEmployeeReportDao' could be replaced by a local variable.	51
Avoid using final local variables, turn them into fields	97 - 99
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	152

org/projectforge/fibu/kost/reporting/Report.java

Violation	Line
Avoid using final local variables, turn them into fields	146
Avoid unnecessary comparisons in boolean expressions	182
Avoid unnecessary comparisons in boolean expressions	182
Avoid unnecessary comparisons in boolean expressions	186
Avoid unnecessary comparisons in boolean expressions	189
Avoid unnecessary comparisons in boolean expressions	243
Avoid unnecessary comparisons in boolean expressions	246
Avoid unnecessary comparisons in boolean expressions	250
Avoid using final local variables, turn them into fields	255
Avoid unnecessary comparisons in boolean expressions	271
Avoid using final local variables, turn them into fields	274
Avoid instantiating new objects inside loops	274
Avoid unnecessary comparisons in boolean expressions	278
Avoid unnecessary comparisons in boolean expressions	278
Avoid unnecessary comparisons in boolean expressions	282
Avoid unnecessary comparisons in boolean expressions	286
Avoid instantiating new objects inside loops	289
Avoid unnecessary comparisons in boolean expressions	292
Avoid instantiating new objects inside loops	295
Avoid unnecessary comparisons in boolean expressions	301
Avoid using final local variables, turn them into fields	302
Avoid using final local variables, turn them into fields	303
Avoid using final local variables, turn them into fields	306
Avoid unnecessary comparisons in boolean expressions	310
Avoid using final local variables, turn them into fields	311
Avoid using final local variables, turn them into fields	312
Avoid using final local variables, turn them into fields	315
Avoid using final local variables, turn them into fields	367 - 386
Avoid using final local variables, turn them into fields	370
Avoid using final local variables, turn them into fields	371
Avoid using final local variables, turn them into fields	372
Avoid unnecessary comparisons in boolean expressions	375
Avoid unnecessary comparisons in boolean expressions	378
Avoid using final local variables, turn them into fields	382
Avoid using final local variables, turn them into fields	383
Avoid unnecessary comparisons in boolean expressions	384
Avoid unnecessary comparisons in boolean expressions	384
Avoid unnecessary comparisons in boolean expressions	425
Avoid using final local variables, turn them into fields	427
Avoid unnecessary comparisons in boolean expressions	428
Avoid unnecessary comparisons in boolean expressions	449
This call to String.startsWith can be rewritten using String.charAt(0)	449
Avoid using final local variables, turn them into fields	452
Consider simply returning the value vs storing it in local variable 'str'	453

org/projectforge/fibu/kost/reporting/ReportDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'xstream' could be made final; it is only initialized in the declaration or constructor.	50
KONSTANTHEIT_VERSTECKTE: Local variable 'reportObjective' could be declared final	71
KONSTANTHEIT_VERSTECKTE: Local variable 'report' could be declared final	72
Consider simply returning the value vs storing it in local variable 'report'	73
KONSTANTHEIT_VERSTECKTE: Local variable 'reportObjective' could be declared final	83
KONSTANTHEIT_VERSTECKTE: Local variable 'report' could be declared final	84
Consider simply returning the value vs storing it in local variable 'report'	85
Avoid using final local variables, turn them into fields	98
Avoid using final local variables, turn them into fields	103
KONSTANTHEIT_VERSTECKTE: Local variable 'reportObjective' could be declared final	110
Consider simply returning the value vs storing it in local variable 'reportObjective'	111
KONSTANTHEIT_VERSTECKTE: Local variable 'reportObjective' could be declared final	121
Consider simply returning the value vs storing it in local variable 'reportObjective'	122
KONSTANTHEIT_VERSTECKTE: Local variable 'xml' could be declared final	131
Consider simply returning the value vs storing it in local variable 'xml'	132

org/projectforge/fibu/kost/reporting/ReportGenerator.java

Violation	Line
Avoid using final local variables, turn them into fields	79
Avoid unnecessary comparisons in boolean expressions	126
Avoid using final local variables, turn them into fields	130
Avoid unnecessary comparisons in boolean expressions	131
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	133 - 135
Avoid using final local variables, turn them into fields	137
Avoid instantiating new objects inside loops	137

org/projectforge/fibu/kost/reporting/ReportGeneratorList.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'reports' could be made final; it is only initialized in the declaration or constructor.	32
KONSTANTHEIT_VERSTECKTE: Local variable 'generator' could be declared final	43
KONSTANTHEIT_VERSTECKTE: Local variable 'generator' could be declared final	54
KONSTANTHEIT_VERSTECKTE: Local variable 'generator' could be declared final	66
KONSTANTHEIT_VERSTECKTE: Local variable 'generator' could be declared final	77

org/projectforge/fibu/kost/reporting/ReportOutputType.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	49
Avoid unnecessary comparisons in boolean expressions	53
Avoid unnecessary comparisons in boolean expressions	53

org/projectforge/fibu/kost/reporting/ReportStorage.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'root' could be made final; it is only initialized in the declaration or constructor.	33
KONSTANTHEIT_VERSTECKTE: Private field 'openReports' could be made final; it is only initialized in the declaration or constructor.	39
KONSTANTHEIT_VERSTECKTE: Local variable 'report' could be declared final	59
Avoid unnecessary comparisons in boolean expressions	82
Avoid unnecessary comparisons in boolean expressions	86
Avoid unnecessary comparisons in boolean expressions	89

org/projectforge/gantt/ExportMSProject.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 247
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	121
Avoid unnecessary comparisons in boolean expressions	124
Avoid unnecessary comparisons in boolean expressions	124
Avoid unnecessary comparisons in boolean expressions	124
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	127
Avoid unnecessary comparisons in boolean expressions	131
Avoid unnecessary comparisons in boolean expressions	135
Avoid using final local variables, turn them into fields	140
Avoid using final local variables, turn them into fields	142
Avoid using final local variables, turn them into fields	154
Avoid using final local variables, turn them into fields	166
Avoid using final local variables, turn them into fields	180
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	194
Avoid using final local variables, turn them into fields	206
Avoid using final local variables, turn them into fields	207
Avoid using final local variables, turn them into fields	213
Avoid using final local variables, turn them into fields	214
Avoid using final local variables, turn them into fields	223

org/projectforge/gantt/GanttChart.java

Violation	Line
Perhaps 'name' could be replaced by a local variable.	49
KONSTANTHEIT_VERSTECKTE: Private field 'style' could be made final; it is only initialized in the declaration or constructor.	51
KONSTANTHEIT_VERSTECKTE: Private field 'settings' could be made final; it is only initialized in the declaration or constructor.	53
KONSTANTHEIT_VERSTECKTE: Private field 'objectMap' could be made final; it is only initialized in the declaration or constructor.	71
Avoid using final local variables, turn them into fields	188
Avoid using final local variables, turn them into fields	202
Avoid instantiating new objects inside loops	202
Avoid using final local variables, turn them into fields	206
Avoid using final local variables, turn them into fields	207
Avoid using final local variables, turn them into fields	260 - 264
Avoid using final local variables, turn them into fields	266
Avoid using final local variables, turn them into fields	268
Avoid unnecessary comparisons in boolean expressions	272
Avoid using final local variables, turn them into fields	273
Avoid unnecessary comparisons in boolean expressions	274
Avoid using final local variables, turn them into fields	325
Avoid unnecessary comparisons in boolean expressions	336
Avoid unnecessary comparisons in boolean expressions	341
Avoid unnecessary comparisons in boolean expressions	353
Avoid unnecessary comparisons in boolean expressions	358
Avoid using final local variables, turn them into fields	361
Avoid unnecessary comparisons in boolean expressions	365
Avoid unnecessary comparisons in boolean expressions	371
Avoid unnecessary comparisons in boolean expressions	379
Avoid unnecessary comparisons in boolean expressions	379
Avoid unnecessary comparisons in boolean expressions	394
Use equals() to compare object references.	404
Avoid unnecessary comparisons in boolean expressions	405
Avoid unnecessary comparisons in boolean expressions	409
Use equals() to compare object references.	424
Avoid unnecessary comparisons in boolean expressions	427
Avoid using final local variables, turn them into fields	431
Avoid unnecessary comparisons in boolean expressions	432
Avoid unnecessary comparisons in boolean expressions	435
Avoid using final local variables, turn them into fields	442
Avoid unnecessary comparisons in boolean expressions	443
KONSTANTHEIT_VERSTECKTE: Local variable 'diagramWidth' could be declared final	448
Avoid using final local variables, turn them into fields	462
Avoid unnecessary comparisons in boolean expressions	468
Avoid unnecessary comparisons in boolean expressions	471
Avoid using final local variables, turn them into fields	480
Avoid unnecessary comparisons in boolean expressions	481
Avoid unnecessary comparisons in boolean expressions	485
KONSTANTHEIT_VERSTECKTE: Local variable 'diagramWidth' could be declared final	502
Avoid using final local variables, turn them into fields	512
Avoid using final local variables, turn them into fields	516
Avoid using final local variables, turn them into fields	517
Avoid unnecessary comparisons in boolean expressions	518
Avoid using final local variables, turn them into fields	525
Avoid using final local variables, turn them into fields	526
Avoid using final local variables, turn them into fields	541
Avoid using final local variables, turn them into fields	542
Avoid using final local variables, turn them into fields	547
Avoid unnecessary comparisons in boolean expressions	551
Avoid using final local variables, turn them into fields	560
Avoid using final local variables, turn them into fields	562
Avoid using final local variables, turn them into fields	568
Avoid unnecessary comparisons in boolean expressions	569
Avoid using final local variables, turn them into fields	570
Avoid using final local variables, turn them into fields	571
Avoid using final local variables, turn them into fields	572
Avoid using final local variables, turn them into fields	573
Avoid using final local variables, turn them into fields	574
KONSTANTHEIT_VERSTECKTE: Local variable 'diagramWidth' could be declared final	588
Avoid unnecessary comparisons in boolean expressions	592
Avoid unnecessary comparisons in boolean expressions	601
Avoid using final local variables, turn them into fields	623
Avoid using final local variables, turn them into fields	624
Avoid using final local variables, turn them into fields	625
Avoid using final local variables, turn them into fields	629
Avoid using final local variables, turn them into fields	636

org/projectforge/gantt/GanttChartDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'taskFields' could be made final; it is only initialized in the declaration or constructor.	78
KONSTANTHEIT_VERSTECKTE: Private field 'fieldMapping' could be made final; it is only initialized in the declaration or constructor.	83
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	102
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	110
Avoid using final local variables, turn them into fields	128
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	133
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	138
Avoid unnecessary comparisons in boolean expressions	139
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	157
Avoid using final local variables, turn them into fields	159
Avoid unnecessary comparisons in boolean expressions	160
Avoid unnecessary comparisons in boolean expressions	174
Avoid using final local variables, turn them into fields	176
Avoid unnecessary comparisons in boolean expressions	177
Avoid unnecessary comparisons in boolean expressions	182
Avoid unnecessary comparisons in boolean expressions	186
Avoid unnecessary comparisons in boolean expressions	191
Avoid unnecessary comparisons in boolean expressions	195
Avoid using final local variables, turn them into fields	200
Avoid using final local variables, turn them into fields	201
Avoid using final local variables, turn them into fields	228
Avoid using final local variables, turn them into fields	229
Avoid using final local variables, turn them into fields	230 - 283
Avoid unnecessary comparisons in boolean expressions	234
Avoid unnecessary comparisons in boolean expressions	234
Avoid unnecessary comparisons in boolean expressions	238
Avoid using final local variables, turn them into fields	239
Avoid unnecessary comparisons in boolean expressions	244
Avoid using final local variables, turn them into fields	245
Avoid unnecessary comparisons in boolean expressions	256
Avoid using final local variables, turn them into fields	259
Avoid unnecessary comparisons in boolean expressions	275
Avoid using final local variables, turn them into fields	291
Avoid using final local variables, turn them into fields	292
Avoid using final local variables, turn them into fields	303
Avoid using final local variables, turn them into fields	306
Avoid using final local variables, turn them into fields	307
Avoid unnecessary comparisons in boolean expressions	308
Avoid using final local variables, turn them into fields	314
Avoid using final local variables, turn them into fields	315
Avoid unnecessary comparisons in boolean expressions	316
Avoid using final local variables, turn them into fields	338 - 413
Avoid unnecessary comparisons in boolean expressions	342
Avoid using final local variables, turn them into fields	346
Avoid using final local variables, turn them into fields	347
Avoid unnecessary comparisons in boolean expressions	348
Avoid unnecessary comparisons in boolean expressions	352
Avoid using final local variables, turn them into fields	355
Avoid using final local variables, turn them into fields	356
Avoid unnecessary comparisons in boolean expressions	358
Avoid unnecessary comparisons in boolean expressions	367
Avoid using final local variables, turn them into fields	368
Avoid using final local variables, turn them into fields	369
Avoid unnecessary comparisons in boolean expressions	374
Avoid unnecessary comparisons in boolean expressions	386
Avoid using final local variables, turn them into fields	387
Avoid unnecessary comparisons in boolean expressions	388
Avoid using final local variables, turn them into fields	389
Avoid using final local variables, turn them into fields	390
Avoid using final local variables, turn them into fields	391
Avoid unnecessary comparisons in boolean expressions	398
Avoid using final local variables, turn them into fields	399
Avoid using final local variables, turn them into fields	400
Avoid using final local variables, turn them into fields	425
Avoid using final local variables, turn them into fields	436

org/projectforge/gantt/GanttChartData.java

Violation	Line
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	96
Avoid unnecessary comparisons in boolean expressions	109

org/projectforge/gantt/GanttChartRight.java

Violation	Line
Avoid using final local variables, turn them into fields	90
Avoid unnecessary comparisons in boolean expressions	102
Avoid unnecessary comparisons in boolean expressions	110
Avoid unnecessary comparisons in boolean expressions	115
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	124

org/projectforge/gantt/GanttChartXLabelBarRenderer.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	70
KONSTANTHEIT_VERSTECKTE: Private field 'fromDate' could be made final; it is only initialized in the declaration or constructor.	72
KONSTANTHEIT_VERSTECKTE: Private field 'toDate' could be made final; it is only initialized in the declaration or constructor.	74
KONSTANTHEIT_VERSTECKTE: Private field 'diagramWidth' could be made final; it is only initialized in the declaration or constructor.	78
KONSTANTHEIT_VERSTECKTE: Private field 'style' could be made final; it is only initialized in the declaration or constructor.	80
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'getScale' called during object construction	89
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	97
Avoid using final local variables, turn them into fields	98
Avoid unnecessary comparisons in boolean expressions	134
Avoid unnecessary comparisons in boolean expressions	152
Avoid unnecessary comparisons in boolean expressions	171
Avoid unnecessary comparisons in boolean expressions	175
Avoid using final local variables, turn them into fields	185
KONSTANTHEIT_VERSTECKTE: Local variable 'widthPerUnit' could be declared final	193
Avoid using final local variables, turn them into fields	215
Avoid using final local variables, turn them into fields	217
Avoid using final local variables, turn them into fields	218
Avoid unnecessary comparisons in boolean expressions	225
Avoid unnecessary comparisons in boolean expressions	227
Avoid unnecessary comparisons in boolean expressions	228
Avoid unnecessary comparisons in boolean expressions	230
Avoid using final local variables, turn them into fields	242
Avoid using final local variables, turn them into fields	243
KONSTANTHEIT_VERSTECKTE: Local variable 'drawTick' could be declared final	251
KONSTANTHEIT_VERSTECKTE: Local variable 'drawTick2' could be declared final	252
KONSTANTHEIT_VERSTECKTE: Local variable 'drawGrid' could be declared final	253
Avoid unnecessary comparisons in boolean expressions	254
Avoid unnecessary comparisons in boolean expressions	282
Avoid unnecessary comparisons in boolean expressions	284
Avoid unnecessary comparisons in boolean expressions	297
Avoid unnecessary comparisons in boolean expressions	299
Avoid unnecessary comparisons in boolean expressions	301
Avoid unnecessary comparisons in boolean expressions	304
Avoid unnecessary comparisons in boolean expressions	304
Avoid using final local variables, turn them into fields	331
Avoid using final local variables, turn them into fields	332
Avoid unnecessary comparisons in boolean expressions	335
Avoid unnecessary comparisons in boolean expressions	335
Avoid using final local variables, turn them into fields	339
Avoid using final local variables, turn them into fields	371
Avoid using final local variables, turn them into fields	372
Avoid using final local variables, turn them into fields	373
Avoid using final local variables, turn them into fields	383

org/projectforge/gantt/GanttTaskImpl.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	49
Avoid unnecessary comparisons in boolean expressions	305
Avoid using final local variables, turn them into fields	316
Avoid unnecessary comparisons in boolean expressions	317
Avoid unnecessary comparisons in boolean expressions	327
Avoid unnecessary comparisons in boolean expressions	350
Avoid unnecessary comparisons in boolean expressions	373
Avoid unnecessary comparisons in boolean expressions	486
Avoid using final local variables, turn them into fields	496
Avoid unnecessary comparisons in boolean expressions	507
Avoid using final local variables, turn them into fields	512
Avoid unnecessary comparisons in boolean expressions	526
Avoid unnecessary comparisons in boolean expressions	536
Avoid unnecessary comparisons in boolean expressions	546
Avoid unnecessary comparisons in boolean expressions	556
Avoid unnecessary comparisons in boolean expressions	560
Avoid using final local variables, turn them into fields	576
Avoid using final local variables, turn them into fields	589
Avoid using final local variables, turn them into fields	594

org/projectforge/gantt/GanttUtils.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 265
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	43 - 82
Avoid unnecessary comparisons in boolean expressions	46
Avoid using final local variables, turn them into fields	49
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	58
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	72
Avoid unnecessary comparisons in boolean expressions	77
Avoid using final local variables, turn them into fields	91
Consider simply returning the value vs storing it in local variable 'start'	92
Avoid unnecessary comparisons in boolean expressions	103
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	108
Avoid unnecessary comparisons in boolean expressions	110
Avoid unnecessary comparisons in boolean expressions	115
Avoid using final local variables, turn them into fields	122
Avoid unnecessary comparisons in boolean expressions	126
Avoid unnecessary comparisons in boolean expressions	137
Avoid using final local variables, turn them into fields	141
Avoid unnecessary comparisons in boolean expressions	144
Avoid unnecessary comparisons in boolean expressions	145
Avoid using final local variables, turn them into fields	153
Avoid unnecessary comparisons in boolean expressions	159
Avoid using final local variables, turn them into fields	169
Consider simply returning the value vs storing it in local variable 'calculatedStartDate'	170
Avoid using final local variables, turn them into fields	172
Consider simply returning the value vs storing it in local variable 'calculatedEndDate'	173
Avoid using final local variables, turn them into fields	184
Consider simply returning the value vs storing it in local variable 'end'	185
Avoid unnecessary comparisons in boolean expressions	201
Avoid using final local variables, turn them into fields	204
Avoid using final local variables, turn them into fields	206
Avoid unnecessary comparisons in boolean expressions	208
Avoid unnecessary comparisons in boolean expressions	213
Avoid using final local variables, turn them into fields	220
Avoid unnecessary comparisons in boolean expressions	224
Avoid unnecessary comparisons in boolean expressions	235
Avoid using final local variables, turn them into fields	240
Avoid unnecessary comparisons in boolean expressions	241
Avoid using final local variables, turn them into fields	247
Avoid unnecessary comparisons in boolean expressions	253
Avoid using final local variables, turn them into fields	261

org/projectforge/gantt/Task2GanttTaskConverter.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 139
Avoid using final local variables, turn them into fields	39
Avoid using final local variables, turn them into fields	52
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	97
Avoid unnecessary comparisons in boolean expressions	98
Avoid unnecessary comparisons in boolean expressions	100
Avoid unnecessary comparisons in boolean expressions	114
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	116
Avoid using final local variables, turn them into fields	121

org/projectforge/humanresources/HRDao.java

Violation	Line
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	84
Avoid unnecessary comparisons in boolean expressions	88
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	99
Avoid using final local variables, turn them into fields	100
Avoid unnecessary comparisons in boolean expressions	113
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	119
Avoid unnecessary comparisons in boolean expressions	125
Avoid using final local variables, turn them into fields	128
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	130
Avoid unnecessary comparisons in boolean expressions	144
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	148
Avoid unnecessary comparisons in boolean expressions	149
Avoid using final local variables, turn them into fields	150
Avoid unnecessary comparisons in boolean expressions	160
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	182
Avoid unnecessary comparisons in boolean expressions	183
Avoid using final local variables, turn them into fields	203
Avoid unnecessary comparisons in boolean expressions	204
Avoid unnecessary comparisons in boolean expressions	205
Avoid unnecessary comparisons in boolean expressions	206
Avoid unnecessary comparisons in boolean expressions	214
Avoid unnecessary comparisons in boolean expressions	216
Avoid unnecessary comparisons in boolean expressions	217
Avoid unnecessary comparisons in boolean expressions	231

org/projectforge/humanresources/HRPlanningDO.java

Violation	Line
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	105
Avoid unnecessary comparisons in boolean expressions	206
Avoid unnecessary comparisons in boolean expressions	243
Avoid unnecessary comparisons in boolean expressions	275
Avoid unnecessary comparisons in boolean expressions	416

org/projectforge/humanresources/HRPlanningDao.java

Violation	Line
Avoid using final local variables, turn them into fields	97
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	136
Avoid unnecessary comparisons in boolean expressions	145
Avoid using final local variables, turn them into fields	156
Avoid unnecessary comparisons in boolean expressions	157
Avoid using final local variables, turn them into fields	161 - 162
Avoid using final local variables, turn them into fields	166
Avoid unnecessary comparisons in boolean expressions	167
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	183
Avoid using final local variables, turn them into fields	184
Avoid using final local variables, turn them into fields	193
Avoid using final local variables, turn them into fields	195
Avoid unnecessary comparisons in boolean expressions	210
Avoid using final local variables, turn them into fields	226
Avoid using final local variables, turn them into fields	240
Avoid using final local variables, turn them into fields	246
Avoid using final local variables, turn them into fields	265
Avoid unnecessary comparisons in boolean expressions	266
Avoid unnecessary comparisons in boolean expressions	269
Avoid using final local variables, turn them into fields	271
Avoid using final local variables, turn them into fields	273
Returning 'ADDITIONAL_SEARCH_DOS' may expose an internal array.	303

org/projectforge/humanresources/HRPlanningEntryDO.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'other' could be declared final	355
Avoid unnecessary comparisons in boolean expressions	359
Avoid unnecessary comparisons in boolean expressions	361
Avoid unnecessary comparisons in boolean expressions	363
KONSTANTHEIT_VERSTECKTE: Local variable 'hcb' could be declared final	373
Avoid using final local variables, turn them into fields	402

org/projectforge/humanresources/HRPlanningEntryDao.java

Violation	Line
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	99
Avoid using final local variables, turn them into fields	101
Avoid using final local variables, turn them into fields	105
Avoid unnecessary comparisons in boolean expressions	107
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	117 - 119
Avoid unnecessary comparisons in boolean expressions	122
Avoid unnecessary comparisons in boolean expressions	122
Avoid using final local variables, turn them into fields	125
Avoid unnecessary comparisons in boolean expressions	126
Avoid using final local variables, turn them into fields	126
Avoid unnecessary comparisons in boolean expressions	128
Avoid using final local variables, turn them into fields	132
Avoid unnecessary comparisons in boolean expressions	136
Avoid unnecessary comparisons in boolean expressions	140
Avoid unnecessary comparisons in boolean expressions	141
Avoid using final local variables, turn them into fields	145
Avoid instantiating new objects inside loops	145
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	155
Avoid instantiating new objects inside loops	155
Avoid using final local variables, turn them into fields	158
Avoid unnecessary comparisons in boolean expressions	159
Avoid unnecessary comparisons in boolean expressions	160
Avoid using final local variables, turn them into fields	180
Avoid using final local variables, turn them into fields	183
Avoid unnecessary comparisons in boolean expressions	198
Avoid using final local variables, turn them into fields	238

org/projectforge/humanresources/HRPlanningExport.java

Violation	Line
Avoid using final local variables, turn them into fields	67
TOTE_ATTRIBUTE: Avoid unused private fields such as 'userGroupCache'.	99
TOTE_ATTRIBUTE: Avoid unused private fields such as 'projektDao'.	102
Avoid using final local variables, turn them into fields	128
Avoid using final local variables, turn them into fields	133
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	134
KONSTANTHEIT_VERSTECKTE: Local variable 'cols' could be declared final	137 - 150
Avoid using final local variables, turn them into fields	155
KONSTANTHEIT_VERSTECKTE: Local variable 'mapping' could be declared final	165
Avoid using final local variables, turn them into fields	199
Avoid using final local variables, turn them into fields	203
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	204
KONSTANTHEIT_VERSTECKTE: Local variable 'cols' could be declared final	207 - 210
Avoid using final local variables, turn them into fields	215
Avoid unused local variables such as 'mapping'.	220
KONSTANTHEIT_VERSTECKTE: Local variable 'mapping' could be declared final	220
Avoid unused local variables such as 'projectNames'.	223
KONSTANTHEIT_VERSTECKTE: Local variable 'projectNames' could be declared final	223
When instantiating a SimpleDateFormat object, specify a Locale	251
Avoid unused local variables such as 'simpleDateFormat'.	251
KONSTANTHEIT_VERSTECKTE: Local variable 'simpleDateFormat' could be declared final	251
Avoid using final local variables, turn them into fields	322
Avoid using final local variables, turn them into fields	326
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	327
KONSTANTHEIT_VERSTECKTE: Local variable 'cols' could be declared final	330 - 333
Avoid using final local variables, turn them into fields	338
Avoid unused local variables such as 'mapping'.	343
KONSTANTHEIT_VERSTECKTE: Local variable 'mapping' could be declared final	343
KONSTANTHEIT_VERSTECKTE: Local variable 'userNames' could be declared final	346
KONSTANTHEIT_VERSTECKTE: Local variable 'userName' could be declared final	348
Avoid unnecessary comparisons in boolean expressions	355
When instantiating a SimpleDateFormat object, specify a Locale	374
Avoid unused local variables such as 'simpleDateFormat'.	374
KONSTANTHEIT_VERSTECKTE: Local variable 'simpleDateFormat' could be declared final	374
Avoid using final local variables, turn them into fields	452
Avoid using final local variables, turn them into fields	456
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	457
Avoid unused local variables such as 'projectNames'.	461
KONSTANTHEIT_VERSTECKTE: Local variable 'projectNames' could be declared final	461
When instantiating a SimpleDateFormat object, specify a Locale	550
KONSTANTHEIT_VERSTECKTE: Local variable 'simpleDateFormat' could be declared final	550
KONSTANTHEIT_VERSTECKTE: Local variable 'year' could be declared final	551

org/projectforge/humanresources/HRPlanningRight.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	69

org/projectforge/humanresources/HRViewData.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'projects' could be made final; it is only initialized in the declaration or constructor.	55
KONSTANTHEIT_VERSTECKTE: Private field 'customers' could be made final; it is only initialized in the declaration or constructor.	57
Avoid unnecessary comparisons in boolean expressions	117
Avoid unnecessary comparisons in boolean expressions	128

org/projectforge/humanresources/HRViewUserData.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	178
Avoid unnecessary comparisons in boolean expressions	192

org/projectforge/jira/JiraConfig.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'createIssueUrl' could be made final; it is only initialized in the declaration or constructor.	37

org/projectforge/jira/JiraUtils.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 135
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	98
Avoid using final local variables, turn them into fields	120
Avoid using final local variables, turn them into fields	121
Avoid instantiating new objects inside loops	124
Avoid using final local variables, turn them into fields	132

org/projectforge/ldap/LdapSetup.java

Violation	Line
A class which only has private constructors should be final	36 - 91
Avoid using final local variables, turn them into fields	74
Avoid unnecessary comparisons in boolean expressions	75

org/projectforge/ldap/PersonDao.java

Violation	Line
TOTE_ATTRIBUTE: Avoid unused private fields such as 'log'.	50
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	111
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	133
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	138
Avoid using final local variables, turn them into fields	143
Avoid using final local variables, turn them into fields	144
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	175
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	180
Avoid using final local variables, turn them into fields	185
Avoid using final local variables, turn them into fields	186
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	217
Avoid using final local variables, turn them into fields	218
Avoid using final local variables, turn them into fields	220
Avoid using final local variables, turn them into fields	244
Avoid using final local variables, turn them into fields	253
Consider simply returning the value vs storing it in local variable 'dn'	254
HASHTABLE_VECTOR: Consider replacing this Hashtable with the newer java.util.Map	257
Avoid using final local variables, turn them into fields	260
Avoid using final local variables, turn them into fields	273
HASHTABLE_VECTOR: Consider replacing this Hashtable with the newer java.util.Map	273
Avoid using final local variables, turn them into fields	274
HASHTABLE_VECTOR: Consider replacing this Hashtable with the newer java.util.Map	274
Avoid using final local variables, turn them into fields	280
HASHTABLE_VECTOR: Consider replacing this Hashtable with the newer java.util.Map	280
Avoid using final local variables, turn them into fields	289
Avoid using final local variables, turn them into fields	290
Avoid using final local variables, turn them into fields	302
Avoid using final local variables, turn them into fields	308
Avoid using final local variables, turn them into fields	310
Avoid using final local variables, turn them into fields	311
Avoid using final local variables, turn them into fields	313
Avoid using final local variables, turn them into fields	314
Avoid using final local variables, turn them into fields	316
Avoid using final local variables, turn them into fields	318
Prefer StringBuffer over += for concatenating strings	327
Prefer StringBuffer over += for concatenating strings	330

org/projectforge/lucene/ClassicAnalyzer.java

Violation	Line
Avoid using final local variables, turn them into fields	126

org/projectforge/lucene/ClassicFilter.java

Violation	Line
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	52
Avoid using final local variables, turn them into fields	53
Use equals() to compare object references.	55
Use equals() to compare object references.	61
Avoid using final local variables, turn them into fields	64

org/projectforge/lucene/ClassicTokenizer.java

Violation	Line
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	202

org/projectforge/lucene/ClassicTokenizerImpl.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	141
KONSTANTHEIT_VERSTECKTE: Local variable 'l' could be declared final	150
KONSTANTHEIT_VERSTECKTE: Local variable 'value' could be declared final	153
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	176
KONSTANTHEIT_VERSTECKTE: Local variable 'l' could be declared final	185
KONSTANTHEIT_VERSTECKTE: Local variable 'high' could be declared final	187
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	263
KONSTANTHEIT_VERSTECKTE: Local variable 'l' could be declared final	272
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	306
KONSTANTHEIT_VERSTECKTE: Local variable 'l' could be declared final	315
KONSTANTHEIT_VERSTECKTE: Local variable 'value' could be declared final	318
Perhaps 'zzState' could be replaced by a local variable.	328
TOTE_ATTRIBUTE: Avoid unused private fields such as 'yyline'.	351
Perhaps 'yyline' could be replaced by a local variable.	351
It is somewhat confusing to have a field name with the same name as a method	354
TOTE_ATTRIBUTE: Avoid unused private fields such as 'yycolumn'.	360
TOTE_ATTRIBUTE: Avoid unused private fields such as 'zzAtBOL'.	365
Perhaps 'zzAtBOL' could be replaced by a local variable.	365
TOTE_ATTRIBUTE: Avoid unused private fields such as 'zzEOFDone'.	371
Perhaps 'zzEOFDone' could be replaced by a local variable.	371
KONSTANTHEIT_VERSTECKTE: Local variable 'value' could be declared final	439
KONSTANTHEIT_VERSTECKTE: Local variable 'newBuffer' could be declared final	471
KONSTANTHEIT_VERSTECKTE: Local variable 'numRead' could be declared final	477 - 478
KONSTANTHEIT_VERSTECKTE: Local variable 'c' could be declared final	486
KONSTANTHEIT_VERSTECKTE: Local variable 'zzCMapL' could be declared final	647
KONSTANTHEIT_VERSTECKTE: Local variable 'zzTransL' could be declared final	649
KONSTANTHEIT_VERSTECKTE: Local variable 'zzRowMapL' could be declared final	650
KONSTANTHEIT_VERSTECKTE: Local variable 'zzAttrL' could be declared final	651
KONSTANTHEIT_VERSTECKTE: Local variable 'eof' could be declared final	684
KONSTANTHEIT_VERSTECKTE: Local variable 'zzNext' could be declared final	698

org/projectforge/lucene/StandardAnalyzer.java

Violation	Line
Avoid using final local variables, turn them into fields	124

org/projectforge/lucene/StandardFilter.java

Violation	Line
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	67
Use equals() to compare object references.	69
Use equals() to compare object references.	75
Avoid using final local variables, turn them into fields	78

org/projectforge/lucene/StandardTokenizer.java

Violation	Line
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	196
Avoid using final local variables, turn them into fields	223

org/projectforge/lucene/StandardTokenizerImpl.java

Violation	Line
Avoid using final local variables, turn them into fields	215
Avoid using final local variables, turn them into fields	224
Avoid using final local variables, turn them into fields	227
Avoid using final local variables, turn them into fields	257
Avoid using final local variables, turn them into fields	266
Avoid using final local variables, turn them into fields	268
Avoid using final local variables, turn them into fields	586
Avoid using final local variables, turn them into fields	595
Avoid using final local variables, turn them into fields	628
Avoid using final local variables, turn them into fields	637
Avoid using final local variables, turn them into fields	640
Perhaps 'zzState' could be replaced by a local variable.	650
TOTE_ATTRIBUTE: Avoid unused private fields such as 'yyline'.	673
Perhaps 'yyline' could be replaced by a local variable.	673
It is somewhat confusing to have a field name with the same name as a method	676
TOTE_ATTRIBUTE: Avoid unused private fields such as 'yycolumn'.	682
TOTE_ATTRIBUTE: Avoid unused private fields such as 'zzAtBOL'.	687
Perhaps 'zzAtBOL' could be replaced by a local variable.	687
TOTE_ATTRIBUTE: Avoid unused private fields such as 'zzEOFDone'.	693
Perhaps 'zzEOFDone' could be replaced by a local variable.	693
Avoid using final local variables, turn them into fields	760
Avoid using final local variables, turn them into fields	765
Avoid using final local variables, turn them into fields	797
Avoid using final local variables, turn them into fields	803 - 804
Avoid using final local variables, turn them into fields	812
Avoid using final local variables, turn them into fields	973
Avoid using final local variables, turn them into fields	975
Avoid using final local variables, turn them into fields	976
Avoid using final local variables, turn them into fields	977
Avoid using final local variables, turn them into fields	1010
Avoid using final local variables, turn them into fields	1024

org/projectforge/lucene/UAX29URLEmailTokenizer.java

Violation	Line
Avoid using final local variables, turn them into fields	249
Avoid using final local variables, turn them into fields	258
Avoid using final local variables, turn them into fields	261
Avoid using final local variables, turn them into fields	443
Avoid using final local variables, turn them into fields	452
Avoid using final local variables, turn them into fields	454
Avoid using final local variables, turn them into fields	3157
Avoid using final local variables, turn them into fields	3166
Avoid using final local variables, turn them into fields	3211
Avoid using final local variables, turn them into fields	3220
Avoid using final local variables, turn them into fields	3223
Perhaps 'zzState' could be replaced by a local variable.	3233
TOTE_ATTRIBUTE: Avoid unused private fields such as 'yyline'.	3256
Perhaps 'yyline' could be replaced by a local variable.	3256
TOTE_ATTRIBUTE: Avoid unused private fields such as 'yycolumn'.	3265
TOTE_ATTRIBUTE: Avoid unused private fields such as 'zzAtBOL'.	3270
Perhaps 'zzAtBOL' could be replaced by a local variable.	3270
TOTE_ATTRIBUTE: Avoid unused private fields such as 'zzEOFDone'.	3276
Perhaps 'zzEOFDone' could be replaced by a local variable.	3276
Avoid using final local variables, turn them into fields	3357
Avoid using final local variables, turn them into fields	3438
Avoid using final local variables, turn them into fields	3443
Avoid using final local variables, turn them into fields	3475
Avoid using final local variables, turn them into fields	3481 - 3482
Avoid using final local variables, turn them into fields	3490
TOTE_METHODEN: Avoid unused private methods such as 'yyclose()'.	3507
TOTE_METHODEN: Avoid unused private methods such as 'yystate()'.	3545
TOTE_METHODEN: Avoid unused private methods such as 'yybegin(int)'.	3555
TOTE_METHODEN: Avoid unused private methods such as 'yytext()'.	3563
TOTE_METHODEN: Avoid unused private methods such as 'yycharat(int)'.	3579
TOTE_METHODEN: Avoid unused private methods such as 'yypushback(int)'.	3627
Avoid using final local variables, turn them into fields	3651
Avoid using final local variables, turn them into fields	3653
Avoid using final local variables, turn them into fields	3654
Avoid using final local variables, turn them into fields	3655
Avoid using final local variables, turn them into fields	3688
Avoid using final local variables, turn them into fields	3702

org/projectforge/mail/Mail.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'sb' could be declared final	259
Avoid unnecessary comparisons in boolean expressions	276
Avoid unnecessary comparisons in boolean expressions	279
Avoid unnecessary comparisons in boolean expressions	282

org/projectforge/mail/MailAccount.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'mailAcccountConfig' could be made final; it is only initialized in the declaration or constructor.	63
Avoid using final local variables, turn them into fields	73
Avoid unnecessary comparisons in boolean expressions	94
Avoid using final local variables, turn them into fields	103
KONSTANTHEIT_VERSTECKTE: Local variable 'totalMessages' could be declared final	105
Avoid using final local variables, turn them into fields	112
Avoid unnecessary comparisons in boolean expressions	113
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	126
Avoid instantiating new objects inside loops	126
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	164
Avoid unnecessary comparisons in boolean expressions	196
Avoid unnecessary comparisons in boolean expressions	223
Avoid unnecessary comparisons in boolean expressions	231
Avoid appending characters as strings in StringBuffer.append.	255
Avoid appending characters as strings in StringBuffer.append.	267
Avoid using final local variables, turn them into fields	277
Avoid using final local variables, turn them into fields	283
Avoid using final local variables, turn them into fields	284
Avoid using final local variables, turn them into fields	287
Avoid empty if statements	288 - 290
Avoid empty if statements	292 - 294
Avoid empty if statements	294 - 296
Avoid empty if statements	300 - 302
Avoid using final local variables, turn them into fields	308
Avoid unnecessary comparisons in boolean expressions	315
KONSTANTHEIT_VERSTECKTE: Local variable 'filename' could be declared final	318
Avoid using final local variables, turn them into fields	336
KONSTANTHEIT_VERSTECKTE: Local variable 'count' could be declared final	337
Avoid using final local variables, turn them into fields	351

org/projectforge/mail/MailAccountConfig.java

Violation	Line
Avoid using final local variables, turn them into fields	130

org/projectforge/mail/SendMail.java

Violation	Line
Avoid using final local variables, turn them into fields	79
String.trim().length()==0 is an inefficient way to validate an empty String.	80
Avoid unnecessary comparisons in boolean expressions	84
KONSTANTHEIT_VERSTECKTE: Local variable 'protocol' could be declared final	93
Avoid unnecessary comparisons in boolean expressions	99
Avoid using final local variables, turn them into fields	114
KONSTANTHEIT_VERSTECKTE: Local variable 'message' could be declared final	117
Avoid unnecessary comparisons in boolean expressions	139
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	147
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	154
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	178
Consider simply returning the value vs storing it in local variable 'result'	179

org/projectforge/mail/SendMailConfig.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'protocol' could be made final; it is only initialized in the declaration or constructor.	32
KONSTANTHEIT_VERSTECKTE: Private field 'port' could be made final; it is only initialized in the declaration or constructor.	36
KONSTANTHEIT_VERSTECKTE: Private field 'charset' could be made final; it is only initialized in the declaration or constructor.	44
KONSTANTHEIT_VERSTECKTE: Private field 'from' could be made final; it is only initialized in the declaration or constructor.	46
KONSTANTHEIT_VERSTECKTE: Private field 'fromReal' could be made final; it is only initialized in the declaration or constructor.	48

org/projectforge/meb/MebCache.java

Violation	Line
The Logger variable declaration does not contain the static and final modifiers	38
KONSTANTHEIT_VERSTECKTE: Private field 'mebDao' could be made final; it is only initialized in the declaration or constructor.	43
Avoid using final local variables, turn them into fields	57
Avoid using final local variables, turn them into fields	61

org/projectforge/meb/MebDao.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'mebCache' could be made final; it is only initialized in the declaration or constructor.	66
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	78
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	79
Avoid unnecessary comparisons in boolean expressions	90
When instantiating a SimpleDateFormat object, specify a Locale	91
Avoid using final local variables, turn them into fields	91
KONSTANTHEIT_VERSTECKTE: Local variable 'seconds' could be declared final	103
Avoid using final local variables, turn them into fields	152
Avoid unnecessary comparisons in boolean expressions	155
Avoid using final local variables, turn them into fields	173
Avoid unnecessary comparisons in boolean expressions	174
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	197 - 199
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	200
Avoid using final local variables, turn them into fields	204 - 205
Avoid using final local variables, turn them into fields	206
Avoid using final local variables, turn them into fields	209
Avoid unnecessary comparisons in boolean expressions	213
Avoid using final local variables, turn them into fields	222
Avoid using final local variables, turn them into fields	226

org/projectforge/meb/MebEntryStatus.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	47
Avoid unnecessary comparisons in boolean expressions	50
Avoid unnecessary comparisons in boolean expressions	52
Avoid unnecessary comparisons in boolean expressions	54
Avoid unnecessary comparisons in boolean expressions	56

org/projectforge/meb/MebJobExecutor.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	49
Avoid unnecessary comparisons in boolean expressions	53
Avoid unnecessary comparisons in boolean expressions	55

org/projectforge/meb/MebMailClient.java

Violation	Line
SYNCHRONISATION: Use block level rather than method level synchronization	56 - 134
Avoid using final local variables, turn them into fields	59
Avoid unnecessary comparisons in boolean expressions	60
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	75
Avoid instantiating new objects inside loops	75
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	78
Avoid instantiating new objects inside loops	78
Avoid unnecessary comparisons in boolean expressions	81
Avoid using final local variables, turn them into fields	82
Avoid unnecessary comparisons in boolean expressions	86
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	89
Avoid unnecessary comparisons in boolean expressions	92
Avoid using final local variables, turn them into fields	94
Avoid unnecessary comparisons in boolean expressions	97
Avoid using final local variables, turn them into fields	99
Avoid instantiating new objects inside loops	100
Avoid instantiating new objects inside loops	107
Avoid unnecessary comparisons in boolean expressions	116
Avoid unnecessary comparisons in boolean expressions	119

org/projectforge/meb/MebRight.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	100

org/projectforge/orga/ContractDao.java

Violation	Line
Avoid using final local variables, turn them into fields	64
KONSTANTHEIT_VERSTECKTE: Local variable 'next' could be declared final	82
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	87 - 88
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	89
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	111
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	113
Avoid using final local variables, turn them into fields	117

org/projectforge/orga/ContractStatus.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	49
Avoid unnecessary comparisons in boolean expressions	52
Avoid unnecessary comparisons in boolean expressions	54
Avoid unnecessary comparisons in boolean expressions	56
Avoid unnecessary comparisons in boolean expressions	58

org/projectforge/orga/PostausgangDao.java

Violation	Line
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	73
Consider simply returning the value vs storing it in local variable 'list'	74

org/projectforge/orga/PosteingangDao.java

Violation	Line
Avoid using final local variables, turn them into fields	55
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	72
Consider simply returning the value vs storing it in local variable 'list'	73

org/projectforge/plugins/banking/BankAccountEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	58
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	80

org/projectforge/plugins/banking/BankAccountListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	45
Avoid using final local variables, turn them into fields	46

org/projectforge/plugins/banking/BankAccountListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	70 - 79
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	86

org/projectforge/plugins/banking/BankingPlugin.java

Violation	Line
Returning 'PERSISTENT_ENTITIES' may expose an internal array.	55
Avoid using final local variables, turn them into fields	73

org/projectforge/plugins/banking/BankingPluginUpdates.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 88
Avoid unnecessary comparisons in boolean expressions	66
Avoid using final local variables, turn them into fields	67 - 69
Avoid unnecessary comparisons in boolean expressions	72
Avoid using final local variables, turn them into fields	73 - 75
Avoid unnecessary comparisons in boolean expressions	78
Avoid using final local variables, turn them into fields	79 - 81

org/projectforge/plugins/core/AbstractPlugin.java

Violation	Line
An empty method in an abstract class should be abstract instead	89 - 92
An empty method in an abstract class should be abstract instead	97 - 100
Avoid unnecessary comparisons in boolean expressions	105
Avoid unnecessary comparisons in boolean expressions	105
An empty method in an abstract class should be abstract instead	121 - 124
An empty method in an abstract class should be abstract instead	141 - 146
An empty method in an abstract class should be abstract instead	155 - 166
Avoid using final local variables, turn them into fields	163
An empty method in an abstract class should be abstract instead	174 - 179
An empty method in an abstract class should be abstract instead	189 - 194
An empty method in an abstract class should be abstract instead	203 - 207
An empty method in an abstract class should be abstract instead	215 - 219
An empty method in an abstract class should be abstract instead	231 - 241
Avoid unnecessary comparisons in boolean expressions	234
An empty method in an abstract class should be abstract instead	249 - 253
An empty method in an abstract class should be abstract instead	262 - 267
An empty method in an abstract class should be abstract instead	274 - 278
An empty method in an abstract class should be abstract instead	288 - 293
Avoid using final local variables, turn them into fields	290
An empty method in an abstract class should be abstract instead	301 - 305
An empty method in an abstract class should be abstract instead	336 - 339
An empty method in an abstract class should be abstract instead	345 - 348

org/projectforge/plugins/core/PluginsRegistry.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	50
SYNCHRONISATION: Use block level rather than method level synchronization	54 - 60
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	82
Avoid using final local variables, turn them into fields	84

org/projectforge/plugins/lessonslearned/LessonsLearnedDO.java

Violation	Line
TOTE_ATTRIBUTE: Avoid unused private fields such as 'proNumber'.	57
TOTE_ATTRIBUTE: Avoid unused private fields such as 'title'.	59
TOTE_ATTRIBUTE: Avoid unused private fields such as 'task'.	61
TOTE_ATTRIBUTE: Avoid unused private fields such as 'recurrence'.	63
TOTE_ATTRIBUTE: Avoid unused private fields such as 'processReviewRequired'.	65
TOTE_ATTRIBUTE: Avoid unused private fields such as 'reason'.	71
TOTE_ATTRIBUTE: Avoid unused private fields such as 'arrangements'.	77
TOTE_ATTRIBUTE: Avoid unused private fields such as 'priority'.	79
TOTE_ATTRIBUTE: Avoid unused private fields such as 'responsibleUser'.	81
TOTE_ATTRIBUTE: Avoid unused private fields such as 'dueDate'.	85

org/projectforge/plugins/marketing/AddressCampaignDO.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	75

org/projectforge/plugins/marketing/AddressCampaignEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	67
Avoid using final local variables, turn them into fields	84

org/projectforge/plugins/marketing/AddressCampaignListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	57

org/projectforge/plugins/marketing/AddressCampaignListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	71 - 81
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	92

org/projectforge/plugins/marketing/AddressCampaignRight.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	51
Avoid unnecessary comparisons in boolean expressions	53

org/projectforge/plugins/marketing/AddressCampaignValueDao.java

Violation	Line
Avoid using final local variables, turn them into fields	65 - 66
Avoid unnecessary comparisons in boolean expressions	67
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	82
Avoid using final local variables, turn them into fields	99
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	106
Avoid instantiating new objects inside loops	116
Avoid unnecessary comparisons in boolean expressions	123
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	163 - 165
Avoid unnecessary comparisons in boolean expressions	166

org/projectforge/plugins/marketing/AddressCampaignValueEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	91

org/projectforge/plugins/marketing/AddressCampaignValueEditPage.java

Violation	Line
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	71
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	77
Avoid unnecessary comparisons in boolean expressions	103
Avoid unnecessary comparisons in boolean expressions	117
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	120
Avoid unnecessary comparisons in boolean expressions	121
Avoid unnecessary comparisons in boolean expressions	122
Avoid unnecessary comparisons in boolean expressions	122
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	125
Avoid instantiating new objects inside loops	125
Avoid using final local variables, turn them into fields	128
Avoid instantiating new objects inside loops	128

org/projectforge/plugins/marketing/AddressCampaignValueExport.java

Violation	Line
Avoid using final local variables, turn them into fields	101 - 102
Avoid using final local variables, turn them into fields	103

org/projectforge/plugins/marketing/AddressCampaignValueListForm.java

Violation	Line
Perhaps 'addressCampaignValue' could be replaced by a local variable.	56
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	80 - 116
Avoid unnecessary comparisons in boolean expressions	86
Avoid using final local variables, turn them into fields	88
Avoid unnecessary comparisons in boolean expressions	90
Avoid unnecessary comparisons in boolean expressions	94
Avoid unnecessary comparisons in boolean expressions	99
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	155
Avoid unnecessary comparisons in boolean expressions	168

org/projectforge/plugins/marketing/AddressCampaignValueListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	120 - 146
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	131
Avoid empty if statements	132 - 134
Avoid unnecessary comparisons in boolean expressions	132
Avoid unnecessary comparisons in boolean expressions	134
Avoid unnecessary comparisons in boolean expressions	137
Avoid unnecessary comparisons in boolean expressions	139
Avoid unnecessary comparisons in boolean expressions	150
Avoid using final local variables, turn them into fields	155
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	169
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	192
Avoid using final local variables, turn them into fields	193 - 195
Avoid unnecessary comparisons in boolean expressions	196
Avoid using final local variables, turn them into fields	197
Avoid using final local variables, turn them into fields	211
Avoid using final local variables, turn them into fields	212
Avoid using final local variables, turn them into fields	213
Avoid using final local variables, turn them into fields	227
Avoid using final local variables, turn them into fields	228
Avoid using final local variables, turn them into fields	229
Avoid using final local variables, turn them into fields	245
Avoid unnecessary comparisons in boolean expressions	247
Avoid using final local variables, turn them into fields	276 - 291
Avoid using final local variables, turn them into fields	281
Avoid using final local variables, turn them into fields	282 - 283
Avoid using final local variables, turn them into fields	288
Avoid using final local variables, turn them into fields	292 - 293
Avoid using final local variables, turn them into fields	303
Avoid unnecessary comparisons in boolean expressions	304
Avoid using final local variables, turn them into fields	305
Avoid using final local variables, turn them into fields	308
Avoid unnecessary comparisons in boolean expressions	310
Avoid unnecessary comparisons in boolean expressions	315
Avoid using final local variables, turn them into fields	329
Avoid unnecessary comparisons in boolean expressions	338
Avoid unnecessary comparisons in boolean expressions	338

org/projectforge/plugins/marketing/AddressCampaignValueMassUpdateForm.java

Violation	Line
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	57
Avoid using final local variables, turn them into fields	58
Avoid using final local variables, turn them into fields	64

org/projectforge/plugins/marketing/AddressCampaignValueMassUpdatePage.java

Violation	Line
Avoid using final local variables, turn them into fields	67 - 68
Avoid using final local variables, turn them into fields	69 - 97
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	100
Avoid using final local variables, turn them into fields	116

org/projectforge/plugins/marketing/AddressCampaignValueRight.java

Violation	Line
Avoid using final local variables, turn them into fields	53
Avoid unnecessary comparisons in boolean expressions	54

org/projectforge/plugins/marketing/AddressEditLinkPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	53

org/projectforge/plugins/marketing/MarketingPlugin.java

Violation	Line
Returning 'PERSISTENT_ENTITIES' may expose an internal array.	52
Avoid using final local variables, turn them into fields	70

org/projectforge/plugins/marketing/MarketingPluginUpdates.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 82

org/projectforge/plugins/memo/MemoDao.java

Violation	Line
Avoid using final local variables, turn them into fields	59
Avoid using final local variables, turn them into fields	65

org/projectforge/plugins/memo/MemoEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	59
Avoid using final local variables, turn them into fields	60
Avoid using final local variables, turn them into fields	66

org/projectforge/plugins/memo/MemoListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	71
Avoid using final local variables, turn them into fields	72 - 81
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	109

org/projectforge/plugins/memo/MemoPlugin.java

Violation	Line
Returning 'PERSISTENT_ENTITIES' may expose an internal array.	48
Avoid using final local variables, turn them into fields	63

org/projectforge/plugins/memo/MemoPluginUpdates.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 69
Avoid unnecessary comparisons in boolean expressions	54
Avoid using final local variables, turn them into fields	61 - 62

org/projectforge/plugins/memo/MemoRight.java

Violation	Line
Avoid using final local variables, turn them into fields	52
Avoid unnecessary comparisons in boolean expressions	56

org/projectforge/plugins/skillmatrix/SkillMatrixPlugin.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	42
Returning 'PERSISTENT_ENTITIES' may expose an internal array.	54
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	72
Avoid unused local variables such as 'parentMenu'.	72

org/projectforge/plugins/skillmatrix/SkillMatrixPluginUpdates.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 72
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	51
Avoid unnecessary comparisons in boolean expressions	53
Avoid unnecessary comparisons in boolean expressions	53
Avoid using final local variables, turn them into fields	61 - 62
Avoid using final local variables, turn them into fields	64 - 65

org/projectforge/plugins/skillmatrix/SkillNode.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	125
Avoid unnecessary comparisons in boolean expressions	127
Avoid unnecessary comparisons in boolean expressions	147
Avoid using final local variables, turn them into fields	150
Avoid unnecessary comparisons in boolean expressions	161
Avoid unnecessary comparisons in boolean expressions	177
Avoid unnecessary comparisons in boolean expressions	197
Avoid using final local variables, turn them into fields	208

org/projectforge/plugins/skillmatrix/SkillRatingDO.java

Violation	Line
TOTE_ATTRIBUTE: Avoid unused private fields such as 'sinceYear'.	62
TOTE_ATTRIBUTE: Avoid unused private fields such as 'certificates'.	64
TOTE_ATTRIBUTE: Avoid unused private fields such as 'trainingCourses'.	66

org/projectforge/plugins/skillmatrix/SkillTree.java

Violation	Line
SYNCHRONISATION: Use block level rather than method level synchronization	68 - 76
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	87
Avoid unnecessary comparisons in boolean expressions	90
Avoid using final local variables, turn them into fields	110
Avoid using final local variables, turn them into fields	139
Avoid using final local variables, turn them into fields	155
Avoid unnecessary comparisons in boolean expressions	160
Avoid unnecessary comparisons in boolean expressions	161
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	234
Avoid instantiating new objects inside loops	238
Avoid unnecessary comparisons in boolean expressions	241
Avoid unnecessary comparisons in boolean expressions	246
Avoid using final local variables, turn them into fields	256
Avoid unnecessary comparisons in boolean expressions	264
Avoid using final local variables, turn them into fields	270
Avoid unnecessary comparisons in boolean expressions	283
Avoid unnecessary comparisons in boolean expressions	286

org/projectforge/plugins/todo/ToDoCache.java

Violation	Line
The Logger variable declaration does not contain the static and final modifiers	38
KONSTANTHEIT_VERSTECKTE: Private field 'toDoDao' could be made final; it is only initialized in the declaration or constructor.	43
Avoid using final local variables, turn them into fields	57
Avoid using final local variables, turn them into fields	61

org/projectforge/plugins/todo/ToDoDao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	94
Avoid using final local variables, turn them into fields	100
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	108
Avoid unnecessary comparisons in boolean expressions	109
Avoid using final local variables, turn them into fields	110
Avoid unnecessary comparisons in boolean expressions	116
Avoid unnecessary comparisons in boolean expressions	119
Avoid unnecessary comparisons in boolean expressions	122
Avoid unnecessary comparisons in boolean expressions	125
Avoid unnecessary comparisons in boolean expressions	128
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	131
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	152
Avoid unnecessary comparisons in boolean expressions	165
Avoid using final local variables, turn them into fields	169
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	173
Avoid using final local variables, turn them into fields	182
Avoid using final local variables, turn them into fields	183
Avoid using final local variables, turn them into fields	184
Avoid using final local variables, turn them into fields	185
Avoid unnecessary comparisons in boolean expressions	186
Avoid unnecessary comparisons in boolean expressions	189
Avoid unnecessary comparisons in boolean expressions	189
Avoid unnecessary comparisons in boolean expressions	192
Use equals() to compare object references.	192
Use equals() to compare object references.	192
Avoid unnecessary comparisons in boolean expressions	200
Avoid unnecessary comparisons in boolean expressions	200
Avoid using final local variables, turn them into fields	209
Avoid using final local variables, turn them into fields	211
Avoid using final local variables, turn them into fields	213
Avoid unnecessary comparisons in boolean expressions	222
Avoid unnecessary comparisons in boolean expressions	231
Avoid using final local variables, turn them into fields	233
Avoid unnecessary comparisons in boolean expressions	235
Avoid using final local variables, turn them into fields	250
Avoid using final local variables, turn them into fields	256
Avoid using final local variables, turn them into fields	267
Avoid using final local variables, turn them into fields	273
Avoid using final local variables, turn them into fields	298

org/projectforge/plugins/todo/ToDoEditForm.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	104
Avoid unnecessary comparisons in boolean expressions	106
Avoid using final local variables, turn them into fields	109 - 121
Avoid using final local variables, turn them into fields	122 - 123
Avoid unnecessary comparisons in boolean expressions	133
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	138
Avoid using final local variables, turn them into fields	139
Avoid using final local variables, turn them into fields	144 - 181
Avoid unnecessary comparisons in boolean expressions	162
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	174
Avoid using final local variables, turn them into fields	189
Avoid using final local variables, turn them into fields	190 - 191
Avoid unnecessary comparisons in boolean expressions	192
Avoid using final local variables, turn them into fields	201
Avoid using final local variables, turn them into fields	202
Avoid using final local variables, turn them into fields	208
Avoid using final local variables, turn them into fields	209
Avoid using final local variables, turn them into fields	215
Avoid using final local variables, turn them into fields	223
Avoid using final local variables, turn them into fields	224
Avoid using final local variables, turn them into fields	230
Avoid unnecessary comparisons in boolean expressions	232
Avoid using final local variables, turn them into fields	236 - 237
Avoid using final local variables, turn them into fields	244
Avoid unnecessary comparisons in boolean expressions	246
Avoid using final local variables, turn them into fields	250 - 251
Avoid using final local variables, turn them into fields	258
Avoid using final local variables, turn them into fields	259 - 260
Avoid using final local variables, turn them into fields	267
Avoid using final local variables, turn them into fields	268 - 269
Avoid using final local variables, turn them into fields	277
Avoid using final local variables, turn them into fields	282
Avoid using final local variables, turn them into fields	287
Avoid using final local variables, turn them into fields	288
Avoid unnecessary comparisons in boolean expressions	289
Avoid using final local variables, turn them into fields	306
Avoid using final local variables, turn them into fields	309
Avoid using final local variables, turn them into fields	311
Avoid using final local variables, turn them into fields	312
Avoid using final local variables, turn them into fields	317 - 334
Avoid using final local variables, turn them into fields	336 - 337
Avoid using final local variables, turn them into fields	340 - 359
Avoid using final local variables, turn them into fields	360 - 361
Avoid unnecessary comparisons in boolean expressions	369

org/projectforge/plugins/todo/ToDoEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	56
Avoid using final local variables, turn them into fields	57
Avoid unnecessary comparisons in boolean expressions	74
Avoid unnecessary comparisons in boolean expressions	78
Avoid unnecessary comparisons in boolean expressions	80
Avoid unnecessary comparisons in boolean expressions	80
Avoid using final local variables, turn them into fields	103
Avoid using final local variables, turn them into fields	111
Avoid unnecessary comparisons in boolean expressions	115
Avoid unnecessary comparisons in boolean expressions	121
Avoid unnecessary comparisons in boolean expressions	132
Avoid unnecessary comparisons in boolean expressions	139
Avoid using final local variables, turn them into fields	140
Avoid unnecessary comparisons in boolean expressions	158
Avoid unnecessary comparisons in boolean expressions	170
Avoid unnecessary comparisons in boolean expressions	172
Avoid unnecessary comparisons in boolean expressions	174
Avoid unnecessary comparisons in boolean expressions	176
Avoid unnecessary comparisons in boolean expressions	188
Avoid unnecessary comparisons in boolean expressions	190
Avoid unnecessary comparisons in boolean expressions	192
Avoid unnecessary comparisons in boolean expressions	194

org/projectforge/plugins/todo/ToDoListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	57 - 73
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	82 - 98
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	107 - 124
Avoid using final local variables, turn them into fields	131
Avoid using final local variables, turn them into fields	132

org/projectforge/plugins/todo/ToDoListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	89 - 101
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	93
Avoid unnecessary comparisons in boolean expressions	94
Avoid unnecessary comparisons in boolean expressions	94
Avoid using final local variables, turn them into fields	109
Avoid using final local variables, turn them into fields	133
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	149
Avoid using final local variables, turn them into fields	152
Avoid using final local variables, turn them into fields	157
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	173
Avoid unnecessary comparisons in boolean expressions	183
Avoid unnecessary comparisons in boolean expressions	186
Avoid unnecessary comparisons in boolean expressions	189
Avoid unnecessary comparisons in boolean expressions	204
Avoid unnecessary comparisons in boolean expressions	207
Avoid unnecessary comparisons in boolean expressions	210

org/projectforge/plugins/todo/ToDoPlugin.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	42
Returning 'PERSISTENT_ENTITIES' may expose an internal array.	54
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	73

org/projectforge/plugins/todo/ToDoPluginUpdates.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 67
Avoid using final local variables, turn them into fields	49
Avoid unnecessary comparisons in boolean expressions	51
Avoid using final local variables, turn them into fields	58 - 60

org/projectforge/plugins/todo/ToDoRight.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	107
Avoid unnecessary comparisons in boolean expressions	107
Avoid unnecessary comparisons in boolean expressions	115
Avoid unnecessary comparisons in boolean expressions	115
Avoid unnecessary comparisons in boolean expressions	118

org/projectforge/registry/DaoRegistry.java

Violation	Line
SYNCHRONISATION: Use block level rather than method level synchronization	210 - 265
Avoid using final local variables, turn them into fields	291
Avoid using final local variables, turn them into fields	292

org/projectforge/registry/Registry.java

Violation	Line
A class which only has private constructors should be final	43 - 184
It is somewhat confusing to have a field name with the same name as a method	47
Avoid using final local variables, turn them into fields	97
Avoid unnecessary comparisons in boolean expressions	101
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	140

org/projectforge/registry/RegistryEntry.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	107
Returning 'nestedDOClasses' may expose an internal array.	172

org/projectforge/renderer/BatikImageRenderer.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 114
Avoid unnecessary comparisons in boolean expressions	51
Avoid unnecessary comparisons in boolean expressions	54
Avoid unnecessary comparisons in boolean expressions	57
Avoid using final local variables, turn them into fields	66
KONSTANTHEIT_VERSTECKTE: Local variable 'input' could be declared final	79
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	81
TOTE_PARAMETER: Avoid unused method parameters such as 'width'.	91 - 95
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	100
KONSTANTHEIT_VERSTECKTE: Local variable 'input' could be declared final	103
Avoid using final local variables, turn them into fields	104
Avoid using final local variables, turn them into fields	105

org/projectforge/renderer/FontMap.java

Violation	Line
It is somewhat confusing to have a field name matching the declaring class name	46
KONSTANTHEIT_VERSTECKTE: Private field 'fontMap' could be made final; it is only initialized in the declaration or constructor.	46
Avoid using final local variables, turn them into fields	50 - 51
Avoid unnecessary comparisons in boolean expressions	52
Avoid using final local variables, turn them into fields	64

org/projectforge/renderer/PdfRenderer.java

Violation	Line
Avoid using final local variables, turn them into fields	91
Avoid unnecessary comparisons in boolean expressions	92
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	161
Avoid using final local variables, turn them into fields	162
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	180
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	184
Avoid using final local variables, turn them into fields	185
Avoid using final local variables, turn them into fields	188

org/projectforge/renderer/RowHolder.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'cells' could be made final; it is only initialized in the declaration or constructor.	37

org/projectforge/renderer/custom/Formatter.java

Violation	Line
An empty method in an abstract class should be abstract instead	52 - 57
An empty method in an abstract class should be abstract instead	59 - 62

org/projectforge/renderer/custom/MicromataFormatter.java

Violation	Line
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	83
Avoid instantiating new objects inside loops	83
Avoid using final local variables, turn them into fields	85
Avoid instantiating new objects inside loops	87
Avoid instantiating new objects inside loops	89
Avoid instantiating new objects inside loops	92
Avoid instantiating new objects inside loops	94
Avoid instantiating new objects inside loops	95
Avoid instantiating new objects inside loops	96
Avoid instantiating new objects inside loops	97
Avoid unnecessary comparisons in boolean expressions	98
Avoid instantiating new objects inside loops	99
Avoid instantiating new objects inside loops	101
Avoid unnecessary comparisons in boolean expressions	111
Avoid using final local variables, turn them into fields	137
Avoid using final local variables, turn them into fields	138
Avoid unnecessary comparisons in boolean expressions	140

org/projectforge/reporting/impl/BuchungssatzImpl.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'buchungssatz' could be made final; it is only initialized in the declaration or constructor.	45
KONSTANTHEIT_VERSTECKTE: Private field 'konto' could be made final; it is only initialized in the declaration or constructor.	47
KONSTANTHEIT_VERSTECKTE: Private field 'gegenKonto' could be made final; it is only initialized in the declaration or constructor.	49
KONSTANTHEIT_VERSTECKTE: Private field 'kost1' could be made final; it is only initialized in the declaration or constructor.	51
KONSTANTHEIT_VERSTECKTE: Private field 'kost2' could be made final; it is only initialized in the declaration or constructor.	53

org/projectforge/reporting/impl/KontoImpl.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'konto' could be made final; it is only initialized in the declaration or constructor.	37

org/projectforge/reporting/impl/Kost1Impl.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'kost1' could be made final; it is only initialized in the declaration or constructor.	39

org/projectforge/reporting/impl/Kost2Impl.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'kost2' could be made final; it is only initialized in the declaration or constructor.	41
KONSTANTHEIT_VERSTECKTE: Private field 'kost2Art' could be made final; it is only initialized in the declaration or constructor.	43
KONSTANTHEIT_VERSTECKTE: Private field 'projekt' could be made final; it is only initialized in the declaration or constructor.	45

org/projectforge/reporting/impl/KundeImpl.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'kunde' could be made final; it is only initialized in the declaration or constructor.	38

org/projectforge/reporting/impl/ProjektImpl.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'projekt' could be made final; it is only initialized in the declaration or constructor.	43
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	124
Avoid unnecessary comparisons in boolean expressions	127
KONSTANTHEIT_VERSTECKTE: Local variable 'html' could be declared final	142
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	143
Avoid unnecessary comparisons in boolean expressions	147
Avoid unnecessary comparisons in boolean expressions	148
Avoid unnecessary comparisons in boolean expressions	151
Avoid appending characters as strings in StringBuffer.append.	154
Avoid unnecessary comparisons in boolean expressions	159
Avoid unnecessary comparisons in boolean expressions	160
Avoid appending characters as strings in StringBuffer.append.	165
Avoid empty if statements	167 - 169
Avoid unnecessary comparisons in boolean expressions	170
Avoid unnecessary comparisons in boolean expressions	170

org/projectforge/scripting/GroovyEngine.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	54
KONSTANTHEIT_VERSTECKTE: Private field 'htmlFormat' could be made final; it is only initialized in the declaration or constructor.	60
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	138
Avoid using final local variables, turn them into fields	139
Avoid using final local variables, turn them into fields	140
Avoid using final local variables, turn them into fields	143
Avoid using final local variables, turn them into fields	144
Prefer StringBuffer over += for concatenating strings	147
Avoid using final local variables, turn them into fields	166
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	375

org/projectforge/scripting/GroovyExecutor.java

Violation	Line
Avoid using final local variables, turn them into fields	57
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	91
Avoid unnecessary comparisons in boolean expressions	94
Avoid using final local variables, turn them into fields	128
Avoid unnecessary comparisons in boolean expressions	155
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	157
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	201
Avoid unnecessary comparisons in boolean expressions	203

org/projectforge/scripting/GroovyResult.java

Violation	Line
Avoid using final local variables, turn them into fields	74
Consider simply returning the value vs storing it in local variable 'esc'	75

org/projectforge/scripting/NullObject.java

Violation	Line
A class which only has private constructors should be final	31 - 38

org/projectforge/scripting/ScriptDO.java

Violation	Line
Avoid using final local variables, turn them into fields	294
Avoid unnecessary comparisons in boolean expressions	306
Avoid unnecessary comparisons in boolean expressions	307
Avoid unnecessary comparisons in boolean expressions	312

org/projectforge/scripting/ScriptDao.java

Violation	Line
Perhaps 'groovyResult' could be replaced by a local variable.	55
Avoid unnecessary comparisons in boolean expressions	69
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	120
Avoid using final local variables, turn them into fields	122

org/projectforge/scripting/ScriptParameter.java

Violation	Line
Avoid using final local variables, turn them into fields	235
Avoid appending characters as strings in StringBuffer.append.	236
Avoid unnecessary comparisons in boolean expressions	237
Avoid using final local variables, turn them into fields	249
Avoid unnecessary comparisons in boolean expressions	252

org/projectforge/scripting/ScriptParameterType.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	51
Avoid unnecessary comparisons in boolean expressions	55

org/projectforge/statistics/TimesheetDisciplineChartBuilder.java

Violation	Line
Do not use the short type	121
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	131
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	135
Avoid unnecessary comparisons in boolean expressions	137
Avoid unnecessary comparisons in boolean expressions	141
Avoid unnecessary comparisons in boolean expressions	141
Avoid unnecessary comparisons in boolean expressions	143
Avoid unnecessary comparisons in boolean expressions	150
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	158
Avoid instantiating new objects inside loops	158
Do not use the short type	177
Avoid using final local variables, turn them into fields	180
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	188
Avoid using final local variables, turn them into fields	189
Avoid using final local variables, turn them into fields	190
Avoid unnecessary comparisons in boolean expressions	192
Avoid unnecessary comparisons in boolean expressions	200
Avoid unnecessary comparisons in boolean expressions	200
KONSTANTHEIT_VERSTECKTE: Local variable 'duration' could be declared final	201
Avoid unnecessary comparisons in boolean expressions	204
KONSTANTHEIT_VERSTECKTE: Local variable 'averageDifference' could be declared final	211
Avoid using final local variables, turn them into fields	212
Avoid instantiating new objects inside loops	212
Avoid using final local variables, turn them into fields	231
Avoid using final local variables, turn them into fields	234
Avoid using final local variables, turn them into fields	236
Avoid using final local variables, turn them into fields	243
Avoid using final local variables, turn them into fields	251
Avoid using final local variables, turn them into fields	256
Avoid using final local variables, turn them into fields	262
Avoid unnecessary comparisons in boolean expressions	263

org/projectforge/task/HibernateSearchTaskPathBridge.java

Violation	Line
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	52
Avoid using final local variables, turn them into fields	53
Avoid using final local variables, turn them into fields	57
Avoid using final local variables, turn them into fields	58
Avoid appending characters as strings in StringBuffer.append.	60
Avoid unnecessary comparisons in boolean expressions	62

org/projectforge/task/ScriptingTaskNode.java

Violation	Line
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	53

org/projectforge/task/ScriptingTaskTree.java

Violation	Line
Avoid using final local variables, turn them into fields	48
Avoid instantiating new objects inside loops	50
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	99

org/projectforge/task/TaskDO.java

Violation	Line
Avoid using final local variables, turn them into fields	594
Avoid unnecessary comparisons in boolean expressions	595
Avoid unnecessary comparisons in boolean expressions	596
Avoid using final local variables, turn them into fields	604
Avoid using final local variables, turn them into fields	612
Avoid unnecessary comparisons in boolean expressions	625
Avoid unnecessary comparisons in boolean expressions	628
Avoid using final local variables, turn them into fields	648

org/projectforge/task/TaskDao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	100
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	158
Avoid using final local variables, turn them into fields	160 - 162
Avoid using final local variables, turn them into fields	165 - 167
Avoid using final local variables, turn them into fields	168
Avoid unnecessary comparisons in boolean expressions	169
Avoid using final local variables, turn them into fields	173
Avoid using final local variables, turn them into fields	174
Avoid using final local variables, turn them into fields	175
Avoid using final local variables, turn them into fields	176
Avoid unnecessary comparisons in boolean expressions	177
Avoid instantiating new objects inside loops	179
Avoid using final local variables, turn them into fields	203
Avoid using final local variables, turn them into fields	205 - 209
WRAPPER_INSTANZIIERUNG: Avoid instantiating Long objects.Call Long.valueOf() instead	211
WRAPPER_INSTANZIIERUNG: Avoid instantiating Long objects.Call Long.valueOf() instead	215
WRAPPER_INSTANZIIERUNG: Avoid instantiating Long objects.Call Long.valueOf() instead	217
Avoid using final local variables, turn them into fields	222 - 224
Avoid unnecessary comparisons in boolean expressions	225
WRAPPER_INSTANZIIERUNG: Avoid instantiating Long objects.Call Long.valueOf() instead	226
Avoid using final local variables, turn them into fields	230
Avoid using final local variables, turn them into fields	231
Avoid using final local variables, turn them into fields	232
Avoid using final local variables, turn them into fields	242
Avoid using final local variables, turn them into fields	248
Avoid using final local variables, turn them into fields	249
Avoid unnecessary comparisons in boolean expressions	250
Avoid unnecessary comparisons in boolean expressions	253
Avoid unnecessary comparisons in boolean expressions	256
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	259
Avoid unnecessary comparisons in boolean expressions	266
Avoid unnecessary comparisons in boolean expressions	282
Avoid unnecessary comparisons in boolean expressions	295
Avoid using final local variables, turn them into fields	305
Avoid unnecessary comparisons in boolean expressions	317
Avoid unnecessary comparisons in boolean expressions	347
Avoid unnecessary comparisons in boolean expressions	351
Avoid using final local variables, turn them into fields	360
Avoid unnecessary comparisons in boolean expressions	366
Avoid unnecessary comparisons in boolean expressions	369
Avoid unnecessary comparisons in boolean expressions	372
Avoid unnecessary comparisons in boolean expressions	374
Avoid unnecessary comparisons in boolean expressions	378
Avoid unnecessary comparisons in boolean expressions	388
Avoid using final local variables, turn them into fields	391
Avoid using final local variables, turn them into fields	392
Avoid unnecessary comparisons in boolean expressions	394
Avoid unnecessary comparisons in boolean expressions	404
Avoid unnecessary comparisons in boolean expressions	408
Avoid unnecessary comparisons in boolean expressions	412
Avoid unnecessary comparisons in boolean expressions	414
Avoid unnecessary comparisons in boolean expressions	414
Avoid unnecessary comparisons in boolean expressions	427
Avoid unnecessary comparisons in boolean expressions	435
Avoid unnecessary comparisons in boolean expressions	438
Avoid unnecessary comparisons in boolean expressions	442
Avoid unnecessary comparisons in boolean expressions	444
Avoid using final local variables, turn them into fields	459
Avoid empty if statements	461 - 463
Avoid unnecessary comparisons in boolean expressions	461
Avoid unnecessary comparisons in boolean expressions	461
Avoid unnecessary comparisons in boolean expressions	467
Avoid unnecessary comparisons in boolean expressions	477
Avoid unnecessary comparisons in boolean expressions	480
Avoid unnecessary comparisons in boolean expressions	491
Avoid unnecessary comparisons in boolean expressions	507
Avoid using final local variables, turn them into fields	511
Avoid using final local variables, turn them into fields	516
Avoid unnecessary comparisons in boolean expressions	517
Avoid unnecessary comparisons in boolean expressions	530
Avoid unnecessary comparisons in boolean expressions	543
Avoid unnecessary comparisons in boolean expressions	546

org/projectforge/task/TaskFilter.java

Violation	Line
Avoid using implementation types like 'HashMap'; use the interface instead	66
Avoid using implementation types like 'HashSet'; use the interface instead	71
Avoid using final local variables, turn them into fields	160
Avoid using final local variables, turn them into fields	163
Avoid unnecessary comparisons in boolean expressions	164
Avoid unnecessary comparisons in boolean expressions	167
Avoid unnecessary comparisons in boolean expressions	170
Avoid unnecessary comparisons in boolean expressions	182
Avoid using final local variables, turn them into fields	197
Avoid unnecessary comparisons in boolean expressions	201
Avoid using final local variables, turn them into fields	205
Avoid using final local variables, turn them into fields	206
Avoid unnecessary comparisons in boolean expressions	207
Avoid unnecessary comparisons in boolean expressions	208
Avoid unnecessary comparisons in boolean expressions	209
Avoid unnecessary comparisons in boolean expressions	210
Avoid unnecessary comparisons in boolean expressions	211
Avoid unnecessary comparisons in boolean expressions	212
Avoid unnecessary comparisons in boolean expressions	213
Avoid unnecessary comparisons in boolean expressions	217
Avoid using final local variables, turn them into fields	219
Avoid using final local variables, turn them into fields	222
Avoid unnecessary comparisons in boolean expressions	223
Avoid unnecessary comparisons in boolean expressions	235
Avoid unnecessary comparisons in boolean expressions	235

org/projectforge/task/TaskHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 106
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	67
Avoid using final local variables, turn them into fields	84
Avoid unnecessary comparisons in boolean expressions	85
Avoid appending characters as strings in StringBuffer.append.	86
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	96
Avoid unnecessary comparisons in boolean expressions	97

org/projectforge/task/TaskNode.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	145
Avoid unnecessary comparisons in boolean expressions	176
Avoid using final local variables, turn them into fields	204
Avoid unnecessary comparisons in boolean expressions	213
Avoid using final local variables, turn them into fields	224
Avoid unnecessary comparisons in boolean expressions	232
Avoid unnecessary comparisons in boolean expressions	261
Avoid unnecessary comparisons in boolean expressions	263
Avoid unnecessary comparisons in boolean expressions	283
Avoid using final local variables, turn them into fields	286
Avoid unnecessary comparisons in boolean expressions	297
Avoid unnecessary comparisons in boolean expressions	313
Avoid unnecessary comparisons in boolean expressions	333
Avoid using final local variables, turn them into fields	353
Avoid using final local variables, turn them into fields	366
Avoid unnecessary comparisons in boolean expressions	367
Avoid unnecessary comparisons in boolean expressions	379
Avoid unnecessary comparisons in boolean expressions	393
Avoid unnecessary comparisons in boolean expressions	395
Avoid using final local variables, turn them into fields	415
Avoid unnecessary comparisons in boolean expressions	416
Avoid using final local variables, turn them into fields	417
Avoid unnecessary comparisons in boolean expressions	418
Avoid unnecessary comparisons in boolean expressions	437
Avoid using final local variables, turn them into fields	451
Avoid unnecessary comparisons in boolean expressions	452
Avoid unnecessary comparisons in boolean expressions	453
Avoid using final local variables, turn them into fields	461
Avoid using final local variables, turn them into fields	469
Avoid using final local variables, turn them into fields	484

org/projectforge/task/TaskStatus.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	41
Avoid unnecessary comparisons in boolean expressions	43
Avoid unnecessary comparisons in boolean expressions	45

org/projectforge/task/TaskTree.java

Violation	Line
SYNCHRONISATION: Use block level rather than method level synchronization	112 - 121
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	132
Avoid unnecessary comparisons in boolean expressions	138
Avoid using final local variables, turn them into fields	158
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	204
Avoid using final local variables, turn them into fields	214
Avoid using final local variables, turn them into fields	229
Avoid using final local variables, turn them into fields	243
Avoid using final local variables, turn them into fields	257
Avoid using final local variables, turn them into fields	258
Avoid unnecessary comparisons in boolean expressions	259
Avoid using final local variables, turn them into fields	263
Avoid unnecessary comparisons in boolean expressions	264
Avoid unnecessary comparisons in boolean expressions	266
Avoid unnecessary comparisons in boolean expressions	267
Avoid using final local variables, turn them into fields	276
Avoid unnecessary comparisons in boolean expressions	279
Avoid unnecessary comparisons in boolean expressions	280
Avoid unnecessary comparisons in boolean expressions	291
Avoid unnecessary comparisons in boolean expressions	297
Avoid using final local variables, turn them into fields	300
Avoid unnecessary comparisons in boolean expressions	308
Avoid using final local variables, turn them into fields	321
Avoid using final local variables, turn them into fields	322
Avoid using final local variables, turn them into fields	323
Avoid using final local variables, turn them into fields	325
Avoid unnecessary comparisons in boolean expressions	328
Avoid using final local variables, turn them into fields	341
Avoid using final local variables, turn them into fields	358
Avoid unnecessary comparisons in boolean expressions	363
Avoid unnecessary comparisons in boolean expressions	364
Avoid using final local variables, turn them into fields	367
Avoid using final local variables, turn them into fields	370
Avoid using final local variables, turn them into fields	386
Avoid using final local variables, turn them into fields	387
Avoid using final local variables, turn them into fields	399
Avoid using final local variables, turn them into fields	400
Avoid using final local variables, turn them into fields	415
Avoid using final local variables, turn them into fields	416
Avoid using final local variables, turn them into fields	419
Avoid using final local variables, turn them into fields	421
Avoid unnecessary comparisons in boolean expressions	533
Avoid using final local variables, turn them into fields	538
Avoid unnecessary comparisons in boolean expressions	540
Avoid unnecessary comparisons in boolean expressions	562
Avoid using final local variables, turn them into fields	586
Avoid using final local variables, turn them into fields	593
Avoid unnecessary comparisons in boolean expressions	594
Avoid using final local variables, turn them into fields	597
Avoid unnecessary comparisons in boolean expressions	613
Avoid unnecessary comparisons in boolean expressions	616
Avoid using final local variables, turn them into fields	617
Avoid unnecessary comparisons in boolean expressions	618
Avoid unnecessary comparisons in boolean expressions	620
Avoid unnecessary comparisons in boolean expressions	635
Avoid using final local variables, turn them into fields	638
Avoid using final local variables, turn them into fields	651
Avoid unnecessary comparisons in boolean expressions	665
Avoid unnecessary comparisons in boolean expressions	668
Avoid using final local variables, turn them into fields	671
Avoid unnecessary comparisons in boolean expressions	675
Avoid using final local variables, turn them into fields	680
Avoid unnecessary comparisons in boolean expressions	700
Avoid using final local variables, turn them into fields	702
Avoid unnecessary comparisons in boolean expressions	723
Avoid using final local variables, turn them into fields	734
Avoid using final local variables, turn them into fields	736
Avoid using final local variables, turn them into fields	737
Avoid using final local variables, turn them into fields	755
Avoid using final local variables, turn them into fields	756
Avoid using final local variables, turn them into fields	787
Avoid instantiating new objects inside loops	791
Avoid unnecessary comparisons in boolean expressions	794
Avoid unnecessary comparisons in boolean expressions	799
Avoid using final local variables, turn them into fields	809
Avoid unnecessary comparisons in boolean expressions	818
Avoid using final local variables, turn them into fields	824
Avoid instantiating new objects inside loops	832
Avoid unnecessary comparisons in boolean expressions	838
Avoid using final local variables, turn them into fields	843
Avoid unnecessary comparisons in boolean expressions	847
Avoid using final local variables, turn them into fields	852
Avoid unnecessary comparisons in boolean expressions	855
Avoid unnecessary comparisons in boolean expressions	866

org/projectforge/task/rest/TaskDaoRest.java

Violation	Line
Avoid using final local variables, turn them into fields	52
Avoid using final local variables, turn them into fields	59
Avoid using final local variables, turn them into fields	64

org/projectforge/task/rest/TasksElement.java

Violation	Line
Avoid instantiating new objects inside loops	48

org/projectforge/timesheet/TimesheetDO.java

Violation	Line
Avoid using final local variables, turn them into fields	137
Avoid using final local variables, turn them into fields	238
Avoid using final local variables, turn them into fields	280

org/projectforge/timesheet/TimesheetDao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	128
Avoid using final local variables, turn them into fields	138 - 139
Avoid using final local variables, turn them into fields	150
Avoid using final local variables, turn them into fields	161
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	191
Avoid using final local variables, turn them into fields	193
Avoid unnecessary comparisons in boolean expressions	205
Avoid using final local variables, turn them into fields	206
Avoid using final local variables, turn them into fields	207
Avoid unnecessary comparisons in boolean expressions	210
Avoid unnecessary comparisons in boolean expressions	222
Avoid using final local variables, turn them into fields	242
Avoid using final local variables, turn them into fields	249
Avoid using final local variables, turn them into fields	253
Avoid unnecessary comparisons in boolean expressions	261
Avoid using final local variables, turn them into fields	264
Avoid unnecessary comparisons in boolean expressions	265
Avoid unnecessary comparisons in boolean expressions	270
Avoid using final local variables, turn them into fields	272
Avoid unnecessary comparisons in boolean expressions	275
Avoid using final local variables, turn them into fields	286
Avoid using final local variables, turn them into fields	287
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	288
Avoid using final local variables, turn them into fields	293
Avoid using final local variables, turn them into fields	330
Avoid using final local variables, turn them into fields	331
Avoid unnecessary comparisons in boolean expressions	332
Avoid unnecessary comparisons in boolean expressions	336
Avoid using final local variables, turn them into fields	361
Avoid unnecessary comparisons in boolean expressions	362
Avoid using final local variables, turn them into fields	365
Avoid unnecessary comparisons in boolean expressions	366
Avoid using final local variables, turn them into fields	376
Avoid using final local variables, turn them into fields	380
Avoid using final local variables, turn them into fields	393
Avoid using final local variables, turn them into fields	400
Avoid using final local variables, turn them into fields	401
Avoid using final local variables, turn them into fields	404
Avoid unnecessary comparisons in boolean expressions	419
Avoid using final local variables, turn them into fields	446
Avoid using final local variables, turn them into fields	454
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	455
Avoid using final local variables, turn them into fields	456
Avoid unnecessary comparisons in boolean expressions	457
Avoid using final local variables, turn them into fields	459
Avoid using final local variables, turn them into fields	460
Avoid unnecessary comparisons in boolean expressions	483
Avoid unnecessary comparisons in boolean expressions	485
Avoid unnecessary comparisons in boolean expressions	490
Avoid unnecessary comparisons in boolean expressions	493
Avoid unnecessary comparisons in boolean expressions	500
Avoid unnecessary comparisons in boolean expressions	515
Avoid unnecessary comparisons in boolean expressions	517
Avoid unnecessary comparisons in boolean expressions	518
Avoid unnecessary comparisons in boolean expressions	519
Avoid using final local variables, turn them into fields	521
Avoid unnecessary comparisons in boolean expressions	523
Avoid unnecessary comparisons in boolean expressions	556
Avoid unnecessary comparisons in boolean expressions	559
Avoid unnecessary comparisons in boolean expressions	561
Avoid unnecessary comparisons in boolean expressions	566
Avoid unnecessary comparisons in boolean expressions	568
Avoid unnecessary comparisons in boolean expressions	572
Avoid unnecessary comparisons in boolean expressions	577
Avoid unnecessary comparisons in boolean expressions	581
Avoid unnecessary comparisons in boolean expressions	590
Avoid unnecessary comparisons in boolean expressions	593
Avoid unnecessary comparisons in boolean expressions	597
Avoid unnecessary comparisons in boolean expressions	625
Avoid unnecessary comparisons in boolean expressions	626
Avoid unnecessary comparisons in boolean expressions	627
Avoid using final local variables, turn them into fields	632
Avoid using final local variables, turn them into fields	636
Avoid unnecessary comparisons in boolean expressions	638
Avoid unnecessary comparisons in boolean expressions	640
Avoid unnecessary comparisons in boolean expressions	646
Avoid unnecessary comparisons in boolean expressions	661
Avoid unnecessary comparisons in boolean expressions	669
Avoid using final local variables, turn them into fields	673
Avoid unnecessary comparisons in boolean expressions	675
Avoid unnecessary comparisons in boolean expressions	687
Avoid unnecessary comparisons in boolean expressions	688
Avoid unnecessary comparisons in boolean expressions	715
Avoid unnecessary comparisons in boolean expressions	716
Avoid unnecessary comparisons in boolean expressions	723
Avoid using final local variables, turn them into fields	727
Avoid using final local variables, turn them into fields	729
Avoid using final local variables, turn them into fields	732
Avoid using final local variables, turn them into fields	736
Avoid instantiating new objects inside loops	736
Avoid unnecessary comparisons in boolean expressions	738
Avoid unnecessary comparisons in boolean expressions	739
Avoid unnecessary comparisons in boolean expressions	759
Avoid using final local variables, turn them into fields	762 - 764
Avoid using final local variables, turn them into fields	765
Avoid using final local variables, turn them into fields	767
Avoid using final local variables, turn them into fields	771
Consider simply returning the value vs storing it in local variable 'list'	772
Avoid using final local variables, turn them into fields	785 - 786
Avoid using final local variables, turn them into fields	787
Avoid using final local variables, turn them into fields	789
Avoid using final local variables, turn them into fields	792
Avoid using final local variables, turn them into fields	794
Avoid unnecessary comparisons in boolean expressions	796
Avoid using final local variables, turn them into fields	830 - 831
Avoid unnecessary comparisons in boolean expressions	833
Avoid unnecessary comparisons in boolean expressions	842
Avoid unnecessary comparisons in boolean expressions	852
Avoid unnecessary comparisons in boolean expressions	864

org/projectforge/timesheet/TimesheetExport.java

Violation	Line
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	127
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	128
KONSTANTHEIT_VERSTECKTE: Local variable 'cols' could be declared final	131 - 148
Avoid using final local variables, turn them into fields	153
KONSTANTHEIT_VERSTECKTE: Local variable 'mapping' could be declared final	160
Avoid using final local variables, turn them into fields	162
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	165
KONSTANTHEIT_VERSTECKTE: Local variable 'projekt' could be declared final	171
KONSTANTHEIT_VERSTECKTE: Local variable 'kunde' could be declared final	174
Avoid empty if statements	177 - 178
Avoid using final local variables, turn them into fields	189
Avoid instantiating new objects inside loops	189
Avoid using final local variables, turn them into fields	190
Avoid instantiating new objects inside loops	190
Avoid using final local variables, turn them into fields	193
Avoid instantiating new objects inside loops	193
Avoid using final local variables, turn them into fields	194
Avoid instantiating new objects inside loops	194
Avoid using final local variables, turn them into fields	196
Avoid instantiating new objects inside loops	196

org/projectforge/timesheet/TimesheetPrefData.java

Violation	Line
SYNCHRONISATION: Use block level rather than method level synchronization	55 - 60
SYNCHRONISATION: Use block level rather than method level synchronization	62 - 67
SYNCHRONISATION: Use block level rather than method level synchronization	69 - 74
KONSTANTHEIT_VERSTECKTE: Local variable 'prefEntry' could be declared final	98
Avoid unnecessary comparisons in boolean expressions	133
Avoid unnecessary comparisons in boolean expressions	169
Avoid instantiating new objects inside loops	173
KONSTANTHEIT_VERSTECKTE: Local variable 'prefEntry' could be declared final	173
Avoid unnecessary comparisons in boolean expressions	185
Avoid unnecessary comparisons in boolean expressions	188

org/projectforge/timesheet/TimesheetPrefEntry.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'other' could be declared final	121
Avoid unnecessary comparisons in boolean expressions	122
Avoid unnecessary comparisons in boolean expressions	125
Avoid unnecessary comparisons in boolean expressions	128
Avoid unnecessary comparisons in boolean expressions	131
KONSTANTHEIT_VERSTECKTE: Local variable 'hcb' could be declared final	142

org/projectforge/user/GroupDO.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	99
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	173
Avoid using final local variables, turn them into fields	189
Avoid unnecessary comparisons in boolean expressions	190
Avoid using final local variables, turn them into fields	200

org/projectforge/user/GroupDao.java

Violation	Line
Avoid using final local variables, turn them into fields	75
Consider simply returning the value vs storing it in local variable 'queryFilter'	76
Avoid using final local variables, turn them into fields	82
Avoid unnecessary comparisons in boolean expressions	105
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	121
Avoid unnecessary comparisons in boolean expressions	122
Avoid using final local variables, turn them into fields	123
Avoid unnecessary comparisons in boolean expressions	124
Avoid using final local variables, turn them into fields	130
Avoid unnecessary comparisons in boolean expressions	134
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	169
Avoid using final local variables, turn them into fields	170
Avoid unnecessary comparisons in boolean expressions	172
Avoid unnecessary comparisons in boolean expressions	177
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	204
Avoid using final local variables, turn them into fields	207
Avoid instantiating new objects inside loops	210
Avoid unnecessary comparisons in boolean expressions	213
Avoid using final local variables, turn them into fields	223
Avoid using final local variables, turn them into fields	226
Avoid using final local variables, turn them into fields	227
Avoid unnecessary comparisons in boolean expressions	228
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	245
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	248
Avoid using final local variables, turn them into fields	265
Consider simply returning the value vs storing it in local variable 'list'	266
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	279
Avoid unnecessary comparisons in boolean expressions	302
Avoid unnecessary comparisons in boolean expressions	302
Avoid unnecessary comparisons in boolean expressions	306
Avoid unnecessary comparisons in boolean expressions	306

org/projectforge/user/HibernateSearchUserRightIdBridge.java

Violation	Line
Avoid using final local variables, turn them into fields	44

org/projectforge/user/I18nHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 97
Avoid using final local variables, turn them into fields	50 - 51
Avoid using final local variables, turn them into fields	66
Avoid unnecessary comparisons in boolean expressions	67

org/projectforge/user/PFUserContext.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 154
Avoid unnecessary comparisons in boolean expressions	56
Avoid unnecessary comparisons in boolean expressions	61
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	97
Avoid unnecessary comparisons in boolean expressions	102
Avoid using final local variables, turn them into fields	125
Avoid using final local variables, turn them into fields	137
Avoid using final local variables, turn them into fields	138

org/projectforge/user/PFUserDO.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	180
Avoid using final local variables, turn them into fields	339
Avoid unnecessary comparisons in boolean expressions	340
Avoid using final local variables, turn them into fields	350
Avoid unnecessary comparisons in boolean expressions	351
Avoid using final local variables, turn them into fields	368
Avoid unnecessary comparisons in boolean expressions	385
Avoid using final local variables, turn them into fields	533
Avoid appending characters as strings in StringBuffer.append.	536
Avoid unnecessary comparisons in boolean expressions	610
Avoid unnecessary comparisons in boolean expressions	689

org/projectforge/user/ProjectForgeGroup.java

Violation	Line
The method name and parameter number are suspiciously close to equals(Object)	56

org/projectforge/user/UserDao.java

Violation	Line
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	86
Avoid using final local variables, turn them into fields	111
Avoid unnecessary comparisons in boolean expressions	117
Avoid using final local variables, turn them into fields	124
Avoid unnecessary comparisons in boolean expressions	127
Avoid unnecessary comparisons in boolean expressions	137
Avoid using final local variables, turn them into fields	138
Avoid using final local variables, turn them into fields	140
Avoid unnecessary comparisons in boolean expressions	143
Avoid appending characters as strings in StringBuffer.append.	146
Avoid unnecessary comparisons in boolean expressions	183
Avoid unnecessary comparisons in boolean expressions	183
Avoid unnecessary comparisons in boolean expressions	186
Avoid unnecessary comparisons in boolean expressions	186
Avoid using final local variables, turn them into fields	230
Avoid using final local variables, turn them into fields	231
Avoid using final local variables, turn them into fields	236
Avoid unnecessary comparisons in boolean expressions	244
Avoid using final local variables, turn them into fields	255 - 256
Avoid unnecessary comparisons in boolean expressions	257
Avoid using final local variables, turn them into fields	266 - 267
Avoid unnecessary comparisons in boolean expressions	268
Avoid unnecessary comparisons in boolean expressions	292
Avoid using final local variables, turn them into fields	323
Avoid using final local variables, turn them into fields	328
Avoid using final local variables, turn them into fields	329
Avoid using final local variables, turn them into fields	350
Avoid using final local variables, turn them into fields	364
Avoid using final local variables, turn them into fields	388
Avoid unnecessary comparisons in boolean expressions	389
Avoid unnecessary comparisons in boolean expressions	389
Avoid unnecessary comparisons in boolean expressions	391
Avoid unnecessary comparisons in boolean expressions	391
Avoid unnecessary comparisons in boolean expressions	395
Avoid unnecessary comparisons in boolean expressions	395
Avoid using final local variables, turn them into fields	405
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	406
Avoid using final local variables, turn them into fields	420
Avoid unnecessary comparisons in boolean expressions	421
Avoid using final local variables, turn them into fields	422
Avoid unnecessary comparisons in boolean expressions	424
Avoid using final local variables, turn them into fields	442
Avoid unnecessary comparisons in boolean expressions	443
Avoid unnecessary comparisons in boolean expressions	446
Avoid using final local variables, turn them into fields	448
Avoid using final local variables, turn them into fields	450
Avoid unnecessary comparisons in boolean expressions	483
Avoid unnecessary comparisons in boolean expressions	486
Avoid unnecessary comparisons in boolean expressions	487
Avoid unnecessary comparisons in boolean expressions	488

org/projectforge/user/UserGroovyRight.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'groovyScript' could be made final; it is only initialized in the declaration or constructor.	49
Avoid using final local variables, turn them into fields	72

org/projectforge/user/UserGroupCache.java

Violation	Line
The Logger variable declaration does not contain the static and final modifiers	48
Avoid unnecessary comparisons in boolean expressions	95
Avoid using final local variables, turn them into fields	105
Avoid unnecessary comparisons in boolean expressions	124
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	188
Avoid using final local variables, turn them into fields	245
Avoid unnecessary comparisons in boolean expressions	246
Avoid unnecessary comparisons in boolean expressions	246
Avoid unnecessary comparisons in boolean expressions	315
Avoid using final local variables, turn them into fields	325
Avoid using final local variables, turn them into fields	329
Avoid using final local variables, turn them into fields	331
Avoid using final local variables, turn them into fields	368 - 369
Avoid using final local variables, turn them into fields	425
Avoid using final local variables, turn them into fields	444
Avoid using final local variables, turn them into fields	445
Avoid using final local variables, turn them into fields	446
Avoid using final local variables, turn them into fields	447
Avoid using final local variables, turn them into fields	448
Avoid using final local variables, turn them into fields	449
Avoid using final local variables, turn them into fields	450
Avoid using final local variables, turn them into fields	451
Avoid using final local variables, turn them into fields	452
Avoid using final local variables, turn them into fields	458
Avoid unnecessary comparisons in boolean expressions	460
Avoid unnecessary comparisons in boolean expressions	463
Avoid unnecessary comparisons in boolean expressions	466
Avoid unnecessary comparisons in boolean expressions	469
Avoid unnecessary comparisons in boolean expressions	472
Avoid unnecessary comparisons in boolean expressions	475
Avoid unnecessary comparisons in boolean expressions	478
Avoid using final local variables, turn them into fields	497
Avoid unnecessary comparisons in boolean expressions	513
Avoid instantiating new objects inside loops	514
Avoid unnecessary comparisons in boolean expressions	520

org/projectforge/user/UserGroupsRight.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	66
Avoid unnecessary comparisons in boolean expressions	84
Avoid using final local variables, turn them into fields	88
Avoid unnecessary comparisons in boolean expressions	92
Avoid unnecessary comparisons in boolean expressions	99
Avoid unnecessary comparisons in boolean expressions	121
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	131
Avoid unnecessary comparisons in boolean expressions	132
Avoid using final local variables, turn them into fields	136

org/projectforge/user/UserPrefAreaRegistry.java

Violation	Line
A class which only has private constructors should be final	40 - 94
It is somewhat confusing to have a field name with the same name as a method	42
KONSTANTHEIT_VERSTECKTE: Private field 'set' could be made final; it is only initialized in the declaration or constructor.	44
Avoid unnecessary comparisons in boolean expressions	59
Avoid using final local variables, turn them into fields	72

org/projectforge/user/UserPrefDO.java

Violation	Line
Avoid using final local variables, turn them into fields	157 - 162
Avoid using final local variables, turn them into fields	188
Avoid using final local variables, turn them into fields	191
Avoid unnecessary comparisons in boolean expressions	192
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	197
Avoid unnecessary comparisons in boolean expressions	226
Avoid unnecessary comparisons in boolean expressions	241
Avoid instantiating new objects inside loops	243

org/projectforge/user/UserPrefDao.java

Violation	Line
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	80
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	96 - 98
Avoid using final local variables, turn them into fields	99
Avoid using final local variables, turn them into fields	121
Avoid unnecessary comparisons in boolean expressions	129
Avoid using final local variables, turn them into fields	138
Avoid using final local variables, turn them into fields	139
Avoid using final local variables, turn them into fields	145
Consider simply returning the value vs storing it in local variable 'list'	146
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	152 - 154
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	164 - 166
Avoid using final local variables, turn them into fields	197
Avoid unnecessary comparisons in boolean expressions	201
Avoid using final local variables, turn them into fields	202
Avoid instantiating new objects inside loops	202
Avoid using final local variables, turn them into fields	228
Avoid unnecessary comparisons in boolean expressions	231
Avoid unnecessary comparisons in boolean expressions	234
Avoid instantiating new objects inside loops	240
Avoid unnecessary comparisons in boolean expressions	246
Avoid using final local variables, turn them into fields	256
Avoid unnecessary comparisons in boolean expressions	263
Avoid using final local variables, turn them into fields	279
Avoid unnecessary comparisons in boolean expressions	285
Avoid using final local variables, turn them into fields	293
Avoid unnecessary comparisons in boolean expressions	358
Avoid unnecessary comparisons in boolean expressions	360
Avoid unnecessary comparisons in boolean expressions	362
Avoid using final local variables, turn them into fields	363
Avoid unnecessary comparisons in boolean expressions	365
Avoid unnecessary comparisons in boolean expressions	367
Avoid unnecessary comparisons in boolean expressions	369
Avoid unnecessary comparisons in boolean expressions	371
Avoid unnecessary comparisons in boolean expressions	380
Avoid using final local variables, turn them into fields	381
Avoid unnecessary comparisons in boolean expressions	387
Avoid using final local variables, turn them into fields	397
Avoid unnecessary comparisons in boolean expressions	424
Avoid unnecessary comparisons in boolean expressions	427

org/projectforge/user/UserPrefEntryDO.java

Violation	Line
Avoid using final local variables, turn them into fields	227
Avoid unnecessary comparisons in boolean expressions	228
Avoid unnecessary comparisons in boolean expressions	230
Avoid using final local variables, turn them into fields	240
Avoid using final local variables, turn them into fields	248

org/projectforge/user/UserRight.java

Violation	Line
An empty method in an abstract class should be abstract instead	72 - 75
An empty method in an abstract class should be abstract instead	81 - 84
Returning 'values' may expose an internal array.	83
An empty method in an abstract class should be abstract instead	94 - 123
Avoid using final local variables, turn them into fields	99
Avoid unnecessary comparisons in boolean expressions	107
Avoid using final local variables, turn them into fields	108
Avoid unnecessary comparisons in boolean expressions	111
An empty method in an abstract class should be abstract instead	132 - 146
Avoid using final local variables, turn them into fields	137
Avoid unnecessary comparisons in boolean expressions	139
KONSTANTHEIT_VERSTECKTE: Local variable 'oa' could be declared final	143
An empty method in an abstract class should be abstract instead	184 - 187
An empty method in an abstract class should be abstract instead	194 - 197
An empty method in an abstract class should be abstract instead	204 - 207
An empty method in an abstract class should be abstract instead	209 - 213
An empty method in an abstract class should be abstract instead	216 - 219

org/projectforge/user/UserRightDO.java

Violation	Line
Avoid using final local variables, turn them into fields	166
Avoid unnecessary comparisons in boolean expressions	167
Avoid unnecessary comparisons in boolean expressions	169
KONSTANTHEIT_VERSTECKTE: Local variable 'hcb' could be declared final	179
KONSTANTHEIT_VERSTECKTE: Local variable 'sb' could be declared final	188

org/projectforge/user/UserRightDao.java

Violation	Line
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	58
Avoid unnecessary comparisons in boolean expressions	67
Avoid instantiating new objects inside loops	73
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	79
Avoid unnecessary comparisons in boolean expressions	80
Avoid unnecessary comparisons in boolean expressions	80
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	89
Avoid unnecessary comparisons in boolean expressions	90
Avoid unnecessary comparisons in boolean expressions	90
Avoid unnecessary comparisons in boolean expressions	100
Avoid unnecessary comparisons in boolean expressions	101
Avoid using final local variables, turn them into fields	113
Avoid using final local variables, turn them into fields	117
Avoid unnecessary comparisons in boolean expressions	119
Avoid using final local variables, turn them into fields	122
Avoid instantiating new objects inside loops	122
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	137
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	143
Consider simply returning the value vs storing it in local variable 'list'	144
Returning 'ADDITIONAL_SEARCH_FIELDS' may expose an internal array.	150

org/projectforge/user/UserRightId.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	45 - 46
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	48 - 49
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	51
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	53
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	55
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	57
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	59
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	61
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	63
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	65
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	67
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	69
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	71
KONSTANTHEIT_VERSTECKTE: Private field 'id' could be made final; it is only initialized in the declaration or constructor.	73
KONSTANTHEIT_VERSTECKTE: Private field 'orderString' could be made final; it is only initialized in the declaration or constructor.	75
KONSTANTHEIT_VERSTECKTE: Private field 'i18nKey' could be made final; it is only initialized in the declaration or constructor.	77
Avoid unnecessary comparisons in boolean expressions	122
Avoid using final local variables, turn them into fields	131

org/projectforge/user/UserRightVO.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'right' could be made final; it is only initialized in the declaration or constructor.	42
Avoid unnecessary comparisons in boolean expressions	56

org/projectforge/user/UserRights.java

Violation	Line
A class which only has private constructors should be final	39 - 176
It is somewhat confusing to have a field name with the same name as a method	77
KONSTANTHEIT_VERSTECKTE: Private field 'rights' could be made final; it is only initialized in the declaration or constructor.	79
KONSTANTHEIT_VERSTECKTE: Private field 'rightIds' could be made final; it is only initialized in the declaration or constructor.	81
KONSTANTHEIT_VERSTECKTE: Private field 'orderedRights' could be made final; it is only initialized in the declaration or constructor.	83
KONSTANTHEIT_VERSTECKTE: Private field 'accessChecker' could be made final; it is only initialized in the declaration or constructor.	85
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	171

org/projectforge/user/UserXmlPreferencesBaseDOSingleValueConverter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'daoClass' could be made final; it is only initialized in the declaration or constructor.	41
KONSTANTHEIT_VERSTECKTE: Private field 'doClass' could be made final; it is only initialized in the declaration or constructor.	43
Avoid unnecessary comparisons in boolean expressions	76
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	80

org/projectforge/user/UserXmlPreferencesCache.java

Violation	Line
Avoid using final local variables, turn them into fields	85
Avoid unnecessary comparisons in boolean expressions	86
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	127
Avoid unnecessary comparisons in boolean expressions	132
Avoid unnecessary comparisons in boolean expressions	134
SYNCHRONISATION: Use block level rather than method level synchronization	141 - 155
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	149
SYNCHRONISATION: Use block level rather than method level synchronization	176 - 183
Avoid using final local variables, turn them into fields	178
Avoid unnecessary comparisons in boolean expressions	179
Avoid using final local variables, turn them into fields	203

org/projectforge/user/UserXmlPreferencesDao.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'registerConverter' called during object construction	68
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'registerConverter' called during object construction	69
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'registerConverter' called during object construction	70
Avoid unnecessary comparisons in boolean expressions	107
Avoid using final local variables, turn them into fields	110 - 112
Avoid using final local variables, turn them into fields	128 - 129
Consider simply returning the value vs storing it in local variable 'list'	130
Avoid using final local variables, turn them into fields	140
Avoid unnecessary comparisons in boolean expressions	141
Avoid using final local variables, turn them into fields	157
Consider simply returning the value vs storing it in local variable 'value'	158
Avoid unnecessary comparisons in boolean expressions	160
Avoid using final local variables, turn them into fields	179
Avoid unnecessary comparisons in boolean expressions	180
Avoid unnecessary comparisons in boolean expressions	194
Avoid using final local variables, turn them into fields	198
Avoid using final local variables, turn them into fields	201
Avoid unnecessary comparisons in boolean expressions	212
Avoid unnecessary comparisons in boolean expressions	213
Avoid unnecessary comparisons in boolean expressions	218
Avoid unnecessary comparisons in boolean expressions	228
Avoid using final local variables, turn them into fields	232

org/projectforge/user/UserXmlPreferencesMap.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	92
KONSTANTHEIT_VERSTECKTE: Local variable 'value' could be declared final	107
Avoid unnecessary comparisons in boolean expressions	144
Avoid unnecessary comparisons in boolean expressions	149

org/projectforge/user/UserXmlPreferencesMigrationDao.java

Violation	Line
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	79 - 80
Avoid empty if statements	99 - 104
Avoid using final local variables, turn them into fields	113 - 114
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	123
StringBuffer constructor is initialized with size 16, but has at least 90 characters appended.	123
Avoid using final local variables, turn them into fields	125
Avoid using final local variables, turn them into fields	137
Avoid unnecessary comparisons in boolean expressions	140
Avoid appending characters as strings in StringBuffer.append.	145

org/projectforge/web/CustomizeMenuPage.java

Violation	Line
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	52
Avoid using final local variables, turn them into fields	63
Avoid unnecessary comparisons in boolean expressions	65
Avoid using final local variables, turn them into fields	65 - 66
Avoid unnecessary comparisons in boolean expressions	66
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	100
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	109
Avoid using final local variables, turn them into fields	111
Avoid unnecessary comparisons in boolean expressions	113
Avoid using final local variables, turn them into fields	117
Avoid using final local variables, turn them into fields	129
Avoid unnecessary comparisons in boolean expressions	132
Avoid using final local variables, turn them into fields	144
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	154
Avoid unnecessary comparisons in boolean expressions	156
Avoid using final local variables, turn them into fields	161

org/projectforge/web/FavoritesMenu.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'buildFromOldUserPrefFormat' called during object construction	92
Avoid unnecessary comparisons in boolean expressions	113
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	127
Avoid using final local variables, turn them into fields	128
Avoid unnecessary comparisons in boolean expressions	135
Avoid unnecessary comparisons in boolean expressions	141
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	157
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	183
Avoid unnecessary comparisons in boolean expressions	184
Avoid unnecessary comparisons in boolean expressions	185
Avoid using final local variables, turn them into fields	193
Avoid unnecessary comparisons in boolean expressions	194
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	202 - 203
Avoid using final local variables, turn them into fields	221
Avoid using final local variables, turn them into fields	233
Avoid using final local variables, turn them into fields	255
Avoid unnecessary comparisons in boolean expressions	256
Avoid unnecessary comparisons in boolean expressions	258
Avoid using final local variables, turn them into fields	262
Avoid using final local variables, turn them into fields	263
Avoid unnecessary comparisons in boolean expressions	276
Avoid using final local variables, turn them into fields	281
Avoid using final local variables, turn them into fields	282
Avoid using final local variables, turn them into fields	286
Avoid unnecessary comparisons in boolean expressions	292
Avoid unnecessary comparisons in boolean expressions	306

org/projectforge/web/HtmlHelper.java

Violation	Line
Avoid using final local variables, turn them into fields	65
Avoid unnecessary comparisons in boolean expressions	66
Avoid unnecessary comparisons in boolean expressions	69
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	109
Avoid using final local variables, turn them into fields	137
Avoid using final local variables, turn them into fields	175
Avoid using final local variables, turn them into fields	203
Avoid using final local variables, turn them into fields	218
Avoid using final local variables, turn them into fields	224
Avoid unnecessary comparisons in boolean expressions	257
Avoid unnecessary comparisons in boolean expressions	261
Avoid using final local variables, turn them into fields	264
Avoid using final local variables, turn them into fields	268
Avoid empty if statements	272 - 274
Avoid unnecessary comparisons in boolean expressions	275
Avoid unnecessary comparisons in boolean expressions	289
Avoid unnecessary comparisons in boolean expressions	301

org/projectforge/web/HtmlRequestBuilder.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	78
Avoid appending characters as strings in StringBuffer.append.	79
Avoid appending characters as strings in StringBuffer.append.	82
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	93
Avoid unnecessary comparisons in boolean expressions	98
Avoid appending characters as strings in StringBuffer.append.	99
Avoid appending characters as strings in StringBuffer.append.	102
Avoid appending characters as strings in StringBuffer.append.	105

org/projectforge/web/HtmlTagBuilder.java

Violation	Line
Avoid appending characters as strings in StringBuffer.append.	83
Avoid appending characters as strings in StringBuffer.append.	87
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	107
Avoid appending characters as strings in StringBuffer.append.	108
Avoid appending characters as strings in StringBuffer.append.	110
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	111
Avoid appending characters as strings in StringBuffer.append.	113
Avoid appending characters as strings in StringBuffer.append.	117

org/projectforge/web/I18nCore.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 131
Avoid unnecessary comparisons in boolean expressions	60
Avoid using final local variables, turn them into fields	72
Avoid unnecessary comparisons in boolean expressions	87
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	96
Avoid unnecessary comparisons in boolean expressions	97
Avoid unnecessary comparisons in boolean expressions	113

org/projectforge/web/LayoutSettingsForm.java

Violation	Line
Avoid using final local variables, turn them into fields	55
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	57 - 79
Avoid using final local variables, turn them into fields	100
Avoid using final local variables, turn them into fields	105

org/projectforge/web/LayoutSettingsPage.java

Violation	Line
Perhaps 'form' could be replaced by a local variable.	36
Avoid using final local variables, turn them into fields	42
Avoid using final local variables, turn them into fields	46

org/projectforge/web/LoginForm.java

Violation	Line
Avoid using final local variables, turn them into fields	57
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	64 - 65
Avoid using final local variables, turn them into fields	68 - 77
Avoid using final local variables, turn them into fields	72

org/projectforge/web/LoginPage.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'errorsContainer' could be made final; it is only initialized in the declaration or constructor.	85
KONSTANTHEIT_VERSTECKTE: Private field 'form' could be made final; it is only initialized in the declaration or constructor.	95
Avoid using final local variables, turn them into fields	103
Avoid using final local variables, turn them into fields	111
Avoid using final local variables, turn them into fields	120
Avoid using final local variables, turn them into fields	138
Avoid using final local variables, turn them into fields	147
Avoid unnecessary comparisons in boolean expressions	165
Avoid unnecessary comparisons in boolean expressions	166
Avoid unnecessary comparisons in boolean expressions	167
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	171
Avoid unnecessary comparisons in boolean expressions	176
Avoid using final local variables, turn them into fields	180
Avoid using final local variables, turn them into fields	190
Avoid unnecessary comparisons in boolean expressions	192
Avoid using final local variables, turn them into fields	196
Avoid using final local variables, turn them into fields	197
Avoid using final local variables, turn them into fields	199
Avoid using final local variables, turn them into fields	227
Avoid using final local variables, turn them into fields	229
Avoid using final local variables, turn them into fields	231
Avoid using final local variables, turn them into fields	256
Avoid unnecessary comparisons in boolean expressions	258
Avoid using final local variables, turn them into fields	261
Avoid using final local variables, turn them into fields	263
Avoid using final local variables, turn them into fields	264
Avoid unnecessary comparisons in boolean expressions	269
Avoid using final local variables, turn them into fields	270
Avoid using final local variables, turn them into fields	271
Avoid using final local variables, turn them into fields	272
Avoid unnecessary comparisons in boolean expressions	283
Avoid unnecessary comparisons in boolean expressions	298
Avoid unnecessary comparisons in boolean expressions	303
Avoid using final local variables, turn them into fields	304
Avoid using final local variables, turn them into fields	305 - 309
Avoid unnecessary comparisons in boolean expressions	315
Avoid unnecessary comparisons in boolean expressions	318

org/projectforge/web/Menu.java

Violation	Line
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	84
Avoid unnecessary comparisons in boolean expressions	97
Avoid using final local variables, turn them into fields	99

org/projectforge/web/MenuBuilder.java

Violation	Line
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	64
Avoid unnecessary comparisons in boolean expressions	86
Avoid unnecessary comparisons in boolean expressions	98

org/projectforge/web/MenuBuilderContext.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'accessChecker' could be made final; it is only initialized in the declaration or constructor.	41
KONSTANTHEIT_VERSTECKTE: Private field 'loggedInUser' could be made final; it is only initialized in the declaration or constructor.	43
KONSTANTHEIT_VERSTECKTE: Private field 'menu' could be made final; it is only initialized in the declaration or constructor.	45
KONSTANTHEIT_VERSTECKTE: Private field 'mobileMenu' could be made final; it is only initialized in the declaration or constructor.	47

org/projectforge/web/MenuEntry.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	86
Avoid unnecessary comparisons in boolean expressions	89
Avoid using final local variables, turn them into fields	93
Avoid instantiating new objects inside loops	98
Avoid using final local variables, turn them into fields	135
Avoid unnecessary comparisons in boolean expressions	163
Avoid unnecessary comparisons in boolean expressions	167
Avoid unnecessary comparisons in boolean expressions	201
Avoid unnecessary comparisons in boolean expressions	213
Avoid using final local variables, turn them into fields	220
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	230
Avoid unnecessary comparisons in boolean expressions	240
Avoid unnecessary comparisons in boolean expressions	304
Avoid unnecessary comparisons in boolean expressions	304
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	317
Avoid unnecessary comparisons in boolean expressions	321
Avoid using final local variables, turn them into fields	343
Avoid using final local variables, turn them into fields	344
Avoid using final local variables, turn them into fields	350
Avoid using final local variables, turn them into fields	351
Avoid using final local variables, turn them into fields	361

org/projectforge/web/MenuEntryConfig.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'visible' could be made final; it is only initialized in the declaration or constructor.	56
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	110
Avoid using final local variables, turn them into fields	114
Avoid unnecessary comparisons in boolean expressions	130
STRING_VERGLEICH_CASING: Using equalsIgnoreCase() is cleaner than using toUpperCase/toLowerCase().equals().	130
Avoid unnecessary comparisons in boolean expressions	152
Avoid using final local variables, turn them into fields	159

org/projectforge/web/MenuItemDef.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	108
Avoid unnecessary comparisons in boolean expressions	108
Avoid unnecessary comparisons in boolean expressions	112
Avoid unnecessary comparisons in boolean expressions	112
Avoid unnecessary comparisons in boolean expressions	116
Avoid unnecessary comparisons in boolean expressions	119
Avoid using final local variables, turn them into fields	122
Avoid unnecessary comparisons in boolean expressions	125
Avoid using final local variables, turn them into fields	129
Avoid unnecessary comparisons in boolean expressions	442
Avoid unnecessary comparisons in boolean expressions	442
Returning 'params' may expose an internal array.	459
Returning 'visibleForGroups' may expose an internal array.	469
Returning 'requiredRightValues' may expose an internal array.	479
Avoid using final local variables, turn them into fields	489
Avoid unnecessary comparisons in boolean expressions	492
Avoid unnecessary comparisons in boolean expressions	499

org/projectforge/web/MenuItemRegistry.java

Violation	Line
A class which only has private constructors should be final	107 - 356
It is somewhat confusing to have a field name with the same name as a method	115
Avoid unnecessary comparisons in boolean expressions	125
Avoid using final local variables, turn them into fields	149
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	169
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	234
Avoid using final local variables, turn them into fields	235
Avoid using final local variables, turn them into fields	236
Avoid using final local variables, turn them into fields	237
Avoid using final local variables, turn them into fields	238
Avoid using final local variables, turn them into fields	239
Avoid using final local variables, turn them into fields	240
Avoid using final local variables, turn them into fields	241
Avoid using final local variables, turn them into fields	242
Avoid using final local variables, turn them into fields	250 - 256
Avoid using final local variables, turn them into fields	278 - 288
Avoid unnecessary comparisons in boolean expressions	283
Avoid using final local variables, turn them into fields	294 - 307
Avoid unnecessary comparisons in boolean expressions	299

org/projectforge/web/RestUserFilter.java

Violation	Line
Avoid using final local variables, turn them into fields	46
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	49
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	52
Avoid using final local variables, turn them into fields	54

org/projectforge/web/TotalNewCounterModel.java

Violation	Line
Avoid using final local variables, turn them into fields	60
Avoid unnecessary comparisons in boolean expressions	61
Avoid unnecessary comparisons in boolean expressions	68

org/projectforge/web/URLHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 76
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	65

org/projectforge/web/UserAgentDetection.java

Violation	Line
Avoid using final local variables, turn them into fields	105
Avoid unnecessary comparisons in boolean expressions	110
Avoid using final local variables, turn them into fields	122
Avoid instantiating new objects inside loops	122
Avoid using final local variables, turn them into fields	125
Avoid unnecessary comparisons in boolean expressions	126
Avoid using final local variables, turn them into fields	136
Avoid unnecessary comparisons in boolean expressions	137

org/projectforge/web/UserAgentDevice.java

Violation	Line
Avoid using final local variables, turn them into fields	43
Avoid unnecessary comparisons in boolean expressions	44
Avoid unnecessary comparisons in boolean expressions	46
Avoid unnecessary comparisons in boolean expressions	48
Avoid unnecessary comparisons in boolean expressions	50
Avoid unnecessary comparisons in boolean expressions	52
Avoid unnecessary comparisons in boolean expressions	54
Avoid unnecessary comparisons in boolean expressions	56
Avoid unnecessary comparisons in boolean expressions	58
Avoid unnecessary comparisons in boolean expressions	60
Avoid unnecessary comparisons in boolean expressions	60
Avoid unnecessary comparisons in boolean expressions	62

org/projectforge/web/UserAgentOS.java

Violation	Line
Avoid using final local variables, turn them into fields	38
Avoid unnecessary comparisons in boolean expressions	39
Avoid unnecessary comparisons in boolean expressions	41
Avoid unnecessary comparisons in boolean expressions	43
Avoid unnecessary comparisons in boolean expressions	43
Avoid unnecessary comparisons in boolean expressions	43

org/projectforge/web/UserFilter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	74
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	76
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	78
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	80
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	82
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	84
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	86
Avoid using final local variables, turn them into fields	121
Avoid unnecessary comparisons in boolean expressions	124
Avoid unnecessary comparisons in boolean expressions	137
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	149
Avoid using final local variables, turn them into fields	156
Avoid unnecessary comparisons in boolean expressions	157
Avoid using final local variables, turn them into fields	171
Avoid unnecessary comparisons in boolean expressions	191
Avoid using final local variables, turn them into fields	193
Avoid using final local variables, turn them into fields	211
Avoid unnecessary comparisons in boolean expressions	216
Avoid unnecessary comparisons in boolean expressions	218
Avoid unnecessary comparisons in boolean expressions	226
Avoid unnecessary comparisons in boolean expressions	229
Avoid unnecessary comparisons in boolean expressions	233
Avoid unnecessary comparisons in boolean expressions	246
Avoid unnecessary comparisons in boolean expressions	262
Avoid using final local variables, turn them into fields	274
Avoid unnecessary comparisons in boolean expressions	275
Avoid unnecessary comparisons in boolean expressions	275
Avoid using final local variables, turn them into fields	280 - 281
Avoid unnecessary comparisons in boolean expressions	282
Avoid using final local variables, turn them into fields	287
Avoid using final local variables, turn them into fields	292
Avoid using final local variables, turn them into fields	294
Avoid unnecessary comparisons in boolean expressions	295
Avoid using final local variables, turn them into fields	298
Avoid using final local variables, turn them into fields	303
Avoid using final local variables, turn them into fields	304
Avoid unnecessary comparisons in boolean expressions	309
Avoid unnecessary comparisons in boolean expressions	313
Avoid using final local variables, turn them into fields	331
Avoid using final local variables, turn them into fields	355
Avoid using final local variables, turn them into fields	356
Avoid unnecessary comparisons in boolean expressions	358
Avoid unnecessary comparisons in boolean expressions	360
Avoid unnecessary comparisons in boolean expressions	363
Avoid unnecessary comparisons in boolean expressions	364
Avoid unnecessary comparisons in boolean expressions	367

org/projectforge/web/WebConfiguration.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 50
Avoid using final local variables, turn them into fields	37
Avoid unnecessary comparisons in boolean expressions	38

org/projectforge/web/access/AccessEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	65 - 66
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	73 - 74
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	134

org/projectforge/web/access/AccessEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	69
Avoid unnecessary comparisons in boolean expressions	71
Avoid unnecessary comparisons in boolean expressions	80
Avoid unnecessary comparisons in boolean expressions	82

org/projectforge/web/access/AccessEditTablePanel.java

Violation	Line
Avoid using final local variables, turn them into fields	57
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	71

org/projectforge/web/access/AccessListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	58
Avoid using final local variables, turn them into fields	59 - 75
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	84 - 100
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	109 - 125
Avoid using final local variables, turn them into fields	133
Avoid using final local variables, turn them into fields	134

org/projectforge/web/access/AccessListPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	77
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	87
Avoid using final local variables, turn them into fields	88 - 98
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	109
Avoid using final local variables, turn them into fields	110
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	127
Avoid unnecessary comparisons in boolean expressions	128
Avoid using final local variables, turn them into fields	142
Avoid using final local variables, turn them into fields	143
Avoid using final local variables, turn them into fields	144
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	160
Avoid using final local variables, turn them into fields	161
Avoid unnecessary comparisons in boolean expressions	182
Avoid unnecessary comparisons in boolean expressions	185
Avoid unnecessary comparisons in boolean expressions	188
Avoid unnecessary comparisons in boolean expressions	203
Avoid unnecessary comparisons in boolean expressions	206
Avoid unnecessary comparisons in boolean expressions	209

org/projectforge/web/access/AccessTablePanel.java

Violation	Line
Avoid using final local variables, turn them into fields	59
Avoid unnecessary comparisons in boolean expressions	61
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	71
Avoid instantiating new objects inside loops	71
Avoid instantiating new objects inside loops	73
Avoid unnecessary comparisons in boolean expressions	95

org/projectforge/web/address/AddressEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	67
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	130

org/projectforge/web/address/AddressEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	58
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	66
Avoid unnecessary comparisons in boolean expressions	71
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	91

org/projectforge/web/address/AddressListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	70 - 89
Avoid using final local variables, turn them into fields	110
Avoid using final local variables, turn them into fields	111
Avoid using final local variables, turn them into fields	131
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	160 - 230
Avoid using final local variables, turn them into fields	184
Avoid using final local variables, turn them into fields	187
Consider simply returning the value vs storing it in local variable 'list'	188

org/projectforge/web/address/AddressListPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	123
Avoid unnecessary comparisons in boolean expressions	124
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	137 - 152
Avoid using final local variables, turn them into fields	140
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	142
Avoid empty if statements	143 - 145
Avoid unnecessary comparisons in boolean expressions	143
Avoid unnecessary comparisons in boolean expressions	145
Avoid using final local variables, turn them into fields	162
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	174
Avoid using final local variables, turn them into fields	196
Avoid using final local variables, turn them into fields	197
Avoid unnecessary comparisons in boolean expressions	200
Avoid using final local variables, turn them into fields	201 - 202
Avoid unnecessary comparisons in boolean expressions	207
Avoid unnecessary comparisons in boolean expressions	208
Avoid using final local variables, turn them into fields	227
Avoid using final local variables, turn them into fields	228
Avoid using final local variables, turn them into fields	229
Avoid using final local variables, turn them into fields	231
Avoid unnecessary comparisons in boolean expressions	233
Avoid unnecessary comparisons in boolean expressions	235
Avoid unnecessary comparisons in boolean expressions	237
Avoid unnecessary comparisons in boolean expressions	239
Avoid using final local variables, turn them into fields	253
Avoid unnecessary comparisons in boolean expressions	257
Avoid using final local variables, turn them into fields	258 - 264
Avoid using final local variables, turn them into fields	269 - 285
Avoid using final local variables, turn them into fields	274
Avoid unnecessary comparisons in boolean expressions	275
Avoid using final local variables, turn them into fields	279
Avoid using final local variables, turn them into fields	280
Avoid using final local variables, turn them into fields	286 - 287
Avoid using final local variables, turn them into fields	292 - 306
Avoid using final local variables, turn them into fields	297
Avoid using final local variables, turn them into fields	298
Avoid using final local variables, turn them into fields	303
Avoid using final local variables, turn them into fields	307 - 308
Avoid using final local variables, turn them into fields	313 - 329
Avoid using final local variables, turn them into fields	318
Avoid unnecessary comparisons in boolean expressions	319
Avoid using final local variables, turn them into fields	323
Avoid using final local variables, turn them into fields	324
Avoid using final local variables, turn them into fields	330 - 331
Avoid using final local variables, turn them into fields	336 - 355
Avoid using final local variables, turn them into fields	341
Avoid using final local variables, turn them into fields	343
Avoid using final local variables, turn them into fields	344
Avoid using final local variables, turn them into fields	356 - 357
Avoid unnecessary comparisons in boolean expressions	365
Avoid unnecessary comparisons in boolean expressions	368
Avoid using final local variables, turn them into fields	371 - 372
Returning 'MY_BOOKMARKABLE_INITIAL_PROPERTIES' may expose an internal array.	383
Avoid unnecessary comparisons in boolean expressions	390
Avoid unnecessary comparisons in boolean expressions	390

org/projectforge/web/address/AddressListPhoneNumberPanel.java

Violation	Line
TOTE_PARAMETER: Avoid unused constructor parameters such as 'first'.	41 - 87
Avoid using final local variables, turn them into fields	45
Avoid unnecessary comparisons in boolean expressions	46
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	65
Avoid unnecessary comparisons in boolean expressions	66
Avoid using final local variables, turn them into fields	73 - 82
Avoid using final local variables, turn them into fields	77
Avoid unnecessary comparisons in boolean expressions	83
Avoid unnecessary comparisons in boolean expressions	83

org/projectforge/web/address/AddressMobileViewPage.java

Violation	Line
Avoid using final local variables, turn them into fields	58
Avoid using final local variables, turn them into fields	67
Avoid unnecessary comparisons in boolean expressions	68
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	77 - 78
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	85 - 86
Avoid using final local variables, turn them into fields	87
Avoid using final local variables, turn them into fields	88 - 89
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	91 - 92
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	94
Avoid unnecessary comparisons in boolean expressions	96
Avoid using final local variables, turn them into fields	101

org/projectforge/web/address/AddressPageSupport.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'gridBuilder' could be made final; it is only initialized in the declaration or constructor.	84
Avoid unnecessary comparisons in boolean expressions	120
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'isNew' called during object construction	120
Returning 'dependentFormComponents' may expose an internal array.	130
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	137
Avoid using final local variables, turn them into fields	138
Avoid unnecessary comparisons in boolean expressions	139
Avoid unnecessary comparisons in boolean expressions	140
Avoid unnecessary comparisons in boolean expressions	141
Avoid using final local variables, turn them into fields	150
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	152
Avoid unnecessary comparisons in boolean expressions	154
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	180
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	182 - 183
Avoid using final local variables, turn them into fields	196
Avoid using final local variables, turn them into fields	197
Avoid using final local variables, turn them into fields	209
Avoid using final local variables, turn them into fields	210
Avoid using final local variables, turn them into fields	223
Avoid using final local variables, turn them into fields	224
Avoid using final local variables, turn them into fields	243
Avoid using final local variables, turn them into fields	244
Avoid using final local variables, turn them into fields	256
Avoid using final local variables, turn them into fields	257
Avoid using final local variables, turn them into fields	269
Avoid using final local variables, turn them into fields	270
Avoid using final local variables, turn them into fields	283
Avoid using final local variables, turn them into fields	284
Avoid using final local variables, turn them into fields	297
Avoid using final local variables, turn them into fields	298
Avoid using final local variables, turn them into fields	299 - 300
Avoid using final local variables, turn them into fields	313
Avoid using final local variables, turn them into fields	314
Avoid using final local variables, turn them into fields	315 - 316
Avoid using final local variables, turn them into fields	330
Avoid using final local variables, turn them into fields	331
Avoid using final local variables, turn them into fields	350
Avoid using final local variables, turn them into fields	351
Avoid using final local variables, turn them into fields	352
Avoid unnecessary comparisons in boolean expressions	355
Avoid using final local variables, turn them into fields	368
Avoid using final local variables, turn them into fields	369
Avoid using final local variables, turn them into fields	381
Avoid using final local variables, turn them into fields	382
Avoid using final local variables, turn them into fields	394
Avoid using final local variables, turn them into fields	395
Avoid using final local variables, turn them into fields	396
Avoid using final local variables, turn them into fields	409
Avoid using final local variables, turn them into fields	410
Avoid using final local variables, turn them into fields	411
Avoid using final local variables, turn them into fields	427
Avoid using final local variables, turn them into fields	428
Avoid using final local variables, turn them into fields	447
Avoid using final local variables, turn them into fields	448
Avoid using final local variables, turn them into fields	460
Avoid using final local variables, turn them into fields	461
Avoid using final local variables, turn them into fields	473
Avoid using final local variables, turn them into fields	474
Avoid using final local variables, turn them into fields	486
Avoid using final local variables, turn them into fields	487

org/projectforge/web/address/AddressViewPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	71
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	80 - 86
Avoid using final local variables, turn them into fields	90 - 100
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	96
Avoid unnecessary comparisons in boolean expressions	103
Avoid using final local variables, turn them into fields	104 - 113
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	109
Avoid unnecessary comparisons in boolean expressions	116
Avoid unnecessary comparisons in boolean expressions	116
Avoid using final local variables, turn them into fields	117 - 131
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	122
Avoid unnecessary comparisons in boolean expressions	124
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	139
Avoid using final local variables, turn them into fields	150
Avoid using final local variables, turn them into fields	158 - 160
Avoid unnecessary comparisons in boolean expressions	161
Avoid unnecessary comparisons in boolean expressions	166
Avoid unnecessary comparisons in boolean expressions	173
Avoid using final local variables, turn them into fields	177
Avoid unnecessary comparisons in boolean expressions	187
Avoid using final local variables, turn them into fields	191
Avoid unnecessary comparisons in boolean expressions	199
Avoid unnecessary comparisons in boolean expressions	202
Avoid unnecessary comparisons in boolean expressions	202
Avoid using final local variables, turn them into fields	203
Avoid appending characters as strings in StringBuffer.append.	205
Avoid unnecessary comparisons in boolean expressions	212
Avoid unnecessary comparisons in boolean expressions	215
Avoid unnecessary comparisons in boolean expressions	218
Avoid unnecessary comparisons in boolean expressions	221
Avoid unnecessary comparisons in boolean expressions	224
Avoid using final local variables, turn them into fields	227
Avoid unnecessary comparisons in boolean expressions	240
Avoid using final local variables, turn them into fields	243
Avoid unnecessary comparisons in boolean expressions	250
Avoid using final local variables, turn them into fields	253

org/projectforge/web/address/BirthdayEventsProvider.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	79
Avoid using final local variables, turn them into fields	87
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	91
Avoid unnecessary comparisons in boolean expressions	108
Avoid using final local variables, turn them into fields	112
Avoid instantiating new objects inside loops	112
Avoid using final local variables, turn them into fields	113
Avoid using final local variables, turn them into fields	116
Avoid instantiating new objects inside loops	116
Avoid unnecessary comparisons in boolean expressions	117
Avoid appending characters as strings in StringBuffer.append.	121
Avoid appending characters as strings in StringBuffer.append.	123
Avoid unnecessary comparisons in boolean expressions	124
Avoid appending characters as strings in StringBuffer.append.	126
Avoid appending characters as strings in StringBuffer.append.	126
Avoid unnecessary comparisons in boolean expressions	129
Avoid unnecessary comparisons in boolean expressions	150

org/projectforge/web/address/PhoneCallForm.java

Violation	Line
Perhaps 'gridBuilder' could be replaced by a local variable.	96
Avoid using final local variables, turn them into fields	150 - 166
Avoid using final local variables, turn them into fields	175
Avoid using final local variables, turn them into fields	203
Avoid unnecessary comparisons in boolean expressions	250
Avoid using final local variables, turn them into fields	252
Avoid unnecessary comparisons in boolean expressions	253
Avoid using final local variables, turn them into fields	257
Avoid unnecessary comparisons in boolean expressions	258
Avoid using final local variables, turn them into fields	269
Avoid using final local variables, turn them into fields	270
Avoid using final local variables, turn them into fields	278 - 279
Avoid using final local variables, turn them into fields	286 - 298
Avoid using final local variables, turn them into fields	294
Avoid using final local variables, turn them into fields	299 - 321
Avoid using final local variables, turn them into fields	306
Avoid appending characters as strings in StringBuffer.append.	308
Avoid unnecessary comparisons in boolean expressions	310
Avoid appending characters as strings in StringBuffer.append.	311
Avoid unnecessary comparisons in boolean expressions	313
Avoid appending characters as strings in StringBuffer.append.	314
Avoid unnecessary comparisons in boolean expressions	316
Avoid using final local variables, turn them into fields	334 - 340
Avoid using final local variables, turn them into fields	341 - 342
Avoid using final local variables, turn them into fields	346
Avoid using final local variables, turn them into fields	348
Avoid using final local variables, turn them into fields	349
Avoid using final local variables, turn them into fields	367
Avoid using final local variables, turn them into fields	375 - 385
Avoid using final local variables, turn them into fields	379
Avoid using final local variables, turn them into fields	386 - 406
Avoid using final local variables, turn them into fields	390
Avoid using final local variables, turn them into fields	403
Avoid unnecessary comparisons in boolean expressions	404

org/projectforge/web/address/PhoneCallPage.java

Violation	Line
Avoid using final local variables, turn them into fields	86
Avoid unnecessary comparisons in boolean expressions	98
Avoid unnecessary comparisons in boolean expressions	111
Avoid unnecessary comparisons in boolean expressions	113
Avoid unnecessary comparisons in boolean expressions	115
Avoid unnecessary comparisons in boolean expressions	117
Avoid using final local variables, turn them into fields	129
Avoid unnecessary comparisons in boolean expressions	130
Avoid unnecessary comparisons in boolean expressions	131
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	138
Avoid unnecessary comparisons in boolean expressions	139
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	153
Avoid unnecessary comparisons in boolean expressions	171
Avoid using final local variables, turn them into fields	179 - 180
Avoid unnecessary comparisons in boolean expressions	181
Avoid unnecessary comparisons in boolean expressions	182
Avoid unnecessary comparisons in boolean expressions	183
Avoid using final local variables, turn them into fields	193
Avoid unnecessary comparisons in boolean expressions	194
Avoid using final local variables, turn them into fields	203
Avoid unnecessary comparisons in boolean expressions	204
Avoid unnecessary comparisons in boolean expressions	207
Avoid unnecessary comparisons in boolean expressions	217
Avoid using final local variables, turn them into fields	226
Avoid using final local variables, turn them into fields	228
Avoid unnecessary comparisons in boolean expressions	232
Avoid appending characters as strings in StringBuffer.append.	233
Avoid unnecessary comparisons in boolean expressions	234
Avoid unnecessary comparisons in boolean expressions	236
Avoid using final local variables, turn them into fields	243
Prefer StringBuffer over += for concatenating strings	245
Prefer StringBuffer over += for concatenating strings	246
Avoid using final local variables, turn them into fields	247
Avoid using final local variables, turn them into fields	248
Avoid using final local variables, turn them into fields	253
Avoid unnecessary comparisons in boolean expressions	254
Avoid unnecessary comparisons in boolean expressions	257
Avoid unnecessary comparisons in boolean expressions	259
Returning 'BOOKMARKABLE_SELECT_PROPERTIES' may expose an internal array.	307

org/projectforge/web/address/SendSmsForm.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	86
Avoid using final local variables, turn them into fields	100 - 120
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	126 - 127
Avoid using final local variables, turn them into fields	137
Avoid using final local variables, turn them into fields	142 - 151
Avoid using final local variables, turn them into fields	153 - 154
Avoid using final local variables, turn them into fields	157 - 163
Avoid using final local variables, turn them into fields	165 - 166
Avoid using final local variables, turn them into fields	179 - 195

org/projectforge/web/address/SendSmsPage.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'form' could be made final; it is only initialized in the declaration or constructor.	69
Avoid using final local variables, turn them into fields	81 - 93
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	120
Avoid unnecessary comparisons in boolean expressions	129
Avoid using final local variables, turn them into fields	161 - 162
Avoid unnecessary comparisons in boolean expressions	163
Avoid using final local variables, turn them into fields	168
Prefer StringBuffer over += for concatenating strings	170
Prefer StringBuffer over += for concatenating strings	171
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	177
Avoid unnecessary comparisons in boolean expressions	180
This call to String.startsWith can be rewritten using String.charAt(0)	180
Avoid unnecessary comparisons in boolean expressions	183
This call to String.startsWith can be rewritten using String.charAt(0)	183
Avoid unnecessary comparisons in boolean expressions	185
This call to String.startsWith can be rewritten using String.charAt(0)	185
Avoid unnecessary comparisons in boolean expressions	187
This call to String.startsWith can be rewritten using String.charAt(0)	187
Returning 'BOOKMARKABLE_SELECT_PROPERTIES' may expose an internal array.	230

org/projectforge/web/admin/AdminForm.java

Violation	Line
Perhaps 'gridBuilder' could be replaced by a local variable.	70
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	91 - 92
Avoid using final local variables, turn them into fields	109 - 110
Avoid using final local variables, turn them into fields	120 - 121
Avoid unnecessary comparisons in boolean expressions	137
Avoid using final local variables, turn them into fields	138 - 139
Avoid using final local variables, turn them into fields	158
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	190
Avoid using final local variables, turn them into fields	198 - 199
Avoid using final local variables, turn them into fields	209 - 210
Avoid using final local variables, turn them into fields	227
Avoid using final local variables, turn them into fields	228 - 234
Avoid using final local variables, turn them into fields	247 - 248
Avoid using final local variables, turn them into fields	254
Avoid using final local variables, turn them into fields	255
Avoid unnecessary comparisons in boolean expressions	273
Avoid using final local variables, turn them into fields	275
Avoid using final local variables, turn them into fields	276 - 282
Avoid using final local variables, turn them into fields	290
Avoid using final local variables, turn them into fields	291 - 292
Avoid using final local variables, turn them into fields	298
Avoid using final local variables, turn them into fields	308
Avoid using final local variables, turn them into fields	309 - 315
An empty method in an abstract class should be abstract instead	351 - 354
An empty method in an abstract class should be abstract instead	358 - 361

org/projectforge/web/admin/AdminPage.java

Violation	Line
Avoid using final local variables, turn them into fields	128
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	144
Avoid using final local variables, turn them into fields	145
Prefer StringBuffer over += for concatenating strings	155
Prefer StringBuffer over += for concatenating strings	157
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	186
StringBuffer constructor is initialized with size 16, but has at least 220 characters appended.	186
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	188
Avoid using final local variables, turn them into fields	189
Avoid using final local variables, turn them into fields	190
Avoid using final local variables, turn them into fields	191
Avoid using final local variables, turn them into fields	196
Avoid unnecessary comparisons in boolean expressions	208
Avoid unnecessary comparisons in boolean expressions	220
Avoid unnecessary comparisons in boolean expressions	228
Avoid unnecessary comparisons in boolean expressions	233
Avoid unnecessary comparisons in boolean expressions	233
Avoid unnecessary comparisons in boolean expressions	233
No need to call String.valueOf to append to a string.	234
Avoid concatenating nonliterals in a StringBuffer constructor or append().	239
Avoid using final local variables, turn them into fields	243
Avoid unnecessary comparisons in boolean expressions	249
Avoid using final local variables, turn them into fields	265
Avoid using final local variables, turn them into fields	266
Avoid using final local variables, turn them into fields	274
Avoid using final local variables, turn them into fields	275
Avoid using final local variables, turn them into fields	276
Avoid using final local variables, turn them into fields	286
Avoid using final local variables, turn them into fields	287
Avoid using final local variables, turn them into fields	295
Avoid using final local variables, turn them into fields	296
Avoid unnecessary comparisons in boolean expressions	308
Avoid using final local variables, turn them into fields	310
Avoid unnecessary comparisons in boolean expressions	321
Avoid using final local variables, turn them into fields	337
Avoid using final local variables, turn them into fields	339
Avoid using final local variables, turn them into fields	379
Avoid using final local variables, turn them into fields	380
Avoid using final local variables, turn them into fields	381
Avoid using final local variables, turn them into fields	382
Avoid using final local variables, turn them into fields	390
Avoid using final local variables, turn them into fields	402
Avoid using final local variables, turn them into fields	416
Avoid using final local variables, turn them into fields	417
Avoid instantiating new objects inside loops	423
Avoid using final local variables, turn them into fields	440
Avoid using final local variables, turn them into fields	447

org/projectforge/web/admin/SetupForm.java

Violation	Line
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	98
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	103
Avoid using final local variables, turn them into fields	106 - 107
Avoid instantiating new objects inside loops	110
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	131
Avoid using final local variables, turn them into fields	144
Avoid using final local variables, turn them into fields	145 - 146
Avoid using final local variables, turn them into fields	152
Avoid using final local variables, turn them into fields	153
Avoid unnecessary comparisons in boolean expressions	154
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	184 - 190
Avoid using final local variables, turn them into fields	191 - 192

org/projectforge/web/admin/SetupImportForm.java

Violation	Line
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	58
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	67
Avoid using final local variables, turn them into fields	70 - 76
Avoid using final local variables, turn them into fields	77 - 78

org/projectforge/web/admin/SetupPage.java

Violation	Line
Avoid using final local variables, turn them into fields	109
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	140
Avoid unnecessary comparisons in boolean expressions	149
Avoid using final local variables, turn them into fields	152
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	168
Avoid unnecessary comparisons in boolean expressions	170
Avoid unnecessary comparisons in boolean expressions	172
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	180
Avoid unnecessary comparisons in boolean expressions	212

org/projectforge/web/admin/SystemUpdateForm.java

Violation	Line
Perhaps 'gridBuilder' could be replaced by a local variable.	57
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	81 - 100
Avoid using final local variables, turn them into fields	112 - 118
Avoid using final local variables, turn them into fields	119 - 120
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	132
Avoid unnecessary comparisons in boolean expressions	138
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	142
Avoid instantiating new objects inside loops	142
Avoid unnecessary comparisons in boolean expressions	144
Avoid instantiating new objects inside loops	150
Avoid instantiating new objects inside loops	151
Avoid using final local variables, turn them into fields	152
Avoid unnecessary comparisons in boolean expressions	153
Avoid instantiating new objects inside loops	153
Avoid instantiating new objects inside loops	154
Avoid instantiating new objects inside loops	155 - 162
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	164 - 170
Avoid instantiating new objects inside loops	164 - 170
Avoid instantiating new objects inside loops	171
Avoid instantiating new objects inside loops	173 - 180
Avoid using final local variables, turn them into fields	177

org/projectforge/web/admin/SystemUpdatePage.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'refresh' called during object construction	57
Avoid unnecessary comparisons in boolean expressions	77

org/projectforge/web/admin/TaskWizardForm.java

Violation	Line
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	77
No need to call String.valueOf to append to a string.	78
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	80 - 81
Avoid using final local variables, turn them into fields	85 - 95
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	108
Avoid unnecessary comparisons in boolean expressions	117
Avoid using final local variables, turn them into fields	134 - 146
Avoid using final local variables, turn them into fields	147 - 148
Avoid using final local variables, turn them into fields	156
No need to call String.valueOf to append to a string.	157
Avoid using final local variables, turn them into fields	160
Avoid using final local variables, turn them into fields	161 - 162
Avoid using final local variables, turn them into fields	165 - 192
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	171
Avoid unnecessary comparisons in boolean expressions	175
Avoid using final local variables, turn them into fields	182
Avoid using final local variables, turn them into fields	194 - 195

org/projectforge/web/admin/TaskWizardPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	68
Avoid using final local variables, turn them into fields	72
Avoid unnecessary comparisons in boolean expressions	83
Avoid unnecessary comparisons in boolean expressions	92
Avoid unnecessary comparisons in boolean expressions	96
Avoid unnecessary comparisons in boolean expressions	126
Avoid unnecessary comparisons in boolean expressions	128
Avoid unnecessary comparisons in boolean expressions	130
Avoid unnecessary comparisons in boolean expressions	140
Avoid unnecessary comparisons in boolean expressions	142
Avoid unnecessary comparisons in boolean expressions	144
Avoid unnecessary comparisons in boolean expressions	165

org/projectforge/web/book/BookEditForm.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	74
Avoid using final local variables, turn them into fields	98
Avoid using final local variables, turn them into fields	99
Avoid using final local variables, turn them into fields	100
Avoid using final local variables, turn them into fields	101
Avoid using final local variables, turn them into fields	102
Avoid unnecessary comparisons in boolean expressions	103
Avoid unnecessary comparisons in boolean expressions	104
Avoid unnecessary comparisons in boolean expressions	105
Avoid unnecessary comparisons in boolean expressions	106
Avoid unnecessary comparisons in boolean expressions	107
Avoid using final local variables, turn them into fields	116
Avoid using final local variables, turn them into fields	117 - 118
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	125
Avoid using final local variables, turn them into fields	131
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	133 - 134
Avoid using final local variables, turn them into fields	140
Avoid using final local variables, turn them into fields	141 - 142
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	148 - 149
Avoid using final local variables, turn them into fields	150 - 151
Avoid using final local variables, turn them into fields	157
Avoid using final local variables, turn them into fields	158
Avoid unnecessary comparisons in boolean expressions	166
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	186
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	192
Avoid using final local variables, turn them into fields	193
Avoid using final local variables, turn them into fields	199
Avoid using final local variables, turn them into fields	204
Avoid unnecessary comparisons in boolean expressions	207
Avoid using final local variables, turn them into fields	210
Avoid using final local variables, turn them into fields	221
Avoid using final local variables, turn them into fields	267

org/projectforge/web/book/BookEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	75
Avoid unnecessary comparisons in boolean expressions	87

org/projectforge/web/book/BookListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	90 - 160
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	117
Consider simply returning the value vs storing it in local variable 'list'	118

org/projectforge/web/book/BookListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	81 - 90
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	100
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	123
Avoid appending characters as strings in StringBuffer.append.	126
Avoid unnecessary comparisons in boolean expressions	129
Avoid appending characters as strings in StringBuffer.append.	130
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	133

org/projectforge/web/calendar/CalendarFeed.java

Violation	Line
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	93
Avoid printStackTrace(); use a logger call instead.	97
Avoid using final local variables, turn them into fields	111
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	121 - 122
Avoid using final local variables, turn them into fields	125
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	157
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	173
Avoid instantiating new objects inside loops	173
Avoid using final local variables, turn them into fields	175
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	181
Avoid instantiating new objects inside loops	181
Avoid instantiating new objects inside loops	182
Avoid instantiating new objects inside loops	183
Avoid using final local variables, turn them into fields	199

org/projectforge/web/calendar/CalendarFilter.java

Violation	Line
Perhaps 'current' could be replaced by a local variable.	54

org/projectforge/web/calendar/CalendarForm.java

Violation	Line
Perhaps 'gridBuilder' could be replaced by a local variable.	59
Avoid using final local variables, turn them into fields	72
Avoid unnecessary comparisons in boolean expressions	79
Avoid using final local variables, turn them into fields	80 - 81
Avoid using final local variables, turn them into fields	85
Avoid unnecessary comparisons in boolean expressions	86
Avoid unnecessary comparisons in boolean expressions	96
Avoid using final local variables, turn them into fields	112 - 123
Avoid using final local variables, turn them into fields	130 - 136
Avoid using final local variables, turn them into fields	176

org/projectforge/web/calendar/CalendarPage.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'init' called during object construction	49
Avoid unnecessary comparisons in boolean expressions	67
Avoid unnecessary comparisons in boolean expressions	70
Avoid unnecessary comparisons in boolean expressions	113
Avoid unnecessary comparisons in boolean expressions	122

org/projectforge/web/calendar/CalendarPanel.java

Violation	Line
Perhaps 'holidayEventsProvider' could be replaced by a local variable.	84
Avoid using final local variables, turn them into fields	103
Avoid unnecessary comparisons in boolean expressions	114
Avoid using final local variables, turn them into fields	117
Avoid using final local variables, turn them into fields	123
Avoid unnecessary comparisons in boolean expressions	136
Avoid unnecessary comparisons in boolean expressions	157
Avoid unnecessary comparisons in boolean expressions	174
Avoid using final local variables, turn them into fields	177
Avoid unnecessary comparisons in boolean expressions	178
Avoid using final local variables, turn them into fields	180
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	183
Avoid unnecessary comparisons in boolean expressions	188
Avoid using final local variables, turn them into fields	190
Avoid using final local variables, turn them into fields	191
Avoid using final local variables, turn them into fields	193
Avoid unnecessary comparisons in boolean expressions	204
Avoid unnecessary comparisons in boolean expressions	250
Avoid using final local variables, turn them into fields	261
Avoid unnecessary comparisons in boolean expressions	262
Avoid using final local variables, turn them into fields	264
Avoid using final local variables, turn them into fields	265
Avoid using final local variables, turn them into fields	269
Avoid using final local variables, turn them into fields	271
Avoid using final local variables, turn them into fields	272
Avoid using final local variables, turn them into fields	279
Avoid unnecessary comparisons in boolean expressions	280
Avoid using final local variables, turn them into fields	284
Avoid using final local variables, turn them into fields	292
Avoid using final local variables, turn them into fields	306
Avoid unnecessary comparisons in boolean expressions	313
Avoid using final local variables, turn them into fields	323
Avoid unnecessary comparisons in boolean expressions	324

org/projectforge/web/calendar/DateTimeFormatter.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	43
Avoid using final local variables, turn them into fields	66
When instantiating a SimpleDateFormat object, specify a Locale	114
Avoid using final local variables, turn them into fields	114
When instantiating a SimpleDateFormat object, specify a Locale	162
Avoid using final local variables, turn them into fields	162
Avoid using final local variables, turn them into fields	189
Avoid using final local variables, turn them into fields	230
Avoid using final local variables, turn them into fields	231
Avoid using final local variables, turn them into fields	232
Avoid unnecessary comparisons in boolean expressions	234
Avoid appending characters as strings in StringBuffer.append.	235
Avoid using final local variables, turn them into fields	249
Avoid using final local variables, turn them into fields	250
Avoid appending characters as strings in StringBuffer.append.	252
Avoid appending characters as strings in StringBuffer.append.	254
Avoid appending characters as strings in StringBuffer.append.	263
Avoid using final local variables, turn them into fields	285
Avoid unnecessary comparisons in boolean expressions	286
Avoid appending characters as strings in StringBuffer.append.	294
Avoid unnecessary comparisons in boolean expressions	298
Avoid appending characters as strings in StringBuffer.append.	301
Avoid appending characters as strings in StringBuffer.append.	304
Avoid using final local variables, turn them into fields	306
Avoid unnecessary comparisons in boolean expressions	307
Avoid unnecessary comparisons in boolean expressions	308
Avoid appending characters as strings in StringBuffer.append.	313
Avoid unnecessary comparisons in boolean expressions	320
Avoid appending characters as strings in StringBuffer.append.	335
Avoid appending characters as strings in StringBuffer.append.	346

org/projectforge/web/calendar/HolidayEventsProvider.java

Violation	Line
Avoid using final local variables, turn them into fields	66
Avoid instantiating new objects inside loops	66
Avoid unnecessary comparisons in boolean expressions	68
Avoid unnecessary comparisons in boolean expressions	69
Avoid using final local variables, turn them into fields	83
Avoid instantiating new objects inside loops	83
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	88
Avoid unnecessary comparisons in boolean expressions	89
Avoid unnecessary comparisons in boolean expressions	100

org/projectforge/web/calendar/MyFullCalendarConfig.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setAllDayText' called during object construction	79
Avoid using final local variables, turn them into fields	81
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setDayNames' called during object construction	82
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setDayNamesShort' called during object construction	83
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setMonthNames' called during object construction	84
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setMonthNamesShort' called during object construction	85
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setWeekMode' called during object construction	86
Returning 'dayNames' may expose an internal array.	246

org/projectforge/web/calendar/MyFullCalendarEventsProvider.java

Violation	Line
An empty method in an abstract class should be abstract instead	75 - 89
Avoid unnecessary comparisons in boolean expressions	79
Avoid unnecessary comparisons in boolean expressions	80
Avoid using final local variables, turn them into fields	94
An empty method in an abstract class should be abstract instead	101 - 104

org/projectforge/web/calendar/QuickSelectMonthPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'selectProperty' could be made final; it is only initialized in the declaration or constructor.	50
Avoid using final local variables, turn them into fields	70 - 79
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	86 - 94
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	101 - 109
Avoid using final local variables, turn them into fields	104

org/projectforge/web/calendar/QuickSelectPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'datePanel' could be made final; it is only initialized in the declaration or constructor.	43
KONSTANTHEIT_VERSTECKTE: Private field 'caller' could be made final; it is only initialized in the declaration or constructor.	45
Avoid using final local variables, turn them into fields	64 - 72
Avoid using final local variables, turn them into fields	69
Consider simply returning the value vs storing it in local variable 'date'	70
Avoid using final local variables, turn them into fields	75 - 83
Avoid using final local variables, turn them into fields	80
Consider simply returning the value vs storing it in local variable 'date'	81

org/projectforge/web/calendar/QuickSelectWeekPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'selectProperty' could be made final; it is only initialized in the declaration or constructor.	50
Avoid using final local variables, turn them into fields	70 - 79
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	86 - 94
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	101 - 109
Avoid using final local variables, turn them into fields	104

org/projectforge/web/common/DateInputField.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'utcMillis' could be declared final	135

org/projectforge/web/common/PhoneNumberValidator.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	38

org/projectforge/web/common/TwoListHelper.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'originalAssignedList' could be made final; it is only initialized in the declaration or constructor.	49
Avoid unnecessary comparisons in boolean expressions	62
Avoid using final local variables, turn them into fields	84
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	107
Avoid unnecessary comparisons in boolean expressions	109
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	121
Avoid unnecessary comparisons in boolean expressions	123
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	135
KONSTANTHEIT_VERSTECKTE: Local variable 'iterator' could be declared final	138
KONSTANTHEIT_VERSTECKTE: Local variable 'entry' could be declared final	140
Avoid unnecessary comparisons in boolean expressions	141
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	153
KONSTANTHEIT_VERSTECKTE: Local variable 'iterator' could be declared final	156
KONSTANTHEIT_VERSTECKTE: Local variable 'entry' could be declared final	158
Avoid unnecessary comparisons in boolean expressions	159
StringBuffer constructor is initialized with size 43, but has at least 45 characters appended.	171
KONSTANTHEIT_VERSTECKTE: Local variable 'sb' could be declared final	171
Avoid appending characters as strings in StringBuffer.append.	175
KONSTANTHEIT_VERSTECKTE: Local variable 'sb' could be declared final	182
Avoid appending characters as strings in StringBuffer.append.	184
Avoid appending characters as strings in StringBuffer.append.	191
Avoid unnecessary comparisons in boolean expressions	194
Avoid appending characters as strings in StringBuffer.append.	199

org/projectforge/web/core/AbstractFormatter.java

Violation	Line
This abstract class does not have any abstract methods	29 - 35
An empty method in an abstract class should be abstract instead	31 - 34

org/projectforge/web/core/ConfigurationEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	104
Avoid using final local variables, turn them into fields	105 - 106
Avoid using final local variables, turn them into fields	115 - 116
Avoid using final local variables, turn them into fields	125

org/projectforge/web/core/ConfigurationEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	97
Avoid unnecessary comparisons in boolean expressions	110

org/projectforge/web/core/ConfigurationListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	75 - 84
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	103
Avoid using final local variables, turn them into fields	104
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	125

org/projectforge/web/core/DummyPageContext.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'request' could be made final; it is only initialized in the declaration or constructor.	51
KONSTANTHEIT_VERSTECKTE: Private field 'response' could be made final; it is only initialized in the declaration or constructor.	53

org/projectforge/web/core/ImageDimension.java

Violation	Line
Avoid using final local variables, turn them into fields	100

org/projectforge/web/core/JsonBuilder.java

Violation	Line
Avoid using final local variables, turn them into fields	50
Avoid unnecessary comparisons in boolean expressions	75
Avoid unnecessary comparisons in boolean expressions	78
Avoid unnecessary comparisons in boolean expressions	116

org/projectforge/web/core/LogoServlet.java

Violation	Line
Avoid using final local variables, turn them into fields	63
Avoid unnecessary comparisons in boolean expressions	64
Avoid unnecessary comparisons in boolean expressions	66
Avoid unnecessary comparisons in boolean expressions	68
Avoid unnecessary comparisons in boolean expressions	68
Avoid unnecessary comparisons in boolean expressions	79
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	84
Avoid unnecessary comparisons in boolean expressions	85

org/projectforge/web/core/NavAbstractPanel.java

Violation	Line
An empty method in an abstract class should be abstract instead	65 - 86
Avoid using final local variables, turn them into fields	67
Avoid unnecessary comparisons in boolean expressions	68
Avoid using final local variables, turn them into fields	72
Avoid unnecessary comparisons in boolean expressions	78
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	83
An empty method in an abstract class should be abstract instead	88 - 101
Avoid using final local variables, turn them into fields	90
An empty method in an abstract class should be abstract instead	103 - 124
Avoid unnecessary comparisons in boolean expressions	116

org/projectforge/web/core/NavSidePanel.java

Violation	Line
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	59
Avoid instantiating new objects inside loops	59
Avoid instantiating new objects inside loops	61
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	65
Avoid instantiating new objects inside loops	65
Avoid unnecessary comparisons in boolean expressions	67
Avoid using final local variables, turn them into fields	72
Avoid instantiating new objects inside loops	72
Avoid using final local variables, turn them into fields	79
Avoid instantiating new objects inside loops	79
Avoid using final local variables, turn them into fields	81

org/projectforge/web/core/NavTopPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	77 - 87
Avoid using final local variables, turn them into fields	88 - 95
Avoid using final local variables, turn them into fields	97
Avoid unnecessary comparisons in boolean expressions	100
Avoid using final local variables, turn them into fields	109 - 119
Avoid using final local variables, turn them into fields	128
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	134
Avoid instantiating new objects inside loops	134
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	139
Avoid instantiating new objects inside loops	139
Avoid unnecessary comparisons in boolean expressions	141
Avoid using final local variables, turn them into fields	146
Avoid instantiating new objects inside loops	146
Avoid using final local variables, turn them into fields	150
Avoid instantiating new objects inside loops	150
Avoid using final local variables, turn them into fields	152
Avoid using final local variables, turn them into fields	155
Avoid instantiating new objects inside loops	155
Avoid unnecessary comparisons in boolean expressions	157
Avoid using final local variables, turn them into fields	161
Avoid instantiating new objects inside loops	161
Avoid using final local variables, turn them into fields	165
Avoid instantiating new objects inside loops	165
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	182
Avoid using final local variables, turn them into fields	185
Avoid using final local variables, turn them into fields	187
Avoid unnecessary comparisons in boolean expressions	188
Avoid using final local variables, turn them into fields	194 - 210
Avoid using final local variables, turn them into fields	212 - 213

org/projectforge/web/core/PriorityFormatter.java

Violation	Line
StringBuffer constructor is initialized with size 16, but has at least 22 characters appended.	47
KONSTANTHEIT_VERSTECKTE: Local variable 'buf' could be declared final	47
Avoid appending characters as strings in StringBuffer.append.	50

org/projectforge/web/core/ResponseUtils.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 90
Avoid using final local variables, turn them into fields	83
Avoid unnecessary comparisons in boolean expressions	84

org/projectforge/web/core/SearchAreaPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	78 - 79
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	85 - 86
Avoid unnecessary comparisons in boolean expressions	89
Avoid using final local variables, turn them into fields	95
Avoid unnecessary comparisons in boolean expressions	96
Avoid using final local variables, turn them into fields	103
Avoid unnecessary comparisons in boolean expressions	104
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	119 - 132
Avoid unnecessary comparisons in boolean expressions	134
Avoid using final local variables, turn them into fields	139

org/projectforge/web/core/SearchForm.java

Violation	Line
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	82
Avoid using final local variables, turn them into fields	87
Avoid using final local variables, turn them into fields	88 - 89
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	97 - 98
Avoid using final local variables, turn them into fields	101 - 102
Avoid using final local variables, turn them into fields	112
Avoid instantiating new objects inside loops	116
Avoid using final local variables, turn them into fields	119 - 151
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	158
Avoid using final local variables, turn them into fields	159 - 160
Avoid using final local variables, turn them into fields	166
Avoid using final local variables, turn them into fields	168
Avoid unnecessary comparisons in boolean expressions	170
Avoid using final local variables, turn them into fields	176 - 183
Avoid using final local variables, turn them into fields	190
Avoid using final local variables, turn them into fields	191 - 192
Avoid using final local variables, turn them into fields	196 - 202
Avoid using final local variables, turn them into fields	204 - 205
Avoid using final local variables, turn them into fields	208
Avoid using final local variables, turn them into fields	209 - 210
Avoid unnecessary comparisons in boolean expressions	218
Avoid unnecessary comparisons in boolean expressions	219
Avoid unnecessary comparisons in boolean expressions	220

org/projectforge/web/core/SearchPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	76
Avoid using final local variables, turn them into fields	77
Avoid unnecessary comparisons in boolean expressions	79
Avoid using final local variables, turn them into fields	80
Avoid unnecessary comparisons in boolean expressions	89
Avoid unnecessary comparisons in boolean expressions	112
Avoid unnecessary comparisons in boolean expressions	118
Avoid unnecessary comparisons in boolean expressions	121
Avoid unnecessary comparisons in boolean expressions	123
Avoid using final local variables, turn them into fields	128
Avoid using final local variables, turn them into fields	148

org/projectforge/web/core/SessionStorage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	51
Avoid using final local variables, turn them into fields	66
Avoid unnecessary comparisons in boolean expressions	69
Avoid unnecessary comparisons in boolean expressions	84
Avoid unnecessary comparisons in boolean expressions	98
Avoid using final local variables, turn them into fields	101
Avoid using final local variables, turn them into fields	103
Avoid unnecessary comparisons in boolean expressions	104
Avoid unnecessary comparisons in boolean expressions	108
Avoid using final local variables, turn them into fields	108
Avoid unnecessary comparisons in boolean expressions	111

org/projectforge/web/debug/SessionSerializableChecker.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	59
Avoid unnecessary comparisons in boolean expressions	76
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	98

org/projectforge/web/doc/DocumentationPage.java

Violation	Line
Avoid using final local variables, turn them into fields	48
Avoid using final local variables, turn them into fields	56
Avoid unnecessary comparisons in boolean expressions	57
Avoid using final local variables, turn them into fields	57
Avoid unnecessary comparisons in boolean expressions	61
Avoid using final local variables, turn them into fields	77

org/projectforge/web/doc/TutorialFilter.java

Violation	Line
Avoid using final local variables, turn them into fields	65
Avoid unnecessary comparisons in boolean expressions	66
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	71
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	78
StringBuffer constructor is initialized with size 16, but has at least 171 characters appended.	78
Avoid unnecessary comparisons in boolean expressions	81
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	103
KONSTANTHEIT_VERSTECKTE: Private field 'output' could be made final; it is only initialized in the declaration or constructor.	129

org/projectforge/web/doc/TutorialPage.java

Violation	Line
Perhaps 'type' could be replaced by a local variable.	91
Avoid unnecessary comparisons in boolean expressions	118
Avoid unnecessary comparisons in boolean expressions	120
Avoid unnecessary comparisons in boolean expressions	122
Avoid unnecessary comparisons in boolean expressions	124
Avoid using final local variables, turn them into fields	134
Avoid unnecessary comparisons in boolean expressions	135
Avoid using final local variables, turn them into fields	138
Avoid unnecessary comparisons in boolean expressions	140
Avoid unnecessary comparisons in boolean expressions	143
Avoid unnecessary comparisons in boolean expressions	145
Avoid using final local variables, turn them into fields	152
Avoid unnecessary comparisons in boolean expressions	163
Avoid using final local variables, turn them into fields	173
TOTE_PARAMETER: Avoid unused method parameters such as 'user'.	182 - 188
TOTE_PARAMETER: Avoid unused method parameters such as 'groups'.	182 - 188
Avoid using final local variables, turn them into fields	184
Avoid using final local variables, turn them into fields	185
Avoid using final local variables, turn them into fields	192
Avoid unnecessary comparisons in boolean expressions	193
Avoid using final local variables, turn them into fields	196
Avoid unnecessary comparisons in boolean expressions	197
Avoid unnecessary comparisons in boolean expressions	199
Avoid using final local variables, turn them into fields	206
Avoid using final local variables, turn them into fields	212
Avoid using final local variables, turn them into fields	221
Avoid unnecessary comparisons in boolean expressions	222
Avoid using final local variables, turn them into fields	225
Avoid unnecessary comparisons in boolean expressions	226
Avoid unnecessary comparisons in boolean expressions	228
Avoid using final local variables, turn them into fields	237
TOTE_METHODEN: Avoid unused private methods such as 'createGroup(String,String)'.	242
Avoid using final local variables, turn them into fields	244
Avoid using final local variables, turn them into fields	248
Avoid using final local variables, turn them into fields	260
Avoid unnecessary comparisons in boolean expressions	261
Avoid using final local variables, turn them into fields	264
Avoid unnecessary comparisons in boolean expressions	267
Avoid unnecessary comparisons in boolean expressions	271
Avoid using final local variables, turn them into fields	283
Avoid using final local variables, turn them into fields	289
Avoid unnecessary comparisons in boolean expressions	292
Avoid using final local variables, turn them into fields	301
Avoid using final local variables, turn them into fields	321
Avoid using final local variables, turn them into fields	328
Avoid using final local variables, turn them into fields	330
Avoid unnecessary comparisons in boolean expressions	331
Avoid using final local variables, turn them into fields	339
Avoid using final local variables, turn them into fields	348
Avoid using final local variables, turn them into fields	357

org/projectforge/web/fibu/AbstractRechnungEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	127
Avoid using final local variables, turn them into fields	128
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	131
Avoid using final local variables, turn them into fields	133
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	143
Avoid using final local variables, turn them into fields	152
Avoid using final local variables, turn them into fields	153
Avoid unnecessary comparisons in boolean expressions	154
Avoid unnecessary comparisons in boolean expressions	180
Avoid unnecessary comparisons in boolean expressions	184
Avoid unnecessary comparisons in boolean expressions	184
Avoid unnecessary comparisons in boolean expressions	184
Avoid using final local variables, turn them into fields	186 - 192
Avoid using final local variables, turn them into fields	204
Avoid using final local variables, turn them into fields	214
Avoid using final local variables, turn them into fields	215 - 221
Avoid using final local variables, turn them into fields	229
Avoid using final local variables, turn them into fields	230 - 236
Avoid using final local variables, turn them into fields	244
Avoid using final local variables, turn them into fields	245 - 251
Avoid using final local variables, turn them into fields	259
Avoid using final local variables, turn them into fields	268
No need to call String.valueOf to append to a string.	270
Avoid using final local variables, turn them into fields	272 - 279
Avoid using final local variables, turn them into fields	303
Avoid using final local variables, turn them into fields	304 - 305
Avoid using final local variables, turn them into fields	312
Avoid using final local variables, turn them into fields	313 - 321
Avoid using final local variables, turn them into fields	330
Avoid using final local variables, turn them into fields	336
Avoid unnecessary comparisons in boolean expressions	340
An empty method in an abstract class should be abstract instead	349 - 352
Avoid using final local variables, turn them into fields	360
Avoid unnecessary comparisons in boolean expressions	361
Avoid using final local variables, turn them into fields	363
Avoid unnecessary comparisons in boolean expressions	370
Avoid using final local variables, turn them into fields	375
Avoid instantiating new objects inside loops	375
Avoid using final local variables, turn them into fields	376
Avoid using final local variables, turn them into fields	377 - 378
Avoid instantiating new objects inside loops	377 - 378
Avoid using final local variables, turn them into fields	381
Avoid instantiating new objects inside loops	381
Avoid instantiating new objects inside loops	383
Avoid instantiating new objects inside loops	384
Avoid instantiating new objects inside loops	386
Avoid using final local variables, turn them into fields	387
Avoid instantiating new objects inside loops	389
Avoid instantiating new objects inside loops	392
Avoid using final local variables, turn them into fields	393
Avoid instantiating new objects inside loops	393
Avoid instantiating new objects inside loops	394 - 395
Avoid instantiating new objects inside loops	396 - 418
Avoid using final local variables, turn them into fields	405
Avoid using final local variables, turn them into fields	407
Avoid instantiating new objects inside loops	422
Avoid using final local variables, turn them into fields	423
Avoid instantiating new objects inside loops	423
Avoid using final local variables, turn them into fields	424 - 425
Avoid instantiating new objects inside loops	424 - 425
Avoid instantiating new objects inside loops	426 - 432
Avoid instantiating new objects inside loops	437
Avoid using final local variables, turn them into fields	438
Avoid instantiating new objects inside loops	438
Avoid using final local variables, turn them into fields	439 - 447
Avoid instantiating new objects inside loops	439 - 447
Avoid instantiating new objects inside loops	448 - 454
Avoid instantiating new objects inside loops	459
Avoid using final local variables, turn them into fields	460
Avoid instantiating new objects inside loops	460
Avoid using final local variables, turn them into fields	461 - 469
Avoid instantiating new objects inside loops	461 - 469
Avoid instantiating new objects inside loops	470 - 476
Avoid instantiating new objects inside loops	481
Avoid instantiating new objects inside loops	482
Avoid using final local variables, turn them into fields	484
Avoid instantiating new objects inside loops	484
Avoid using final local variables, turn them into fields	485 - 491
Avoid instantiating new objects inside loops	485 - 491
Avoid instantiating new objects inside loops	497
Avoid using final local variables, turn them into fields	499 - 500
Avoid instantiating new objects inside loops	499
Avoid using final local variables, turn them into fields	501 - 507
Avoid instantiating new objects inside loops	501 - 507
Avoid instantiating new objects inside loops	513
Avoid using final local variables, turn them into fields	515
Avoid instantiating new objects inside loops	515
Avoid using final local variables, turn them into fields	516 - 522
Avoid instantiating new objects inside loops	516 - 522
Avoid instantiating new objects inside loops	527
Avoid unnecessary comparisons in boolean expressions	530
Avoid instantiating new objects inside loops	531
Avoid instantiating new objects inside loops	533
Avoid using final local variables, turn them into fields	535
Avoid instantiating new objects inside loops	535
Avoid instantiating new objects inside loops	536
Avoid unnecessary comparisons in boolean expressions	539
Avoid instantiating new objects inside loops	542
Avoid instantiating new objects inside loops	544
Avoid using final local variables, turn them into fields	545
Avoid instantiating new objects inside loops	545
Avoid instantiating new objects inside loops	549
Avoid using final local variables, turn them into fields	550
Avoid unnecessary comparisons in boolean expressions	551
Avoid unnecessary comparisons in boolean expressions	553
Avoid using final local variables, turn them into fields	558 - 570
Avoid instantiating new objects inside loops	558 - 570
Avoid instantiating new objects inside loops	572
Avoid instantiating new objects inside loops	574
Avoid unnecessary comparisons in boolean expressions	576
Avoid instantiating new objects inside loops	577
Avoid unnecessary comparisons in boolean expressions	583
Avoid using final local variables, turn them into fields	586 - 600
Avoid using final local variables, turn them into fields	590
Avoid using final local variables, turn them into fields	593
Avoid using final local variables, turn them into fields	601
An empty method in an abstract class should be abstract instead	612 - 615
Avoid using final local variables, turn them into fields	621
Avoid using final local variables, turn them into fields	624
Avoid using final local variables, turn them into fields	626
Avoid using final local variables, turn them into fields	630 - 647
Avoid using final local variables, turn them into fields	649 - 650
Avoid unnecessary comparisons in boolean expressions	653
Avoid using final local variables, turn them into fields	653
Avoid using final local variables, turn them into fields	654 - 676
Avoid using final local variables, turn them into fields	661
Avoid using final local variables, turn them into fields	662
Avoid using final local variables, turn them into fields	677 - 678
An empty method in an abstract class should be abstract instead	706 - 709
An empty method in an abstract class should be abstract instead	715 - 717

org/projectforge/web/fibu/AbstractRechnungListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	63 - 64
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	74 - 75
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	80 - 99
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	137
No need to call String.valueOf to append to a string.	184
No need to call String.valueOf to append to a string.	192
An empty method in an abstract class should be abstract instead	200 - 203
An empty method in an abstract class should be abstract instead	214 - 217
An empty method in an abstract class should be abstract instead	234 - 237

org/projectforge/web/fibu/AccountingRecordEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	71 - 72
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	79 - 80
Avoid using final local variables, turn them into fields	83 - 84
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	91 - 92
Avoid using final local variables, turn them into fields	98 - 99
Avoid using final local variables, turn them into fields	100 - 101
Avoid using final local variables, turn them into fields	104 - 105
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	131 - 132
Avoid using final local variables, turn them into fields	135 - 136
Avoid using final local variables, turn them into fields	142 - 144
Avoid using final local variables, turn them into fields	145 - 146
Avoid using final local variables, turn them into fields	149 - 150
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	157
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	172

org/projectforge/web/fibu/AccountingRecordListForm.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	57
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	66 - 67
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	74 - 75
Avoid using final local variables, turn them into fields	82 - 83
Avoid using final local variables, turn them into fields	87 - 88

org/projectforge/web/fibu/AccountingRecordListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	101
Avoid using final local variables, turn them into fields	127
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	137 - 147
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	142
Avoid using final local variables, turn them into fields	154
Avoid using final local variables, turn them into fields	169
Avoid using final local variables, turn them into fields	182
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	208
Avoid unnecessary comparisons in boolean expressions	245
Avoid using final local variables, turn them into fields	246
Avoid using final local variables, turn them into fields	251
Avoid unnecessary comparisons in boolean expressions	273

org/projectforge/web/fibu/AuftragEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	136 - 137
Avoid unnecessary comparisons in boolean expressions	140
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	148 - 154
Avoid using final local variables, turn them into fields	162
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	177 - 178
Avoid using final local variables, turn them into fields	179 - 180
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	188 - 189
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	205
Avoid using final local variables, turn them into fields	206 - 207
Avoid using final local variables, turn them into fields	214
Avoid using final local variables, turn them into fields	215 - 216
Avoid using final local variables, turn them into fields	222
Avoid using final local variables, turn them into fields	223 - 224
Avoid using final local variables, turn them into fields	232
Avoid using final local variables, turn them into fields	233 - 234
Avoid using final local variables, turn them into fields	242
Avoid using final local variables, turn them into fields	247
Avoid using final local variables, turn them into fields	252
Avoid using final local variables, turn them into fields	253
Avoid using final local variables, turn them into fields	254 - 255
Avoid using final local variables, turn them into fields	268
Avoid unnecessary comparisons in boolean expressions	269
Avoid using final local variables, turn them into fields	275
Avoid using final local variables, turn them into fields	276 - 277
Avoid instantiating new objects inside loops	276 - 277
Avoid using final local variables, turn them into fields	280
Avoid instantiating new objects inside loops	280
Avoid instantiating new objects inside loops	282
Avoid instantiating new objects inside loops	283
Avoid instantiating new objects inside loops	285
Avoid using final local variables, turn them into fields	287
Avoid instantiating new objects inside loops	287
Avoid instantiating new objects inside loops	288
Avoid instantiating new objects inside loops	290
Avoid instantiating new objects inside loops	291
Avoid using final local variables, turn them into fields	294
Avoid instantiating new objects inside loops	294
Avoid using final local variables, turn them into fields	295 - 296
Avoid instantiating new objects inside loops	295 - 296
Avoid using final local variables, turn them into fields	297 - 298
Avoid instantiating new objects inside loops	297 - 298
Avoid instantiating new objects inside loops	303
Avoid using final local variables, turn them into fields	306
Avoid instantiating new objects inside loops	306
Avoid instantiating new objects inside loops	307 - 308
Avoid instantiating new objects inside loops	310
Avoid using final local variables, turn them into fields	313
Avoid instantiating new objects inside loops	313
Avoid instantiating new objects inside loops	314 - 321
Avoid unnecessary comparisons in boolean expressions	322
Avoid instantiating new objects inside loops	326
Avoid instantiating new objects inside loops	327
Avoid using final local variables, turn them into fields	328
Avoid using final local variables, turn them into fields	329
Avoid using final local variables, turn them into fields	332
Avoid instantiating new objects inside loops	332
Avoid unnecessary comparisons in boolean expressions	333
Avoid using final local variables, turn them into fields	334
Avoid instantiating new objects inside loops	334
Avoid instantiating new objects inside loops	341
Avoid using final local variables, turn them into fields	344
Avoid instantiating new objects inside loops	344
Avoid unnecessary comparisons in boolean expressions	345
Avoid instantiating new objects inside loops	346
Avoid unnecessary comparisons in boolean expressions	350
Avoid using final local variables, turn them into fields	351
Avoid instantiating new objects inside loops	352 - 353
Avoid instantiating new objects inside loops	356
Avoid using final local variables, turn them into fields	359
Avoid instantiating new objects inside loops	359
Avoid using final local variables, turn them into fields	360 - 361
Avoid instantiating new objects inside loops	360 - 361
Avoid using final local variables, turn them into fields	362 - 363
Avoid instantiating new objects inside loops	362 - 363
Avoid unnecessary comparisons in boolean expressions	367
Avoid instantiating new objects inside loops	371
Avoid using final local variables, turn them into fields	374
Avoid instantiating new objects inside loops	374
Avoid using final local variables, turn them into fields	375 - 383
Avoid instantiating new objects inside loops	375 - 383
Avoid using final local variables, turn them into fields	389
Avoid instantiating new objects inside loops	389
Avoid instantiating new objects inside loops	390
Avoid unnecessary comparisons in boolean expressions	393
Avoid using final local variables, turn them into fields	395 - 402
Avoid using final local variables, turn them into fields	403

org/projectforge/web/fibu/AuftragEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	62
Avoid unnecessary comparisons in boolean expressions	84
Avoid unnecessary comparisons in boolean expressions	87
Avoid using final local variables, turn them into fields	89
Avoid unnecessary comparisons in boolean expressions	95
Avoid unnecessary comparisons in boolean expressions	97
Avoid unnecessary comparisons in boolean expressions	100
Avoid using final local variables, turn them into fields	101
Avoid using final local variables, turn them into fields	102
Avoid unnecessary comparisons in boolean expressions	111
Avoid unnecessary comparisons in boolean expressions	121
Avoid unnecessary comparisons in boolean expressions	123
Avoid unnecessary comparisons in boolean expressions	125
Avoid unnecessary comparisons in boolean expressions	128
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	162
Avoid unnecessary comparisons in boolean expressions	165
Avoid unnecessary comparisons in boolean expressions	178
Avoid unnecessary comparisons in boolean expressions	188
Avoid unnecessary comparisons in boolean expressions	191
Avoid using final local variables, turn them into fields	199

org/projectforge/web/fibu/AuftragListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	70 - 83
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	93 - 106
Avoid using final local variables, turn them into fields	111
Avoid using final local variables, turn them into fields	116 - 130
Avoid using final local variables, turn them into fields	143

org/projectforge/web/fibu/AuftragListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	101
Avoid using final local variables, turn them into fields	102 - 126
Avoid using final local variables, turn them into fields	105
Avoid unnecessary comparisons in boolean expressions	110
Avoid using final local variables, turn them into fields	110 - 111
Avoid unnecessary comparisons in boolean expressions	111
Avoid using final local variables, turn them into fields	112
Avoid empty if statements	113 - 115
Avoid unnecessary comparisons in boolean expressions	115
Avoid unnecessary comparisons in boolean expressions	117
Avoid unnecessary comparisons in boolean expressions	119
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	147
Avoid appending characters as strings in StringBuffer.append.	149
Avoid using final local variables, turn them into fields	151
Avoid unnecessary comparisons in boolean expressions	152
Avoid using final local variables, turn them into fields	153
Avoid appending characters as strings in StringBuffer.append.	154
Avoid appending characters as strings in StringBuffer.append.	156
Avoid appending characters as strings in StringBuffer.append.	156
Avoid unnecessary comparisons in boolean expressions	160
Avoid unnecessary comparisons in boolean expressions	172
Avoid appending characters as strings in StringBuffer.append.	178
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	214
Avoid using final local variables, turn them into fields	215
Avoid unnecessary comparisons in boolean expressions	216
Avoid using final local variables, turn them into fields	219 - 226
Returning 'MY_BOOKMARKABLE_INITIAL_PROPERTIES' may expose an internal array.	285

org/projectforge/web/fibu/AuftragsPositionFormComponent.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	67
Avoid using final local variables, turn them into fields	70
Avoid unnecessary comparisons in boolean expressions	90
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	120
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	173
Avoid appending characters as strings in StringBuffer.append.	174
Avoid unnecessary comparisons in boolean expressions	186

org/projectforge/web/fibu/BusinessAssessment4Fieldset.java

Violation	Line
Avoid using final local variables, turn them into fields	55 - 60
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	87
Avoid using final local variables, turn them into fields	94 - 103
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	117
Avoid using final local variables, turn them into fields	118 - 131
Avoid using final local variables, turn them into fields	125
An empty method in an abstract class should be abstract instead	136 - 139

org/projectforge/web/fibu/CustomerEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	67
Avoid using final local variables, turn them into fields	68 - 76
Avoid unnecessary comparisons in boolean expressions	79
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	86
Avoid unnecessary comparisons in boolean expressions	88
Avoid unnecessary comparisons in boolean expressions	92
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	95 - 96
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	117
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	119 - 120

org/projectforge/web/fibu/CustomerListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	48

org/projectforge/web/fibu/CustomerListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	77 - 91
Avoid using final local variables, turn them into fields	80
Avoid unnecessary comparisons in boolean expressions	85
Avoid using final local variables, turn them into fields	85 - 86
Avoid unnecessary comparisons in boolean expressions	86
Avoid using final local variables, turn them into fields	101
Avoid unnecessary comparisons in boolean expressions	102
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	127
Avoid using final local variables, turn them into fields	154 - 155
Avoid using final local variables, turn them into fields	156

org/projectforge/web/fibu/CustomerSelectPanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	88
Avoid using final local variables, turn them into fields	95 - 103
Avoid using final local variables, turn them into fields	100
Avoid using final local variables, turn them into fields	105 - 111
Avoid using final local variables, turn them into fields	115 - 127
Avoid using final local variables, turn them into fields	151
Avoid unnecessary comparisons in boolean expressions	158

org/projectforge/web/fibu/DatevImportForm.java

Violation	Line
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	101
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	103 - 113
Avoid using final local variables, turn them into fields	140

org/projectforge/web/fibu/DatevImportPage.java

Violation	Line
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	86
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	150
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	174
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	178
Avoid using final local variables, turn them into fields	181 - 182

org/projectforge/web/fibu/DatevImportStoragePanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	114
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	118
Avoid instantiating new objects inside loops	118
Avoid instantiating new objects inside loops	120
Avoid using final local variables, turn them into fields	121
Avoid instantiating new objects inside loops	121
Avoid instantiating new objects inside loops	126
Avoid using final local variables, turn them into fields	148
Avoid appending characters as strings in StringBuffer.append.	151
Avoid unnecessary comparisons in boolean expressions	152
Avoid appending characters as strings in StringBuffer.append.	153
Avoid using final local variables, turn them into fields	161 - 167
Avoid appending characters as strings in StringBuffer.append.	184
Avoid using final local variables, turn them into fields	198
Avoid unnecessary comparisons in boolean expressions	200
Avoid unnecessary comparisons in boolean expressions	201
Avoid unnecessary comparisons in boolean expressions	209
Avoid unnecessary comparisons in boolean expressions	246
Avoid using final local variables, turn them into fields	269
Avoid using final local variables, turn them into fields	276
Avoid using final local variables, turn them into fields	278
Avoid unnecessary comparisons in boolean expressions	279
Avoid unnecessary comparisons in boolean expressions	279
Avoid using final local variables, turn them into fields	283
Avoid using final local variables, turn them into fields	300
Avoid using final local variables, turn them into fields	304
Avoid using final local variables, turn them into fields	305
Avoid unnecessary comparisons in boolean expressions	306
Avoid unnecessary comparisons in boolean expressions	307
Avoid unnecessary comparisons in boolean expressions	307
Avoid unnecessary comparisons in boolean expressions	308
Avoid unnecessary comparisons in boolean expressions	308
Avoid unnecessary comparisons in boolean expressions	308
Avoid unnecessary comparisons in boolean expressions	308
Avoid empty if statements	309 - 311
Avoid using final local variables, turn them into fields	315
Avoid instantiating new objects inside loops	315
Avoid using final local variables, turn them into fields	319
Avoid unnecessary comparisons in boolean expressions	320
Avoid using final local variables, turn them into fields	327
Avoid instantiating new objects inside loops	327
Avoid using final local variables, turn them into fields	332
Avoid instantiating new objects inside loops	332
Avoid using final local variables, turn them into fields	337
Avoid unnecessary comparisons in boolean expressions	338
Avoid unnecessary comparisons in boolean expressions	340
Avoid instantiating new objects inside loops	345
Avoid using final local variables, turn them into fields	347
Avoid instantiating new objects inside loops	347
Avoid using final local variables, turn them into fields	350
Avoid using final local variables, turn them into fields	354
Avoid using final local variables, turn them into fields	361
Avoid using final local variables, turn them into fields	366
Avoid using final local variables, turn them into fields	373
Avoid instantiating new objects inside loops	373
Avoid appending characters as strings in StringBuffer.append.	377
Avoid appending characters as strings in StringBuffer.append.	378
Avoid unnecessary comparisons in boolean expressions	384
Avoid using final local variables, turn them into fields	385
Avoid instantiating new objects inside loops	385
Avoid appending characters as strings in StringBuffer.append.	390
Avoid using final local variables, turn them into fields	402

org/projectforge/web/fibu/EingangsrechnungEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	73 - 80
Avoid using final local variables, turn them into fields	86
Avoid unnecessary comparisons in boolean expressions	89
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	92 - 93
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	106 - 107
Avoid using final local variables, turn them into fields	108 - 109

org/projectforge/web/fibu/EingangsrechnungEditPage.java

Violation	Line
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	92

org/projectforge/web/fibu/EingangsrechnungListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	40

org/projectforge/web/fibu/EingangsrechnungListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	113
Avoid using final local variables, turn them into fields	114 - 130
Avoid using final local variables, turn them into fields	117
Avoid using final local variables, turn them into fields	118
Avoid empty if statements	119 - 121
Avoid unnecessary comparisons in boolean expressions	119
Avoid unnecessary comparisons in boolean expressions	121
Avoid unnecessary comparisons in boolean expressions	123
Avoid using final local variables, turn them into fields	137
Avoid unnecessary comparisons in boolean expressions	139
Avoid using final local variables, turn them into fields	140
Avoid unnecessary comparisons in boolean expressions	141
Prefer StringBuffer over += for concatenating strings	142
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	160
Avoid using final local variables, turn them into fields	191 - 197
Avoid using final local variables, turn them into fields	204
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	205
Avoid using final local variables, turn them into fields	210 - 214
Avoid using final local variables, turn them into fields	215

org/projectforge/web/fibu/EmployeeEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	66 - 67
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	80 - 81
Avoid using final local variables, turn them into fields	82 - 83
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	100
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	110
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	121

org/projectforge/web/fibu/EmployeeEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	56
Avoid using final local variables, turn them into fields	57
Avoid unnecessary comparisons in boolean expressions	64
Avoid using final local variables, turn them into fields	65

org/projectforge/web/fibu/EmployeeListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	48

org/projectforge/web/fibu/EmployeeListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	75 - 84
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	96
Avoid unnecessary comparisons in boolean expressions	97
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	142

org/projectforge/web/fibu/EmployeeSalaryEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	67
Avoid using final local variables, turn them into fields	68 - 69
Avoid using final local variables, turn them into fields	76 - 77
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	82 - 83
Avoid using final local variables, turn them into fields	87 - 88
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	95 - 96
Avoid using final local variables, turn them into fields	97 - 98
Avoid using final local variables, turn them into fields	104
Avoid using final local variables, turn them into fields	116

org/projectforge/web/fibu/EmployeeSalaryEditPage.java

Violation	Line
Avoid using final local variables, turn them into fields	79
Avoid unnecessary comparisons in boolean expressions	109
Avoid using final local variables, turn them into fields	110

org/projectforge/web/fibu/EmployeeSalaryListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	57
Avoid using final local variables, turn them into fields	59
Avoid using final local variables, turn them into fields	60 - 70
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	79 - 89
Avoid using final local variables, turn them into fields	93

org/projectforge/web/fibu/EmployeeSalaryListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	83 - 93
Avoid using final local variables, turn them into fields	87
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	104
Avoid unnecessary comparisons in boolean expressions	105
Avoid using final local variables, turn them into fields	135
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	136
Avoid using final local variables, turn them into fields	141 - 145
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	153
Avoid using final local variables, turn them into fields	158 - 169
Avoid using final local variables, turn them into fields	170 - 171

org/projectforge/web/fibu/EmployeeSelectPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	105
Consider simply returning the value vs storing it in local variable 'list'	106
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	146
Avoid unnecessary comparisons in boolean expressions	162
Avoid using final local variables, turn them into fields	166
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	173
Avoid using final local variables, turn them into fields	188

org/projectforge/web/fibu/InvoicePositionsPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	69
Avoid unnecessary comparisons in boolean expressions	74
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	79
Avoid instantiating new objects inside loops	79
Avoid using final local variables, turn them into fields	81
Avoid instantiating new objects inside loops	81
Avoid instantiating new objects inside loops	87 - 97
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	99
Avoid using final local variables, turn them into fields	100
Avoid instantiating new objects inside loops	100
Avoid unnecessary comparisons in boolean expressions	102
Avoid instantiating new objects inside loops	103

org/projectforge/web/fibu/KontoEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	60
Avoid using final local variables, turn them into fields	61 - 62
Avoid unnecessary comparisons in boolean expressions	64
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	71 - 72
Avoid using final local variables, turn them into fields	73 - 74
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	82 - 83
Avoid unnecessary comparisons in boolean expressions	85
Avoid using final local variables, turn them into fields	91

org/projectforge/web/fibu/KontoFormComponent.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	55
Avoid using final local variables, turn them into fields	58
Avoid unnecessary comparisons in boolean expressions	80
Avoid using final local variables, turn them into fields	86
Avoid using final local variables, turn them into fields	112
No need to call String.valueOf to append to a string.	116
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	124
No need to call String.valueOf to append to a string.	149

org/projectforge/web/fibu/KontoListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	48

org/projectforge/web/fibu/KontoListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	71
Avoid using final local variables, turn them into fields	72 - 81
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	91
Avoid unnecessary comparisons in boolean expressions	92

org/projectforge/web/fibu/KontoSelectPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	99
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	104
Avoid unnecessary comparisons in boolean expressions	109
Avoid using final local variables, turn them into fields	139
Avoid unnecessary comparisons in boolean expressions	150
Avoid using final local variables, turn them into fields	154
String.indexOf(char) is faster than String.indexOf(String).	154
Avoid using final local variables, turn them into fields	155
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	157
Avoid using final local variables, turn them into fields	176

org/projectforge/web/fibu/Kost1EditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	66
Avoid unnecessary comparisons in boolean expressions	69
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	117
Avoid using final local variables, turn them into fields	118 - 119
Avoid using final local variables, turn them into fields	120 - 121

org/projectforge/web/fibu/Kost1FormComponent.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	73
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	118

org/projectforge/web/fibu/Kost1ListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	49
Avoid using final local variables, turn them into fields	56 - 57

org/projectforge/web/fibu/Kost1ListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	86
Avoid using final local variables, turn them into fields	87 - 96
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	106
Avoid unnecessary comparisons in boolean expressions	107
Avoid using final local variables, turn them into fields	134 - 140
Avoid using final local variables, turn them into fields	141 - 142
Avoid using final local variables, turn them into fields	156
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	157
Avoid using final local variables, turn them into fields	162
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	166
Avoid using final local variables, turn them into fields	167 - 170
Avoid using final local variables, turn them into fields	172

org/projectforge/web/fibu/Kost2ArtEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	66 - 74
Avoid unnecessary comparisons in boolean expressions	75
Avoid using final local variables, turn them into fields	82
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	84 - 85
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	94 - 95
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	113

org/projectforge/web/fibu/Kost2ArtListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	51

org/projectforge/web/fibu/Kost2ArtListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	71 - 80
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	104
Avoid unnecessary comparisons in boolean expressions	105
Avoid using final local variables, turn them into fields	120
Avoid unnecessary comparisons in boolean expressions	121

org/projectforge/web/fibu/Kost2DropDownChoice.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'kost2' could be made final; it is only initialized in the declaration or constructor.	50
Avoid using final local variables, turn them into fields	79
Avoid unnecessary comparisons in boolean expressions	83
An empty method in an abstract class should be abstract instead	97 - 100
Avoid unnecessary comparisons in boolean expressions	106
An empty method in an abstract class should be abstract instead	114 - 117
An empty method in an abstract class should be abstract instead	119 - 125
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	133
Avoid unnecessary comparisons in boolean expressions	137

org/projectforge/web/fibu/Kost2EditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	84 - 85
Avoid using final local variables, turn them into fields	91
Avoid unnecessary comparisons in boolean expressions	94
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	162
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	173 - 174
Avoid using final local variables, turn them into fields	175 - 176

org/projectforge/web/fibu/Kost2EditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	68
Avoid unnecessary comparisons in boolean expressions	84

org/projectforge/web/fibu/Kost2FormComponent.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	73
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	118

org/projectforge/web/fibu/Kost2ListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	46
Avoid using final local variables, turn them into fields	48

org/projectforge/web/fibu/Kost2ListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	97
Avoid using final local variables, turn them into fields	98 - 107
Avoid using final local variables, turn them into fields	101
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	117
Avoid unnecessary comparisons in boolean expressions	118
Avoid using final local variables, turn them into fields	137
Avoid using final local variables, turn them into fields	138
Avoid unnecessary comparisons in boolean expressions	139
Avoid using final local variables, turn them into fields	142
Avoid using final local variables, turn them into fields	171 - 177
Avoid using final local variables, turn them into fields	178 - 179
Avoid using final local variables, turn them into fields	193
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	194
Avoid using final local variables, turn them into fields	199
Avoid using final local variables, turn them into fields	200
Avoid using final local variables, turn them into fields	201
Avoid using final local variables, turn them into fields	203
Avoid using final local variables, turn them into fields	204 - 211
Avoid using final local variables, turn them into fields	213

org/projectforge/web/fibu/Kost2SelectPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	61 - 72
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	74 - 83
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	86
Avoid unnecessary comparisons in boolean expressions	87
Avoid using final local variables, turn them into fields	91 - 103
Avoid unnecessary comparisons in boolean expressions	101
Avoid unnecessary comparisons in boolean expressions	101

org/projectforge/web/fibu/MonthlyEmployeeReportFilter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'date' could be declared final	46

org/projectforge/web/fibu/MonthlyEmployeeReportForm.java

Violation	Line
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	70 - 71
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	110 - 132
Avoid using final local variables, turn them into fields	117
Avoid using final local variables, turn them into fields	137
Avoid using final local variables, turn them into fields	138 - 139
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	162
Avoid using final local variables, turn them into fields	168

org/projectforge/web/fibu/MonthlyEmployeeReportPage.java

Violation	Line
Perhaps 'gridBuilder' could be replaced by a local variable.	109
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	130 - 136
Avoid using final local variables, turn them into fields	139
Avoid unnecessary comparisons in boolean expressions	142
Avoid using final local variables, turn them into fields	142
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	153
Avoid unnecessary comparisons in boolean expressions	158
Avoid using final local variables, turn them into fields	160
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	178
Avoid using final local variables, turn them into fields	189 - 199
Avoid using final local variables, turn them into fields	231
Avoid unnecessary comparisons in boolean expressions	233
Avoid using final local variables, turn them into fields	242
Avoid instantiating new objects inside loops	245 - 248
Avoid using final local variables, turn them into fields	250
Avoid using final local variables, turn them into fields	254
Avoid instantiating new objects inside loops	254
Avoid using final local variables, turn them into fields	261
Avoid using final local variables, turn them into fields	262
Avoid using final local variables, turn them into fields	265
Avoid instantiating new objects inside loops	265
Avoid using final local variables, turn them into fields	268
Avoid instantiating new objects inside loops	269
Avoid instantiating new objects inside loops	271
Avoid using final local variables, turn them into fields	275
Avoid instantiating new objects inside loops	275
Avoid using final local variables, turn them into fields	282
Avoid using final local variables, turn them into fields	284
Avoid instantiating new objects inside loops	284
Avoid using final local variables, turn them into fields	287
Avoid instantiating new objects inside loops	288
Avoid instantiating new objects inside loops	290
Avoid using final local variables, turn them into fields	294
Avoid using final local variables, turn them into fields	303
Avoid instantiating new objects inside loops	306
Avoid using final local variables, turn them into fields	317
Avoid using final local variables, turn them into fields	319 - 336
Avoid using final local variables, turn them into fields	323
Avoid using final local variables, turn them into fields	340
Avoid using final local variables, turn them into fields	341
Avoid using final local variables, turn them into fields	342
Avoid using final local variables, turn them into fields	370
Avoid appending characters as strings in StringBuffer.append.	371
Avoid using final local variables, turn them into fields	372
Avoid appending characters as strings in StringBuffer.append.	373
Avoid appending characters as strings in StringBuffer.append.	373
Avoid using final local variables, turn them into fields	375
Avoid using final local variables, turn them into fields	378
Avoid using final local variables, turn them into fields	379
Avoid using final local variables, turn them into fields	382
Avoid using final local variables, turn them into fields	393
Avoid using final local variables, turn them into fields	406
Avoid unnecessary comparisons in boolean expressions	425
Avoid using final local variables, turn them into fields	426
Avoid unnecessary comparisons in boolean expressions	433
Avoid using final local variables, turn them into fields	434

org/projectforge/web/fibu/NewCustomerSelectPanel.java

Violation	Line
TOTE_PARAMETER: Avoid unused constructor parameters such as 'label'.	96 - 186
Avoid using final local variables, turn them into fields	104
Avoid using final local variables, turn them into fields	107
Consider simply returning the value vs storing it in local variable 'list'	108
Avoid using final local variables, turn them into fields	138
Avoid unnecessary comparisons in boolean expressions	156
Avoid using final local variables, turn them into fields	160
Avoid using final local variables, turn them into fields	161
Avoid unused local variables such as 'customername'.	161
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	204 - 219
Avoid using final local variables, turn them into fields	216
Avoid unnecessary comparisons in boolean expressions	217
Avoid using final local variables, turn them into fields	229

org/projectforge/web/fibu/OrderPositionsPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	65
Avoid unnecessary comparisons in boolean expressions	71
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	75
Avoid instantiating new objects inside loops	75
Avoid using final local variables, turn them into fields	77
Avoid instantiating new objects inside loops	77
Avoid instantiating new objects inside loops	81
Avoid instantiating new objects inside loops	88 - 98
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	94
Avoid instantiating new objects inside loops	100
Avoid appending characters as strings in StringBuffer.append.	104
Avoid using final local variables, turn them into fields	111
Avoid appending characters as strings in StringBuffer.append.	112
Avoid unnecessary comparisons in boolean expressions	114
Avoid unnecessary comparisons in boolean expressions	119
Avoid using final local variables, turn them into fields	129
Avoid appending characters as strings in StringBuffer.append.	131
Avoid appending characters as strings in StringBuffer.append.	131

org/projectforge/web/fibu/ProjectEditCost2TypeTablePanel.java

Violation	Line
Avoid using final local variables, turn them into fields	59
Avoid using final local variables, turn them into fields	60
Avoid unnecessary comparisons in boolean expressions	62
Avoid using final local variables, turn them into fields	63
Avoid instantiating new objects inside loops	63
Avoid using final local variables, turn them into fields	65
Avoid instantiating new objects inside loops	65
Avoid unnecessary comparisons in boolean expressions	67
Avoid using final local variables, turn them into fields	68
Avoid instantiating new objects inside loops	68
Avoid using final local variables, turn them into fields	70
Avoid unnecessary comparisons in boolean expressions	72
Avoid unnecessary comparisons in boolean expressions	73
Avoid unnecessary comparisons in boolean expressions	77
Avoid using final local variables, turn them into fields	81
Avoid instantiating new objects inside loops	81
Avoid using final local variables, turn them into fields	83 - 84
Avoid instantiating new objects inside loops	83 - 84
Avoid unnecessary comparisons in boolean expressions	86
Avoid using final local variables, turn them into fields	91
Avoid instantiating new objects inside loops	91
Avoid unnecessary comparisons in boolean expressions	93
Avoid using final local variables, turn them into fields	93 - 94
Avoid instantiating new objects inside loops	93 - 94

org/projectforge/web/fibu/ProjektEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	79 - 87
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	94 - 95
Avoid using final local variables, turn them into fields	101
Avoid using final local variables, turn them into fields	103 - 111
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	131
Avoid using final local variables, turn them into fields	132 - 133
Avoid using final local variables, turn them into fields	139
Avoid using final local variables, turn them into fields	140 - 141
Avoid using final local variables, turn them into fields	142 - 143
Avoid using final local variables, turn them into fields	149
Avoid using final local variables, turn them into fields	150 - 151
Avoid using final local variables, turn them into fields	157
Avoid unnecessary comparisons in boolean expressions	160
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	168

org/projectforge/web/fibu/ProjektEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	75
Avoid unnecessary comparisons in boolean expressions	75
Avoid using final local variables, turn them into fields	76
Avoid instantiating new objects inside loops	76
Avoid unnecessary comparisons in boolean expressions	99
Avoid unnecessary comparisons in boolean expressions	101
Avoid unnecessary comparisons in boolean expressions	103
Avoid unnecessary comparisons in boolean expressions	112
Avoid unnecessary comparisons in boolean expressions	114
Avoid unnecessary comparisons in boolean expressions	116

org/projectforge/web/fibu/ProjektListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	46
Avoid using final local variables, turn them into fields	48

org/projectforge/web/fibu/ProjektListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	89 - 102
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	97
Avoid using final local variables, turn them into fields	112
Avoid unnecessary comparisons in boolean expressions	113
Avoid using final local variables, turn them into fields	144
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	152
Avoid using final local variables, turn them into fields	166
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	186
Avoid using final local variables, turn them into fields	187

org/projectforge/web/fibu/ProjektSelectPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'projektAsStringLabel' could be made final; it is only initialized in the declaration or constructor.	58
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	93 - 99
Avoid using final local variables, turn them into fields	102
Avoid unnecessary comparisons in boolean expressions	103
Avoid using final local variables, turn them into fields	108 - 120
Avoid unnecessary comparisons in boolean expressions	118
Avoid unnecessary comparisons in boolean expressions	118
Avoid using final local variables, turn them into fields	126 - 149
Avoid using final local variables, turn them into fields	145
Avoid unnecessary comparisons in boolean expressions	152

org/projectforge/web/fibu/RechnungCostEditTablePanel.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'add' called during object construction	95
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'add' called during object construction	97
Avoid unnecessary comparisons in boolean expressions	121
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	129 - 138
Avoid using final local variables, turn them into fields	141 - 161
Avoid using final local variables, turn them into fields	145
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	166 - 178
Avoid using final local variables, turn them into fields	180
Avoid using final local variables, turn them into fields	189
Avoid using final local variables, turn them into fields	191
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	200 - 208
Avoid using final local variables, turn them into fields	213 - 233
Avoid using final local variables, turn them into fields	220
Avoid unnecessary comparisons in boolean expressions	221
Avoid unnecessary comparisons in boolean expressions	221
Avoid using final local variables, turn them into fields	226
Avoid unnecessary comparisons in boolean expressions	227
Avoid unnecessary comparisons in boolean expressions	237
Avoid using final local variables, turn them into fields	238 - 255
Avoid using final local variables, turn them into fields	243
Avoid using final local variables, turn them into fields	267
Avoid using final local variables, turn them into fields	270
Avoid unnecessary comparisons in boolean expressions	276
Avoid using final local variables, turn them into fields	278
Avoid using final local variables, turn them into fields	280
Avoid using final local variables, turn them into fields	282
Avoid using final local variables, turn them into fields	284
Avoid unnecessary comparisons in boolean expressions	285

org/projectforge/web/fibu/RechnungCostTablePanel.java

Violation	Line
Perhaps 'listView' could be replaced by a local variable.	55
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	89
Avoid unnecessary comparisons in boolean expressions	90
Avoid unnecessary comparisons in boolean expressions	90
Avoid using final local variables, turn them into fields	95
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'refresh' called during object construction	100
Avoid using final local variables, turn them into fields	117
Avoid unnecessary comparisons in boolean expressions	120

org/projectforge/web/fibu/RechnungEditForm.java

Violation	Line
Perhaps 'customerSelectPanel' could be replaced by a local variable.	64
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	87
Avoid using final local variables, turn them into fields	88 - 89
Avoid unnecessary comparisons in boolean expressions	92
Avoid using final local variables, turn them into fields	99
Avoid using final local variables, turn them into fields	100 - 101
Avoid using final local variables, turn them into fields	111
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	113 - 114
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	131
Avoid using final local variables, turn them into fields	132 - 133
Avoid using final local variables, turn them into fields	146 - 158
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	153
Avoid using final local variables, turn them into fields	178
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	180
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	182
Avoid using final local variables, turn them into fields	183
Avoid unnecessary comparisons in boolean expressions	184
Avoid unnecessary comparisons in boolean expressions	187

org/projectforge/web/fibu/RechnungEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	63
Avoid using final local variables, turn them into fields	64
Avoid unnecessary comparisons in boolean expressions	75
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	109
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	122
Avoid unnecessary comparisons in boolean expressions	137
Avoid unnecessary comparisons in boolean expressions	142
Avoid using final local variables, turn them into fields	144
Avoid unnecessary comparisons in boolean expressions	149
Avoid unnecessary comparisons in boolean expressions	158
Avoid unnecessary comparisons in boolean expressions	160

org/projectforge/web/fibu/RechnungListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	40

org/projectforge/web/fibu/RechnungListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	116 - 136
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	124
Avoid empty if statements	125 - 127
Avoid unnecessary comparisons in boolean expressions	125
Avoid unnecessary comparisons in boolean expressions	127
Avoid unnecessary comparisons in boolean expressions	129
Avoid using final local variables, turn them into fields	146
Avoid unnecessary comparisons in boolean expressions	148
Avoid using final local variables, turn them into fields	149
Avoid unnecessary comparisons in boolean expressions	150
Prefer StringBuffer over += for concatenating strings	151
Avoid using final local variables, turn them into fields	154
Avoid using final local variables, turn them into fields	185
Avoid unnecessary comparisons in boolean expressions	186
Avoid using final local variables, turn them into fields	189 - 198
Avoid using final local variables, turn them into fields	217 - 223
Avoid using final local variables, turn them into fields	230
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	231
Avoid using final local variables, turn them into fields	236 - 240
Avoid using final local variables, turn them into fields	241

org/projectforge/web/fibu/ReportObjectivesFilter.java

Violation	Line
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	71

org/projectforge/web/fibu/ReportObjectivesForm.java

Violation	Line
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	84
Avoid unnecessary comparisons in boolean expressions	85
Avoid using final local variables, turn them into fields	93 - 99
Avoid using final local variables, turn them into fields	111 - 117
Avoid using final local variables, turn them into fields	124 - 130
Avoid using final local variables, turn them into fields	142
Avoid using final local variables, turn them into fields	156

org/projectforge/web/fibu/ReportObjectivesPage.java

Violation	Line
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	92

org/projectforge/web/fibu/ReportObjectivesPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	120
Use equals() to compare object references.	128
Avoid using final local variables, turn them into fields	132
Avoid instantiating new objects inside loops	132
Avoid using final local variables, turn them into fields	139
Avoid unnecessary comparisons in boolean expressions	141
Avoid using final local variables, turn them into fields	143
Avoid instantiating new objects inside loops	143
Avoid unnecessary comparisons in boolean expressions	145
Avoid instantiating new objects inside loops	147
Avoid instantiating new objects inside loops	149
Avoid instantiating new objects inside loops	150
Avoid instantiating new objects inside loops	152 - 158
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	172
Avoid instantiating new objects inside loops	172
Avoid instantiating new objects inside loops	175
Avoid instantiating new objects inside loops	176
Avoid instantiating new objects inside loops	181
Avoid using final local variables, turn them into fields	182
Avoid instantiating new objects inside loops	182
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	188
Avoid using final local variables, turn them into fields	189
Avoid using final local variables, turn them into fields	190
Avoid instantiating new objects inside loops	190
Avoid instantiating new objects inside loops	192
Avoid using final local variables, turn them into fields	197
Avoid unnecessary comparisons in boolean expressions	202
Avoid instantiating new objects inside loops	202 - 203
Avoid instantiating new objects inside loops	204 - 211
TOTE_PARAMETER: Avoid unused method parameters such as 'reportStorage'.	217 - 226

org/projectforge/web/fibu/ReportScriptingStorage.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'filename' could be declared final	67

org/projectforge/web/filter/ResponseHeaderFilter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'response' could be declared final	81
KONSTANTHEIT_VERSTECKTE: Local variable 'e' could be declared final	83
KONSTANTHEIT_VERSTECKTE: Local variable 'headerName' could be declared final	84
KONSTANTHEIT_VERSTECKTE: Local variable 'value' could be declared final	85

org/projectforge/web/filter/SpringContext.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 51
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	34
Avoid using final local variables, turn them into fields	48

org/projectforge/web/gantt/GanttChartEditForm.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	87
Avoid unnecessary comparisons in boolean expressions	91
Avoid using final local variables, turn them into fields	110
Avoid using final local variables, turn them into fields	111 - 119
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	127
Avoid using final local variables, turn them into fields	133
Avoid using final local variables, turn them into fields	134 - 135
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	142 - 143
Avoid using final local variables, turn them into fields	150
Avoid using final local variables, turn them into fields	151 - 152
Avoid using final local variables, turn them into fields	153 - 154
Avoid using final local variables, turn them into fields	161
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	168 - 169
Avoid using final local variables, turn them into fields	170 - 171
Avoid using final local variables, turn them into fields	178
Avoid using final local variables, turn them into fields	185
Avoid using final local variables, turn them into fields	186
Avoid using final local variables, turn them into fields	207
Avoid using final local variables, turn them into fields	208 - 209
Avoid using final local variables, turn them into fields	212 - 213
Avoid using final local variables, turn them into fields	218
Avoid using final local variables, turn them into fields	219
Avoid using final local variables, turn them into fields	227 - 228
Avoid using final local variables, turn them into fields	241
Avoid using final local variables, turn them into fields	259 - 260
Avoid unnecessary comparisons in boolean expressions	263
Avoid unnecessary comparisons in boolean expressions	263
Avoid using final local variables, turn them into fields	265 - 273
Avoid using final local variables, turn them into fields	275 - 276

org/projectforge/web/gantt/GanttChartEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	75
Avoid using final local variables, turn them into fields	76
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'refresh' called during object construction	81
Avoid using final local variables, turn them into fields	86
Avoid using final local variables, turn them into fields	91
Avoid unnecessary comparisons in boolean expressions	92
Avoid unnecessary comparisons in boolean expressions	95
Avoid unnecessary comparisons in boolean expressions	97
Avoid unnecessary comparisons in boolean expressions	99
Avoid unnecessary comparisons in boolean expressions	102
Avoid unnecessary comparisons in boolean expressions	105
Avoid unnecessary comparisons in boolean expressions	107
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	116
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	122
Avoid unnecessary comparisons in boolean expressions	123
Avoid unnecessary comparisons in boolean expressions	126
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	158
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	161
Avoid unnecessary comparisons in boolean expressions	194
Avoid using final local variables, turn them into fields	195
Avoid unnecessary comparisons in boolean expressions	201
Avoid unnecessary comparisons in boolean expressions	207
Avoid using final local variables, turn them into fields	208
Avoid using final local variables, turn them into fields	229
Avoid unnecessary comparisons in boolean expressions	230
Avoid unnecessary comparisons in boolean expressions	230

org/projectforge/web/gantt/GanttChartEditTreeTablePanel.java

Violation	Line
TOTE_PARAMETER: Avoid unused constructor parameters such as 'ganttChartDO'.	136 - 149
Avoid using final local variables, turn them into fields	141
StringBuffer constructor is initialized with size 16, but has at least 150 characters appended.	141
Avoid using final local variables, turn them into fields	202
Consider simply returning the value vs storing it in local variable 'ganttTreeTable'	203
Avoid using final local variables, turn them into fields	213 - 218
Avoid using final local variables, turn them into fields	219
Consider simply returning the value vs storing it in local variable 'treeList'	220
Avoid using final local variables, turn them into fields	227
Avoid using final local variables, turn them into fields	228
Avoid using final local variables, turn them into fields	234
Avoid using final local variables, turn them into fields	235
Avoid unnecessary comparisons in boolean expressions	238
Avoid unnecessary comparisons in boolean expressions	238
Avoid unnecessary comparisons in boolean expressions	241
Avoid unnecessary comparisons in boolean expressions	241
Avoid unnecessary comparisons in boolean expressions	244
Avoid unnecessary comparisons in boolean expressions	244
Avoid unnecessary comparisons in boolean expressions	247
Avoid unnecessary comparisons in boolean expressions	247
Avoid unnecessary comparisons in boolean expressions	250
Avoid unnecessary comparisons in boolean expressions	250
Avoid unnecessary comparisons in boolean expressions	253
Avoid unnecessary comparisons in boolean expressions	253
Avoid unnecessary comparisons in boolean expressions	256
Avoid unnecessary comparisons in boolean expressions	256
Avoid unnecessary comparisons in boolean expressions	259
Avoid unnecessary comparisons in boolean expressions	259
Avoid unnecessary comparisons in boolean expressions	262
Avoid unnecessary comparisons in boolean expressions	262
Avoid using final local variables, turn them into fields	272
Avoid unnecessary comparisons in boolean expressions	273
Avoid using final local variables, turn them into fields	274
Avoid using final local variables, turn them into fields	275
Avoid unnecessary comparisons in boolean expressions	277
Avoid using final local variables, turn them into fields	278
Use equals() to compare object references.	281
Avoid unnecessary comparisons in boolean expressions	285
Avoid unnecessary comparisons in boolean expressions	293
Avoid using final local variables, turn them into fields	294
Avoid using final local variables, turn them into fields	312
Avoid unnecessary comparisons in boolean expressions	313
Avoid unnecessary comparisons in boolean expressions	323
Avoid unnecessary comparisons in boolean expressions	328
Avoid unnecessary comparisons in boolean expressions	333
Avoid unnecessary comparisons in boolean expressions	338
Avoid unnecessary comparisons in boolean expressions	343
Avoid unnecessary comparisons in boolean expressions	348
Avoid unnecessary comparisons in boolean expressions	353
Avoid using final local variables, turn them into fields	397
Avoid using final local variables, turn them into fields	398
Avoid using final local variables, turn them into fields	399
Avoid using final local variables, turn them into fields	405 - 430
Avoid unnecessary comparisons in boolean expressions	409
Avoid using final local variables, turn them into fields	419
Avoid unnecessary comparisons in boolean expressions	420
Avoid using final local variables, turn them into fields	423
Avoid using final local variables, turn them into fields	432 - 433
Avoid using final local variables, turn them into fields	440
Avoid using final local variables, turn them into fields	442
Avoid using final local variables, turn them into fields	444
Avoid using final local variables, turn them into fields	448
Avoid using final local variables, turn them into fields	451
Use equals() to compare object references.	468
Avoid using final local variables, turn them into fields	487
Avoid using final local variables, turn them into fields	488
Avoid using final local variables, turn them into fields	490
Use equals() to compare object references.	501
Use equals() to compare object references.	514
Avoid using final local variables, turn them into fields	517
Avoid using final local variables, turn them into fields	518
Use equals() to compare object references.	519
Avoid using final local variables, turn them into fields	528
Avoid using final local variables, turn them into fields	529
Avoid using final local variables, turn them into fields	530
Use equals() to compare object references.	532
Avoid using final local variables, turn them into fields	535
Avoid using final local variables, turn them into fields	543
Avoid using final local variables, turn them into fields	550
Avoid using final local variables, turn them into fields	560
Avoid using final local variables, turn them into fields	579
Avoid using final local variables, turn them into fields	580
Avoid using final local variables, turn them into fields	582
Avoid using final local variables, turn them into fields	598
Avoid using final local variables, turn them into fields	599
Avoid using final local variables, turn them into fields	600
Avoid using final local variables, turn them into fields	611
Avoid using final local variables, turn them into fields	613
Avoid using final local variables, turn them into fields	618
Avoid using final local variables, turn them into fields	619
Avoid using final local variables, turn them into fields	638
Avoid using final local variables, turn them into fields	640
Avoid using final local variables, turn them into fields	671 - 672
An empty method in an abstract class should be abstract instead	724 - 728
An empty method in an abstract class should be abstract instead	730 - 735
TOTE_PARAMETER: Avoid unused method parameters such as 'node'.	747 - 771
Avoid using final local variables, turn them into fields	750 - 751
Avoid using final local variables, turn them into fields	777 - 778
TOTE_PARAMETER: Avoid unused method parameters such as 'node'.	799 - 820
Avoid using final local variables, turn them into fields	802 - 803
Avoid using final local variables, turn them into fields	826 - 827
TOTE_PARAMETER: Avoid unused method parameters such as 'node'.	848 - 875
Avoid using final local variables, turn them into fields	851 - 858
TOTE_PARAMETER: Avoid unused method parameters such as 'node'.	878 - 941
Avoid using final local variables, turn them into fields	881
Avoid using final local variables, turn them into fields	883
Avoid using final local variables, turn them into fields	884
Avoid using final local variables, turn them into fields	885 - 892
Avoid using final local variables, turn them into fields	889
Avoid using final local variables, turn them into fields	894
Avoid using final local variables, turn them into fields	895 - 908
Avoid using final local variables, turn them into fields	900
Avoid using final local variables, turn them into fields	910 - 923
TOTE_PARAMETER: Avoid unused method parameters such as 'node'.	944 - 965
Avoid using final local variables, turn them into fields	947 - 948
TOTE_PARAMETER: Avoid unused method parameters such as 'node'.	968 - 998
Avoid using final local variables, turn them into fields	971
Avoid using final local variables, turn them into fields	977 - 979
Avoid using final local variables, turn them into fields	982
TOTE_PARAMETER: Avoid unused method parameters such as 'node'.	1001 - 1027
Avoid using final local variables, turn them into fields	1004
Avoid using final local variables, turn them into fields	1008 - 1009
Avoid using final local variables, turn them into fields	1012
Avoid using final local variables, turn them into fields	1051
Avoid using final local variables, turn them into fields	1061
Avoid unnecessary comparisons in boolean expressions	1071
Avoid using final local variables, turn them into fields	1072
Avoid using final local variables, turn them into fields	1076
Avoid unnecessary comparisons in boolean expressions	1080
Avoid using final local variables, turn them into fields	1081
Avoid using final local variables, turn them into fields	1085
Avoid unnecessary comparisons in boolean expressions	1089
Avoid using final local variables, turn them into fields	1090
Avoid using final local variables, turn them into fields	1094
Avoid using final local variables, turn them into fields	1100
Avoid using final local variables, turn them into fields	1123
Avoid using final local variables, turn them into fields	1132
Avoid using final local variables, turn them into fields	1133
Avoid unnecessary comparisons in boolean expressions	1195

org/projectforge/web/gantt/GanttChartListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	45
Avoid using final local variables, turn them into fields	46

org/projectforge/web/gantt/GanttChartListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	76 - 85
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	95

org/projectforge/web/gantt/GanttTreeTable.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'addDescendantNodes' called during object construction	39
Avoid using final local variables, turn them into fields	45
Avoid using final local variables, turn them into fields	48
Avoid instantiating new objects inside loops	48

org/projectforge/web/gantt/GanttTreeTableNode.java

Violation	Line
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	75

org/projectforge/web/humanresources/HRListEntryPanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	49
Avoid using final local variables, turn them into fields	49
Avoid unnecessary comparisons in boolean expressions	50
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	51
Avoid unnecessary comparisons in boolean expressions	53
Avoid using final local variables, turn them into fields	57
Avoid unnecessary comparisons in boolean expressions	59

org/projectforge/web/humanresources/HRListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	67
Avoid using final local variables, turn them into fields	75 - 83
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	109

org/projectforge/web/humanresources/HRListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	117
Avoid using final local variables, turn them into fields	118 - 128
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	138
Avoid using final local variables, turn them into fields	155
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	162
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	181
Avoid instantiating new objects inside loops	188 - 219
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	196
Avoid using final local variables, turn them into fields	201
Avoid using final local variables, turn them into fields	207
Avoid using final local variables, turn them into fields	213
Avoid instantiating new objects inside loops	223 - 237
Avoid using final local variables, turn them into fields	229
Avoid using final local variables, turn them into fields	246
Avoid using final local variables, turn them into fields	253
Avoid unnecessary comparisons in boolean expressions	254
Avoid using final local variables, turn them into fields	254
Avoid unnecessary comparisons in boolean expressions	255
Avoid using final local variables, turn them into fields	255
Avoid using final local variables, turn them into fields	256
Avoid unnecessary comparisons in boolean expressions	257
Avoid unnecessary comparisons in boolean expressions	260
Avoid appending characters as strings in StringBuffer.append.	261
Avoid using final local variables, turn them into fields	279
Consider simply returning the value vs storing it in local variable 'editPage'	280
Avoid using final local variables, turn them into fields	287
Avoid unnecessary comparisons in boolean expressions	293
Avoid unnecessary comparisons in boolean expressions	359
Position literals first in String comparisons	359
Avoid using final local variables, turn them into fields	360
Avoid using final local variables, turn them into fields	361
Avoid using final local variables, turn them into fields	395

org/projectforge/web/humanresources/HRListResourceLinkPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	76
Avoid instantiating new objects inside loops	76
Avoid using final local variables, turn them into fields	78 - 92
Avoid instantiating new objects inside loops	79 - 92
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	88
Avoid instantiating new objects inside loops	94

org/projectforge/web/humanresources/HRPlanningEditForm.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	131
Avoid using final local variables, turn them into fields	151 - 152
Avoid using final local variables, turn them into fields	153
Avoid using final local variables, turn them into fields	154
Avoid using final local variables, turn them into fields	155
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	170 - 171
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	180 - 181
Avoid using final local variables, turn them into fields	190
Avoid using final local variables, turn them into fields	192
Avoid using final local variables, turn them into fields	224 - 233
Avoid unnecessary comparisons in boolean expressions	253
Avoid using final local variables, turn them into fields	259
Avoid unnecessary comparisons in boolean expressions	260
Avoid unnecessary comparisons in boolean expressions	261
Avoid unnecessary comparisons in boolean expressions	293
Avoid unnecessary comparisons in boolean expressions	298
Avoid unnecessary comparisons in boolean expressions	301
Avoid unnecessary comparisons in boolean expressions	305
Avoid using final local variables, turn them into fields	318
Avoid instantiating new objects inside loops	318
Avoid unnecessary comparisons in boolean expressions	322
Avoid using final local variables, turn them into fields	325
Avoid unnecessary comparisons in boolean expressions	326
Prefer StringBuffer over += for concatenating strings	327
Avoid instantiating new objects inside loops	329
Avoid instantiating new objects inside loops	330
Avoid instantiating new objects inside loops	332
Avoid using final local variables, turn them into fields	335 - 336
Avoid instantiating new objects inside loops	335 - 336
Avoid using final local variables, turn them into fields	337 - 338
Avoid instantiating new objects inside loops	337 - 338
Avoid using final local variables, turn them into fields	339 - 340
Avoid instantiating new objects inside loops	339 - 340
Avoid using final local variables, turn them into fields	344 - 345
Avoid instantiating new objects inside loops	344 - 345
Avoid using final local variables, turn them into fields	351 - 363
Avoid instantiating new objects inside loops	351 - 363
Avoid unnecessary comparisons in boolean expressions	355
Avoid using final local variables, turn them into fields	364
Avoid unnecessary comparisons in boolean expressions	365
Avoid instantiating new objects inside loops	376 - 378
Avoid instantiating new objects inside loops	380
Avoid instantiating new objects inside loops	381
Avoid using final local variables, turn them into fields	384
Avoid instantiating new objects inside loops	384
Avoid using final local variables, turn them into fields	385
Avoid instantiating new objects inside loops	385
Avoid using final local variables, turn them into fields	386 - 387
Avoid instantiating new objects inside loops	386 - 387
Avoid instantiating new objects inside loops	391
Avoid using final local variables, turn them into fields	394
Avoid instantiating new objects inside loops	394
Avoid using final local variables, turn them into fields	395
Avoid instantiating new objects inside loops	395
Avoid using final local variables, turn them into fields	401 - 402
Avoid instantiating new objects inside loops	401 - 402
Avoid instantiating new objects inside loops	406
Avoid instantiating new objects inside loops	407
Avoid using final local variables, turn them into fields	410
Avoid instantiating new objects inside loops	410
Avoid using final local variables, turn them into fields	411
Avoid instantiating new objects inside loops	411
Avoid instantiating new objects inside loops	415
Avoid using final local variables, turn them into fields	418
Avoid instantiating new objects inside loops	418
Avoid using final local variables, turn them into fields	419
Avoid instantiating new objects inside loops	419
Avoid using final local variables, turn them into fields	420
Avoid instantiating new objects inside loops	420
Avoid unnecessary comparisons in boolean expressions	421
Avoid instantiating new objects inside loops	425
Avoid unnecessary comparisons in boolean expressions	429
Avoid unnecessary comparisons in boolean expressions	429
Avoid using final local variables, turn them into fields	436 - 443
Avoid using final local variables, turn them into fields	444
Avoid unnecessary comparisons in boolean expressions	452
Avoid using final local variables, turn them into fields	454
Avoid using final local variables, turn them into fields	457

org/projectforge/web/humanresources/HRPlanningEditPage.java

Violation	Line
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	67
Avoid using final local variables, turn them into fields	68
Avoid using final local variables, turn them into fields	91
Avoid unnecessary comparisons in boolean expressions	92
Avoid using final local variables, turn them into fields	98
Avoid unnecessary comparisons in boolean expressions	129
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	131
Avoid unnecessary comparisons in boolean expressions	133
Avoid unnecessary comparisons in boolean expressions	146
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	148

org/projectforge/web/humanresources/HRPlanningEditTablePanel.java

Violation	Line
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	51 - 52
Avoid using final local variables, turn them into fields	54
Avoid using final local variables, turn them into fields	56 - 57
Avoid using final local variables, turn them into fields	59 - 60
Avoid using final local variables, turn them into fields	62 - 63
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	67 - 68

org/projectforge/web/humanresources/HRPlanningEventsProvider.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	76
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	92
Avoid instantiating new objects inside loops	92
Avoid unnecessary comparisons in boolean expressions	108
Avoid unnecessary comparisons in boolean expressions	111
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	123
Avoid appending characters as strings in StringBuffer.append.	124
Avoid unnecessary comparisons in boolean expressions	126

org/projectforge/web/humanresources/HRPlanningListFilter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'date' could be declared final	45

org/projectforge/web/humanresources/HRPlanningListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	86
Avoid unnecessary comparisons in boolean expressions	87
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	115
Avoid using final local variables, turn them into fields	139
Avoid unnecessary comparisons in boolean expressions	140
Avoid unnecessary comparisons in boolean expressions	144
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	148 - 154
Avoid unnecessary comparisons in boolean expressions	158
Avoid unnecessary comparisons in boolean expressions	160
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	164 - 180
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	188
Avoid using final local variables, turn them into fields	201
WRAPPER_INSTANZIIERUNG: Don't create instances of already existing BigInteger and BigDecimal (ZERO, ONE, TEN)	206
Avoid using final local variables, turn them into fields	209

org/projectforge/web/humanresources/HRPlanningListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	97
Avoid using final local variables, turn them into fields	98 - 108
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	103
Avoid unnecessary comparisons in boolean expressions	115
Avoid using final local variables, turn them into fields	131
When instantiating a SimpleDateFormat object, specify a Locale	132
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	133
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	152
Avoid using final local variables, turn them into fields	175
Avoid using final local variables, turn them into fields	176 - 188
Avoid unnecessary comparisons in boolean expressions	181
Avoid using final local variables, turn them into fields	216
Avoid using final local variables, turn them into fields	220
Consider simply returning the value vs storing it in local variable 'editPage'	221
Avoid unnecessary comparisons in boolean expressions	268
Avoid unnecessary comparisons in boolean expressions	271
Avoid unnecessary comparisons in boolean expressions	274
Avoid using final local variables, turn them into fields	275
Avoid using final local variables, turn them into fields	277
Avoid unnecessary comparisons in boolean expressions	278
Avoid unnecessary comparisons in boolean expressions	280
Avoid unnecessary comparisons in boolean expressions	295
Avoid unnecessary comparisons in boolean expressions	298

org/projectforge/web/imagecropper/DownloadImageFile.java

Violation	Line
Avoid using final local variables, turn them into fields	54
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	68

org/projectforge/web/imagecropper/ImageCropperPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	77
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setEnableWhiteBoardFilter' called during object construction	78
Avoid unnecessary comparisons in boolean expressions	80
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setEnableWhiteBoardFilter' called during object construction	81
Avoid unnecessary comparisons in boolean expressions	83
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setDefaultLanguage' called during object construction	84
Avoid unnecessary comparisons in boolean expressions	86
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setRatioList' called during object construction	87
Avoid unnecessary comparisons in boolean expressions	89
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setDefaultRatio' called during object construction	90
Avoid unnecessary comparisons in boolean expressions	92
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setFileFormat' called during object construction	93
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	96
Avoid unnecessary comparisons in boolean expressions	98
Avoid using final local variables, turn them into fields	103
Avoid using final local variables, turn them into fields	104
Avoid using final local variables, turn them into fields	114
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'getDefaultLanguage' called during object construction	120
Avoid unnecessary comparisons in boolean expressions	199
Avoid unnecessary comparisons in boolean expressions	219
Avoid appending characters as strings in StringBuffer.append.	242
Avoid appending characters as strings in StringBuffer.append.	242

org/projectforge/web/imagecropper/ImageCropperUtils.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 39
KONSTANTHEIT_VERSTECKTE: Local variable 'result' could be declared final	36
Consider simply returning the value vs storing it in local variable 'result'	37

org/projectforge/web/imagecropper/UpAndDownloadImageFileAsByteArray.java

Violation	Line
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	57

org/projectforge/web/imagecropper/UploadImageFile.java

Violation	Line
Avoid unnecessary return statements	50

org/projectforge/web/imagecropper/UploadImageFileTemporary.java

Violation	Line
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	70
Avoid unnecessary comparisons in boolean expressions	71
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	86
Avoid using final local variables, turn them into fields	98
Avoid using final local variables, turn them into fields	111
Avoid using final local variables, turn them into fields	113
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	116
Avoid unnecessary comparisons in boolean expressions	120

org/projectforge/web/legacy/AuftragEditLegacyServlet.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'uri' could be declared final	45
KONSTANTHEIT_VERSTECKTE: Local variable 'id' could be declared final	46
KONSTANTHEIT_VERSTECKTE: Local variable 'redirectUrl' could be declared final	47

org/projectforge/web/meb/MebEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	100
Avoid unnecessary comparisons in boolean expressions	102
Avoid using final local variables, turn them into fields	106 - 107
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	120
Avoid using final local variables, turn them into fields	121 - 122
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	134
Avoid unnecessary comparisons in boolean expressions	148
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	177 - 194
No need to check for null before an instanceof	189
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	202 - 218
Avoid unnecessary comparisons in boolean expressions	221
Avoid using final local variables, turn them into fields	227
Avoid using final local variables, turn them into fields	240

org/projectforge/web/meb/MebEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	54
Avoid unnecessary comparisons in boolean expressions	71
Avoid using final local variables, turn them into fields	72
Avoid unnecessary comparisons in boolean expressions	89
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	127

org/projectforge/web/meb/MebListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	48

org/projectforge/web/meb/MebListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	77 - 95
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	81
Avoid empty if statements	82 - 84
Avoid unnecessary comparisons in boolean expressions	82
Avoid using final local variables, turn them into fields	103

org/projectforge/web/meb/SMSReceiverServlet.java

Violation	Line
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	67
Avoid unnecessary comparisons in boolean expressions	68
Avoid unnecessary comparisons in boolean expressions	73
Avoid using final local variables, turn them into fields	78
Avoid unnecessary comparisons in boolean expressions	79
Avoid using final local variables, turn them into fields	84
Avoid unnecessary comparisons in boolean expressions	85
Avoid using final local variables, turn them into fields	90
Avoid unnecessary comparisons in boolean expressions	91
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	102
KONSTANTHEIT_VERSTECKTE: Local variable 'entry' could be declared final	104

org/projectforge/web/mobile/AbstractMobileEditForm.java

Violation	Line
An empty method in an abstract class should be abstract instead	48 - 51
Avoid using final local variables, turn them into fields	67 - 73
Avoid using final local variables, turn them into fields	74
Avoid unnecessary comparisons in boolean expressions	79

org/projectforge/web/mobile/AbstractMobileEditPage.java

Violation	Line
Avoid using final local variables, turn them into fields	58
Avoid unnecessary comparisons in boolean expressions	60
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'init' called during object construction	67
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'init' called during object construction	69
Avoid using final local variables, turn them into fields	83
Avoid unnecessary comparisons in boolean expressions	85
Avoid unnecessary comparisons in boolean expressions	109
An empty method in an abstract class should be abstract instead	148 - 151
An empty method in an abstract class should be abstract instead	154 - 157
An empty method in an abstract class should be abstract instead	160 - 163
An empty method in an abstract class should be abstract instead	169 - 173
An empty method in an abstract class should be abstract instead	179 - 183
An empty method in an abstract class should be abstract instead	192 - 195
An empty method in an abstract class should be abstract instead	198 - 201
An empty method in an abstract class should be abstract instead	204 - 207
An empty method in an abstract class should be abstract instead	210 - 213
Avoid using final local variables, turn them into fields	227
Avoid using final local variables, turn them into fields	228
Avoid using final local variables, turn them into fields	234
An empty method in an abstract class should be abstract instead	245 - 247
An empty method in an abstract class should be abstract instead	249 - 255
An empty method in an abstract class should be abstract instead	260 - 266
An empty method in an abstract class should be abstract instead	272 - 275

org/projectforge/web/mobile/AbstractMobileForm.java

Violation	Line
An empty method in an abstract class should be abstract instead	53 - 56
An empty method in an abstract class should be abstract instead	61 - 64

org/projectforge/web/mobile/AbstractMobileListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	44

org/projectforge/web/mobile/AbstractMobileListPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	70
Avoid using final local variables, turn them into fields	77
Avoid instantiating new objects inside loops	77
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	81 - 82
Avoid instantiating new objects inside loops	81 - 82
Avoid unnecessary comparisons in boolean expressions	83
An empty method in an abstract class should be abstract instead	111 - 114
Avoid using final local variables, turn them into fields	121
An empty method in an abstract class should be abstract instead	131 - 134
An empty method in an abstract class should be abstract instead	139 - 142

org/projectforge/web/mobile/AbstractMobilePage.java

Violation	Line
Possible unsafe assignment to a non-final static field in a constructor.	67
Avoid using final local variables, turn them into fields	102 - 108
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'getUser' called during object construction	110
Avoid empty if statements	111 - 113
Avoid unnecessary comparisons in boolean expressions	111
Avoid empty if statements	113 - 114
Avoid unnecessary comparisons in boolean expressions	141
Avoid unnecessary comparisons in boolean expressions	147
Avoid unnecessary comparisons in boolean expressions	157
An empty method in an abstract class should be abstract instead	183 - 186
An empty method in an abstract class should be abstract instead	193 - 196
An empty method in an abstract class should be abstract instead	198 - 204
An empty method in an abstract class should be abstract instead	210 - 213
An empty method in an abstract class should be abstract instead	218 - 221
An empty method in an abstract class should be abstract instead	226 - 229
An empty method in an abstract class should be abstract instead	231 - 234

org/projectforge/web/mobile/AbstractMobileViewPage.java

Violation	Line
Avoid using final local variables, turn them into fields	51
Avoid unnecessary comparisons in boolean expressions	53
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	71

org/projectforge/web/mobile/AbstractSecuredMobilePage.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'putUserPrefEntry' called during object construction	65
An empty method in an abstract class should be abstract instead	74 - 78
An empty method in an abstract class should be abstract instead	84 - 87
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	108
An empty method in an abstract class should be abstract instead	118 - 126
Avoid using final local variables, turn them into fields	124
An empty method in an abstract class should be abstract instead	136 - 152
Avoid using final local variables, turn them into fields	138
Avoid unnecessary comparisons in boolean expressions	142
An empty method in an abstract class should be abstract instead	159 - 167
Avoid using final local variables, turn them into fields	165
An empty method in an abstract class should be abstract instead	188 - 191
An empty method in an abstract class should be abstract instead	199 - 213
Avoid using final local variables, turn them into fields	204
Avoid unnecessary comparisons in boolean expressions	206

org/projectforge/web/mobile/ActionLinkPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	61
Avoid unnecessary comparisons in boolean expressions	62
Avoid using final local variables, turn them into fields	80

org/projectforge/web/mobile/CollapsiblePanel.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	45
Avoid unnecessary comparisons in boolean expressions	119

org/projectforge/web/mobile/JQueryButtonPanel.java

Violation	Line
TOTE_ATTRIBUTE: Avoid unused private fields such as 'alignment'.	57
Perhaps 'alignment' could be replaced by a local variable.	57
Avoid unnecessary comparisons in boolean expressions	101
Avoid using final local variables, turn them into fields	103
Avoid unnecessary comparisons in boolean expressions	118
Avoid unnecessary comparisons in boolean expressions	121
Avoid unnecessary comparisons in boolean expressions	124

org/projectforge/web/mobile/ListViewItemPanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	121
Avoid empty if statements	143 - 145

org/projectforge/web/mobile/ListViewPanel.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'add' called during object construction	45

org/projectforge/web/mobile/LoginMobileForm.java

Violation	Line
Avoid using final local variables, turn them into fields	51 - 57

org/projectforge/web/mobile/LoginMobilePage.java

Violation	Line
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	81 - 82
Avoid using final local variables, turn them into fields	94
Avoid unnecessary comparisons in boolean expressions	95
Avoid using final local variables, turn them into fields	100 - 107

org/projectforge/web/mobile/MenuMobilePage.java

Violation	Line
Avoid using final local variables, turn them into fields	61
Avoid unnecessary comparisons in boolean expressions	77
Avoid using final local variables, turn them into fields	78 - 79
Avoid using final local variables, turn them into fields	86
Avoid using final local variables, turn them into fields	89
Avoid unnecessary comparisons in boolean expressions	92
Avoid instantiating new objects inside loops	93 - 94
Avoid unnecessary comparisons in boolean expressions	112

org/projectforge/web/mobile/RecentMobilePageInfo.java

Violation	Line
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	82

org/projectforge/web/orga/ContractEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	71 - 78
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	93 - 94
Avoid unnecessary comparisons in boolean expressions	97
Avoid using final local variables, turn them into fields	104
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	117
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	120 - 121
Avoid using final local variables, turn them into fields	127
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	133 - 134
Avoid using final local variables, turn them into fields	142
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	184
Avoid using final local variables, turn them into fields	189
Avoid using final local variables, turn them into fields	194
Avoid using final local variables, turn them into fields	201
Avoid using final local variables, turn them into fields	206
Avoid using final local variables, turn them into fields	211
Avoid using final local variables, turn them into fields	218
Avoid using final local variables, turn them into fields	219
Avoid using final local variables, turn them into fields	225

org/projectforge/web/orga/ContractEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	50
Avoid unnecessary comparisons in boolean expressions	58

org/projectforge/web/orga/ContractListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	53
Avoid using final local variables, turn them into fields	54 - 61
Avoid using final local variables, turn them into fields	64

org/projectforge/web/orga/ContractListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	72 - 81
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	88

org/projectforge/web/orga/PostausgangEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	71 - 72
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	82
Avoid using final local variables, turn them into fields	83
Avoid unnecessary comparisons in boolean expressions	84
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	96 - 97
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	106 - 113
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	122 - 129
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	136 - 143
Avoid using final local variables, turn them into fields	150

org/projectforge/web/orga/PostausgangEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	51

org/projectforge/web/orga/PostausgangListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	54
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	69

org/projectforge/web/orga/PostausgangListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	71
Avoid using final local variables, turn them into fields	72 - 82
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	93

org/projectforge/web/orga/PosteingangEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	71 - 72
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	82
Avoid using final local variables, turn them into fields	83
Avoid unnecessary comparisons in boolean expressions	84
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	96 - 97
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	106 - 113
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	122 - 129
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	136 - 143
Avoid using final local variables, turn them into fields	150

org/projectforge/web/orga/PosteingangEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	51

org/projectforge/web/orga/PosteingangListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	54
Avoid using final local variables, turn them into fields	56
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	69

org/projectforge/web/orga/PosteingangListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	71
Avoid using final local variables, turn them into fields	73 - 83
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	94

org/projectforge/web/registry/DaoLocator.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'id' could be made final; it is only initialized in the declaration or constructor.	37

org/projectforge/web/registry/WebRegistry.java

Violation	Line
A class which only has private constructors should be final	129 - 365
It is somewhat confusing to have a field name with the same name as a method	139
Avoid using final local variables, turn them into fields	203
Avoid unnecessary comparisons in boolean expressions	207
Avoid using final local variables, turn them into fields	227

org/projectforge/web/scripting/RecentScriptCalls.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'recentQueue' could be made final; it is only initialized in the declaration or constructor.	34
Avoid unnecessary comparisons in boolean expressions	52

org/projectforge/web/scripting/ScriptEditForm.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	57
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	87
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	103
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	111 - 112
Avoid using final local variables, turn them into fields	113 - 114
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	128
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	134 - 151
Avoid using final local variables, turn them into fields	153 - 154

org/projectforge/web/scripting/ScriptEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	54
Avoid using final local variables, turn them into fields	56 - 62
Avoid using final local variables, turn them into fields	63 - 64

org/projectforge/web/scripting/ScriptExecuteForm.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	104
Avoid using final local variables, turn them into fields	111
Avoid using final local variables, turn them into fields	112
Avoid unnecessary comparisons in boolean expressions	116
Avoid using final local variables, turn them into fields	120
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	144
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	159 - 165
Avoid using final local variables, turn them into fields	166 - 167
Avoid unnecessary comparisons in boolean expressions	177
Avoid using final local variables, turn them into fields	202 - 203
Avoid instantiating new objects inside loops	207
Avoid instantiating new objects inside loops	209
Avoid instantiating new objects inside loops	211
Avoid using final local variables, turn them into fields	213
Avoid instantiating new objects inside loops	214
Avoid instantiating new objects inside loops	217
Avoid instantiating new objects inside loops	218
Avoid instantiating new objects inside loops	220
Avoid using final local variables, turn them into fields	225 - 226
Avoid instantiating new objects inside loops	225 - 226
Avoid using final local variables, turn them into fields	231 - 232
Avoid instantiating new objects inside loops	231 - 232
Avoid unnecessary comparisons in boolean expressions	239

org/projectforge/web/scripting/ScriptExecutePage.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'form' could be made final; it is only initialized in the declaration or constructor.	80
KONSTANTHEIT_VERSTECKTE: Private field 'id' could be made final; it is only initialized in the declaration or constructor.	82
KONSTANTHEIT_VERSTECKTE: Private field 'sourceCodePanel' could be made final; it is only initialized in the declaration or constructor.	86
KONSTANTHEIT_VERSTECKTE: Private field 'resultGridBuilder' could be made final; it is only initialized in the declaration or constructor.	88
Perhaps 'resultGridBuilder' could be replaced by a local variable.	88
Avoid using final local variables, turn them into fields	97 - 109
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	104
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'loadScript' called during object construction	111
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	129 - 135
Avoid using final local variables, turn them into fields	149
Avoid using final local variables, turn them into fields	165
Avoid using final local variables, turn them into fields	172
StringBuffer constructor is initialized with size 16, but has at least 19 characters appended.	172
Avoid unnecessary comparisons in boolean expressions	177
Avoid unnecessary comparisons in boolean expressions	189
Avoid unnecessary comparisons in boolean expressions	193
Avoid using final local variables, turn them into fields	194
Avoid unnecessary comparisons in boolean expressions	195
Avoid unnecessary comparisons in boolean expressions	197
Avoid using final local variables, turn them into fields	205
Avoid using final local variables, turn them into fields	208
Avoid using final local variables, turn them into fields	209
Avoid using final local variables, turn them into fields	219
Avoid using final local variables, turn them into fields	220
Avoid using final local variables, turn them into fields	221
Avoid using final local variables, turn them into fields	222
Avoid using final local variables, turn them into fields	225
Avoid using final local variables, turn them into fields	242
Avoid using final local variables, turn them into fields	243
Avoid using final local variables, turn them into fields	273
Avoid using final local variables, turn them into fields	274
Avoid using final local variables, turn them into fields	281
Avoid unnecessary comparisons in boolean expressions	282
Avoid using final local variables, turn them into fields	283
Avoid using final local variables, turn them into fields	289
Avoid unnecessary comparisons in boolean expressions	290
Avoid unnecessary comparisons in boolean expressions	292
Avoid unnecessary comparisons in boolean expressions	301
Avoid using final local variables, turn them into fields	302
Avoid unnecessary comparisons in boolean expressions	304
Avoid using final local variables, turn them into fields	305

org/projectforge/web/scripting/ScriptListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	48

org/projectforge/web/scripting/ScriptListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	66
Avoid using final local variables, turn them into fields	67 - 76
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	71
Avoid using final local variables, turn them into fields	86
Avoid using final local variables, turn them into fields	98
Avoid using final local variables, turn them into fields	99

org/projectforge/web/scripting/ScriptingForm.java

Violation	Line
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	97
Avoid using final local variables, turn them into fields	102 - 108
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	113 - 114
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	120 - 146
Avoid using final local variables, turn them into fields	127
Avoid using final local variables, turn them into fields	128
Avoid unnecessary comparisons in boolean expressions	130
Avoid using final local variables, turn them into fields	143
Avoid unnecessary comparisons in boolean expressions	144
Avoid using final local variables, turn them into fields	151 - 157
Avoid using final local variables, turn them into fields	158 - 159
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	169
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	184
Avoid unnecessary comparisons in boolean expressions	185
Avoid using final local variables, turn them into fields	188

org/projectforge/web/scripting/ScriptingPage.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'sourceCodePanel' could be made final; it is only initialized in the declaration or constructor.	96
KONSTANTHEIT_VERSTECKTE: Private field 'imageResultContainer' could be made final; it is only initialized in the declaration or constructor.	100
Avoid using final local variables, turn them into fields	127
Avoid using final local variables, turn them into fields	129
Avoid unnecessary comparisons in boolean expressions	173
Avoid unnecessary comparisons in boolean expressions	175
Avoid unnecessary comparisons in boolean expressions	179
Avoid using final local variables, turn them into fields	180
Avoid unnecessary comparisons in boolean expressions	181
Avoid unnecessary comparisons in boolean expressions	183
Avoid using final local variables, turn them into fields	200
Avoid using final local variables, turn them into fields	204
Avoid using final local variables, turn them into fields	205
Avoid unnecessary comparisons in boolean expressions	206
Avoid using final local variables, turn them into fields	208
Avoid unnecessary comparisons in boolean expressions	212
Avoid using final local variables, turn them into fields	213
Avoid using final local variables, turn them into fields	215
Avoid unnecessary comparisons in boolean expressions	225
Avoid unnecessary comparisons in boolean expressions	238
Avoid using final local variables, turn them into fields	242
Avoid using final local variables, turn them into fields	243
Avoid using final local variables, turn them into fields	244
Avoid unnecessary comparisons in boolean expressions	253
Avoid using final local variables, turn them into fields	257
Avoid using final local variables, turn them into fields	258
Avoid using final local variables, turn them into fields	259
Avoid using final local variables, turn them into fields	267
Avoid using final local variables, turn them into fields	268
Avoid using final local variables, turn them into fields	269
Avoid using final local variables, turn them into fields	270
Avoid using final local variables, turn them into fields	273
Avoid using final local variables, turn them into fields	274
Avoid using final local variables, turn them into fields	288
Avoid using final local variables, turn them into fields	289
Avoid using final local variables, turn them into fields	292
Avoid using final local variables, turn them into fields	293
Avoid using final local variables, turn them into fields	307
Avoid using final local variables, turn them into fields	308
Avoid using final local variables, turn them into fields	309
Avoid using final local variables, turn them into fields	310
Avoid using final local variables, turn them into fields	311
Avoid using final local variables, turn them into fields	314
Avoid using final local variables, turn them into fields	322
Avoid using final local variables, turn them into fields	323

org/projectforge/web/statistics/PersonalStatisticsPage.java

Violation	Line
Do not use the short type	49
Avoid using final local variables, turn them into fields	64 - 65
Avoid using final local variables, turn them into fields	67
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	71
Avoid unnecessary comparisons in boolean expressions	73
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	82
Avoid using final local variables, turn them into fields	83 - 85
Avoid using final local variables, turn them into fields	86 - 88
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	90 - 91
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	100 - 102
Avoid using final local variables, turn them into fields	103 - 105
Avoid using final local variables, turn them into fields	106 - 107

org/projectforge/web/statistics/SystemStatisticsPage.java

Violation	Line
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	71

org/projectforge/web/task/TaskEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	120
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	130 - 131
Avoid unnecessary comparisons in boolean expressions	134
Avoid using final local variables, turn them into fields	143
Avoid using final local variables, turn them into fields	144
Avoid unnecessary comparisons in boolean expressions	147
Avoid using final local variables, turn them into fields	154
Avoid using final local variables, turn them into fields	155
Avoid using final local variables, turn them into fields	156 - 157
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	165
Avoid using final local variables, turn them into fields	166 - 167
Avoid using final local variables, turn them into fields	174
Avoid unnecessary comparisons in boolean expressions	176
Avoid using final local variables, turn them into fields	180 - 181
Avoid using final local variables, turn them into fields	188
Avoid using final local variables, turn them into fields	189 - 190
Avoid unnecessary comparisons in boolean expressions	193
Avoid unnecessary comparisons in boolean expressions	193
Avoid using final local variables, turn them into fields	201
Avoid using final local variables, turn them into fields	202
Avoid using final local variables, turn them into fields	208
Avoid using final local variables, turn them into fields	220
Avoid using final local variables, turn them into fields	221 - 222
Avoid using final local variables, turn them into fields	223 - 224
Avoid using final local variables, turn them into fields	231
Avoid using final local variables, turn them into fields	232 - 240
Avoid using final local variables, turn them into fields	247
Avoid using final local variables, turn them into fields	248 - 249
Avoid using final local variables, turn them into fields	255
Avoid using final local variables, turn them into fields	256 - 257
Avoid using final local variables, turn them into fields	265
Avoid using final local variables, turn them into fields	266 - 267
Avoid using final local variables, turn them into fields	274
Avoid using final local variables, turn them into fields	275 - 276
Avoid using final local variables, turn them into fields	283
Avoid using final local variables, turn them into fields	284 - 285
Avoid using final local variables, turn them into fields	286 - 288
Avoid using final local variables, turn them into fields	294
Avoid using final local variables, turn them into fields	295 - 296
Avoid using final local variables, turn them into fields	308 - 309
Avoid using final local variables, turn them into fields	312
Avoid using final local variables, turn them into fields	313
Avoid using final local variables, turn them into fields	315
Avoid using final local variables, turn them into fields	320
Avoid using final local variables, turn them into fields	321
Avoid using final local variables, turn them into fields	330
Avoid using final local variables, turn them into fields	334 - 336
Avoid using final local variables, turn them into fields	337 - 338
Avoid unnecessary comparisons in boolean expressions	341
Avoid using final local variables, turn them into fields	345 - 356
Avoid using final local variables, turn them into fields	362
Avoid using final local variables, turn them into fields	363 - 364
Avoid unnecessary comparisons in boolean expressions	366
Avoid using final local variables, turn them into fields	372
Avoid using final local variables, turn them into fields	373 - 374
Avoid using final local variables, turn them into fields	375 - 377
Avoid unnecessary comparisons in boolean expressions	380
Avoid using final local variables, turn them into fields	386
Avoid using final local variables, turn them into fields	387
Avoid using final local variables, turn them into fields	388 - 389
Avoid using final local variables, turn them into fields	399
Avoid using final local variables, turn them into fields	400

org/projectforge/web/task/TaskEditPage.java

Violation	Line
Avoid using final local variables, turn them into fields	82
Avoid unnecessary comparisons in boolean expressions	83
Avoid unnecessary comparisons in boolean expressions	105
Avoid unnecessary comparisons in boolean expressions	107
Avoid unnecessary comparisons in boolean expressions	109
Avoid unnecessary comparisons in boolean expressions	111
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	114
Avoid using final local variables, turn them into fields	116
Avoid unnecessary comparisons in boolean expressions	131
Avoid unnecessary comparisons in boolean expressions	133
Avoid unnecessary comparisons in boolean expressions	135
Avoid unnecessary comparisons in boolean expressions	153
Avoid using final local variables, turn them into fields	154
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	161
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	174
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	190
Avoid using final local variables, turn them into fields	192
Avoid using final local variables, turn them into fields	199

org/projectforge/web/task/TaskFormatter.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	47
Possible unsafe assignment to a non-final static field in a constructor.	47
Avoid using final local variables, turn them into fields	107
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	108
Avoid using final local variables, turn them into fields	109
Avoid using final local variables, turn them into fields	112
Avoid unnecessary comparisons in boolean expressions	155
Avoid using final local variables, turn them into fields	162
Avoid unnecessary comparisons in boolean expressions	163
Avoid using final local variables, turn them into fields	166
Avoid using final local variables, turn them into fields	169
Avoid unnecessary comparisons in boolean expressions	196
Avoid using final local variables, turn them into fields	197
Avoid unnecessary comparisons in boolean expressions	206
Avoid unnecessary comparisons in boolean expressions	209
Avoid unnecessary comparisons in boolean expressions	210
Avoid appending characters as strings in StringBuffer.append.	213
Avoid appending characters as strings in StringBuffer.append.	219
Avoid using final local variables, turn them into fields	235
StringBuffer constructor is initialized with size 16, but has at least 25 characters appended.	235
Avoid appending characters as strings in StringBuffer.append.	238

org/projectforge/web/task/TaskListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	49
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	67 - 74

org/projectforge/web/task/TaskListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	146
Avoid using final local variables, turn them into fields	155 - 156
Avoid unnecessary comparisons in boolean expressions	156
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	162
Avoid using final local variables, turn them into fields	165
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	180
Avoid appending characters as strings in StringBuffer.append.	187
Avoid using final local variables, turn them into fields	190
Avoid using final local variables, turn them into fields	200
Avoid using final local variables, turn them into fields	201
Avoid using final local variables, turn them into fields	208
Avoid using final local variables, turn them into fields	209
Avoid using final local variables, turn them into fields	233 - 242
Avoid using final local variables, turn them into fields	236
Avoid using final local variables, turn them into fields	237
Avoid using final local variables, turn them into fields	243
Avoid using final local variables, turn them into fields	249
Avoid using final local variables, turn them into fields	250
Avoid using final local variables, turn them into fields	252
Avoid unnecessary comparisons in boolean expressions	254
Avoid using final local variables, turn them into fields	268
Avoid unnecessary comparisons in boolean expressions	273
Avoid using final local variables, turn them into fields	279
Avoid unnecessary comparisons in boolean expressions	285
Avoid unnecessary comparisons in boolean expressions	287
Avoid using final local variables, turn them into fields	292
Avoid using final local variables, turn them into fields	293
Avoid unnecessary comparisons in boolean expressions	294
Avoid using final local variables, turn them into fields	295
Avoid using final local variables, turn them into fields	298 - 307
Avoid unnecessary comparisons in boolean expressions	317
Avoid using final local variables, turn them into fields	328
Avoid using final local variables, turn them into fields	338
Avoid using final local variables, turn them into fields	343 - 345
Avoid using final local variables, turn them into fields	355
Avoid using final local variables, turn them into fields	356

org/projectforge/web/task/TaskPropertyColumn.java

Violation	Line
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	91
Avoid unnecessary comparisons in boolean expressions	96
Avoid using final local variables, turn them into fields	101

org/projectforge/web/task/TaskSelectPanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	78
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	95
Use equals() to compare object references.	96
Avoid unnecessary comparisons in boolean expressions	100
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	103
Avoid using final local variables, turn them into fields	104
Avoid unnecessary comparisons in boolean expressions	105
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	112
Avoid instantiating new objects inside loops	112
Avoid using final local variables, turn them into fields	114 - 120
Avoid instantiating new objects inside loops	114 - 120
Avoid instantiating new objects inside loops	124
Avoid using final local variables, turn them into fields	139 - 153
Avoid using final local variables, turn them into fields	143
Avoid using final local variables, turn them into fields	147
Avoid using final local variables, turn them into fields	149
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	169 - 179
Avoid using final local variables, turn them into fields	173
Avoid using final local variables, turn them into fields	183 - 195
Avoid unnecessary comparisons in boolean expressions	193
Avoid using final local variables, turn them into fields	201 - 224
Avoid using final local variables, turn them into fields	220
Avoid unnecessary comparisons in boolean expressions	227

org/projectforge/web/task/TaskTreeForm.java

Violation	Line
Perhaps 'listViewButtonPanel' could be replaced by a local variable.	63
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	82 - 83
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	111 - 117
Avoid using final local variables, turn them into fields	123 - 129
Avoid using final local variables, turn them into fields	135 - 141
Avoid using final local variables, turn them into fields	147 - 153
Avoid unnecessary comparisons in boolean expressions	176
Avoid using final local variables, turn them into fields	187

org/projectforge/web/task/TaskTreePage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	83
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'isSelectMode' called during object construction	86
TOTE_PARAMETER: Avoid unused constructor parameters such as 'parameters'.	94 - 98
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'isSelectMode' called during object construction	106
Avoid unnecessary comparisons in boolean expressions	117
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	132
Avoid unnecessary comparisons in boolean expressions	135
Avoid using final local variables, turn them into fields	140
Avoid using final local variables, turn them into fields	141
Avoid unnecessary comparisons in boolean expressions	152
Avoid unnecessary comparisons in boolean expressions	200
Avoid unnecessary comparisons in boolean expressions	226
Avoid unnecessary comparisons in boolean expressions	256

org/projectforge/web/task/TaskTreeTable.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'reload' called during object construction	55
KONSTANTHEIT_VERSTECKTE: Local variable 'task' could be declared final	80
Avoid unnecessary comparisons in boolean expressions	83
Avoid instantiating new objects inside loops	86
KONSTANTHEIT_VERSTECKTE: Local variable 'child' could be declared final	86
SYNCHRONISATION: Use block level rather than method level synchronization	94 - 106

org/projectforge/web/task/TaskTreeTableNode.java

Violation	Line
Avoid using final local variables, turn them into fields	109
Avoid appending characters as strings in StringBuffer.append.	113
Avoid using final local variables, turn them into fields	121

org/projectforge/web/task/TaskTreeTablePanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	108
Avoid unnecessary comparisons in boolean expressions	111
Avoid unnecessary comparisons in boolean expressions	113
Avoid unnecessary comparisons in boolean expressions	117
Avoid using final local variables, turn them into fields	160
Avoid using final local variables, turn them into fields	161 - 162
Avoid using final local variables, turn them into fields	164
Avoid unnecessary comparisons in boolean expressions	167
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	179
Avoid unnecessary comparisons in boolean expressions	180
Avoid unnecessary comparisons in boolean expressions	180
Avoid using final local variables, turn them into fields	189
Avoid using final local variables, turn them into fields	190
Avoid unnecessary comparisons in boolean expressions	193
Avoid unnecessary comparisons in boolean expressions	197
Avoid unnecessary comparisons in boolean expressions	199
Avoid using final local variables, turn them into fields	200
Avoid unnecessary comparisons in boolean expressions	201
Avoid unnecessary comparisons in boolean expressions	212
Avoid using final local variables, turn them into fields	230
Avoid using final local variables, turn them into fields	231
Avoid unnecessary comparisons in boolean expressions	234

org/projectforge/web/timesheet/TimesheetEditForm.java

Violation	Line
Perhaps 'stopHourOfDay' could be replaced by a local variable.	128
Avoid unnecessary comparisons in boolean expressions	160
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	173
Avoid using final local variables, turn them into fields	174
Avoid using final local variables, turn them into fields	175
Avoid unnecessary comparisons in boolean expressions	190
Avoid using final local variables, turn them into fields	191
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	197
Avoid unnecessary comparisons in boolean expressions	199
Avoid unnecessary comparisons in boolean expressions	217
Avoid using final local variables, turn them into fields	224
Avoid using final local variables, turn them into fields	225 - 233
Avoid unnecessary comparisons in boolean expressions	240
Avoid using final local variables, turn them into fields	244 - 245
Avoid using final local variables, turn them into fields	246 - 247
Avoid using final local variables, turn them into fields	255
Avoid unnecessary comparisons in boolean expressions	257
Avoid using final local variables, turn them into fields	268
Avoid using final local variables, turn them into fields	269 - 271
Avoid using final local variables, turn them into fields	278
Avoid using final local variables, turn them into fields	293 - 295
Avoid using final local variables, turn them into fields	300 - 302
Avoid using final local variables, turn them into fields	309
Avoid using final local variables, turn them into fields	324
Avoid using final local variables, turn them into fields	328
Avoid using final local variables, turn them into fields	329
Avoid using final local variables, turn them into fields	335
Avoid using final local variables, turn them into fields	336
Avoid unnecessary comparisons in boolean expressions	339
Avoid using final local variables, turn them into fields	341 - 347
Avoid using final local variables, turn them into fields	349 - 358
Avoid unnecessary comparisons in boolean expressions	356
Avoid using final local variables, turn them into fields	366
Avoid using final local variables, turn them into fields	367
Avoid using final local variables, turn them into fields	370
Avoid using final local variables, turn them into fields	371
Avoid using final local variables, turn them into fields	376 - 411
Avoid unnecessary comparisons in boolean expressions	396
Avoid using final local variables, turn them into fields	398
Avoid using final local variables, turn them into fields	415 - 429
Avoid using final local variables, turn them into fields	419 - 421
Avoid using final local variables, turn them into fields	438
Avoid using final local variables, turn them into fields	447 - 463
Avoid using final local variables, turn them into fields	469
Avoid unnecessary comparisons in boolean expressions	473
Avoid using final local variables, turn them into fields	499
Avoid using final local variables, turn them into fields	502
Avoid unnecessary comparisons in boolean expressions	508
Avoid using final local variables, turn them into fields	522
Avoid using final local variables, turn them into fields	531 - 532
Avoid using final local variables, turn them into fields	542
Avoid using final local variables, turn them into fields	545

org/projectforge/web/timesheet/TimesheetEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	128
Avoid using final local variables, turn them into fields	129
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	152
Avoid using final local variables, turn them into fields	157
Avoid using final local variables, turn them into fields	158
Avoid unnecessary comparisons in boolean expressions	167
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	206
Avoid using final local variables, turn them into fields	207
Avoid using final local variables, turn them into fields	210
Avoid using final local variables, turn them into fields	216
Avoid using final local variables, turn them into fields	217
Avoid using final local variables, turn them into fields	218
Avoid using final local variables, turn them into fields	219
Avoid using final local variables, turn them into fields	220
Avoid using final local variables, turn them into fields	221
Avoid using final local variables, turn them into fields	232
Avoid using final local variables, turn them into fields	248
Avoid using final local variables, turn them into fields	257
Avoid using final local variables, turn them into fields	258
Avoid using final local variables, turn them into fields	260
Avoid using final local variables, turn them into fields	264
Avoid using final local variables, turn them into fields	280
Avoid unnecessary comparisons in boolean expressions	291
Avoid using final local variables, turn them into fields	292
Avoid unnecessary comparisons in boolean expressions	300
Avoid using final local variables, turn them into fields	301
Avoid unnecessary comparisons in boolean expressions	308
Avoid using final local variables, turn them into fields	309
Avoid unnecessary comparisons in boolean expressions	326
Avoid unnecessary comparisons in boolean expressions	329
Avoid unnecessary comparisons in boolean expressions	332
Avoid using final local variables, turn them into fields	352
Avoid using final local variables, turn them into fields	353
Avoid unnecessary comparisons in boolean expressions	356
Avoid unnecessary comparisons in boolean expressions	360
Avoid using final local variables, turn them into fields	361
Returning 'BOOKMARKABLE_SELECT_PROPERTIES' may expose an internal array.	371

org/projectforge/web/timesheet/TimesheetEditSelectRecentDialogPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	131 - 147
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	135
Avoid unnecessary comparisons in boolean expressions	137
Avoid unnecessary comparisons in boolean expressions	148
Avoid using final local variables, turn them into fields	155
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	163
Avoid unnecessary comparisons in boolean expressions	167
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	193
Avoid using final local variables, turn them into fields	194
Avoid using final local variables, turn them into fields	195
Avoid using final local variables, turn them into fields	198
Avoid using final local variables, turn them into fields	201
Avoid using final local variables, turn them into fields	212
Avoid using final local variables, turn them into fields	213 - 219
Avoid using final local variables, turn them into fields	220
Avoid using final local variables, turn them into fields	265 - 268

org/projectforge/web/timesheet/TimesheetEventsProvider.java

Violation	Line
Perhaps 'days' could be replaced by a local variable.	71
Avoid using final local variables, turn them into fields	104
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	113
Avoid unnecessary comparisons in boolean expressions	114
Avoid using final local variables, turn them into fields	126
Avoid using final local variables, turn them into fields	132
Avoid instantiating new objects inside loops	132
Avoid using final local variables, turn them into fields	133
Avoid instantiating new objects inside loops	133
Avoid unnecessary comparisons in boolean expressions	134
Avoid unnecessary comparisons in boolean expressions	134
Avoid using final local variables, turn them into fields	138
Avoid using final local variables, turn them into fields	139
Avoid instantiating new objects inside loops	139
Avoid using final local variables, turn them into fields	140
Do not add empty strings	141
Avoid using final local variables, turn them into fields	144
Avoid unnecessary comparisons in boolean expressions	145
Avoid using final local variables, turn them into fields	161
Avoid unnecessary comparisons in boolean expressions	164
Avoid using final local variables, turn them into fields	173
Avoid using final local variables, turn them into fields	174
Avoid using final local variables, turn them into fields	175
Avoid unnecessary comparisons in boolean expressions	176
Avoid using final local variables, turn them into fields	180
Avoid instantiating new objects inside loops	180
Avoid using final local variables, turn them into fields	181
Avoid using final local variables, turn them into fields	184
Avoid unnecessary comparisons in boolean expressions	185
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	188
Avoid instantiating new objects inside loops	188
Avoid unnecessary comparisons in boolean expressions	205
Avoid using final local variables, turn them into fields	216
Avoid using final local variables, turn them into fields	217
Avoid appending characters as strings in StringBuffer.append.	219
Avoid appending characters as strings in StringBuffer.append.	221
Avoid unnecessary comparisons in boolean expressions	222
Avoid appending characters as strings in StringBuffer.append.	223
Avoid using final local variables, turn them into fields	230
Avoid using final local variables, turn them into fields	231
Avoid using final local variables, turn them into fields	235
Avoid using final local variables, turn them into fields	236
Avoid using final local variables, turn them into fields	237
Avoid unnecessary comparisons in boolean expressions	248
Avoid using final local variables, turn them into fields	262
Avoid using final local variables, turn them into fields	263
Avoid using final local variables, turn them into fields	264
Avoid using final local variables, turn them into fields	265
Avoid unnecessary comparisons in boolean expressions	266
Avoid unnecessary comparisons in boolean expressions	268

org/projectforge/web/timesheet/TimesheetListFilter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'date' could be declared final	42

org/projectforge/web/timesheet/TimesheetListForm.java

Violation	Line
Avoid empty if statements	93 - 95
Avoid unnecessary comparisons in boolean expressions	93
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	97
Avoid using final local variables, turn them into fields	98
Avoid unnecessary comparisons in boolean expressions	101
Avoid using final local variables, turn them into fields	107
Avoid using final local variables, turn them into fields	111
Avoid using final local variables, turn them into fields	112 - 128
Avoid using final local variables, turn them into fields	136
Avoid using final local variables, turn them into fields	153
Avoid using final local variables, turn them into fields	163 - 172
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	201
Avoid using final local variables, turn them into fields	202
Avoid using final local variables, turn them into fields	215
Avoid using final local variables, turn them into fields	216 - 232
Avoid unnecessary comparisons in boolean expressions	278

org/projectforge/web/timesheet/TimesheetListPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	139
Avoid using final local variables, turn them into fields	140
Avoid unnecessary comparisons in boolean expressions	141
Avoid unnecessary comparisons in boolean expressions	152
Avoid using final local variables, turn them into fields	153
Avoid unnecessary comparisons in boolean expressions	156
Avoid using final local variables, turn them into fields	157
Avoid unnecessary comparisons in boolean expressions	160
Avoid using final local variables, turn them into fields	161
Avoid unnecessary comparisons in boolean expressions	164
Avoid using final local variables, turn them into fields	165
Avoid unnecessary comparisons in boolean expressions	172
Avoid using final local variables, turn them into fields	173
Avoid using final local variables, turn them into fields	186
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	190 - 196
Avoid using final local variables, turn them into fields	201 - 207
Avoid using final local variables, turn them into fields	216
Avoid unnecessary comparisons in boolean expressions	218
Avoid using final local variables, turn them into fields	234 - 235
Avoid using final local variables, turn them into fields	257
Avoid using final local variables, turn them into fields	258 - 273
Avoid using final local variables, turn them into fields	261
Avoid using final local variables, turn them into fields	262
Avoid using final local variables, turn them into fields	268
Avoid unnecessary comparisons in boolean expressions	279
Avoid using final local variables, turn them into fields	285
Avoid using final local variables, turn them into fields	286
Avoid using final local variables, turn them into fields	309
Avoid unnecessary comparisons in boolean expressions	310
Avoid unnecessary comparisons in boolean expressions	318
Avoid using final local variables, turn them into fields	329
Avoid using final local variables, turn them into fields	330 - 331
Avoid using final local variables, turn them into fields	341
Avoid using final local variables, turn them into fields	342
Avoid using final local variables, turn them into fields	353
Avoid using final local variables, turn them into fields	354
Avoid using final local variables, turn them into fields	367
Avoid using final local variables, turn them into fields	368 - 384
Avoid unnecessary comparisons in boolean expressions	373
Avoid unnecessary comparisons in boolean expressions	378
Avoid unnecessary comparisons in boolean expressions	424
Avoid unnecessary comparisons in boolean expressions	427
Avoid unnecessary comparisons in boolean expressions	430
Avoid using final local variables, turn them into fields	431
Avoid using final local variables, turn them into fields	433
Avoid unnecessary comparisons in boolean expressions	434
Avoid unnecessary comparisons in boolean expressions	436
Avoid unnecessary comparisons in boolean expressions	457
Avoid unnecessary comparisons in boolean expressions	460
Avoid using final local variables, turn them into fields	471
Avoid using final local variables, turn them into fields	481
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	482
Avoid using final local variables, turn them into fields	487
StringBuffer constructor is initialized with size 16, but has at least 18 characters appended.	487
Avoid using final local variables, turn them into fields	489
Avoid appending characters as strings in StringBuffer.append.	491
Avoid using final local variables, turn them into fields	494
Avoid appending characters as strings in StringBuffer.append.	495
Avoid appending characters as strings in StringBuffer.append.	497
Avoid using final local variables, turn them into fields	499
Avoid using final local variables, turn them into fields	502
Avoid using final local variables, turn them into fields	503
Avoid using final local variables, turn them into fields	506
Avoid using final local variables, turn them into fields	508
Avoid using final local variables, turn them into fields	510
Avoid using final local variables, turn them into fields	513
Avoid using final local variables, turn them into fields	521
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	522
Avoid using final local variables, turn them into fields	527
Avoid using final local variables, turn them into fields	528
Avoid unnecessary comparisons in boolean expressions	552
Avoid unnecessary comparisons in boolean expressions	554
Avoid unnecessary comparisons in boolean expressions	558
Avoid unnecessary comparisons in boolean expressions	561
Avoid unnecessary comparisons in boolean expressions	563
Avoid unnecessary comparisons in boolean expressions	567
Returning 'MY_BOOKMARKABLE_INITIAL_PROPERTIES' may expose an internal array.	584

org/projectforge/web/timesheet/TimesheetMassUpdateForm.java

Violation	Line
Perhaps 'kost2Fieldset' could be replaced by a local variable.	49
Perhaps 'timesheetPageSupport' could be replaced by a local variable.	63
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	80 - 81
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	109

org/projectforge/web/timesheet/TimesheetMassUpdatePage.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'timesheets' could be made final; it is only initialized in the declaration or constructor.	68
Avoid unnecessary comparisons in boolean expressions	81
Avoid using final local variables, turn them into fields	92 - 93
Avoid using final local variables, turn them into fields	94 - 119
Avoid using final local variables, turn them into fields	98
Avoid using final local variables, turn them into fields	99
Avoid using final local variables, turn them into fields	122
Avoid unnecessary comparisons in boolean expressions	133
Avoid unnecessary comparisons in boolean expressions	143
Avoid unnecessary comparisons in boolean expressions	163

org/projectforge/web/timesheet/TimesheetPageSupport.java

Violation	Line
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	90 - 103

org/projectforge/web/tree/DefaultTreeTablePanel.java

Violation	Line
Avoid using final local variables, turn them into fields	137
An empty method in an abstract class should be abstract instead	146 - 149
An empty method in an abstract class should be abstract instead	153 - 157
Avoid using final local variables, turn them into fields	155
Consider simply returning the value vs storing it in local variable 'colHead'	156
An empty method in an abstract class should be abstract instead	159 - 180
Avoid using final local variables, turn them into fields	161
Avoid unnecessary comparisons in boolean expressions	164
Avoid using final local variables, turn them into fields	168
Avoid using final local variables, turn them into fields	170
Avoid using final local variables, turn them into fields	173
An empty method in an abstract class should be abstract instead	182 - 185
An empty method in an abstract class should be abstract instead	201 - 207
An empty method in an abstract class should be abstract instead	211 - 217
An empty method in an abstract class should be abstract instead	226 - 229
An empty method in an abstract class should be abstract instead	231 - 243
Avoid using final local variables, turn them into fields	233 - 234
Avoid unnecessary comparisons in boolean expressions	235
Avoid using final local variables, turn them into fields	236
Avoid using final local variables, turn them into fields	237
Avoid unnecessary comparisons in boolean expressions	238
Avoid using final local variables, turn them into fields	252
An empty method in an abstract class should be abstract instead	260 - 267
Avoid using final local variables, turn them into fields	262
An empty method in an abstract class should be abstract instead	277 - 280
Avoid unnecessary comparisons in boolean expressions	285
Avoid unnecessary comparisons in boolean expressions	292
Avoid using final local variables, turn them into fields	295
Avoid using final local variables, turn them into fields	296
Avoid using final local variables, turn them into fields	298
Avoid using final local variables, turn them into fields	301
Avoid using final local variables, turn them into fields	304
Avoid using final local variables, turn them into fields	318
Avoid using final local variables, turn them into fields	325
Avoid using final local variables, turn them into fields	326
Avoid using final local variables, turn them into fields	327
Avoid unnecessary comparisons in boolean expressions	328
Avoid using final local variables, turn them into fields	329
Avoid using final local variables, turn them into fields	330
Avoid unnecessary comparisons in boolean expressions	331
Avoid using final local variables, turn them into fields	343
Avoid unnecessary comparisons in boolean expressions	355
Avoid using final local variables, turn them into fields	358
Use equals() to compare object references.	359
An empty method in an abstract class should be abstract instead	366 - 368
An empty method in an abstract class should be abstract instead	376 - 379

org/projectforge/web/tree/TreeIconsActionPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	86 - 95
Avoid using final local variables, turn them into fields	113 - 114
Avoid using final local variables, turn them into fields	131 - 138
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	165
Avoid unnecessary comparisons in boolean expressions	167
Avoid unnecessary comparisons in boolean expressions	171
Avoid using final local variables, turn them into fields	177
Avoid using final local variables, turn them into fields	180
Avoid unnecessary comparisons in boolean expressions	182
Avoid using final local variables, turn them into fields	186
Avoid unnecessary comparisons in boolean expressions	187
Avoid unnecessary comparisons in boolean expressions	197
Avoid unnecessary comparisons in boolean expressions	206
Avoid using final local variables, turn them into fields	228
Avoid using final local variables, turn them into fields	232
Avoid unnecessary comparisons in boolean expressions	233
Avoid unnecessary comparisons in boolean expressions	242
Avoid unnecessary comparisons in boolean expressions	251
Avoid unnecessary comparisons in boolean expressions	256
Avoid unnecessary comparisons in boolean expressions	270
Avoid unnecessary comparisons in boolean expressions	280
Avoid using final local variables, turn them into fields	288
Avoid using final local variables, turn them into fields	290
Avoid unnecessary comparisons in boolean expressions	291
Avoid using final local variables, turn them into fields	297
Avoid using final local variables, turn them into fields	298
Avoid using final local variables, turn them into fields	299
Avoid unnecessary comparisons in boolean expressions	302
Avoid using final local variables, turn them into fields	312

org/projectforge/web/tree/TreeTable.java

Violation	Line
An empty method in an abstract class should be abstract instead	70 - 83
KONSTANTHEIT_VERSTECKTE: Local variable 'nodes' could be declared final	72
KONSTANTHEIT_VERSTECKTE: Local variable 'childs' could be declared final	76
An empty method in an abstract class should be abstract instead	88 - 91
Avoid unnecessary comparisons in boolean expressions	101
Avoid unnecessary comparisons in boolean expressions	103
Avoid unnecessary comparisons in boolean expressions	105
An empty method in an abstract class should be abstract instead	118 - 141
KONSTANTHEIT_VERSTECKTE: Local variable 'node' could be declared final	120
Avoid unnecessary comparisons in boolean expressions	125
Avoid unnecessary comparisons in boolean expressions	131
KONSTANTHEIT_VERSTECKTE: Local variable 'node' could be declared final	150
An empty method in an abstract class should be abstract instead	165 - 168
Avoid unnecessary comparisons in boolean expressions	190
Avoid unnecessary comparisons in boolean expressions	202
Avoid unnecessary comparisons in boolean expressions	214
KONSTANTHEIT_VERSTECKTE: Local variable 'parent' could be declared final	226
An empty method in an abstract class should be abstract instead	235 - 238
An empty method in an abstract class should be abstract instead	246 - 249
An empty method in an abstract class should be abstract instead	257 - 279
Avoid using final local variables, turn them into fields	259
Avoid unnecessary comparisons in boolean expressions	262
Avoid unnecessary comparisons in boolean expressions	264
Avoid unnecessary comparisons in boolean expressions	272
Avoid using final local variables, turn them into fields	273
Avoid unnecessary comparisons in boolean expressions	274
An empty method in an abstract class should be abstract instead	286 - 304
Avoid using final local variables, turn them into fields	288
Avoid unnecessary comparisons in boolean expressions	291
Avoid unnecessary comparisons in boolean expressions	292
Avoid unnecessary comparisons in boolean expressions	296

org/projectforge/web/tree/TreeTableNode.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	127
Avoid unnecessary comparisons in boolean expressions	129
Avoid unnecessary comparisons in boolean expressions	143
Avoid unnecessary comparisons in boolean expressions	150
Avoid unnecessary comparisons in boolean expressions	195
Avoid unnecessary comparisons in boolean expressions	199
Avoid unnecessary comparisons in boolean expressions	205
Avoid unnecessary return statements	213
KONSTANTHEIT_VERSTECKTE: Local variable 'path' could be declared final	224
Avoid unnecessary comparisons in boolean expressions	235
Avoid unnecessary comparisons in boolean expressions	236
Avoid unnecessary comparisons in boolean expressions	240

org/projectforge/web/user/ChangePasswordForm.java

Violation	Line
Perhaps 'gridBuilder' could be replaced by a local variable.	44
Avoid using final local variables, turn them into fields	59
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	71
Avoid using final local variables, turn them into fields	72
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	86 - 92
Avoid using final local variables, turn them into fields	94 - 95
Avoid using final local variables, turn them into fields	98 - 104
Avoid using final local variables, turn them into fields	105 - 106

org/projectforge/web/user/ChangePasswordPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	59

org/projectforge/web/user/GroupEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	91
Avoid using final local variables, turn them into fields	92 - 93
Avoid using final local variables, turn them into fields	98
Avoid unnecessary comparisons in boolean expressions	103
Avoid using final local variables, turn them into fields	113
Avoid using final local variables, turn them into fields	118
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	125
Avoid using final local variables, turn them into fields	126
Avoid instantiating new objects inside loops	128
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	131
Avoid using final local variables, turn them into fields	176
Avoid using final local variables, turn them into fields	182

org/projectforge/web/user/GroupEditPage.java

Violation	Line
Avoid using final local variables, turn them into fields	69
Avoid unnecessary comparisons in boolean expressions	70
Avoid using final local variables, turn them into fields	78

org/projectforge/web/user/GroupListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	48
Avoid using final local variables, turn them into fields	49

org/projectforge/web/user/GroupListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	75 - 84
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	95
Avoid unnecessary comparisons in boolean expressions	96
Avoid unnecessary comparisons in boolean expressions	99

org/projectforge/web/user/GroupSelectPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	74 - 85
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	87 - 93
Avoid using final local variables, turn them into fields	97 - 109
Avoid unnecessary comparisons in boolean expressions	107

org/projectforge/web/user/MyAccountEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	58
Avoid using final local variables, turn them into fields	66

org/projectforge/web/user/MyAccountEditPage.java

Violation	Line
Avoid using final local variables, turn them into fields	53
Avoid using final local variables, turn them into fields	70
Avoid unnecessary comparisons in boolean expressions	82
Avoid unnecessary comparisons in boolean expressions	88

org/projectforge/web/user/UserEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	131 - 132
Avoid using final local variables, turn them into fields	140
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	149
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	163
Avoid using final local variables, turn them into fields	172
Avoid using final local variables, turn them into fields	174 - 182
Avoid using final local variables, turn them into fields	191
Avoid using final local variables, turn them into fields	192
Avoid instantiating new objects inside loops	195
Avoid using final local variables, turn them into fields	197 - 218
Avoid unnecessary comparisons in boolean expressions	212
Avoid using final local variables, turn them into fields	239
Avoid using final local variables, turn them into fields	240
Avoid using final local variables, turn them into fields	243 - 244
Avoid using final local variables, turn them into fields	252
Avoid using final local variables, turn them into fields	253
Avoid unnecessary comparisons in boolean expressions	265
Avoid using final local variables, turn them into fields	267
Avoid unnecessary comparisons in boolean expressions	280
Avoid using final local variables, turn them into fields	282
Avoid using final local variables, turn them into fields	293
Avoid using final local variables, turn them into fields	302
Avoid using final local variables, turn them into fields	306
Avoid unnecessary comparisons in boolean expressions	307
Avoid using final local variables, turn them into fields	308 - 309
Avoid unnecessary comparisons in boolean expressions	318
Avoid unnecessary comparisons in boolean expressions	318
Avoid unnecessary comparisons in boolean expressions	333
Avoid unnecessary comparisons in boolean expressions	349
Avoid using final local variables, turn them into fields	361
Avoid using final local variables, turn them into fields	362 - 374
Avoid unnecessary comparisons in boolean expressions	370
Avoid using final local variables, turn them into fields	376 - 387
Avoid unnecessary comparisons in boolean expressions	383
Avoid using final local variables, turn them into fields	392
Avoid using final local variables, turn them into fields	394
Avoid unnecessary comparisons in boolean expressions	395
Avoid unnecessary comparisons in boolean expressions	395
Avoid unnecessary comparisons in boolean expressions	398
Avoid unnecessary comparisons in boolean expressions	403
Avoid using final local variables, turn them into fields	404
Avoid using final local variables, turn them into fields	425
Avoid using final local variables, turn them into fields	426
Avoid unnecessary comparisons in boolean expressions	429
Avoid using final local variables, turn them into fields	429
When instantiating a SimpleDateFormat object, specify a Locale	431
Avoid using final local variables, turn them into fields	431
Avoid instantiating new objects inside loops	431
Avoid instantiating new objects inside loops	432
Avoid using final local variables, turn them into fields	438 - 439
Avoid using final local variables, turn them into fields	446
Avoid using final local variables, turn them into fields	450
Avoid using final local variables, turn them into fields	451
Avoid unnecessary comparisons in boolean expressions	452
Avoid unnecessary comparisons in boolean expressions	455
Avoid instantiating new objects inside loops	458
Avoid unnecessary comparisons in boolean expressions	461
Avoid using final local variables, turn them into fields	467
Avoid using final local variables, turn them into fields	468
Avoid unnecessary comparisons in boolean expressions	469
Avoid using final local variables, turn them into fields	470
Avoid using final local variables, turn them into fields	471 - 472
Avoid instantiating new objects inside loops	471 - 472
Avoid using final local variables, turn them into fields	477 - 478
Avoid instantiating new objects inside loops	477 - 478
Avoid using final local variables, turn them into fields	479 - 480
Avoid instantiating new objects inside loops	479 - 480
Avoid using final local variables, turn them into fields	490
Avoid using final local variables, turn them into fields	491
Avoid using final local variables, turn them into fields	492
Avoid instantiating new objects inside loops	494
Avoid using final local variables, turn them into fields	496
Avoid using final local variables, turn them into fields	497
Avoid unnecessary comparisons in boolean expressions	513
Avoid using final local variables, turn them into fields	548
Avoid using final local variables, turn them into fields	554

org/projectforge/web/user/UserEditPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	87
Avoid unnecessary comparisons in boolean expressions	95
Avoid using final local variables, turn them into fields	105
Avoid using final local variables, turn them into fields	109
Avoid using final local variables, turn them into fields	116

org/projectforge/web/user/UserFormatter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Local variable 'u' could be declared final	61
KONSTANTHEIT_VERSTECKTE: Local variable 'user' could be declared final	81
KONSTANTHEIT_VERSTECKTE: Local variable 'user' could be declared final	87

org/projectforge/web/user/UserListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	48

org/projectforge/web/user/UserListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	80 - 89
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	97
Avoid unnecessary comparisons in boolean expressions	98
Avoid unnecessary comparisons in boolean expressions	101
Avoid unnecessary comparisons in boolean expressions	115
Avoid using final local variables, turn them into fields	120
Avoid using final local variables, turn them into fields	121
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	130
Avoid using final local variables, turn them into fields	131
Avoid using final local variables, turn them into fields	132
Avoid unnecessary comparisons in boolean expressions	137
Avoid using final local variables, turn them into fields	142
Avoid using final local variables, turn them into fields	154

org/projectforge/web/user/UserPrefEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	91 - 92
Avoid using final local variables, turn them into fields	100
Avoid using final local variables, turn them into fields	123
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	132
Avoid using final local variables, turn them into fields	151
Avoid using final local variables, turn them into fields	157 - 164
Avoid unnecessary comparisons in boolean expressions	177
Avoid using final local variables, turn them into fields	179 - 186
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	188 - 204
Avoid unnecessary comparisons in boolean expressions	199
Avoid unnecessary comparisons in boolean expressions	216
Avoid unnecessary comparisons in boolean expressions	225
Avoid using final local variables, turn them into fields	230 - 231
Avoid unnecessary comparisons in boolean expressions	232
Avoid unnecessary comparisons in boolean expressions	236
Avoid using final local variables, turn them into fields	237 - 238
Avoid instantiating new objects inside loops	237 - 238
Avoid unnecessary comparisons in boolean expressions	244
Avoid using final local variables, turn them into fields	245 - 246
Avoid instantiating new objects inside loops	245 - 246
Avoid unnecessary comparisons in boolean expressions	252
Avoid using final local variables, turn them into fields	253 - 254
Avoid instantiating new objects inside loops	253 - 254
Avoid unnecessary comparisons in boolean expressions	257
Avoid using final local variables, turn them into fields	258
Avoid using final local variables, turn them into fields	263
Avoid using final local variables, turn them into fields	268 - 275
Avoid instantiating new objects inside loops	268 - 275
Avoid unnecessary comparisons in boolean expressions	278
Avoid using final local variables, turn them into fields	279 - 280
Avoid instantiating new objects inside loops	279 - 280
Avoid unnecessary comparisons in boolean expressions	286
Avoid using final local variables, turn them into fields	287 - 288
Avoid instantiating new objects inside loops	287 - 288
Avoid unnecessary comparisons in boolean expressions	294
Avoid instantiating new objects inside loops	299 - 300
Avoid unnecessary comparisons in boolean expressions	301
Avoid using final local variables, turn them into fields	302 - 303
Avoid instantiating new objects inside loops	302 - 303
Avoid using final local variables, turn them into fields	304 - 305
Avoid instantiating new objects inside loops	304 - 305
Avoid using final local variables, turn them into fields	313 - 314
Avoid instantiating new objects inside loops	313 - 314
Avoid instantiating new objects inside loops	316

org/projectforge/web/user/UserPrefEditPage.java

Violation	Line
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	125
Avoid using final local variables, turn them into fields	136
Avoid unnecessary comparisons in boolean expressions	139
Avoid using final local variables, turn them into fields	140

org/projectforge/web/user/UserPrefListForm.java

Violation	Line
Avoid using final local variables, turn them into fields	46
Avoid using final local variables, turn them into fields	48 - 49

org/projectforge/web/user/UserPrefListPage.java

Violation	Line
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	66
Consider simply returning the value vs storing it in local variable 'link'	67
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	86 - 90
Avoid using final local variables, turn them into fields	100
Avoid using final local variables, turn them into fields	101
Avoid using final local variables, turn them into fields	132

org/projectforge/web/user/UserPropertyColumn.java

Violation	Line
Avoid using final local variables, turn them into fields	74
KONSTANTHEIT_VERSTECKTE: Local variable 'obj' could be declared final	81
KONSTANTHEIT_VERSTECKTE: Local variable 'userId' could be declared final	88

org/projectforge/web/user/UserRightsEditData.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'rights' could be made final; it is only initialized in the declaration or constructor.	39

org/projectforge/web/user/UserSelectPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	91
Consider simply returning the value vs storing it in local variable 'list'	92
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	132
Avoid unnecessary comparisons in boolean expressions	151
Avoid using final local variables, turn them into fields	155
Avoid using final local variables, turn them into fields	156
Avoid using final local variables, turn them into fields	157
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	209 - 224
Avoid using final local variables, turn them into fields	221
Avoid unnecessary comparisons in boolean expressions	222
Avoid using final local variables, turn them into fields	234

org/projectforge/web/wicket/AbstractEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	110 - 111
Avoid using final local variables, turn them into fields	115 - 125
Avoid using final local variables, turn them into fields	132 - 142
Avoid using final local variables, turn them into fields	149 - 159
Avoid using final local variables, turn them into fields	160 - 161
Avoid using final local variables, turn them into fields	251
Avoid unnecessary comparisons in boolean expressions	252
Avoid unnecessary comparisons in boolean expressions	259
Avoid unnecessary comparisons in boolean expressions	266
Avoid unnecessary comparisons in boolean expressions	268
Avoid unnecessary comparisons in boolean expressions	277
Avoid unnecessary comparisons in boolean expressions	285
Avoid unnecessary comparisons in boolean expressions	290
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type.	299
Avoid using final local variables, turn them into fields	301
An empty method in an abstract class should be abstract instead	331 - 334
An empty method in an abstract class should be abstract instead	339 - 342

org/projectforge/web/wicket/AbstractEditPage.java

Violation	Line
Avoid using final local variables, turn them into fields	108
StringBuffer constructor is initialized with size 16, but has at least 72 characters appended.	108
Avoid unnecessary comparisons in boolean expressions	110
Avoid using final local variables, turn them into fields	117
Avoid unnecessary comparisons in boolean expressions	133
Avoid using final local variables, turn them into fields	138
Avoid using final local variables, turn them into fields	139 - 146
Avoid using final local variables, turn them into fields	147 - 148
Avoid using final local variables, turn them into fields	183
Avoid using final local variables, turn them into fields	184 - 196
Avoid using final local variables, turn them into fields	197
Avoid using final local variables, turn them into fields	200
Avoid using final local variables, turn them into fields	203
An empty method in an abstract class should be abstract instead	211 - 217
An empty method in an abstract class should be abstract instead	223 - 225
An empty method in an abstract class should be abstract instead	230 - 234
An empty method in an abstract class should be abstract instead	241 - 245
An empty method in an abstract class should be abstract instead	252 - 256
An empty method in an abstract class should be abstract instead	262 - 266
An empty method in an abstract class should be abstract instead	271 - 275
An empty method in an abstract class should be abstract instead	283 - 287
An empty method in an abstract class should be abstract instead	293 - 297
An empty method in an abstract class should be abstract instead	303 - 307
An empty method in an abstract class should be abstract instead	339 - 342
Avoid using final local variables, turn them into fields	404
Avoid using final local variables, turn them into fields	405
Avoid using final local variables, turn them into fields	411
An empty method in an abstract class should be abstract instead	422 - 425
An empty method in an abstract class should be abstract instead	431 - 437
An empty method in an abstract class should be abstract instead	443 - 449
An empty method in an abstract class should be abstract instead	457 - 460
Avoid unnecessary comparisons in boolean expressions	469
An empty method in an abstract class should be abstract instead	481 - 489
Avoid unnecessary comparisons in boolean expressions	483
Avoid using final local variables, turn them into fields	486
An empty method in an abstract class should be abstract instead	495 - 498
An empty method in an abstract class should be abstract instead	504 - 507
An empty method in an abstract class should be abstract instead	510 - 513
An empty method in an abstract class should be abstract instead	524 - 527

org/projectforge/web/wicket/AbstractForm.java

Violation	Line
An empty method in an abstract class should be abstract instead	54 - 57
An empty method in an abstract class should be abstract instead	78 - 93
Avoid using final local variables, turn them into fields	80 - 89
An empty method in an abstract class should be abstract instead	95 - 98
An empty method in an abstract class should be abstract instead	103 - 105
An empty method in an abstract class should be abstract instead	117 - 120
An empty method in an abstract class should be abstract instead	125 - 128
An empty method in an abstract class should be abstract instead	155 - 161
An empty method in an abstract class should be abstract instead	166 - 169
An empty method in an abstract class should be abstract instead	174 - 177
An empty method in an abstract class should be abstract instead	182 - 185
An empty method in an abstract class should be abstract instead	195 - 198
An empty method in an abstract class should be abstract instead	203 - 206

org/projectforge/web/wicket/AbstractListForm.java

Violation	Line
Perhaps 'extendedFilter' could be replaced by a local variable.	90
An empty method in an abstract class should be abstract instead	116 - 130
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	120
Avoid instantiating new objects inside loops	121
Avoid using final local variables, turn them into fields	126 - 127
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'getSearchFilter' called during object construction	135
Avoid using final local variables, turn them into fields	143 - 152
Avoid unnecessary comparisons in boolean expressions	156
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	165
Avoid unnecessary comparisons in boolean expressions	166
Avoid using final local variables, turn them into fields	167
Avoid using final local variables, turn them into fields	178
Avoid using final local variables, turn them into fields	181 - 187
Avoid using final local variables, turn them into fields	188
Avoid unnecessary comparisons in boolean expressions	195
Avoid using final local variables, turn them into fields	202
Avoid unnecessary comparisons in boolean expressions	208
Avoid unnecessary comparisons in boolean expressions	208
Avoid using final local variables, turn them into fields	211
Avoid using final local variables, turn them into fields	216 - 222
Avoid using final local variables, turn them into fields	227 - 233
Avoid using final local variables, turn them into fields	238 - 244
Avoid using final local variables, turn them into fields	248 - 254
Avoid using final local variables, turn them into fields	265
Avoid using final local variables, turn them into fields	277
Avoid using final local variables, turn them into fields	291 - 303
Avoid using final local variables, turn them into fields	306
Avoid using final local variables, turn them into fields	320 - 321
Avoid using final local variables, turn them into fields	329
Avoid using final local variables, turn them into fields	331 - 347
An empty method in an abstract class should be abstract instead	358 - 365
Avoid using final local variables, turn them into fields	360 - 361
An empty method in an abstract class should be abstract instead	382 - 385
Avoid unnecessary comparisons in boolean expressions	396
Avoid unnecessary comparisons in boolean expressions	403
Avoid using final local variables, turn them into fields	424
Avoid using final local variables, turn them into fields	425
Avoid using final local variables, turn them into fields	431
Avoid unnecessary comparisons in boolean expressions	432
Avoid unnecessary comparisons in boolean expressions	434
Avoid unnecessary comparisons in boolean expressions	436
Avoid unnecessary comparisons in boolean expressions	438
Avoid unnecessary comparisons in boolean expressions	440
Avoid unnecessary comparisons in boolean expressions	442
Avoid unnecessary comparisons in boolean expressions	445
An empty method in an abstract class should be abstract instead	459 - 492
Avoid unnecessary comparisons in boolean expressions	462
Avoid using final local variables, turn them into fields	463
Avoid unnecessary comparisons in boolean expressions	465
Avoid unnecessary comparisons in boolean expressions	487
An empty method in an abstract class should be abstract instead	495 - 511
An empty method in an abstract class should be abstract instead	513 - 516
An empty method in an abstract class should be abstract instead	519 - 540
Avoid using final local variables, turn them into fields	522 - 535
An empty method in an abstract class should be abstract instead	545 - 554
An empty method in an abstract class should be abstract instead	559 - 562
Avoid unnecessary comparisons in boolean expressions	572
An empty method in an abstract class should be abstract instead	596 - 599
An empty method in an abstract class should be abstract instead	605 - 608
Avoid unnecessary comparisons in boolean expressions	617

org/projectforge/web/wicket/AbstractListPage.java

Violation	Line
An empty method in an abstract class should be abstract instead	74 - 85
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	122
Avoid unnecessary comparisons in boolean expressions	134
Avoid using final local variables, turn them into fields	135
Avoid using final local variables, turn them into fields	157
Avoid unnecessary comparisons in boolean expressions	158
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setup' called during object construction	168
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'isSelectMode' called during object construction	169
An empty method in an abstract class should be abstract instead	177 - 179
An empty method in an abstract class should be abstract instead	190 - 193
An empty method in an abstract class should be abstract instead	195 - 201
An empty method in an abstract class should be abstract instead	209 - 225
Avoid using final local variables, turn them into fields	211
StringBuffer constructor is initialized with size 16, but has at least 30 characters appended.	211
Avoid unnecessary comparisons in boolean expressions	215
Avoid unnecessary comparisons in boolean expressions	218
Avoid unnecessary comparisons in boolean expressions	221
An empty method in an abstract class should be abstract instead	232 - 235
An empty method in an abstract class should be abstract instead	242 - 247
Avoid using final local variables, turn them into fields	244
An empty method in an abstract class should be abstract instead	253 - 256
Returning 'BOOKMARKABLE_INITIAL_PROPERTIES' may expose an internal array.	255
An empty method in an abstract class should be abstract instead	262 - 265
An empty method in an abstract class should be abstract instead	272 - 275
An empty method in an abstract class should be abstract instead	281 - 284
Avoid unnecessary comparisons in boolean expressions	292
Avoid unnecessary comparisons in boolean expressions	292
Avoid unnecessary comparisons in boolean expressions	292
Avoid using final local variables, turn them into fields	304 - 310
Avoid unnecessary comparisons in boolean expressions	311
An empty method in an abstract class should be abstract instead	349 - 351
An empty method in an abstract class should be abstract instead	359 - 370
Avoid using final local variables, turn them into fields	364
Avoid using final local variables, turn them into fields	365 - 366
An empty method in an abstract class should be abstract instead	378 - 405
Avoid unnecessary comparisons in boolean expressions	382
Avoid using final local variables, turn them into fields	386
Avoid empty if statements	391 - 403
Avoid unnecessary comparisons in boolean expressions	421
Avoid unnecessary comparisons in boolean expressions	424
An empty method in an abstract class should be abstract instead	457 - 473
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type.	463
Avoid using final local variables, turn them into fields	464
An empty method in an abstract class should be abstract instead	477 - 480
Avoid unnecessary comparisons in boolean expressions	485
Avoid unnecessary comparisons in boolean expressions	485
Avoid unnecessary comparisons in boolean expressions	490
Avoid unnecessary comparisons in boolean expressions	493
An empty method in an abstract class should be abstract instead	510 - 513
An empty method in an abstract class should be abstract instead	515 - 517
Avoid using final local variables, turn them into fields	524
Avoid using final local variables, turn them into fields	534
An empty method in an abstract class should be abstract instead	539 - 542
An empty method in an abstract class should be abstract instead	548 - 551
An empty method in an abstract class should be abstract instead	560 - 565
Avoid using final local variables, turn them into fields	562
An empty method in an abstract class should be abstract instead	572 - 575
An empty method in an abstract class should be abstract instead	583 - 586
Avoid unnecessary comparisons in boolean expressions	605
An empty method in an abstract class should be abstract instead	617 - 620
An empty method in an abstract class should be abstract instead	626 - 629
Avoid unnecessary comparisons in boolean expressions	637
Avoid unnecessary comparisons in boolean expressions	652
An empty method in an abstract class should be abstract instead	662 - 674
Avoid unnecessary comparisons in boolean expressions	669
Avoid unnecessary comparisons in boolean expressions	683
Avoid using final local variables, turn them into fields	684
Avoid unnecessary comparisons in boolean expressions	685
Avoid unnecessary comparisons in boolean expressions	685

org/projectforge/web/wicket/AbstractMassEditForm.java

Violation	Line
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	80 - 86
Avoid using final local variables, turn them into fields	88 - 89
Avoid using final local variables, turn them into fields	93 - 99
Avoid using final local variables, turn them into fields	100 - 101

org/projectforge/web/wicket/AbstractMassEditPage.java

Violation	Line
An empty method in an abstract class should be abstract instead	63 - 66

org/projectforge/web/wicket/AbstractReindexTopRightMenu.java

Violation	Line
Avoid using final local variables, turn them into fields	47 - 53
Avoid unnecessary comparisons in boolean expressions	56
Avoid using final local variables, turn them into fields	57 - 63

org/projectforge/web/wicket/AbstractSecuredBasePage.java

Violation	Line
An empty method in an abstract class should be abstract instead	74 - 77
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	102
An empty method in an abstract class should be abstract instead	112 - 120
Avoid using final local variables, turn them into fields	118
An empty method in an abstract class should be abstract instead	130 - 146
Avoid using final local variables, turn them into fields	132
Avoid unnecessary comparisons in boolean expressions	136
An empty method in an abstract class should be abstract instead	153 - 161
Avoid using final local variables, turn them into fields	159
An empty method in an abstract class should be abstract instead	182 - 185
An empty method in an abstract class should be abstract instead	204 - 218
Avoid using final local variables, turn them into fields	209
Avoid unnecessary comparisons in boolean expressions	211
An empty method in an abstract class should be abstract instead	226 - 229

org/projectforge/web/wicket/AbstractSecuredForm.java

Violation	Line
An empty method in an abstract class should be abstract instead	39 - 42
An empty method in an abstract class should be abstract instead	49 - 52

org/projectforge/web/wicket/AbstractSecuredPage.java

Violation	Line
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	81
Avoid using final local variables, turn them into fields	84 - 102
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	104
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	110 - 118
Avoid unnecessary comparisons in boolean expressions	123
Avoid unnecessary comparisons in boolean expressions	123
Avoid unnecessary comparisons in boolean expressions	132
Avoid unnecessary comparisons in boolean expressions	132
An empty method in an abstract class should be abstract instead	145 - 149
An empty method in an abstract class should be abstract instead	156 - 159
An empty method in an abstract class should be abstract instead	166 - 169
An empty method in an abstract class should be abstract instead	182 - 185
An empty method in an abstract class should be abstract instead	191 - 195
Avoid using final local variables, turn them into fields	193
An empty method in an abstract class should be abstract instead	215 - 221
Avoid using final local variables, turn them into fields	217
An empty method in an abstract class should be abstract instead	227 - 230
An empty method in an abstract class should be abstract instead	236 - 239
An empty method in an abstract class should be abstract instead	245 - 248
An empty method in an abstract class should be abstract instead	254 - 257

org/projectforge/web/wicket/AbstractSelectPanel.java

Violation	Line
An empty method in an abstract class should be abstract instead	70 - 74
An empty method in an abstract class should be abstract instead	80 - 84
An empty method in an abstract class should be abstract instead	90 - 94
An empty method in an abstract class should be abstract instead	100 - 103
An empty method in an abstract class should be abstract instead	110 - 113
Avoid unnecessary comparisons in boolean expressions	122

org/projectforge/web/wicket/AbstractStandardForm.java

Violation	Line
Avoid using final local variables, turn them into fields	52
Avoid using final local variables, turn them into fields	62 - 63

org/projectforge/web/wicket/AbstractUnsecureBasePage.java

Violation	Line
An empty method in an abstract class should be abstract instead	69 - 74
Avoid using final local variables, turn them into fields	71
Avoid using final local variables, turn them into fields	86
Avoid using final local variables, turn them into fields	90
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	111
StringBuffer constructor is initialized with size 16, but has at least 156 characters appended.	111
Avoid using final local variables, turn them into fields	113
Avoid unnecessary comparisons in boolean expressions	124
Avoid using final local variables, turn them into fields	143
Avoid unnecessary comparisons in boolean expressions	145
Avoid using final local variables, turn them into fields	148
Avoid using final local variables, turn them into fields	150
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'escapeHtml' called during object construction	153
Avoid using final local variables, turn them into fields	163
An empty method in an abstract class should be abstract instead	180 - 183
An empty method in an abstract class should be abstract instead	189 - 192
An empty method in an abstract class should be abstract instead	198 - 201
An empty method in an abstract class should be abstract instead	207 - 210
An empty method in an abstract class should be abstract instead	215 - 218
An empty method in an abstract class should be abstract instead	223 - 226
An empty method in an abstract class should be abstract instead	254 - 256
An empty method in an abstract class should be abstract instead	266 - 269
An empty method in an abstract class should be abstract instead	281 - 284
An empty method in an abstract class should be abstract instead	291 - 294
An empty method in an abstract class should be abstract instead	296 - 302

org/projectforge/web/wicket/BatikImage.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'document' could be made final; it is only initialized in the declaration or constructor.	43
Returning 'ba' may expose an internal array.	57

org/projectforge/web/wicket/ByteArrayResourceStream.java

Violation	Line
TOTE_PARAMETER: Avoid unused constructor parameters such as 'filename'.	61 - 65

org/projectforge/web/wicket/CellItemListenerPropertyColumn.java

Violation	Line
Avoid using final local variables, turn them into fields	102
Avoid using final local variables, turn them into fields	103
Avoid using final local variables, turn them into fields	115

org/projectforge/web/wicket/CurrencyPropertyColumn.java

Violation	Line
Avoid using final local variables, turn them into fields	57
Avoid using final local variables, turn them into fields	58
Avoid unnecessary comparisons in boolean expressions	59

org/projectforge/web/wicket/DatePropertyColumn.java

Violation	Line
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	77

org/projectforge/web/wicket/DatesAsUTCModel.java

Violation	Line
Avoid using final local variables, turn them into fields	46
StringBuffer constructor is initialized with size 16, but has at least 25 characters appended.	46
Avoid appending characters as strings in StringBuffer.append.	59

org/projectforge/web/wicket/DetachableDOModel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'baseDao' could be made final; it is only initialized in the declaration or constructor.	37
KONSTANTHEIT_VERSTECKTE: Local variable 'other' could be declared final	71

org/projectforge/web/wicket/DownloadUtils.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 143
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	95
Avoid using final local variables, turn them into fields	101
Avoid unnecessary comparisons in boolean expressions	117
Avoid unnecessary comparisons in boolean expressions	117
Avoid unnecessary comparisons in boolean expressions	119
Avoid unnecessary comparisons in boolean expressions	121
Avoid unnecessary comparisons in boolean expressions	123
Avoid unnecessary comparisons in boolean expressions	125
Avoid unnecessary comparisons in boolean expressions	127
Avoid unnecessary comparisons in boolean expressions	127
Avoid unnecessary comparisons in boolean expressions	129
Avoid unnecessary comparisons in boolean expressions	131
Avoid unnecessary comparisons in boolean expressions	133
Avoid unnecessary comparisons in boolean expressions	135
Avoid unnecessary comparisons in boolean expressions	137

org/projectforge/web/wicket/EditPageSupport.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	47
Avoid unnecessary comparisons in boolean expressions	61
Avoid unnecessary comparisons in boolean expressions	65
Avoid unnecessary comparisons in boolean expressions	69
Avoid using final local variables, turn them into fields	74
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	95
Avoid unnecessary comparisons in boolean expressions	117
Avoid unnecessary comparisons in boolean expressions	121
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	135
Avoid unnecessary comparisons in boolean expressions	157
Avoid unnecessary comparisons in boolean expressions	177
Avoid unnecessary comparisons in boolean expressions	181
Avoid using final local variables, turn them into fields	185
Avoid unnecessary comparisons in boolean expressions	199
Avoid unnecessary comparisons in boolean expressions	203
Avoid using final local variables, turn them into fields	207
Avoid unnecessary comparisons in boolean expressions	221
Avoid unnecessary comparisons in boolean expressions	225
Avoid using final local variables, turn them into fields	229

org/projectforge/web/wicket/EqualsDecorator.java

Violation	Line
Classes implementing Serializable should set a serialVersionUID	52 - 76
KONSTANTHEIT_VERSTECKTE: Local variable 'methodName' could be declared final	63
Position literals first in String comparisons	64
Position literals first in String comparisons	68
KONSTANTHEIT_VERSTECKTE: Local variable 'val' could be declared final	69
Position literals first in String comparisons	71
Classes implementing Serializable should set a serialVersionUID	79 - 92

org/projectforge/web/wicket/ErrorForm.java

Violation	Line
Perhaps 'gridBuilder' could be replaced by a local variable.	53
Avoid using final local variables, turn them into fields	71
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	85
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	93
Avoid using final local variables, turn them into fields	97
Avoid using final local variables, turn them into fields	98
Avoid using final local variables, turn them into fields	105 - 111
Avoid using final local variables, turn them into fields	113 - 114
Avoid using final local variables, turn them into fields	118 - 124
Avoid using final local variables, turn them into fields	126 - 127

org/projectforge/web/wicket/ErrorHighlightBehavior.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	44
KONSTANTHEIT_VERSTECKTE: Local variable 'fc' could be declared final	47
Avoid unnecessary comparisons in boolean expressions	48
Avoid unnecessary comparisons in boolean expressions	52
KONSTANTHEIT_VERSTECKTE: Local variable 'value' could be declared final	53
Avoid unnecessary comparisons in boolean expressions	54

org/projectforge/web/wicket/ErrorPage.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	63
Perhaps 'showFeedback' could be replaced by a local variable.	67
Avoid using final local variables, turn them into fields	81
Avoid unnecessary comparisons in boolean expressions	82
Avoid using final local variables, turn them into fields	87
Avoid unnecessary comparisons in boolean expressions	88
Avoid using final local variables, turn them into fields	93
Avoid unnecessary comparisons in boolean expressions	94
Avoid using final local variables, turn them into fields	141
Avoid using final local variables, turn them into fields	147
Avoid unnecessary comparisons in boolean expressions	153
Avoid using final local variables, turn them into fields	153
Avoid unnecessary comparisons in boolean expressions	155
Avoid using final local variables, turn them into fields	159
Avoid using final local variables, turn them into fields	161 - 171
Avoid using final local variables, turn them into fields	191
Avoid unnecessary comparisons in boolean expressions	192

org/projectforge/web/wicket/FeedbackForm.java

Violation	Line
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	65
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	84 - 90
Avoid using final local variables, turn them into fields	92 - 93

org/projectforge/web/wicket/FeedbackPage.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	43
TOTE_PARAMETER: Avoid unused constructor parameters such as 'parameters'.	47 - 57
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	74
Avoid unnecessary comparisons in boolean expressions	75

org/projectforge/web/wicket/ImageDef.java

Violation	Line
TOTE_ATTRIBUTE: Avoid unused private fields such as 'SMALL_GREY'.	202

org/projectforge/web/wicket/InitialPageParameterHolder.java

Violation	Line
Avoid using final local variables, turn them into fields	39
Avoid using final local variables, turn them into fields	45

org/projectforge/web/wicket/JFreeChartImage.java

Violation	Line
Avoid using final local variables, turn them into fields	68
Avoid unused local variables such as 'format'.	68
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	82

org/projectforge/web/wicket/ListSelectActionPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	75 - 82
Avoid using final local variables, turn them into fields	118 - 133
Avoid using final local variables, turn them into fields	122
Avoid using final local variables, turn them into fields	126 - 127

org/projectforge/web/wicket/MessagePage.java

Violation	Line
Avoid using final local variables, turn them into fields	78 - 84
Avoid unnecessary comparisons in boolean expressions	89

org/projectforge/web/wicket/MyAuthorizationStrategy.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	53
Avoid unnecessary comparisons in boolean expressions	54
Avoid unnecessary comparisons in boolean expressions	57
Avoid unnecessary comparisons in boolean expressions	58
Avoid unnecessary comparisons in boolean expressions	59
Avoid unnecessary comparisons in boolean expressions	69

org/projectforge/web/wicket/MyListDataProvider.java

Violation	Line
An empty method in an abstract class should be abstract instead	48 - 55
An empty method in an abstract class should be abstract instead	60 - 63
An empty method in an abstract class should be abstract instead	68 - 71
An empty method in an abstract class should be abstract instead	83 - 89

org/projectforge/web/wicket/MyResourceStreamLocator.java

Violation	Line
Avoid using final local variables, turn them into fields	43
Avoid unnecessary comparisons in boolean expressions	52

org/projectforge/web/wicket/MySession.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setLocale' called during object construction	78
Avoid using final local variables, turn them into fields	79
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'getUserAgent' called during object construction	83
Avoid using final local variables, turn them into fields	87
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setUser' called during object construction	93
SYNCHRONISATION: Use block level rather than method level synchronization	104 - 107
SYNCHRONISATION: Use block level rather than method level synchronization	112 - 115
SYNCHRONISATION: Use block level rather than method level synchronization	117 - 121
SYNCHRONISATION: Use block level rather than method level synchronization	123 - 126
SYNCHRONISATION: Use block level rather than method level synchronization	128 - 131
Avoid unnecessary comparisons in boolean expressions	159
Avoid using final local variables, turn them into fields	177
Avoid unnecessary comparisons in boolean expressions	186

org/projectforge/web/wicket/MySortableDataProvider.java

Violation	Line
An empty method in an abstract class should be abstract instead	62 - 74
Avoid using final local variables, turn them into fields	64
Avoid using final local variables, turn them into fields	65
Avoid unnecessary comparisons in boolean expressions	69
Avoid using final local variables, turn them into fields	70
An empty method in an abstract class should be abstract instead	76 - 79
An empty method in an abstract class should be abstract instead	92 - 95

org/projectforge/web/wicket/NumberPropertyColumn.java

Violation	Line
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	71
Avoid unnecessary comparisons in boolean expressions	75
Avoid unnecessary comparisons in boolean expressions	75

org/projectforge/web/wicket/PageExpiredPage.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	41

org/projectforge/web/wicket/PresizedImage.java

Violation	Line
Avoid using final local variables, turn them into fields	59
Avoid using final local variables, turn them into fields	60
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	74 - 75
Avoid using final local variables, turn them into fields	101
Avoid unnecessary comparisons in boolean expressions	103
Avoid unnecessary comparisons in boolean expressions	106

org/projectforge/web/wicket/ShinyFormVisitor.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	58
Avoid using final local variables, turn them into fields	61
Avoid unnecessary comparisons in boolean expressions	62
Avoid unnecessary comparisons in boolean expressions	62
Avoid unnecessary comparisons in boolean expressions	63
Avoid unnecessary return statements	76
Avoid unnecessary comparisons in boolean expressions	85

org/projectforge/web/wicket/ValidationMsgBehavior.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	43
Avoid using final local variables, turn them into fields	46
Avoid unnecessary comparisons in boolean expressions	47
Avoid unnecessary comparisons in boolean expressions	49

org/projectforge/web/wicket/WicketAjaxUtils.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 57

org/projectforge/web/wicket/WicketApplication.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	214
Avoid unnecessary comparisons in boolean expressions	248
Avoid using final local variables, turn them into fields	268
Avoid using final local variables, turn them into fields	274
Avoid using final local variables, turn them into fields	277
Avoid unnecessary comparisons in boolean expressions	281
Avoid using final local variables, turn them into fields	293
Avoid using final local variables, turn them into fields	306 - 307
Avoid using final local variables, turn them into fields	308
Avoid using final local variables, turn them into fields	310
Avoid using final local variables, turn them into fields	322
Avoid using final local variables, turn them into fields	324
Avoid using final local variables, turn them into fields	325
Avoid unnecessary comparisons in boolean expressions	327
Avoid using final local variables, turn them into fields	348
Avoid using final local variables, turn them into fields	354
Avoid using final local variables, turn them into fields	355
Avoid unnecessary comparisons in boolean expressions	359
Avoid unnecessary comparisons in boolean expressions	359
Avoid unnecessary comparisons in boolean expressions	364
Avoid unnecessary comparisons in boolean expressions	377
Avoid using final local variables, turn them into fields	401
Avoid unnecessary comparisons in boolean expressions	411
Avoid using final local variables, turn them into fields	414
Avoid using final local variables, turn them into fields	433
Consider simply returning the value vs storing it in local variable 'mySession'	434
Avoid using final local variables, turn them into fields	453

org/projectforge/web/wicket/WicketApplicationFilter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	68
Avoid using final local variables, turn them into fields	68

org/projectforge/web/wicket/WicketUtils.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 1136
KONSTANTHEIT_VERSTECKTE: The field name indicates a constant but its modifiers do not	87
Avoid using final local variables, turn them into fields	113
Avoid unnecessary comparisons in boolean expressions	117
Avoid using final local variables, turn them into fields	123
Avoid unnecessary comparisons in boolean expressions	124
Avoid using final local variables, turn them into fields	133
Avoid unnecessary comparisons in boolean expressions	134
Avoid using final local variables, turn them into fields	143
Avoid unnecessary comparisons in boolean expressions	144
Avoid using final local variables, turn them into fields	153
Avoid unnecessary comparisons in boolean expressions	154
Avoid using final local variables, turn them into fields	163
Avoid unnecessary comparisons in boolean expressions	164
Avoid using final local variables, turn them into fields	173
Avoid unnecessary comparisons in boolean expressions	174
Avoid using final local variables, turn them into fields	183
Avoid unnecessary comparisons in boolean expressions	184
Avoid unnecessary comparisons in boolean expressions	206
This call to String.startsWith can be rewritten using String.charAt(0)	206
Avoid unnecessary comparisons in boolean expressions	239
Avoid using final local variables, turn them into fields	252
Avoid using final local variables, turn them into fields	254
Avoid using final local variables, turn them into fields	258
Avoid using final local variables, turn them into fields	266
Avoid appending characters as strings in StringBuffer.append.	271
Avoid appending characters as strings in StringBuffer.append.	273
Avoid appending characters as strings in StringBuffer.append.	275
Avoid using final local variables, turn them into fields	294
Avoid using final local variables, turn them into fields	315
Avoid using final local variables, turn them into fields	316
Avoid empty if statements	365 - 367
Avoid empty if statements	367 - 369
Avoid unnecessary comparisons in boolean expressions	382
Avoid using final local variables, turn them into fields	397
Avoid instantiating new objects inside loops	397
Avoid using final local variables, turn them into fields	398
Avoid unnecessary comparisons in boolean expressions	399
Avoid using final local variables, turn them into fields	405
Avoid unnecessary comparisons in boolean expressions	421
Avoid using final local variables, turn them into fields	422
Avoid unnecessary comparisons in boolean expressions	423
Avoid unnecessary comparisons in boolean expressions	427
Avoid unnecessary comparisons in boolean expressions	429
Avoid unnecessary comparisons in boolean expressions	432
Avoid unnecessary comparisons in boolean expressions	434
Avoid unnecessary comparisons in boolean expressions	436
Avoid unnecessary comparisons in boolean expressions	438
Avoid unnecessary comparisons in boolean expressions	440
Avoid unnecessary comparisons in boolean expressions	445
Avoid using final local variables, turn them into fields	446
Avoid unnecessary comparisons in boolean expressions	447
Avoid using final local variables, turn them into fields	450
Avoid using final local variables, turn them into fields	451 - 452
Consider simply returning the value vs storing it in local variable 'en'	453
Avoid unnecessary comparisons in boolean expressions	454
Avoid using final local variables, turn them into fields	455
Avoid unnecessary comparisons in boolean expressions	456
Avoid unnecessary comparisons in boolean expressions	460
Avoid unnecessary comparisons in boolean expressions	462
Avoid using final local variables, turn them into fields	463
Avoid using final local variables, turn them into fields	467
Avoid using final local variables, turn them into fields	472
Avoid using final local variables, turn them into fields	473
Avoid using final local variables, turn them into fields	483
Avoid unnecessary comparisons in boolean expressions	484
Avoid using final local variables, turn them into fields	505
Avoid instantiating new objects inside loops	505
Avoid unnecessary comparisons in boolean expressions	506
Avoid unnecessary comparisons in boolean expressions	507
Avoid unnecessary comparisons in boolean expressions	512
Avoid using final local variables, turn them into fields	517
Avoid instantiating new objects inside loops	517
Avoid unnecessary comparisons in boolean expressions	519
Avoid unnecessary comparisons in boolean expressions	521
Avoid unnecessary comparisons in boolean expressions	524
Avoid using final local variables, turn them into fields	534
Avoid unnecessary comparisons in boolean expressions	535
Avoid using final local variables, turn them into fields	549
Avoid using final local variables, turn them into fields	553
Avoid using final local variables, turn them into fields	578
Avoid using final local variables, turn them into fields	606
Avoid unnecessary comparisons in boolean expressions	607
Avoid using final local variables, turn them into fields	628
Consider simply returning the value vs storing it in local variable 'icon'	629
Avoid using final local variables, turn them into fields	700
StringBuffer constructor is initialized with size 16, but has at least 77 characters appended.	700
Avoid unnecessary comparisons in boolean expressions	702
Avoid using final local variables, turn them into fields	731
Avoid appending characters as strings in StringBuffer.append.	732
Avoid appending characters as strings in StringBuffer.append.	736
Avoid appending characters as strings in StringBuffer.append.	738
Avoid appending characters as strings in StringBuffer.append.	741
Avoid using final local variables, turn them into fields	754
Avoid using final local variables, turn them into fields	768
Avoid using final local variables, turn them into fields	778
Avoid using final local variables, turn them into fields	779
Avoid using final local variables, turn them into fields	780
Avoid using final local variables, turn them into fields	795
Avoid using final local variables, turn them into fields	797
Avoid instantiating new objects inside loops	797
Avoid unnecessary comparisons in boolean expressions	813
Avoid unnecessary comparisons in boolean expressions	814
Avoid unnecessary comparisons in boolean expressions	835
Avoid unnecessary comparisons in boolean expressions	838
Avoid unnecessary comparisons in boolean expressions	897
Avoid unnecessary comparisons in boolean expressions	928
Avoid using final local variables, turn them into fields	977
StringBuffer constructor is initialized with size 20, but has at least 24 characters appended.	977
Avoid unnecessary comparisons in boolean expressions	984
Avoid appending characters as strings in StringBuffer.append.	987
Avoid unnecessary comparisons in boolean expressions	1062
Avoid unnecessary comparisons in boolean expressions	1064
Avoid using final local variables, turn them into fields	1098
Avoid using final local variables, turn them into fields	1105
Avoid using final local variables, turn them into fields	1115
Use equals() to compare object references.	1118

org/projectforge/web/wicket/autocompletion/I18nEnumAutoCompleteTextField.java

Violation	Line
Avoid using final local variables, turn them into fields	69
Avoid using final local variables, turn them into fields	80

org/projectforge/web/wicket/autocompletion/PFAutoCompleteBehavior.java

Violation	Line
TOTE_ATTRIBUTE: Avoid unused private fields such as 'log'.	41
Avoid using final local variables, turn them into fields	75
Prefer StringBuffer over += for concatenating strings	80
Avoid using final local variables, turn them into fields	82
StringBuffer constructor is initialized with size 16, but has at least 99 characters appended.	82
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	85
Avoid appending characters as strings in StringBuffer.append.	91
Avoid unnecessary comparisons in boolean expressions	94
Avoid unnecessary comparisons in boolean expressions	99
Avoid concatenating nonliterals in a StringBuffer constructor or append().	102
Avoid unnecessary comparisons in boolean expressions	104
Avoid using final local variables, turn them into fields	107
An empty method in an abstract class should be abstract instead	112 - 135
Avoid using final local variables, turn them into fields	114
Avoid unnecessary comparisons in boolean expressions	131
Avoid unnecessary comparisons in boolean expressions	142
Avoid using final local variables, turn them into fields	178
Avoid using final local variables, turn them into fields	179
Avoid using final local variables, turn them into fields	186
Avoid using final local variables, turn them into fields	187
Avoid using final local variables, turn them into fields	188
An empty method in an abstract class should be abstract instead	240 - 243
Avoid unnecessary comparisons in boolean expressions	262
Avoid using final local variables, turn them into fields	263

org/projectforge/web/wicket/autocompletion/PFAutoCompleteMaxLengthTextField.java

Violation	Line
Avoid using final local variables, turn them into fields	84 - 85

org/projectforge/web/wicket/autocompletion/PFAutoCompleteRenderer.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	36

org/projectforge/web/wicket/autocompletion/PFAutoCompleteTextField.java

Violation	Line
Perhaps 'behavior' could be replaced by a local variable.	42
An empty method in an abstract class should be abstract instead	102 - 112
An empty method in an abstract class should be abstract instead	131 - 134
An empty method in an abstract class should be abstract instead	141 - 144
An empty method in an abstract class should be abstract instead	151 - 154
An empty method in an abstract class should be abstract instead	161 - 164
An empty method in an abstract class should be abstract instead	170 - 173
An empty method in an abstract class should be abstract instead	190 - 194
An empty method in an abstract class should be abstract instead	200 - 204
An empty method in an abstract class should be abstract instead	210 - 214
An empty method in an abstract class should be abstract instead	220 - 224
An empty method in an abstract class should be abstract instead	230 - 234
An empty method in an abstract class should be abstract instead	240 - 244
An empty method in an abstract class should be abstract instead	250 - 254
An empty method in an abstract class should be abstract instead	260 - 264
An empty method in an abstract class should be abstract instead	270 - 274
An empty method in an abstract class should be abstract instead	280 - 284
An empty method in an abstract class should be abstract instead	290 - 294
An empty method in an abstract class should be abstract instead	300 - 304
An empty method in an abstract class should be abstract instead	310 - 314
An empty method in an abstract class should be abstract instead	320 - 324
An empty method in an abstract class should be abstract instead	330 - 334
An empty method in an abstract class should be abstract instead	340 - 344
An empty method in an abstract class should be abstract instead	350 - 354

org/projectforge/web/wicket/components/AjaxMaxLengthEditableLabel.java

Violation	Line
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	88
Avoid using final local variables, turn them into fields	89 - 90
TOTE_PARAMETER: Avoid unused method parameters such as 'id'.	98 - 104

org/projectforge/web/wicket/components/ConsumptionBarPanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	65
Avoid using final local variables, turn them into fields	68 - 80
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	77
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	85 - 86
Avoid using final local variables, turn them into fields	87
Avoid unnecessary comparisons in boolean expressions	88
Avoid unnecessary comparisons in boolean expressions	99
Avoid using final local variables, turn them into fields	108
Avoid appending characters as strings in StringBuffer.append.	114

org/projectforge/web/wicket/components/ContentMenuEntryPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	53

org/projectforge/web/wicket/components/DatePanel.java

Violation	Line
Avoid using final local variables, turn them into fields	75
Avoid unnecessary comparisons in boolean expressions	79
Avoid unnecessary comparisons in boolean expressions	124
Avoid unnecessary comparisons in boolean expressions	142

org/projectforge/web/wicket/components/DateTimePanel.java

Violation	Line
Avoid using final local variables, turn them into fields	134
Avoid unnecessary comparisons in boolean expressions	182
Avoid unnecessary comparisons in boolean expressions	201
Avoid unnecessary comparisons in boolean expressions	209
Avoid unnecessary comparisons in boolean expressions	217
Avoid unnecessary comparisons in boolean expressions	232
Avoid using final local variables, turn them into fields	273
Avoid unnecessary comparisons in boolean expressions	277
Avoid unnecessary comparisons in boolean expressions	280
Avoid unnecessary comparisons in boolean expressions	291
Avoid using final local variables, turn them into fields	295
Avoid using final local variables, turn them into fields	299
Avoid using final local variables, turn them into fields	300
Avoid unnecessary comparisons in boolean expressions	307
Avoid unnecessary comparisons in boolean expressions	312
Avoid unnecessary comparisons in boolean expressions	321

org/projectforge/web/wicket/components/DateTimePanelSettings.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	10 - 25

org/projectforge/web/wicket/components/ExternalLinkPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'link' could be made final; it is only initialized in the declaration or constructor.	38

org/projectforge/web/wicket/components/FavoritesChoicePanel.java

Violation	Line
An empty method in an abstract class should be abstract instead	86 - 139
Avoid using final local variables, turn them into fields	88
Avoid unnecessary comparisons in boolean expressions	108
Avoid unnecessary comparisons in boolean expressions	109
Avoid using final local variables, turn them into fields	110
Avoid using final local variables, turn them into fields	111
Avoid using final local variables, turn them into fields	119
Avoid unnecessary comparisons in boolean expressions	123
An empty method in an abstract class should be abstract instead	141 - 150
Avoid using final local variables, turn them into fields	143
Avoid using final local variables, turn them into fields	144
Avoid unnecessary comparisons in boolean expressions	156
Avoid using final local variables, turn them into fields	158
An empty method in an abstract class should be abstract instead	169 - 173
An empty method in an abstract class should be abstract instead	175 - 179
An empty method in an abstract class should be abstract instead	184 - 187
An empty method in an abstract class should be abstract instead	197 - 209
Avoid unnecessary comparisons in boolean expressions	199
Avoid using final local variables, turn them into fields	202
Avoid using final local variables, turn them into fields	204

org/projectforge/web/wicket/components/ImageBookmarkablePageLinkPanel.java

Violation	Line
TOTE_PARAMETER: Avoid unused constructor parameters such as 'response'.	51 - 56
TOTE_PARAMETER: Avoid unused constructor parameters such as 'response'.	58 - 63
TOTE_PARAMETER: Avoid unused constructor parameters such as 'response'.	65 - 70

org/projectforge/web/wicket/components/ImageSubmitLinkPanel.java

Violation	Line
TOTE_PARAMETER: Avoid unused constructor parameters such as 'response'.	58 - 62
TOTE_PARAMETER: Avoid unused constructor parameters such as 'response'.	64 - 68
TOTE_PARAMETER: Avoid unused constructor parameters such as 'response'.	70 - 74
TOTE_PARAMETER: Avoid unused constructor parameters such as 'response'.	76 - 81
TOTE_PARAMETER: Avoid unused constructor parameters such as 'response'.	83 - 87
TOTE_PARAMETER: Avoid unused constructor parameters such as 'response'.	89 - 94
An empty method in an abstract class should be abstract instead	98 - 102

org/projectforge/web/wicket/components/JiraIssuesPanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	52
Avoid using final local variables, turn them into fields	53
Avoid using final local variables, turn them into fields	59
Avoid using final local variables, turn them into fields	61
Avoid using final local variables, turn them into fields	66
Avoid instantiating new objects inside loops	66
Avoid instantiating new objects inside loops	69

org/projectforge/web/wicket/components/LabelForPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	44

org/projectforge/web/wicket/components/LabelValueChoiceRenderer.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'addValue' called during object construction	68
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'addValue' called during object construction	82
Avoid using final local variables, turn them into fields	98 - 99
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'addValue' called during object construction	100
Avoid using final local variables, turn them into fields	111 - 112
Avoid using final local variables, turn them into fields	142
Avoid using final local variables, turn them into fields	143

org/projectforge/web/wicket/components/LanguageField.java

Violation	Line
Avoid using final local variables, turn them into fields	66
This call to Collection.toArray() may be optimizable	70
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	84
Avoid using final local variables, turn them into fields	86
Avoid unnecessary comparisons in boolean expressions	87
Avoid using final local variables, turn them into fields	119
Avoid using final local variables, turn them into fields	120
Avoid using final local variables, turn them into fields	122

org/projectforge/web/wicket/components/MaxLengthTextArea.java

Violation	Line
Avoid using final local variables, turn them into fields	57
Avoid using final local variables, turn them into fields	78
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	81 - 82
TOTE_PARAMETER: Avoid unused method parameters such as 'id'.	91 - 97

org/projectforge/web/wicket/components/MaxLengthTextField.java

Violation	Line
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	89
Avoid using final local variables, turn them into fields	90 - 91
TOTE_PARAMETER: Avoid unused method parameters such as 'id'.	99 - 105

org/projectforge/web/wicket/components/MinMaxNumberField.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	55
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'setMaxLength' called during object construction	56

org/projectforge/web/wicket/components/RadioButtonLabelPanel.java

Violation	Line
Avoid using final local variables, turn them into fields	49

org/projectforge/web/wicket/components/SingleImagePanel.java

Violation	Line
A class which only has private constructors should be final	38 - 63
Avoid using final local variables, turn them into fields	50
Avoid using final local variables, turn them into fields	51
Avoid using final local variables, turn them into fields	58
Avoid using final local variables, turn them into fields	59

org/projectforge/web/wicket/components/SingleTextFieldPanel.java

Violation	Line
A class which only has private constructors should be final	41 - 103
Avoid using final local variables, turn them into fields	75
Avoid using final local variables, turn them into fields	76
Avoid using final local variables, turn them into fields	98
Avoid using final local variables, turn them into fields	99

org/projectforge/web/wicket/components/SourceCodePanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	66
Avoid unnecessary comparisons in boolean expressions	75
Avoid using final local variables, turn them into fields	80
Avoid using final local variables, turn them into fields	83
Avoid instantiating new objects inside loops	83
Avoid instantiating new objects inside loops	85
Avoid using final local variables, turn them into fields	86
Avoid instantiating new objects inside loops	86
Avoid using final local variables, turn them into fields	108
Avoid using final local variables, turn them into fields	114
Avoid instantiating new objects inside loops	117

org/projectforge/web/wicket/components/TextFieldOrLabelPanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	53

org/projectforge/web/wicket/components/TimeZoneField.java

Violation	Line
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	75
Avoid unnecessary comparisons in boolean expressions	79
Avoid using final local variables, turn them into fields	83
Avoid using final local variables, turn them into fields	87
Avoid using final local variables, turn them into fields	94
Avoid using final local variables, turn them into fields	96
Avoid unnecessary comparisons in boolean expressions	97
Avoid using final local variables, turn them into fields	127

org/projectforge/web/wicket/components/TimeZonePanel.java

Violation	Line
Avoid using final local variables, turn them into fields	60
Avoid using final local variables, turn them into fields	62
Avoid using final local variables, turn them into fields	63
Avoid using final local variables, turn them into fields	65
Avoid unnecessary comparisons in boolean expressions	69
Avoid using final local variables, turn them into fields	73
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	75 - 109
Avoid using final local variables, turn them into fields	79
Avoid using final local variables, turn them into fields	81
Avoid unnecessary comparisons in boolean expressions	82
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	121

org/projectforge/web/wicket/components/YearListCoiceRenderer.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	65
No need to call String.valueOf to append to a string.	108

org/projectforge/web/wicket/converter/BigDecimalPercentConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	63
Avoid unnecessary comparisons in boolean expressions	67
Avoid unnecessary comparisons in boolean expressions	83

org/projectforge/web/wicket/converter/CurrencyConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	73
Avoid unnecessary comparisons in boolean expressions	75
Avoid using final local variables, turn them into fields	77

org/projectforge/web/wicket/converter/I18nEnumConverter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'parent' could be made final; it is only initialized in the declaration or constructor.	41
KONSTANTHEIT_VERSTECKTE: Private field 'supportedValues' could be made final; it is only initialized in the declaration or constructor.	43
Avoid unnecessary comparisons in boolean expressions	71
Avoid unnecessary comparisons in boolean expressions	75

org/projectforge/web/wicket/converter/IntegerPercentConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	50

org/projectforge/web/wicket/converter/LanguageConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	56
Avoid using final local variables, turn them into fields	57
Avoid unnecessary comparisons in boolean expressions	84
Avoid using final local variables, turn them into fields	87
Avoid unnecessary comparisons in boolean expressions	89
STRING_VERGLEICH_CASING: Using equalsIgnoreCase() is cleaner than using toUpperCase/toLowerCase().equals().	89
Avoid using final local variables, turn them into fields	109

org/projectforge/web/wicket/converter/MonthConverter.java

Violation	Line
Avoid using final local variables, turn them into fields	53

org/projectforge/web/wicket/converter/MyAbstractDateConverter.java

Violation	Line
An empty method in an abstract class should be abstract instead	64 - 70
An empty method in an abstract class should be abstract instead	78 - 84
An empty method in an abstract class should be abstract instead	91 - 94
Avoid unnecessary comparisons in boolean expressions	103
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	107
Avoid instantiating new objects inside loops	110
Avoid unnecessary comparisons in boolean expressions	112
Avoid using final local variables, turn them into fields	120
Avoid unnecessary comparisons in boolean expressions	133
Avoid using final local variables, turn them into fields	134
An empty method in an abstract class should be abstract instead	150 - 208
Avoid using final local variables, turn them into fields	152
Avoid using final local variables, turn them into fields	154
Avoid using final local variables, turn them into fields	155
Avoid using final local variables, turn them into fields	164
Avoid unnecessary comparisons in boolean expressions	165
Avoid unnecessary comparisons in boolean expressions	166
Avoid unnecessary comparisons in boolean expressions	174
Avoid using final local variables, turn them into fields	176
Avoid unnecessary comparisons in boolean expressions	182
Avoid using final local variables, turn them into fields	197
Avoid using final local variables, turn them into fields	198

org/projectforge/web/wicket/converter/MyDateConverter.java

Violation	Line
TOTE_ATTRIBUTE: Avoid unused private fields such as 'dateStyle'.	39
Perhaps 'dateStyle' could be replaced by a local variable.	39
Avoid using final local variables, turn them into fields	90
Consider simply returning the value vs storing it in local variable 'dtf'	91

org/projectforge/web/wicket/converter/TimeZoneConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	43
Avoid using final local variables, turn them into fields	46
Avoid using final local variables, turn them into fields	47
Avoid using final local variables, turn them into fields	48
Avoid unnecessary comparisons in boolean expressions	49
Avoid using final local variables, turn them into fields	62

org/projectforge/web/wicket/flowlayout/AbstractFieldsetPanel.java

Violation	Line
An empty method in an abstract class should be abstract instead	81 - 85
An empty method in an abstract class should be abstract instead	90 - 93
An empty method in an abstract class should be abstract instead	99 - 103
An empty method in an abstract class should be abstract instead	105 - 114
An empty method in an abstract class should be abstract instead	121 - 125
An empty method in an abstract class should be abstract instead	127 - 130
Avoid unnecessary comparisons in boolean expressions	139
An empty method in an abstract class should be abstract instead	160 - 168
Avoid using final local variables, turn them into fields	162
An empty method in an abstract class should be abstract instead	175 - 182
Avoid using final local variables, turn them into fields	177
An empty method in an abstract class should be abstract instead	184 - 188
An empty method in an abstract class should be abstract instead	195 - 203
Avoid using final local variables, turn them into fields	197
An empty method in an abstract class should be abstract instead	208 - 211
An empty method in an abstract class should be abstract instead	218 - 226
Avoid using final local variables, turn them into fields	220
An empty method in an abstract class should be abstract instead	231 - 234
An empty method in an abstract class should be abstract instead	245 - 249
An empty method in an abstract class should be abstract instead	261 - 268
Avoid using final local variables, turn them into fields	264
An empty method in an abstract class should be abstract instead	277 - 281
An empty method in an abstract class should be abstract instead	290 - 297
Avoid using final local variables, turn them into fields	293
An empty method in an abstract class should be abstract instead	302 - 305
An empty method in an abstract class should be abstract instead	309 - 312
Avoid unnecessary comparisons in boolean expressions	318
Avoid using final local variables, turn them into fields	321
Avoid instantiating new objects inside loops	328
Avoid unnecessary comparisons in boolean expressions	339
Avoid unnecessary comparisons in boolean expressions	339
Avoid unnecessary comparisons in boolean expressions	343
An empty method in an abstract class should be abstract instead	358 - 362
An empty method in an abstract class should be abstract instead	368 - 371

org/projectforge/web/wicket/flowlayout/AccordionPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'ul' could be made final; it is only initialized in the declaration or constructor.	46
KONSTANTHEIT_VERSTECKTE: Private field 'liRepeater' could be made final; it is only initialized in the declaration or constructor.	48
Avoid using final local variables, turn them into fields	64

org/projectforge/web/wicket/flowlayout/AdminicaDialogPanel.java

Violation	Line
Perhaps 'dialog' could be replaced by a local variable.	41

org/projectforge/web/wicket/flowlayout/CheckBoxPanel.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	48
It is somewhat confusing to have a field name with the same name as a method	48

org/projectforge/web/wicket/flowlayout/DivPanel.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'addCssClasses' called during object construction	63
Avoid unnecessary comparisons in boolean expressions	92
Avoid using final local variables, turn them into fields	165

org/projectforge/web/wicket/flowlayout/DropDownChoicePanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	96

org/projectforge/web/wicket/flowlayout/FieldsetPanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	86
Avoid using final local variables, turn them into fields	214
Avoid using final local variables, turn them into fields	230
Avoid using final local variables, turn them into fields	252
Avoid using final local variables, turn them into fields	264
Avoid using final local variables, turn them into fields	286
Avoid using final local variables, turn them into fields	298
Avoid unnecessary comparisons in boolean expressions	321
Avoid unnecessary comparisons in boolean expressions	336
Avoid unnecessary comparisons in boolean expressions	357
Avoid using final local variables, turn them into fields	378
Avoid using final local variables, turn them into fields	385
Avoid unnecessary comparisons in boolean expressions	396
Avoid unnecessary comparisons in boolean expressions	400

org/projectforge/web/wicket/flowlayout/FileUploadPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'fileUploadField' could be made final; it is only initialized in the declaration or constructor.	40

org/projectforge/web/wicket/flowlayout/GridBuilder.java

Violation	Line
Avoid using final local variables, turn them into fields	139
Avoid unnecessary comparisons in boolean expressions	140
Avoid unnecessary comparisons in boolean expressions	220
Avoid empty if statements	252 - 254
Avoid unnecessary comparisons in boolean expressions	260
Avoid using final local variables, turn them into fields	283
Avoid using final local variables, turn them into fields	293

org/projectforge/web/wicket/flowlayout/HeadingPanel.java

Violation	Line
An empty method in an abstract class should be abstract instead	60 - 64

org/projectforge/web/wicket/flowlayout/IconButtonPanel.java

Violation	Line
Perhaps 'div' could be replaced by a local variable.	46

org/projectforge/web/wicket/flowlayout/IconLinkPanel.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'appendAttribute' called during object construction	62

org/projectforge/web/wicket/flowlayout/IconPanel.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'appendAttribute' called during object construction	56
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'appendAttribute' called during object construction	67
Avoid unnecessary comparisons in boolean expressions	112

org/projectforge/web/wicket/flowlayout/ImagePanel.java

Violation	Line
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'addImage' called during object construction	50
KONSTRUKTOR_RUFT_VIRT_METHODE: Overridable method 'addImage' called during object construction	56

org/projectforge/web/wicket/flowlayout/InputPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'field' could be made final; it is only initialized in the declaration or constructor.	41

org/projectforge/web/wicket/flowlayout/LayoutContext.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	85
Avoid unnecessary comparisons in boolean expressions	85

org/projectforge/web/wicket/flowlayout/ListMultipleChoicePanel.java

Violation	Line
TOTE_PARAMETER: Avoid unused constructor parameters such as 'submitOnChange'.	61 - 67

org/projectforge/web/wicket/flowlayout/MyAjaxComponentHolder.java

Violation	Line
Avoid using final local variables, turn them into fields	72
Avoid unnecessary comparisons in boolean expressions	73
Avoid using final local variables, turn them into fields	74
Use equals() to compare object references.	75

org/projectforge/web/wicket/flowlayout/MyComponentsRepeater.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	132
Avoid unnecessary comparisons in boolean expressions	133
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()	137

org/projectforge/web/wicket/flowlayout/PasswordPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'field' could be made final; it is only initialized in the declaration or constructor.	40

org/projectforge/web/wicket/flowlayout/RadioGroupPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'radioGroup' could be made final; it is only initialized in the declaration or constructor.	48
KONSTANTHEIT_VERSTECKTE: Private field 'repeater' could be made final; it is only initialized in the declaration or constructor.	50
TOTE_PARAMETER: Avoid unused constructor parameters such as 'groupName'.	59 - 84
Avoid using final local variables, turn them into fields	106
Avoid using final local variables, turn them into fields	108
Avoid unnecessary comparisons in boolean expressions	109
Avoid using final local variables, turn them into fields	113

org/projectforge/web/wicket/flowlayout/SpanPanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	77

org/projectforge/web/wicket/flowlayout/TextAreaPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'field' could be made final; it is only initialized in the declaration or constructor.	41

org/projectforge/web/wicket/flowlayout/TextLinkPanel.java

Violation	Line
TOTE_PARAMETER: Avoid unused method parameters such as 'id'.	92 - 98

org/projectforge/web/wicket/flowlayout/ToggleContainerPanel.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'toggleLink' could be made final; it is only initialized in the declaration or constructor.	46

org/projectforge/web/wicket/mobileflowlayout/LabelValueDataTablePanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	66
Avoid using final local variables, turn them into fields	70
Avoid using final local variables, turn them into fields	78
Avoid unnecessary comparisons in boolean expressions	90
Avoid using final local variables, turn them into fields	96
Avoid using final local variables, turn them into fields	99

org/projectforge/web/wicket/mobileflowlayout/MobileFieldsetPanel.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	126

org/projectforge/web/wicket/mobileflowlayout/MobileGridBuilder.java

Violation	Line
Avoid using final local variables, turn them into fields	56

org/projectforge/xls/ExcelImport.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'work' could be made final; it is only initialized in the declaration or constructor.	57
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	169
KONSTANTHEIT_VERSTECKTE: Local variable 'columnNames' could be declared final	170
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	171
KONSTANTHEIT_VERSTECKTE: Local variable 'columnName' could be declared final	176
KONSTANTHEIT_VERSTECKTE: Local variable 'sheet' could be declared final	196
KONSTANTHEIT_VERSTECKTE: Local variable 'numberOfRows' could be declared final	197
KONSTANTHEIT_VERSTECKTE: Local variable 'list' could be declared final	198
KONSTANTHEIT_VERSTECKTE: Local variable 'columnNames' could be declared final	199
Avoid unnecessary comparisons in boolean expressions	207
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	219
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	221
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	224 - 229
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	231
KONSTANTHEIT_VERSTECKTE: Local variable 'o' could be declared final	256
KONSTANTHEIT_VERSTECKTE: Local variable 'mapName' could be declared final	270
KONSTANTHEIT_VERSTECKTE: Local variable 'destClazz' could be declared final	276
KONSTANTHEIT_VERSTECKTE: Local variable 'value' could be declared final	281
WRAPPER_INSTANZIIERUNG: Avoid instantiating Integer objects. Call Integer.valueOf() instead.	286
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	286
Avoid unnecessary comparisons in boolean expressions	290

org/projectforge/xls/ExcelImportException.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'row' could be made final; it is only initialized in the declaration or constructor.	42
KONSTANTHEIT_VERSTECKTE: Private field 'columnname' could be made final; it is only initialized in the declaration or constructor.	47

org/projectforge/xml/stream/AliasMap.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'aliasMap1' could be made final; it is only initialized in the declaration or constructor.	31
KONSTANTHEIT_VERSTECKTE: Private field 'aliasMap2' could be made final; it is only initialized in the declaration or constructor.	33

org/projectforge/xml/stream/ProjectForgeRootElement.java

Violation	Line
This abstract class does not have any abstract methods	37 - 98
An empty method in an abstract class should be abstract instead	49 - 52
An empty method in an abstract class should be abstract instead	57 - 62
Avoid using final local variables, turn them into fields	59
An empty method in an abstract class should be abstract instead	68 - 72
An empty method in an abstract class should be abstract instead	77 - 80
An empty method in an abstract class should be abstract instead	82 - 86
An empty method in an abstract class should be abstract instead	88 - 91
An empty method in an abstract class should be abstract instead	93 - 97

org/projectforge/xml/stream/XmlHelper.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	24 - 142
Avoid using final local variables, turn them into fields	64
Consider simply returning the value vs storing it in local variable 'text'	65
Avoid unnecessary comparisons in boolean expressions	70
Avoid using final local variables, turn them into fields	74
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	93
Avoid unnecessary comparisons in boolean expressions	94
Avoid using final local variables, turn them into fields	98
Avoid using final local variables, turn them into fields	112
Avoid using final local variables, turn them into fields	113
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	118
Avoid unnecessary comparisons in boolean expressions	120
Avoid using final local variables, turn them into fields	124
Avoid using final local variables, turn them into fields	125
Avoid using final local variables, turn them into fields	126
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	131
Avoid using final local variables, turn them into fields	133
EXCEPTIONS_WEITERLEITEN: Caught exception is rethrown, original stack trace may be lost	138

org/projectforge/xml/stream/XmlObjectReader.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	143
Avoid unnecessary comparisons in boolean expressions	148
Avoid using final local variables, turn them into fields	149
Avoid unnecessary comparisons in boolean expressions	150
Avoid unnecessary comparisons in boolean expressions	155
Avoid unnecessary comparisons in boolean expressions	155
Avoid using final local variables, turn them into fields	171
Avoid using final local variables, turn them into fields	175
Avoid using final local variables, turn them into fields	192
Avoid using final local variables, turn them into fields	194
Consider simply returning the value vs storing it in local variable 'obj'	195
Avoid using final local variables, turn them into fields	213
Avoid using final local variables, turn them into fields	215
Avoid unnecessary comparisons in boolean expressions	216
Avoid unnecessary comparisons in boolean expressions	224
Avoid appending characters as strings in StringBuffer.append.	225
Avoid using final local variables, turn them into fields	227 - 228
Avoid using final local variables, turn them into fields	230
Avoid unnecessary comparisons in boolean expressions	232
Avoid appending characters as strings in StringBuffer.append.	233
Avoid using final local variables, turn them into fields	237 - 238
Avoid unnecessary comparisons in boolean expressions	249
Avoid using final local variables, turn them into fields	257
Avoid using final local variables, turn them into fields	289
Avoid using final local variables, turn them into fields	301
Avoid unnecessary comparisons in boolean expressions	303
Avoid using final local variables, turn them into fields	323
Avoid using final local variables, turn them into fields	325
Avoid unnecessary comparisons in boolean expressions	326
Avoid using final local variables, turn them into fields	330
Avoid using final local variables, turn them into fields	342
Avoid unnecessary comparisons in boolean expressions	347
Avoid unnecessary comparisons in boolean expressions	351
Avoid using final local variables, turn them into fields	354 - 355
Avoid unnecessary comparisons in boolean expressions	357
Avoid unnecessary comparisons in boolean expressions	359
Avoid using final local variables, turn them into fields	366
Avoid using final local variables, turn them into fields	367
Avoid unnecessary comparisons in boolean expressions	369
Avoid unnecessary comparisons in boolean expressions	374
Avoid unnecessary comparisons in boolean expressions	374
Avoid using final local variables, turn them into fields	379
Avoid using final local variables, turn them into fields	387
Avoid using final local variables, turn them into fields	389
Avoid unnecessary comparisons in boolean expressions	390
Avoid using final local variables, turn them into fields	414
Avoid using final local variables, turn them into fields	417
Avoid using final local variables, turn them into fields	418
Avoid unnecessary comparisons in boolean expressions	419
Avoid using final local variables, turn them into fields	423
Avoid using final local variables, turn them into fields	427
Avoid using final local variables, turn them into fields	428
Avoid unnecessary comparisons in boolean expressions	474
Avoid unnecessary comparisons in boolean expressions	477
Avoid using final local variables, turn them into fields	477
Avoid unnecessary comparisons in boolean expressions	478
Avoid unnecessary comparisons in boolean expressions	478
Avoid using final local variables, turn them into fields	486
Avoid using final local variables, turn them into fields	487
Avoid unnecessary comparisons in boolean expressions	489

org/projectforge/xml/stream/XmlObjectWriter.java

Violation	Line
KONSTANTHEIT_VERSTECKTE: Private field 'writtenObjects' could be made final; it is only initialized in the declaration or constructor.	72
Avoid using final local variables, turn them into fields	134
Avoid using final local variables, turn them into fields	147
Avoid unnecessary comparisons in boolean expressions	148
Avoid using final local variables, turn them into fields	164
Avoid using final local variables, turn them into fields	165
Avoid using final local variables, turn them into fields	185
Avoid unnecessary comparisons in boolean expressions	189
Avoid using final local variables, turn them into fields	190
Avoid unnecessary comparisons in boolean expressions	191
Avoid unnecessary comparisons in boolean expressions	201
Avoid using final local variables, turn them into fields	202
Avoid using final local variables, turn them into fields	204
Avoid using final local variables, turn them into fields	215
KONSTANTHEIT_VERSTECKTE: Local variable 'converter' could be declared final	220
Avoid using final local variables, turn them into fields	222
Avoid unnecessary comparisons in boolean expressions	225
Avoid using final local variables, turn them into fields	226
Avoid using final local variables, turn them into fields	230
Avoid using final local variables, turn them into fields	231
Avoid unnecessary comparisons in boolean expressions	232
Avoid using final local variables, turn them into fields	237
Avoid using final local variables, turn them into fields	239
Avoid unnecessary comparisons in boolean expressions	242
Avoid unnecessary comparisons in boolean expressions	242
Avoid unnecessary comparisons in boolean expressions	245
Avoid using final local variables, turn them into fields	245
Avoid unnecessary comparisons in boolean expressions	246
Avoid unnecessary comparisons in boolean expressions	246
Avoid using final local variables, turn them into fields	249
Avoid unnecessary comparisons in boolean expressions	257
Avoid unnecessary comparisons in boolean expressions	262
Avoid unnecessary comparisons in boolean expressions	262
Avoid unnecessary comparisons in boolean expressions	262
Avoid unnecessary comparisons in boolean expressions	265
Avoid unnecessary comparisons in boolean expressions	268
Avoid using final local variables, turn them into fields	268
Avoid using final local variables, turn them into fields	269
Avoid unnecessary comparisons in boolean expressions	270
Avoid unnecessary comparisons in boolean expressions	289
Avoid unnecessary comparisons in boolean expressions	291
Avoid unnecessary comparisons in boolean expressions	332
Avoid unnecessary comparisons in boolean expressions	337
Avoid unnecessary comparisons in boolean expressions	345
Avoid unnecessary comparisons in boolean expressions	352
Avoid unnecessary comparisons in boolean expressions	353
Avoid unnecessary comparisons in boolean expressions	354
Avoid unnecessary comparisons in boolean expressions	372
Avoid unnecessary comparisons in boolean expressions	375
Avoid unnecessary comparisons in boolean expressions	376

org/projectforge/xml/stream/XmlRegistry.java

Violation	Line
It is somewhat confusing to have a field name with the same name as a method	55
Avoid using final local variables, turn them into fields	141
Avoid unnecessary comparisons in boolean expressions	146
Avoid using final local variables, turn them into fields	147
Avoid unnecessary comparisons in boolean expressions	165
Avoid using final local variables, turn them into fields	178
Avoid using final local variables, turn them into fields	192

org/projectforge/xml/stream/converter/AbstractValueConverter.java

Violation	Line
An empty method in an abstract class should be abstract instead	28 - 34

org/projectforge/xml/stream/converter/BigDecimalConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	39
Avoid unnecessary comparisons in boolean expressions	39

org/projectforge/xml/stream/converter/BooleanConverter.java

Violation	Line
WRAPPER_INSTANZIIERUNG: Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.	31

org/projectforge/xml/stream/converter/DateConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	75
Avoid unnecessary comparisons in boolean expressions	75
Avoid using final local variables, turn them into fields	80
When instantiating a SimpleDateFormat object, specify a Locale	92
Avoid using final local variables, turn them into fields	92
Avoid using final local variables, turn them into fields	102
WRAPPER_INSTANZIIERUNG: Avoid instantiating Long objects.Call Long.valueOf() instead	102

org/projectforge/xml/stream/converter/DoubleConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	37
Avoid unnecessary comparisons in boolean expressions	37

org/projectforge/xml/stream/converter/ISODateConverter.java

Violation	Line
Avoid using final local variables, turn them into fields	40
Avoid using final local variables, turn them into fields	41
When instantiating a SimpleDateFormat object, specify a Locale	55
Avoid using final local variables, turn them into fields	55

org/projectforge/xml/stream/converter/IntConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	37
Avoid unnecessary comparisons in boolean expressions	37
WRAPPER_INSTANZIIERUNG: Avoid instantiating Integer objects. Call Integer.valueOf() instead.	40

org/projectforge/xml/stream/converter/LocaleConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	35

org/projectforge/xml/stream/converter/LongConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	37
Avoid unnecessary comparisons in boolean expressions	37
WRAPPER_INSTANZIIERUNG: Avoid instantiating Long objects.Call Long.valueOf() instead	40

org/projectforge/xml/stream/converter/TimeZoneConverter.java

Violation	Line
Avoid unnecessary comparisons in boolean expressions	44

Project Documentation

PMD Results

Files

net/ftlines/wicket/fullcalendar/AbstractFullCalendar.java

net/ftlines/wicket/fullcalendar/ButtonText.java

net/ftlines/wicket/fullcalendar/CalendarResponse.java

net/ftlines/wicket/fullcalendar/Config.java

net/ftlines/wicket/fullcalendar/Event.java

net/ftlines/wicket/fullcalendar/EventManager.java

net/ftlines/wicket/fullcalendar/EventSource.java

net/ftlines/wicket/fullcalendar/FullCalendar.java

net/ftlines/wicket/fullcalendar/Header.java

net/ftlines/wicket/fullcalendar/Json.java

net/ftlines/wicket/fullcalendar/callback/AbstractAjaxCallback.java

net/ftlines/wicket/fullcalendar/callback/AbstractAjaxCallbackWithClientsideRevert.java

net/ftlines/wicket/fullcalendar/callback/AbstractCallback.java

net/ftlines/wicket/fullcalendar/callback/AbstractEventParam.java

net/ftlines/wicket/fullcalendar/callback/BlockingDecorator.java

net/ftlines/wicket/fullcalendar/callback/DateRangeSelectedCallback.java

net/ftlines/wicket/fullcalendar/callback/EventClickedCallback.java

net/ftlines/wicket/fullcalendar/callback/EventDroppedCallback.java

net/ftlines/wicket/fullcalendar/callback/EventResizedCallback.java

net/ftlines/wicket/fullcalendar/callback/GetEventsCallback.java

net/ftlines/wicket/fullcalendar/callback/View.java

net/ftlines/wicket/fullcalendar/callback/ViewDisplayCallback.java

org/projectforge/Version.java

org/projectforge/access/AccessChecker.java

org/projectforge/access/AccessDao.java

org/projectforge/access/AccessEntryDO.java

org/projectforge/access/AccessException.java

org/projectforge/access/GroupTaskAccessDO.java

org/projectforge/address/AddressDO.java

org/projectforge/address/AddressDao.java

org/projectforge/address/AddressExport.java

org/projectforge/address/AddressFilter.java

org/projectforge/address/AddressStatus.java

org/projectforge/address/BirthdayAddress.java

org/projectforge/address/ContactStatus.java

org/projectforge/address/FormOfAddress.java

org/projectforge/address/HibernateSearchInstantMessagingBridge.java

org/projectforge/address/InstantMessagingType.java

org/projectforge/address/PersonalAddressDO.java

org/projectforge/address/PersonalAddressDao.java

org/projectforge/admin/DatabaseCoreUpdates.java

org/projectforge/admin/SystemUpdater.java

org/projectforge/admin/UpdateEntry.java

org/projectforge/admin/UpdateEntryImpl.java

org/projectforge/book/BookDO.java

org/projectforge/book/BookDao.java

org/projectforge/calendar/ConfigureHoliday.java

org/projectforge/calendar/DayHolder.java

org/projectforge/calendar/Holiday.java

org/projectforge/calendar/Holidays.java

org/projectforge/calendar/MonthHolder.java

org/projectforge/calendar/TimePeriod.java

org/projectforge/calendar/WeekHolder.java

org/projectforge/common/AbstractCache.java

org/projectforge/common/Base64Helper.java

org/projectforge/common/BaseFormatter.java

org/projectforge/common/BeanHelper.java

org/projectforge/common/CSVParser.java

org/projectforge/common/CSVWriter.java

org/projectforge/common/ClassHelper.java

org/projectforge/common/Crypt.java

org/projectforge/common/CurrencyHelper.java

org/projectforge/common/DateFormats.java

org/projectforge/common/DateHelper.java

org/projectforge/common/DateHolder.java

org/projectforge/common/ExceptionHelper.java

org/projectforge/common/FileHelper.java

org/projectforge/common/ImportStorage.java

org/projectforge/common/ImportedElement.java

org/projectforge/common/ImportedSheet.java

org/projectforge/common/IntRanges.java

org/projectforge/common/KeyValueBean.java

org/projectforge/common/LabelValueBean.java

org/projectforge/common/ListCopyHelper.java

org/projectforge/common/MyBeanComparator.java

org/projectforge/common/NumberHelper.java

org/projectforge/common/ObjectHelper.java